From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.92.41.19]) by mx.groups.io with SMTP id smtpd.web09.7169.1603145580168507940 for ; Mon, 19 Oct 2020 15:13:00 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=XHj1PbBm; spf=pass (domain: outlook.com, ip: 40.92.41.19, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V9Bd04uQDuXTMm+cunsxKcSjoyMwfWLDqbRmXqWtZ+Ul9AUbewx3iSl26tISByOD5HbfkwdbFyQUE1UmS8vvDvXJ352YqWQaAvsnlatxiy8vRsw2mWawP3k2/EkecRfel/hPArLb1bAG8q66Ng4sDjiVRhwDJjrpawOvLoy9VMH9mTHy9m8DmHNTEIYodGto2G02jK5W+qkZGVoWWCvRw+VK/lKynx9zNQioA+ralq3S5OJEl5VPmGZdu2L8rNkUFFHR6kWFQm+bZoG+MVYg3nsMhge7BV8L9MszCvCkB+Jo/o5vye1FyE1iNtt/+OX4Z+uD8xd4o2seXO5pYRRkLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2tzb5XdHUC5xjDDTN2bd51yPv1MldFmTNGZNtbKdfBE=; b=IGsHULNfo3aFllBV4d3lyAGQn4XUNZDEUHdndK2mJg9c12qPefaWSQV+wYN1A+VG9HD5rIWfqViEcNpSeZU6OFpOCb2rKc4Y/Lq7erGQL/uGLTPytBRp0Ah2FYEia0XBitdGfCS+vXApwmBrTfICfBdqpccMvlFbXADPnxsIc7FgcuFXasXH9XgfYQMF5Kxy0Nh9v0n/lIqSCN7UyVLyDkcMpgMaKlTpM0qx+E66ayZmMlP5pKGt/+qqUcIjqUdEP3vTXkkIkTitHRatQ81T8a77Q+4D7eNYSQHRV0q1xz+G2spdr2X42wUCRARJmIVpFP7VFITyUGYuU9ECenAnqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2tzb5XdHUC5xjDDTN2bd51yPv1MldFmTNGZNtbKdfBE=; b=XHj1PbBm9Ve53vzWYuv4B/XiMowReg1xLMz0I9XY6pHHFskwJqSiLv/2EVReJUE608bVpVOuKCwCvdZQq4t7YMkSfaDJmGTHOvGIWk/v0UknxFCD0HBbWgcwfzh5Ggwi0IzL/jahN4wArqn7fM5tdOVOtd6HfzoTBSesCTHpJz5swuTjBAhCZ30He45nbvYQCJcfMCO1nqAl6Pdmo0kW01zp0qY0IW4dNiHQH2h6W9iarZSJZ4NZ60QJEmqnuPrsG7zfrdqab954Q7D1YWpdw0RGBrHTnw5BwIeNmmjCpedpVbPNHQBfLuyw44Vj8NNjF/wQSiDui2yK8hMX2Lcmvw== Received: from MW2NAM10FT024.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::52) by MW2NAM10HT228.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::423) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.23; Mon, 19 Oct 2020 22:12:59 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:7e87::42) by MW2NAM10FT024.mail.protection.outlook.com (2a01:111:e400:7e87::455) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Mon, 19 Oct 2020 22:12:59 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:FCAB1D2DBAD64706692B42E61D9B1DAA05970BE3C6C659674B10B1ABA650CC33;UpperCasedChecksum:1A710EF62E48622BBADFD225738A2137BE008CF396C9A869D7896D74266095E0;SizeAsReceived:7357;Count:45 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::858f:bd50:1b65:e803]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::858f:bd50:1b65:e803%7]) with mapi id 15.20.3477.028; Mon, 19 Oct 2020 22:12:59 +0000 From: "Michael Kubacki" To: devel@edk2.groups.io CC: Ard Biesheuvel , Leif Lindholm Subject: [PATCH v2 1/1] ArmPkg/ArmMmuLib: Explicitly cast function pointer argument Date: Mon, 19 Oct 2020 15:12:23 -0700 Message-ID: X-Mailer: git-send-email 2.28.0.windows.1 X-TMN: [aQwD+MGGXaXGSoaWvsV+4Np0ijeRsvkS] X-ClientProxiedBy: MW2PR2101CA0001.namprd21.prod.outlook.com (2603:10b6:302:1::14) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <20201019221223.1769-1-michael.kubacki@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (131.107.160.74) by MW2PR2101CA0001.namprd21.prod.outlook.com (2603:10b6:302:1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.4 via Frontend Transport; Mon, 19 Oct 2020 22:12:58 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: aa0ea25a-b06d-49d2-3498-08d8747c2346 X-MS-TrafficTypeDiagnostic: MW2NAM10HT228: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ysESp/Px9um1f/QWMIkr3DCBCDpvoJJ+Wtx4opnIhb3f+OPVWIErgu6fVwJYfGCVCUNmV+4/R0W0R2o0OGZuwnvjd5CIUOZJlPNxjKbJ2ujoK+6C3KGsl/lyn9UabwyvmxkfLz9T6hZQhI0CV+XOMVHgYcdpbyoWp63OTxjqAfc6qF5/AXTbZpKVeGR3OT/HIjElvbqtM+bmu1l5DpXWtw== X-MS-Exchange-AntiSpam-MessageData: IllH8MmcMrSJPhNNrrkwSSEN59rHExqwjjudTeJsRXn87yKzqV9WuhylHx6XEjM787XttJMVTmdWz59fqRFLdAltn/AwlDl6TSQ/ENJzNVGa2Yku5Eg6UGNVMCdaOf8XW3P4ExrK0wvfqNw7C4DYJA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa0ea25a-b06d-49d2-3498-08d8747c2346 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2020 22:12:59.1514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT024.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM10HT228 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Michael Kubacki The function ArmReplaceLiveTranslationEntry () is passed as a VOID pointer to WriteBackDataCacheRange (). This produces the following warning on VS2019: warning C4152: nonstandard extension, function/data pointer conversion in expression This change explicitly casts the argument to the formal parameter type VOID*. This can be reproduced with the following build command: build -b DEBUG -a AARCH64 -t VS2019 -p ArmPkg/ArmPkg.dsc -m ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael Kubacki --- Notes: V2 changes: =20 1. Added a cast to UINTN prior to casting to VOID*. =20 This also makes the change consistent with a very similar change in commit 654dc3ed852a. ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c b/A= rmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c index 80317923cfa4..5f259d216420 100644 --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c @@ -47,7 +47,7 @@ ArmMmuPeiLibConstructor ( // The ArmReplaceLiveTranslationEntry () helper function may be invoke= d // with the MMU off so we have to ensure that it gets cleaned to the P= oC // - WriteBackDataCacheRange (ArmReplaceLiveTranslationEntry, + WriteBackDataCacheRange ((VOID *) (UINTN) ArmReplaceLiveTranslationEnt= ry, ArmReplaceLiveTranslationEntrySize); } =20 --=20 2.28.0.windows.1