Re: [edk2-devel] [PATCH v2 00/12] Add the VariablePolicy feature

["Michael Kubacki" <michael.kubacki@outlook.com>]

While most of the feedback in the series is relevant for the author 
(Bret), this is a change I will make for the patches I generate.

Thanks,
Michael

On 5/12/2020 5:37 AM, Laszlo Ersek wrote:
> On 05/12/20 14:15, Laszlo Ersek wrote:
>> On 05/12/20 13:52, Laszlo Ersek wrote:
>>> On 05/12/20 08:46, Michael Kubacki wrote:
>>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>
>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2522
>>>>
>>>> The 12 patches in this series add the VariablePolicy feature to the
>>>> core, deprecate Edk2VarLock (while adding a compatibility layer to
>>>> reduce code churn), and integrate the VariablePolicy libraries and
>>>> protocols into Variable Services.
>>>>
>>>> Since the integration requires multiple changes, including adding
>>>> libraries, a protocol, an SMI communication handler, and
>>>> VariableServices integration, the patches are broken up by
>>>> individual library additions and then a final integration.
>>>> Security-sensitive changes like bypassing Authenticated Variable
>>>> enforcement are also broken out into individual patches so that
>>>> attention can be called directly to them.
> 
> (4) Can you please run SetupGit.py in your edk2 clone, for the future?
> 
> It will mark the DEC, DSC, etc "ini-style" files with the "diff=ini"
> attribute. Furthermore, it will set the "xfuncname" knob for the
> "diff=ini"-marked files.
> 
> As a result, when you format a patch that modifies e.g. a DSC file, the
> "@@" hunk headers will display the section being modified. For example:
> 
>> @@ -492,6 +496,9 @@ [PcdsFixedAtBuild]
>>     gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVolatileVariableSize|0x40000
>>   !endif
>>
>> +  # Optional: Omit if VariablePolicy should be always-on.
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdAllowVariablePolicyEnforcementDisable|TRUE
>> +
>>     gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0
>>
>>     gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07
> 
> Note that the "@@" hunk header now states "[PcdsFixedAtBuild]". It tells
> me as a reviewer about the access method of the PCD that was chosen for
> OvmfPkg.
> 
> Such hunk headers improve reviewer throughput quite a bit.
> 
> Thanks,
> Laszlo
>