Re: [PATCH v3 0/7] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

["Michael Kubacki" <michael.kubacki@outlook.com>]

Patches #1 - #6 merged as commit range 4fcfd089aa31..099dfbb29d8b via 
https://github.com/tianocore/edk2/pull/553.

As noted in the v3 cover letter, patch #7 merged separately in commit 
64ab457d1f21 via https://github.com/tianocore/edk2/pull/555.

Thanks,
Michael

On 4/24/2020 2:31 PM, michael.kubacki@outlook.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Attention: Reviewed-by is still needed from some package maintainers.
> * 0002-ArmVirtPkg-Add-Platform-CI-and-configuration-for-Cor.patch
>    * Laszlo Ersek <lersek@redhat.com>
>    * Ard Biesheuvel <ard.biesheuvel@arm.com>
>    * Leif Lindholm <leif@nuviainc.com>
> * 0003-EmulatorPkg-Add-Platform-CI-and-configuration-for-Co.patch
>    * Jordan Justen <jordan.l.justen@intel.com>
>    * Andrew Fish <afish@apple.com>
>    * Ray Ni <ray.ni@intel.com>
> * 0004-OvmfPkg-Add-Platform-CI-and-configuration-for-Core-C.patch
>    * Jordan Justen <jordan.l.justen@intel.com>
>    * Laszlo Ersek <lersek@redhat.com>
>    * Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> The following 7 patches add support for Azure DevOps based "Platform CI"
> for ArmVirtPkg, OvmfPkg, and EmulatorPkg.
> 
> The patch set also adds ArmVirtPkg, OvmfPkg, and EmulatorPkg to Core CI
> for the code evaluation tests (not compiling).
> 
> *Note about patch #7*:
> On final commit to master, patch 7 will be committed after the builds are
> defined for each package. These cannot be defined until patches 1-6 are
> committed to master and the builds created in Azure Dev Ops. Once created,
> the links in the ReadMe.rst file will be corrected and then patch #7 will
> be committed.
> 
> Changes for V3:
> * Package Platform CI ReadMe’s have been moved to the PlatformCI folder
>    and are in markdown format. Build status is not included in this
>    readme but instead all combined in the edk2 readme to bring top level
>    visibility to these builds since they will be required to pass for
>    PR completion.
> * Patch #7 added to convert edk2 readme to RST and add table of platform
>    CI status badges.
> 
> Changes for V2:
> * PlatformBuild.py, iasl dependency, and azurepipeline files have been
>    moved into a PlatformCI folder within the respective package.
> * PlatformBuild.py - RequiredSubmodules function configured to read from
>    edk2 .gitmodules to lower required updates.
> * ReadMe files have been switched to reStructuredText to make Build Status
>    table less distracting when viewing plaintext.
> 
> Branch: https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages_v10
> 
> Please send feedback to the mailing list and do not leave feedback directly
> on github.
> 
> On a separate note, shallow threading might not work on this patch series
> due to changes made by the SMTP server. Please bear with me while I am
> investigating if this can be changed.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Sean Brogan (7):
>    .azurepipelines: Add Platform CI template
>    ArmVirtPkg: Add Platform CI and configuration for Core CI
>    EmulatorPkg: Add Platform CI and configuration for Core CI
>    OvmfPkg: Add Platform CI and configuration for Core CI
>    .pytool: Update CI Settings to support Emulator, ArmVirt, and Ovmf
>      packages
>    .azurepipelines: Update Core CI build matrix to include platforms
>    ReadMe: Convert to rst and add Platform CI Status
> 
>   .azurepipelines/ReadMe.md                                 |  50 +++
>   .azurepipelines/templates/ReadMe.md                       |  59 ++++
>   .azurepipelines/templates/platform-build-run-steps.yml    | 134 ++++++++
>   .azurepipelines/templates/pr-gate-build-job.yml           |   5 +
>   .pytool/CISettings.py                                     |   7 +-
>   .pytool/Plugin/SpellCheck/cspell.base.yaml                |  14 +
>   .pytool/Readme.md                                         |  10 +-
>   ArmVirtPkg/ArmVirtPkg.ci.yaml                             | 103 ++++++
>   ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml     |  89 +++++
>   ArmVirtPkg/PlatformCI/PlatformBuild.py                    | 276 +++++++++++++++
>   ArmVirtPkg/PlatformCI/ReadMe.md                           | 125 +++++++
>   ArmVirtPkg/PlatformCI/iasl_ext_dep.yaml                   |  21 ++
>   EmulatorPkg/EmulatorPkg.ci.yaml                           |  85 +++++
>   EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml    |  95 ++++++
>   EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml |  85 +++++
>   EmulatorPkg/PlatformCI/PlatformBuild.py                   | 272 +++++++++++++++
>   EmulatorPkg/PlatformCI/ReadMe.md                          | 128 +++++++
>   OvmfPkg/OvmfPkg.ci.yaml                                   |  83 +++++
>   OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml        | 133 ++++++++
>   OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml     | 138 ++++++++
>   OvmfPkg/PlatformCI/PlatformBuild.py                       | 254 ++++++++++++++
>   OvmfPkg/PlatformCI/ReadMe.md                              | 137 ++++++++
>   OvmfPkg/PlatformCI/iasl_ext_dep.yaml                      |  21 ++
>   ReadMe.rst                                                | 354 ++++++++++++++++++++
>   Readme.md                                                 | 235 -------------
>   25 files changed, 2670 insertions(+), 243 deletions(-)
>   create mode 100644 .azurepipelines/ReadMe.md
>   create mode 100644 .azurepipelines/templates/ReadMe.md
>   create mode 100644 .azurepipelines/templates/platform-build-run-steps.yml
>   create mode 100644 ArmVirtPkg/ArmVirtPkg.ci.yaml
>   create mode 100644 ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>   create mode 100644 ArmVirtPkg/PlatformCI/PlatformBuild.py
>   create mode 100644 ArmVirtPkg/PlatformCI/ReadMe.md
>   create mode 100644 ArmVirtPkg/PlatformCI/iasl_ext_dep.yaml
>   create mode 100644 EmulatorPkg/EmulatorPkg.ci.yaml
>   create mode 100644 EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>   create mode 100644 EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
>   create mode 100644 EmulatorPkg/PlatformCI/PlatformBuild.py
>   create mode 100644 EmulatorPkg/PlatformCI/ReadMe.md
>   create mode 100644 OvmfPkg/OvmfPkg.ci.yaml
>   create mode 100644 OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>   create mode 100644 OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
>   create mode 100644 OvmfPkg/PlatformCI/PlatformBuild.py
>   create mode 100644 OvmfPkg/PlatformCI/ReadMe.md
>   create mode 100644 OvmfPkg/PlatformCI/iasl_ext_dep.yaml
>   create mode 100644 ReadMe.rst
>   delete mode 100644 Readme.md
>