From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.92.19.28]) by mx.groups.io with SMTP id smtpd.web11.1654.1586483332280124442 for ; Thu, 09 Apr 2020 18:48:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=BTaTV/u9; spf=pass (domain: outlook.com, ip: 40.92.19.28, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hNFBYaMiFR5T0TXZjDI4ccMkX093aXONrHkuoGFlpoFvXcFoLV5RfuSU9c/mIQSuTzFm3AQoDPsSl5ZaHAvhRHisfHEEsRb0T7VDSOgI329sHiN/L5JgSOBoPpGMP1e+qtF+3Ne2CgjozQbEKOqUfHsk8rkIvtUaxPxTtrpr4GKj7tvNUGTpy1gGoN8fmDb7BQtG4sNR2BzDc+qHzW46V7g60p9Upgfryh++An1QmnmaE2lmQzVW04J/Jh9fMXiv5ZolcHy3EXL/gdfJyvqCRR912jGXWzV3YLddq9hXkNR6btcGjZNph6F2lG/Gn1CEx7n4bkU439cUR+ZTTQcJ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=REIoWFRNIRpusU0ceS2ZjsaEX9YObreLYqvwGtQa1N4=; b=SQzBcSM0b4NgLx+Tk8c3xyjzWc97QpKYhXqphySaSI4hItCCSHPUa7bdUIJkrU+tcVFB++dpad6158VfYIg6NPRVpugSRqf94cCbkv+9yKvQVGHubSvEj8mQKj1EmtkKFATRnPXCBeXIRgpNHkjyc5JGPM1fTLhVUkvNTiUcBqbCC/YnQEitG02654IxsHZn2TkmIamiW81GySbzCVlCNvE55zhEyRAeBWik6KYwb4guZuJEocheFmKj/zAT1ipVzMHqeGIl1CAHeJXwZxHNv2ZMQcn0zAXV4+zXxc5y4+/ZZFvc363kqGY2054OqIHibRyArclSg+YOhNx9W4kR/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=REIoWFRNIRpusU0ceS2ZjsaEX9YObreLYqvwGtQa1N4=; b=BTaTV/u9BsK+wXJzthL0qy/faziaf/xt9EBULxfhF7+dk5jVRzL5DVNJDNEHfsoFSaQFIJNaP9lluJwD75K7Km5n3UonUwy8tV/L155flmW/mkMYV1CzW3ABND8F0Z46Gzj0S137f5jeP6qLGgawEPGvPurgF0ekCQephguYD4sca2SApFRxZJEHyzBgDs62+yJJvd3DztlIUorOMsIGUvzj3DQ9JP0lBrgP0zuxr3ZtAsuuJ9B74sshExh3f9PTXz1s76x31T9fuFOP5hlONRnq94qhPqqWks/TlbxE0xSMZJllC/Ch8uILPTmgs5IjJT7bUNZBEfuE28rsplkmoA== Received: from CO1NAM11FT032.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::49) by CO1NAM11HT245.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.18; Fri, 10 Apr 2020 01:48:50 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:3861::48) by CO1NAM11FT032.mail.protection.outlook.com (2a01:111:e400:3861::218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.18 via Frontend Transport; Fri, 10 Apr 2020 01:48:50 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:33F12ED2A0DF79B58FA8457AE9E001DE8559A6AD4000382B80E1E5EC29F0ED10;UpperCasedChecksum:7ECACE014B6E2126FA3D1CCC31C0E99231DCA5C7D18393B9F0A22CB904D156B0;SizeAsReceived:9396;Count:50 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3%6]) with mapi id 15.20.2900.015; Fri, 10 Apr 2020 01:48:50 +0000 Subject: Re: [PATCH v1 0/7] Add linked list iteration macros to BaseLib.h To: "Wu, Hao A" , "devel@edk2.groups.io" Cc: "Zhang, Chao B" , "Bi, Dandan" , "Wang, Jian J" , "Gao, Liming" , "Kinney, Michael D" , "Ni, Ray" , Sean Brogan References: From: "Michael Kubacki" Message-ID: Date: Thu, 9 Apr 2020 18:48:50 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 In-Reply-To: X-ClientProxiedBy: MWHPR22CA0063.namprd22.prod.outlook.com (2603:10b6:300:12a::25) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <32c1865a-b768-fe6c-80ed-aae54b09cac6@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:7169:e1b0:d9a4:a469] (2001:4898:80e8:7:f18a:e1b0:d9a4:a469) by MWHPR22CA0063.namprd22.prod.outlook.com (2603:10b6:300:12a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.16 via Frontend Transport; Fri, 10 Apr 2020 01:48:50 +0000 X-Microsoft-Original-Message-ID: <32c1865a-b768-fe6c-80ed-aae54b09cac6@outlook.com> X-TMN: [W50+7R9+1VDFOHzclKQopp2nxHVkzsLgmF6D+yDYvQ/W0oI9zU6dZUgrenj+Ath+] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: fc64f7bf-ebbf-45ae-c675-08d7dcf1514f X-MS-TrafficTypeDiagnostic: CO1NAM11HT245: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FD/g0NburYCny6nsTWoXdfbaID4pyG+tU/sxHruoZi9HY4DYJ4gr3L7TDqjrqUrv8SOn5iU+fKQBzu8FqOpgYrcefObNKVqJMjS1EqUgiSYTfQLWxSM78IgSk8FTBDREwK5BISgoRCUa2kgmimi0m3hT45rdvemar+XeLiPxfy9+4rt52xqovIVd2DjadcQWRxOSctjZGkoqpfFSwI+ro689vRfAwOuMldNQ9D01uNM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: 9gbElLCEfUbLZtS3tvwpKwdx+QLcJldvd94U9f/ESNcdASmG4itV5fHeVZF8aY+r0G68yMpk4DT6WFnR62ouKF8t6BPVltIbZUY1kMOODEWvRl5xR/tpM4TZcVzjYLQcmmxjfXLm7kVNWpdAcKksj7d5Yd+kqlFNCRPVadtW4olZrjqd+OHP6oOq1GInr0Zak9Y+6LKaty9z766jvLWybA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc64f7bf-ebbf-45ae-c675-08d7dcf1514f X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 01:48:50.7655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM11HT245 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I agree it should be added. I'll leave the series up until tomorrow to collect further feedback and then I will send out v2 with R-bs and modifications included. Thanks, Michael On 4/9/2020 6:43 PM, Wu, Hao A wrote: >> -----Original Message----- >> From: michael.kubacki@outlook.com [mailto:michael.kubacki@outlook.com] >> Sent: Friday, April 10, 2020 4:05 AM >> To: devel@edk2.groups.io >> Cc: Zhang, Chao B; Bi, Dandan; Wu, Hao A; Wang, Jian J; Gao, Liming; Kinney, >> Michael D; Ni, Ray; Sean Brogan >> Subject: [PATCH v1 0/7] Add linked list iteration macros to BaseLib.h >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959 >> >> The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been >> duplicated across several drivers such as: >> >> * EhciPei >> * EhciDxe >> * HddPasswordDxe >> * RamDiskDxe >> * UfsPassThruDxe >> * XhciDxe >> >> These macros have proven useful and established a commonly used pattern >> for linked list iteration. >> >> This patch series consolidates the definitions to a single definition in >> BaseLib.h so they are maintained alongside other pre-existing generic >> linked list macros and functions. >> >> Note: Another commonly used generic linked list macro is >> EFI_LIST_CONTAINER. >> I'm considering consolidating that to BaseLib.h as well but that is not >> done in this patch series since it satisfies a separate use case than the >> iteration macros and the change can be made independently. >> >> On a separate note, shallow threading might not work on this patch series >> due to changes made by the SMTP server. Please bear with me while I am >> investigating if this can be changed. >> >> Cc: Chao Zhang >> Cc: Dandan Bi >> Cc: Hao A Wu >> Cc: Jian J Wang >> Cc: Liming Gao >> Cc: Michael D Kinney >> Cc: Ray Ni >> Cc: Sean Brogan >> Signed-off-by: Michael Kubacki >> >> Michael Kubacki (7): >> MdePkg/BaseLib: Add linked list iteration macros >> MdeModulePkg/EhciDxe: Use BaseLib linked list iteration macros >> MdeModulePkg/EhciPei: Use BaseLib linked list iteration macros >> MdeModulePkg/XhciDxe: Use BaseLib linked list iteration macros >> MdeModulePkg/UfsPassThruDxe: Use BaseLib linked list iteration macros >> MdeModulePkg/RamDiskDxe: Use BaseLib linked list iteration macros > > > Hello Michael, > > I found that for EhciPei, it does not have explicit dependency on the BaseLib, > could you help to add it? > > With this handled, for the MdeModulePkg changes (patch 2~6): > Reviewed-by: Hao A Wu > > Best Regards, > Hao Wu > > >> SecurityPkg/HddPassword: Use BaseLib linked list iteration macros >> >> MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 3 ++- >> MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 11 ++++---- >> MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 5 ++-- >> MdeModulePkg/Bus/Pci/EhciPei/EhciSched.c | 3 ++- >> MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 5 ++-- >> MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 9 ++++--- >> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 3 ++- >> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 3 ++- >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 3 ++- >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 9 ++++--- >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c | 5 ++-- >> SecurityPkg/HddPassword/HddPasswordDxe.c | 13 +++++----- >> MdeModulePkg/Bus/Pci/EhciDxe/Ehci.h | 15 +---------- >> MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h | 15 +---------- >> MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h | 9 +------ >> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h | 9 +------ >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.h | 15 +--------- >> - >> MdePkg/Include/Library/BaseLib.h | 27 >> ++++++++++++++++++++ >> SecurityPkg/HddPassword/HddPasswordDxe.h | 7 +---- >> 19 files changed, 75 insertions(+), 94 deletions(-) >> >> -- >> 2.16.3.windows.1 >