From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.92.40.20]) by mx.groups.io with SMTP id smtpd.web11.2008.1587669897558491254 for ; Thu, 23 Apr 2020 12:24:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=WBV8aXiU; spf=pass (domain: outlook.com, ip: 40.92.40.20, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlLfxJDqbDLIW93ljzJhf/krADDN3xw1ooRGO4hakC5EojUHOyoMOMJ/6L4ieEV9C1MSy2l+A5KrmcR6vhISl4FurEFoYO6qQzGSyrH83t8eLJlS24y7BTggh7BzJFfSrQ/B5LVmIEqYqIDgG35t/oPBvWLv7hc+SqgapMJC4gHTT92BycfmIG064AUdZI3uc+cjKoWFuEAEHV9whvi3zrh7DtS241qOY2m9kck4GSXz+PS8hdoN9MHAJGvM9NLvI+0mUzfgmsrGMpkWr2+Yl2q19knzXj0lw0fiRrunqMstHB45Ex4Pw9MH70duvP7h9sWxHLzyV9v3LbIgv6f37w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DnLL6xVIubCZ2y92wHla1u/nfwN9iiAJGQsPLp4o6T0=; b=hi5QcGP6JFa6COH3ZaDOROgANsAkBsACFt2krhxSEXQtlx9Us5PtjyYy9YQbyGCAWlUBsXDWxWJsF8YbSJ6nXpyHLm/QIIoPTNxtwe5taJxNQtflHrtAbTpwK1FeNAj2/DXwiHyEFDHZ6025ovMaYfrMg0A6acab5pSXUWiliCe8OtkFz0xp17kW1GBZXfTymBzzsCoXKjWe2Tug8lFNczeZPUybKMl4z3HxXGLQmHKVzXaMhUkB/hxh8QBGvF5O9iDHnf7X3kv94o5387jKg8z/4CFYImG0rDA+qW3u969c3Z6j/PzH2aXRNE7SiK18xNTYB1lZwW4UdHaIWW2YyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DnLL6xVIubCZ2y92wHla1u/nfwN9iiAJGQsPLp4o6T0=; b=WBV8aXiU/v9qgFcA1cKg01rGcLIewA1CD9iLmLNU8b6eqpIYem2YLd/6VFy/u9yYwsK9Ywp+0A0cFktQWDQcB91a9Kgds5Hg/UXNIQ+gzUNi6gWVV/t9E10VGYUmZ0eo4x0h2vVKDy5BRQp83thsZ9A+0DKUcMAY9tlOT0GYImbI8HbADIoopObh92idoBsmJxjm+ujhx6SkfeFUNXvrghTl+OYJSx3ynQhZJ0UJmRoH9QrhN4p6876AFjCzXVfFeClRSu7nUbvGkr8WXMnQWHXeNtVSyyzwNzGWYV2ro1FkzY2DTcVUEhTdbuqCnP0yPH8riH7zq1F3HHqF4j6Dmw== Received: from BN7NAM10FT030.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::52) by BN7NAM10HT052.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.15; Thu, 23 Apr 2020 19:24:56 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:7e8f::46) by BN7NAM10FT030.mail.protection.outlook.com (2a01:111:e400:7e8f::101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.15 via Frontend Transport; Thu, 23 Apr 2020 19:24:56 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:AF8B8CA086667FFD988FB49CABBB6DF5FEF530872529395F5E03E2FB03C09ABA;UpperCasedChecksum:07521832056EC9733D172C99540251EBBA6EE168E47C77823CF6DC57D3F7EE06;SizeAsReceived:9090;Count:50 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3%6]) with mapi id 15.20.2921.030; Thu, 23 Apr 2020 19:24:56 +0000 Subject: Re: [edk2-devel] [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code To: devel@edk2.groups.io, heng.luo@intel.com Cc: Liming Gao , Eric Dong , Ray Ni References: <20200423084258.1100-1-heng.luo@intel.com> <20200423084258.1100-3-heng.luo@intel.com> From: "Michael Kubacki" Message-ID: Date: Thu, 23 Apr 2020 12:24:55 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 In-Reply-To: <20200423084258.1100-3-heng.luo@intel.com> X-ClientProxiedBy: MW2PR2101CA0028.namprd21.prod.outlook.com (2603:10b6:302:1::41) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <2a4f0595-ee6a-2ec9-5a4d-b97bc7ba7659@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:3ca8:b84e:3eea:df33] (2001:4898:80e8:3:bccd:b84e:3eea:df33) by MW2PR2101CA0028.namprd21.prod.outlook.com (2603:10b6:302:1::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.2 via Frontend Transport; Thu, 23 Apr 2020 19:24:55 +0000 X-Microsoft-Original-Message-ID: <2a4f0595-ee6a-2ec9-5a4d-b97bc7ba7659@outlook.com> X-TMN: [8OWi7B6YMxc6cjnUEdT0c7QdTy6wsIjU7lXdwN1sMrYMUJFRaTU0dx9O2sFzMaXN] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: fd4e5eb0-6b4d-448b-d58a-08d7e7bc00e9 X-MS-TrafficTypeDiagnostic: BN7NAM10HT052: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4I3TvKWlmP2XKfFycipRXKlo/bKPqe++SGi6XxHqzLE3p6rmUizO9WfyfFITNinJs0AfCc3zgtgKh6PHWwzbgBnFQdSQIJBSiantHjlmZVu4pgD213q1MpVYkhUpOwbv0SglPE+a6JcDH8Zp42KLEXOHzmEtLhm0Qm9RiQ0wRoBQKQi5WlZUJfaz6M9pafOX721w+UhuxWzqfWL4XXW9i21mNROnffFnVm13M8yYt1KVS4ogY8rUjkZAaHXFBrTM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: Zs3B/FwDnjpbm+z6dhTanOHTEcPEu5q4QoHFUf7cgDWlffBMPiOMEXaPDHM2bF9wFwG/FX34QhL87Wwh/YuDcLRX1fMH3UQppFLcAz3QICKcUKLkM5/cVlJozvLETB5YbjZZGLkGJMU5CwDbY69mKB0TWqol4GVD2bYRGW/ylvx3uCMdwb4pdLdwLzwh3hPUc6ySESd9R7dWY3gJkWQDYg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd4e5eb0-6b4d-448b-d58a-08d7e7bc00e9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2020 19:24:56.0011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT052 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Reviewed-by: Michael Kubacki On 4/23/2020 1:42 AM, Heng Luo wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2688 > > Use AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc instead of > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc > > Cc: Michael Kubacki > Cc: Liming Gao > Cc: Eric Dong > Cc: Ray Ni > Signed-off-by: Heng Luo > --- > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 2 +- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 2 +- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 2 +- > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 2 +- > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 2 +- > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > index 14e82ba34d..8e04ca8a4f 100644 > --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > @@ -39,7 +39,7 @@ > # > > # Include PCD configuration for this board. > > # > > - !include AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc > > + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > !include OpenBoardPkgPcd.dsc > > !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > > > > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index bf63d53bef..7bb8cd5279 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -38,7 +38,7 @@ > # > > # Include PCD configuration for this board. > > # > > - !include AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc > > + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > !include OpenBoardPkgPcd.dsc > > !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > > > > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > index 044688ba4e..ef82f8b716 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > @@ -37,7 +37,7 @@ > # > > # Include PCD configuration for this board. > > # > > - !include AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc > > + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > !include OpenBoardPkgPcd.dsc > > !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > > > > diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > index 350a75a313..3bafc1ff0a 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > @@ -42,7 +42,7 @@ > DEFINE NETWORK_ISCSI_ENABLE = FALSE > > DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE > > > > - !include AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc > > + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > !include $(PROJECT)/OpenBoardPkgPcd.dsc > > !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > > > > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > index 2ab9cb03ea..07cf311210 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > @@ -39,7 +39,7 @@ > # > > # Include PCD configuration for this board. > > # > > - !include AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc > > + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > !include OpenBoardPkgPcd.dsc > > !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > > > > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc > index 1a9e608bd6..1dace5ee22 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc > @@ -39,7 +39,7 @@ > # > > # Include PCD configuration for this board. > > # > > - !include AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc > > + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > !include OpenBoardPkgPcd.dsc > > !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > > >