From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.92.42.101]) by mx.groups.io with SMTP id smtpd.web10.682.1597091301393601537 for ; Mon, 10 Aug 2020 13:28:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=uL/POiGq; spf=pass (domain: outlook.com, ip: 40.92.42.101, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EISJFW/6vGCabwA+5GBlkWfWUBna9sT1A05oyktwJtLDGk/ukpRKbf4b7tEICglIZla+FJvIBp//3SC0JMyJPlDBIZnTwACzuKrn+zY4HC1muI5j6we60NdHXYDcPc1EUBmUf5vO1xqiYQoSSRwBKga3lTHubp8/4YuNB16fjfS7TJ9KYKXNTPHjZUlU9cjkv2isDYNJ1FtME2pMBwPNaT6yfJ+x7fy+V3/D15Xs6nBeEAM5w65iN3edmTnNr07mfj9+Q+TLpybW0YvYTeoxGIfF7iwNNhHsidUabn1KeF/Ya+oCHaWuPWBDX2h8F5LwEkpMFpDSttQEZdmK85/s1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tmPqQCTttKIeCw/VP6wbB9GRHAXIvvUef9Rvyt8NUKc=; b=ISrwRLD7tz7+kMcT7mCH+Ef+bRPIF3/2mmb0dAszrcXpNOcpoCIclpGouSaELE/281vMiLx7ZCZMaOhFZmVqPT2xUadeN068GGsU42vt0NCqiWk5xm/fr4PjR6b1NsFzuntJh+JVw63f4tUL2HhRsTQ7AXVCYcSl+Q09BoY+Q6V4LCvalvPgEqOwSVuNwFTJ92Rps4uKV5JbLMLZCP3fRRP6RC+TGIkF8yUDVv8a127gMib7dJL+l7TedGRoALl748s4IKjXuwmRK7J+CEcVAWISJ0+RHlFuNPdvIsdnUQk6Dono4efaguYOWZOo3dfoomjKbk8Ea/ghhwF2aOHsqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tmPqQCTttKIeCw/VP6wbB9GRHAXIvvUef9Rvyt8NUKc=; b=uL/POiGqHUHx+0chWVd8rHm7vEcnWJtCP9N1pp4+VuL4kRaD5aKokoQIXqUnFmipITpmoiUrnwJ4/vNB5tst9sNNLqs0wcmiZYxTB6M4q56Wd2TeYjJ5WaYLX6dN0/Cri1jnIjnv4+zprQIP2O75a/PiJ7LIpPwua5FEE+0Lj7FNuHAFO2Q2y8y4Iw8r4q6E9iTjDFrjUpvjPdPBj2GFn0STMxgRFhu+eb+29gMXEx2FEXNHNiXeHIL4aD8k23lrT8MVgCS9v1uGVUR6tb22Fu/Cp3sS9CCPyUR9X5YTt2xbmH1qcM7gL5Yk4WeqO1J9camQWUQ4wusPBQXzVsne9A== Received: from MW2NAM10FT048.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::49) by MW2NAM10HT229.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::465) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16; Mon, 10 Aug 2020 20:28:20 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:7e87::44) by MW2NAM10FT048.mail.protection.outlook.com (2a01:111:e400:7e87::98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16 via Frontend Transport; Mon, 10 Aug 2020 20:28:20 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:E7538CF4826D344A483D02F8F9A09AC0E5392A809F54ADD90A124F3671FAEC83;UpperCasedChecksum:72120DE08D05B98319C37711AF34DF85BF0E0292B3B4282A6B2ED5CAD891630B;SizeAsReceived:7680;Count:47 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e%7]) with mapi id 15.20.3261.024; Mon, 10 Aug 2020 20:28:20 +0000 From: "Michael Kubacki" To: devel@edk2.groups.io CC: Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu , Zhiguang Liu Subject: [PATCH v2 0/6] Extend Last Attempt Status Usage Date: Mon, 10 Aug 2020 13:27:47 -0700 Message-ID: X-Mailer: git-send-email 2.28.0.windows.1 X-ClientProxiedBy: MWHPR13CA0008.namprd13.prod.outlook.com (2603:10b6:300:16::18) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <20200810202753.1318-1-michael.kubacki@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2001:4898:80e8:1:cc6:648f:7db1:5bf9) by MWHPR13CA0008.namprd13.prod.outlook.com (2603:10b6:300:16::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.10 via Frontend Transport; Mon, 10 Aug 2020 20:28:19 +0000 X-Mailer: git-send-email 2.28.0.windows.1 X-Microsoft-Original-Message-ID: <20200810202753.1318-1-michael.kubacki@outlook.com> X-TMN: [2C6jMGU0V2wqFlMpakBlXy0lpuJO4COkr6Gk+i0yrZn4WbDX2mwNjYm7DDJH9HVz] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 1de82067-1ffc-4d67-c22b-08d83d6beb85 X-MS-TrafficTypeDiagnostic: MW2NAM10HT229: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LJEK231OFFvRm6VlnxNl8fDN3AUXJ5I9+qRYvgIu7RqjCYWq4zKrg65hNcYvJ778nPpOKQROjaB7cm1JRWaeTnqPRnqdk/ASRrSbpVWbZ1Ok9jJy+r9CxbKd2FLQsjpMwnLBB39Zs081UnmKsoMhvLIrjY9O/vdKgbtjCPFLLJ6tXSoxujCmJh24quk9aNu8qNXoEte3u+hJHkj0DRq8ElwkEottDnpcmx1f56hCPuKQk4t3cEoqur2tJ5+4aB/H X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: bPIDfC33GlhAxOxO6S+sSq7rrANkGe75b5eIHTyrQsgnY5rRDD0ED6PuIyqYm+eW4rW07mJ8S2glbs5DvYFLIGcHapKj/vOsCaZgckrwrd5eg0MM07FSd80DzoSk5kpmacKvSiInuUE+SbMqnBPJCy4s+5oDxkhj9tdvPxL8GNMXZ0NymZtLTrSvpll/WFirpQO66rUHee2LzOlQkGA0xA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1de82067-1ffc-4d67-c22b-08d83d6beb85 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2020 20:28:19.9389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT048.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM10HT229 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2802 This patch series adds more granularity to Last Attempt Status codes reported during FMP check image and set image operations that greatly improve precision of the status codes. The vendor range (0x1000 - 0x4000) was introduced in UEFI Specification 2.8. That range is used within this patch series to define three subranges: 1. FMP driver codes 2. FMP dependency related codes 3. FMP device library codes Most of the vendor range remains allocated to vendor device library codes. There might be a preference to move some of these codes explicitly to the UEFI Specification or other ranges in the Last Attempt Status space. That is left open to feedback to the series. V2 changes: 1. Consolidate all previous incremental updates to=20 LastAttemptStatus.h into one patch (patch 2) 2. Move LastAttemptStatus.h from Include to PrivateInclude 3. Correct patch 1 subject from "FmpDevicePkg" to "MdePkg" Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Cc: Zhiguang Liu Signed-off-by: Michael Kubacki Michael Kubacki (6): MdePkg/SystemResourceTable.h: Add vendor range values FmpDevicePkg: Add LastAttemptStatus.h FmpDevicePkg/FmpDxe: Add check image path Last Attempt Status capability FmpDevicePkg/FmpDxe: Improve set image path Last Attempt Status granularity FmpDevicePkg: Add Last Attempt Status support to dependency libs FmpDevicePkg/FmpDeviceLib: Add Last Attempt Status to Check/Set API FmpDevicePkg/FmpDxe/FmpDxe.c = | 180 +++++++++++++++++--- FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c = | 38 +++-- FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.c= | 9 +- FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c = | 95 +++++++++-- FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c = | 42 +++-- FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/EvaluateDependencyUnit= Test.c | 7 +- FmpDevicePkg/FmpDxe/FmpDxe.h = | 3 +- FmpDevicePkg/Include/Library/FmpDependencyCheckLib.h = | 8 +- FmpDevicePkg/Include/Library/FmpDependencyLib.h = | 44 +++-- FmpDevicePkg/Include/Library/FmpDeviceLib.h = | 44 +++-- FmpDevicePkg/PrivateInclude/LastAttemptStatus.h = | 81 +++++++++ MdePkg/Include/Guid/SystemResourceTable.h = | 4 + 12 files changed, 462 insertions(+), 93 deletions(-) create mode 100644 FmpDevicePkg/PrivateInclude/LastAttemptStatus.h --=20 2.28.0.windows.1