From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.92.22.22]) by mx.groups.io with SMTP id smtpd.web12.386.1596663636574394199 for ; Wed, 05 Aug 2020 14:40:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=Mq9KrbTQ; spf=pass (domain: outlook.com, ip: 40.92.22.22, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RXqZl5lg9tzP+uFKKwOksyqQFflOpgoOaWMH6jBEDQrDMg4e9IaFqvItnwwTcWle+elWeODm0S5EGfjyBd7qMCa/ahCJ5c/FY5MsS+zpuhA5AXZEITtRXSImyy7tBszWwJ59cy/EffYhxF7nfhASa8LMcX8QbwFbmO1s8oBKKf/1htV63d+9LFO1SGuRVcSxgTMp5wXzvlyKEqjcBpLdeTBUPU2Qo2wL1wEGOYeje+pgb3XzZQkieSDd2LF4NM7eJ8gDBVBnSXZVLq6zf+N918p/wtpkwxpYsiGf4y5St8/Uq1pZJFO0oq+Kmk0Od6d6OR62JpVD76bFulA9r4kf9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6Xy3VCOIifBLpWDptTrS5K+8lilaOiLJd8pK/JZ1II=; b=NwTlINA9DIS6fvLyjaLmoNMTSLwChC6LATEKxUJXZGT4XhENO15yhdK2/EiW8Uih1YIb1TGGpXSzImDDwtA83LeOQ6oMqyQlSgTZLNrcNgvfeFA88TFpNV8rJh88ln5eyTupEIWIaHsLi50BDgvfzooTIeOazyGU/+V4TdpY3NRHmtFKQPtvRFOjH7vUWsX7b5Qw4uuMmgRc8Q6gSWCz7C98fGuNE7sJNroIV4u3DRYJlHEc5OCQHGYBgEhFl/qDjdcTovPElYrN7UVAWu1sD1OM6dXPcFF6SlMrSGhcdtNfg+hT0cBom1LvZQqY3OWo1EgW3Do8C0F246FYzFXLbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6Xy3VCOIifBLpWDptTrS5K+8lilaOiLJd8pK/JZ1II=; b=Mq9KrbTQJym6yygUqBsi5uWUYJI/zsz/Yu+vVXoWRdFXT1uNooiejlwzkiLiHh2mkdJRz78qnfnvTt2/Ilq/yVIiBf7hAaFuBG9ygwH3WhYg3Cx0HhUaMwwfvVaFtiSt40fOH4CTisR365QSEg0FdA8BJlgJwHLqVt5/D27Y3XC+M2ZoneDwh0SF8az6HAZb0U/OwvcXvnoIIOMPxz0DvrY3TYJ+rcskV29oKiqprgH/B0KcX8k4JNCDHuboZeMScGwhOs2gPX1U4kOoTcSZDjAa5O5iTHh18CwsvO6YO10iu0oBRlMxTWEBFvFbXafhR4+Ld9lYjGLRYsy3Wo8TGQ== Received: from MW2NAM12FT045.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::41) by MW2NAM12HT215.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::478) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.10; Wed, 5 Aug 2020 21:40:35 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:fc65::42) by MW2NAM12FT045.mail.protection.outlook.com (2a01:111:e400:fc65::268) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.10 via Frontend Transport; Wed, 5 Aug 2020 21:40:35 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:C389492DDA0AF3BCCCA610EE0771ED7697FD9088BBE83DAC2F8FAA788D4ED90B;UpperCasedChecksum:6CAE4B53DB9022EC526FD88EC575769163407A6141A09EE91F92EBCF3F48C6CB;SizeAsReceived:7806;Count:49 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e%7]) with mapi id 15.20.3239.022; Wed, 5 Aug 2020 21:40:35 +0000 From: "Michael Kubacki" To: devel@edk2.groups.io CC: Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu Subject: [PATCH v2 6/7] FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName Date: Wed, 5 Aug 2020 14:39:43 -0700 Message-ID: X-Mailer: git-send-email 2.27.0.windows.1 In-Reply-To: <20200805213944.1811-1-michael.kubacki@outlook.com> References: <20200805213944.1811-1-michael.kubacki@outlook.com> X-ClientProxiedBy: MWHPR2001CA0014.namprd20.prod.outlook.com (2603:10b6:301:15::24) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <20200805213944.1811-7-michael.kubacki@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2001:4898:80e8:a:f5bb:f844:3092:4e93) by MWHPR2001CA0014.namprd20.prod.outlook.com (2603:10b6:301:15::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Wed, 5 Aug 2020 21:40:35 +0000 X-Mailer: git-send-email 2.27.0.windows.1 X-Microsoft-Original-Message-ID: <20200805213944.1811-7-michael.kubacki@outlook.com> X-TMN: [NV64bqcD4NhQXpfTRFc8xQGbEaEQIWytCmwaxdnSlNex9Sl+XrQkCJbORQIsQaX7] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 6f093e7c-e633-4e84-fc97-08d839882fda X-MS-TrafficTypeDiagnostic: MW2NAM12HT215: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YlHJ+z7pP9cJ84IqXDRUB9qL3s8J06ugeMKBscRWAxh3GUFU7mahr0QR1FBRGXsAtTWGKblfx+a/pqsG4dvWWxNZAV2NjuHVH5BsggU5UQWy1441J8uWHHXv7ZEKuFExi6SMCzV5UK90KU9cKsRCgtL2xrtwem5yr4WNS6K/3ohSpUjPdMcUuc7AAodSwc9Q1UhZ9D4+brNfwkAZbV1a8w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: T2/okIpvPGYSmtUVVMCEOoj7542y7/YiRq57+K31N7xe4d90mHe7Z0hcSPhCxgpHLcx5U7GWbNEb4pRxuKoDfFgLcKuyrIc49cRotoUjZ3GatkoS/gnTOhu1TxiN3dx9tF6PRUrCEvoSNa5lWjB5OrYgcNo20n04nf8+48Nxn+p2HscUPJvLhXG6Cdybs6Ow6GglejvCNy6MUetIWdbjLw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f093e7c-e633-4e84-fc97-08d839882fda X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2020 21:40:35.5910 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT045.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT215 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Michael Kubacki Updates the debug error message to include the GUID of the FMP instance that encountered the issue to help the user better isolate the problem. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney Reviewed-by: Guomin Jiang Reviewed-by: Wei6 Xu --- FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index 14994ce4ee0e..a3e342591936 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -1679,7 +1679,7 @@ FmpDxeEntryPoint ( // // PcdFmpDeviceImageIdName must be set to a non-empty Unicode string // - DEBUG ((DEBUG_ERROR, "FmpDxe: PcdFmpDeviceImageIdName is an empty stri= ng.\n")); + DEBUG ((DEBUG_ERROR, "FmpDxe(%g): PcdFmpDeviceImageIdName is an empty = string.\n", &gEfiCallerIdGuid)); ASSERT (FALSE); return EFI_UNSUPPORTED; } --=20 2.27.0.windows.1