public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <michael.kubacki@outlook.com>
To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com
Cc: Chasel Chiu <chasel.chiu@intel.com>,
	Rangasai V Chaganty <rangasai.v.chaganty@intel.com>,
	Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>,
	Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>,
	Prince Agyeman <prince.agyeman@intel.com>,
	Michael Kubacki <Michael.Kubacki@microsoft.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver
Date: Wed, 22 Apr 2020 11:14:07 -0700	[thread overview]
Message-ID: <MWHPR07MB3440516654103481B1485291E9D20@MWHPR07MB3440.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20200421204028.10410-2-nathaniel.l.desimone@intel.com>

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 4/21/2020 1:40 PM, Nate DeSimone wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
> 
> Added a DXE driver that registers the minimum platform
> BDS hook points, to WhiskeylakeURvp board.
> These hooks are triggered on the BDS hook events
> 
> What was done:
> 
> * Included an instance of BdsHookLib and BoardBootManagerLib
> from BoardModulePkg
> 
> * Included BdsHookDxe to register the callbacks implemented
> in BdsHookLib
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
> ---
>   .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc      | 4 ++++
>   .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf      | 1 +
>   2 files changed, 5 insertions(+)
> 
> diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> index 14e82ba34d..958a2d0c50 100644
> --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> @@ -224,6 +224,8 @@
>     #######################################
>     DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyUpdateLib/DxePolicyUpdateLib.inf
>     DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtPolicyLib/DxeTbtPolicyLib.inf
> +  BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf
> +  BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf
>   
>     #######################################
>     # Board-specific
> @@ -452,3 +454,5 @@
>     $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
>   !endif
>     BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
> +  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
> +
> diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf
> index e2d40bcbb6..31f4d22311 100644
> --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf
> +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf
> @@ -346,6 +346,7 @@ INF  MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf
>   INF  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
>   INF  BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
>   INF  MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf
> +INF  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
>   
>   INF  ShellPkg/Application/Shell/Shell.inf
>   
> 

  reply	other threads:[~2020-04-22 18:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 20:40 [edk2-platforms] [PATCH V1 0/2] Integrate BDS Hook Points into New Platforms Nate DeSimone
2020-04-21 20:40 ` [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver Nate DeSimone
2020-04-22 18:14   ` Michael Kubacki [this message]
2020-04-23  8:26   ` Chaganty, Rangasai V
2020-04-24  6:44   ` Chiu, Chasel
2020-04-24  7:09   ` Kathappan Esakkithevar
2020-04-24  7:33   ` Chiu, Chasel
2020-04-21 20:40 ` [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: " Nate DeSimone
2020-04-22 18:15   ` [edk2-devel] " Michael Kubacki
2020-04-23  8:29   ` Chaganty, Rangasai V
2020-04-24  6:44   ` Chiu, Chasel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR07MB3440516654103481B1485291E9D20@MWHPR07MB3440.namprd07.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox