From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.92.20.77]) by mx.groups.io with SMTP id smtpd.web12.1284.1587579250672552597 for ; Wed, 22 Apr 2020 11:14:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=ZEPzB378; spf=pass (domain: outlook.com, ip: 40.92.20.77, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b0ZMaPKELYvHsxYuZYXuhup2XekmxnqNxrX/EDgZULV/sUt7FVFpX28swg1SV3rpRNJ90SU398TSeJYCYVKxz6MKXOgfftB5Z4ipIUEbh+ChHQfflcrXkj7i4nuihSmlkzjhG9nIk6vSQy4AiJws+AwCZWGGuTVWxUbsdYvKq3MEiLK7muMMmMk1qetOnEZz+ZVoDARHG8a9f74XFV0XgdafTIpzzQdDxExHg45/GMmgKtJ7RueX6XlPGoy1qMwNS+AlopJwXrfUCXUM7HYh/MTLsfLntlOiCvuFiMKZ4YltjYhcUBbP2usrppqNMdwePUr4ru4KRYTInzHXTo9hDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OcP52aYQWm2+c4Bi92ybNngg28iMDZ2JK+dFHcUk23Y=; b=GIlI0cCV/rj2ERwjxaGA2eibkBR60DtCF3jvZyWSPVzdxpkjwhFd64sDBt4uTEAVYMePrq45bNBSCLEKlrA64g2DOVie7XnVq5mmGGsPpbOTCnNkvtoQmYbBzNLTpRtOEeeO4iWBlt6rCw5+UA5Lo3vzOKMmxtBYnmH1uTk1HD0aRAf9sp+qdiBYeqXyai3Jkh0G3r/uhrhDZJGlvD8eWyPVTWxf3c8seMXLYStKD0DHBw28DGrzkIO32m8NdxXEiPJ//FIEHlSXpEoX6cZJtLUdNX7R9p8/QUOcXDUEQaBcYQivdvYKqSjR8Z7Xbjtf1nkprtOVz/eH/VCjHxKhUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OcP52aYQWm2+c4Bi92ybNngg28iMDZ2JK+dFHcUk23Y=; b=ZEPzB378IMxxtx4uFxU3Sq9K5NyYxRVB1jXY5RymMlp5v6/zrKRgPPNBK3DGfME5OeFhQyqyZzC8J4c8VB0A9KBOiP1xOtJZWVMLhqsuMoQGGCiSih/X/opYUrbKO5XbiJj5OlSy/OrXQy/ZqcCJhMzJ1NFKPaSVfc2ex1M3Rk1jPfAfiC6cIJV4/0zh0TlGpom5XbManL/R5qtsgdWHvPH/558v80xFUKFQh832C0ecTC2CIao0P3XGn+JnAkzzUl5dWLiDSJmg0w+QJSfJmMStK1OpF5Sd7KN+CZuSNrT31iy+jAAe/0eK6oimqqryj2BmTtyYyaIOi6uDIwD8jA== Received: from CO1NAM11FT019.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::48) by CO1NAM11HT228.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::340) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.15; Wed, 22 Apr 2020 18:14:09 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:3861::4d) by CO1NAM11FT019.mail.protection.outlook.com (2a01:111:e400:3861::313) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.15 via Frontend Transport; Wed, 22 Apr 2020 18:14:09 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:C4D4076A669712707DF02DB807FC064FA3399B2EE917FF5BEEAE5A6E110EF81B;UpperCasedChecksum:7CB82F1AA4E3EF23963AA6E83FADD25B3E6750A2FAD24D440B294584AEF3258F;SizeAsReceived:9354;Count:50 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3%6]) with mapi id 15.20.2921.030; Wed, 22 Apr 2020 18:14:08 +0000 Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com Cc: Chasel Chiu , Rangasai V Chaganty , Deepika Kethi Reddy , Kathappan Esakkithevar , Prince Agyeman , Michael Kubacki References: <20200421204028.10410-1-nathaniel.l.desimone@intel.com> <20200421204028.10410-2-nathaniel.l.desimone@intel.com> From: "Michael Kubacki" Message-ID: Date: Wed, 22 Apr 2020 11:14:07 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 In-Reply-To: <20200421204028.10410-2-nathaniel.l.desimone@intel.com> X-ClientProxiedBy: MWHPR1601CA0001.namprd16.prod.outlook.com (2603:10b6:300:da::11) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <476664ce-e63a-b7de-7713-c1fb201e5999@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:90d1:2af2:f899:a90] (2001:4898:80e8:0:10fa:2af2:f899:a90) by MWHPR1601CA0001.namprd16.prod.outlook.com (2603:10b6:300:da::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.27 via Frontend Transport; Wed, 22 Apr 2020 18:14:08 +0000 X-Microsoft-Original-Message-ID: <476664ce-e63a-b7de-7713-c1fb201e5999@outlook.com> X-TMN: [fF9JWjlCLHf5mSTi5MQeLgcOghOwZ6yd3lCjQjA9JIAkV0/9deREWInd5p66FPFi] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 81cb7ce0-cc02-4cb3-1832-08d7e6e8f351 X-MS-TrafficTypeDiagnostic: CO1NAM11HT228: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aGuc+36jCFXQfXSiTzEWY56DjgMrXy3mNdHNyk7LbbeQ+B5hg5BeLQGeF0OwzRpADkNuoMIkbq9F0TZr3rk7ZnJ+AnmBw9IrpYeS0FUt5ml+aBbnmVm8c8IAbg3wCUC2XNPb47u3Vdov8s8VKYWUVMlP1kE1IDVZLbb+7Jz4o1PVHi5ROACSmBEJUv8NTfoYxod6GGsBwIeopbAm/PuUmorbgeZeRFWfCho9f3rxudaQL4R13e9jYwiWH8Ay7WRC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: nz8B1l1LeED44U/rSgMU6/Un1U/lvXYMQv2L1Xedp4rAnNm/iWKMw/+FhVBx6BrAu+TSyzqWxyZYVxX8aTXl0is7FdLlre6EZ+hXdzU8v5rG5F6kmS51Co2HS9CwQnM7M5Xh00EhOrrMBS3JZ0pS8lMMDnjbfIY28oo1QurO/mqzw/sJuOWOgoF2O2mZlIXeHg//gNHQgY6gmyFTdKBtXA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81cb7ce0-cc02-4cb3-1832-08d7e6e8f351 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2020 18:14:08.8561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM11HT228 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Reviewed-by: Michael Kubacki On 4/21/2020 1:40 PM, Nate DeSimone wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 > > Added a DXE driver that registers the minimum platform > BDS hook points, to WhiskeylakeURvp board. > These hooks are triggered on the BDS hook events > > What was done: > > * Included an instance of BdsHookLib and BoardBootManagerLib > from BoardModulePkg > > * Included BdsHookDxe to register the callbacks implemented > in BdsHookLib > > Signed-off-by: Nate DeSimone > Cc: Chasel Chiu > Cc: Rangasai V Chaganty > Cc: Deepika Kethi Reddy > Cc: Kathappan Esakkithevar > Cc: Prince Agyeman > Cc: Michael Kubacki > --- > .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 4 ++++ > .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > index 14e82ba34d..958a2d0c50 100644 > --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > @@ -224,6 +224,8 @@ > ####################################### > DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyUpdateLib/DxePolicyUpdateLib.inf > DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtPolicyLib/DxeTbtPolicyLib.inf > + BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf > + BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf > > ####################################### > # Board-specific > @@ -452,3 +454,5 @@ > $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf > !endif > BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > + > diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf > index e2d40bcbb6..31f4d22311 100644 > --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf > +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf > @@ -346,6 +346,7 @@ INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > > INF ShellPkg/Application/Shell/Shell.inf > >