From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.92.41.35]) by mx.groups.io with SMTP id smtpd.web11.13673.1596740772052806350 for ; Thu, 06 Aug 2020 12:06:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=KgDoed2l; spf=pass (domain: outlook.com, ip: 40.92.41.35, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+OA+gqAgc6/BcRdy/IsQXehi9DagYkJDaxjPFx6QYwXeFNBRxMbY7jOKiAzZErdzhblkM193RxLhYMj+ogJWDOHK0VdpjM4la4P1DGTauBZj1uVNi3YE43v6LNZ6V/3fuLusw2g9+RrcptOYnXlLPj1Q7A+h6BjQy8pwkmyEV1MDj8JoIn8xODBeebpY+frm3EAwXOYF97Zl6AiwzROZQb5CPrQCq5b/slRTduDbEgbcCxAjt3uDCL+CZmx/Ay1RGH5XhM3hJ+M/VQ2wned57sRlrv//5f+KyJ7fkXZkIT8eK21n8ibTJtbwqGl6ULsYWoLJ9BctxJfitvphqzqfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8R5736OI3LGBOJYVUYf92uRWoW9wUdgK7xDVMDCaCso=; b=Dsv7OlP9BkeYmyJqYoocEqRTPXqgWrrsP05F5IBxxRK/kSvXlU2ZVbBLBvK1NCtfnUENmzm3VW6MbEFJujemmApxe/mdDjJf5WZQkKFyTASWd6GooNSC8KQv0yIe+TivxTjuL0Mf/oeiLZUPlF9/kCF8Z69aBVc+hcO6F1M7EVnANJ8BehhfAZEjwXbXLNU10xqYiOK25t0dOpmpCB+fVD04V8zf/dQarAknOMkeJ2W10Gv5bQjWZ8JjuVhFnP8ovdUiGKgVzigSLEdxA8A2fUOcTQqz4Mqn83dPBZBSG2dOya+xnahYb4RthxaYfjj3OEPEt5Kczmh9Ei5/dIt+ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8R5736OI3LGBOJYVUYf92uRWoW9wUdgK7xDVMDCaCso=; b=KgDoed2l0s07y+NC9yC+MW1pLrmczwwqd3C7ACLElG05bpiW0mIbZ55EEa1h5N1zduMNCPpr5nxfPATRICEdEyZoghRKuHllEozCL5csXEqNe6CavSRtaLhBOjYEck1tPgXOKwefzY17gC2S2E+uy8FXxWsGBjFFXYObtaRJ/OYBD/9Qr2unB+N0VbWMLKXul/glNdk0UsjlmtXAex4OE0kVLkWWRNzXKTUDBHX0DHz/9+FoitQLTUp3IyCNbPufI/wUR6h9Njbl0RjDGUG1wZ+rltSXntQH+2ci/kjS9a6y49PLKF58dIQxmiG6WaUay+BJjii/k1DnXdxyWByM4Q== Received: from MW2NAM10FT040.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::46) by MW2NAM10HT192.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16; Thu, 6 Aug 2020 19:06:11 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:7e87::42) by MW2NAM10FT040.mail.protection.outlook.com (2a01:111:e400:7e87::414) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16 via Frontend Transport; Thu, 6 Aug 2020 19:06:11 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:48D06F8A539FB00FE1058A6C0B67EE7B4952ED254D9656F21B7A8DC05DB2ED50;UpperCasedChecksum:38D26892531B7E96979E08E8E1D3E6EA26B68054663E303F80EADD6ACC40AB82;SizeAsReceived:7802;Count:49 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e%7]) with mapi id 15.20.3261.019; Thu, 6 Aug 2020 19:06:11 +0000 From: "Michael Kubacki" To: devel@edk2.groups.io CC: Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu Subject: [PATCH v3 1/7] FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency() documentation Date: Thu, 6 Aug 2020 12:05:36 -0700 Message-ID: X-Mailer: git-send-email 2.27.0.windows.1 In-Reply-To: <20200806190542.959-1-michael.kubacki@outlook.com> References: <20200806190542.959-1-michael.kubacki@outlook.com> X-ClientProxiedBy: MW2PR16CA0055.namprd16.prod.outlook.com (2603:10b6:907:1::32) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <20200806190542.959-2-michael.kubacki@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2001:4898:80e8:9:a161:5170:12c:6904) by MW2PR16CA0055.namprd16.prod.outlook.com (2603:10b6:907:1::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.18 via Frontend Transport; Thu, 6 Aug 2020 19:06:10 +0000 X-Mailer: git-send-email 2.27.0.windows.1 X-Microsoft-Original-Message-ID: <20200806190542.959-2-michael.kubacki@outlook.com> X-TMN: [f7VHhpjL6lSZy43rfajwCUq24aXsHCF+3c/0GEm/PAwpExWnAsNIU0p30mM3O8gt] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: e13c096b-386d-4aff-cc88-08d83a3bc822 X-MS-TrafficTypeDiagnostic: MW2NAM10HT192: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k5A3BW38qJZWRCNJRahBskYrwPlhCZKapbuyNR6T50xIXEvPmP9sFl1ruDdvnus6k0yv/svWCNK19rbn1JfaVMZCmeMmbCDdFj+Cn2ednQDGTqUTxVTpZLg86oFzxyt033AzW4HsPEHC96i22nR3Rt8w37CfhsB7RsF/WvChVrCPG9BdBDff59j1Shr6WpoXV84pdwnFAA2shhSZWTTEAQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: 3aIW7/sPfM/R3/w4r60qHYnLslpnetyRxuXf0BPFb5fwac6DgCfc+U/IO192t4fCAQ/VrWdTIe08QA7sSf9DrbBwmzpKeDolXOIiu68faTl55Vtv5IwSvbTF5G6ABnoiCSwJDOwVOcEfan/IXsxofg0V2kbW7qeDrthkJP3lucSGi04OavvQm0daNKqvHTanlRjDfxp9xfXLhKSO3DAKTw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e13c096b-386d-4aff-cc88-08d83a3bc822 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2020 19:06:10.9979 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT040.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM10HT192 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Michael Kubacki Modifies the return value documentation to state that the BOOLEAN value indicates whether a given dependency expression is valid not a capsule. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney Reviewed-by: Guomin Jiang Reviewed-by: Wei6 Xu --- FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 5 +++-- FmpDevicePkg/Include/Library/FmpDependencyLib.h | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c b/Fmp= DevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c index 91dc0b9abd33..28358069950a 100644 --- a/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c +++ b/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c @@ -1,6 +1,7 @@ /** @file Supports Fmp Capsule Dependency Expression. =20 + Copyright (c) Microsoft Corporation.
Copyright (c) 2020, Intel Corporation. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent @@ -433,8 +434,8 @@ EvaluateDependency ( @param[in] MaxDepexSize Max size of the dependency. @param[out] DepexSize Size of dependency. =20 - @retval TRUE The capsule is valid. - @retval FALSE The capsule is invalid. + @retval TRUE The dependency expression is valid. + @retval FALSE The dependency expression is invalid. =20 **/ BOOLEAN diff --git a/FmpDevicePkg/Include/Library/FmpDependencyLib.h b/FmpDevicePkg= /Include/Library/FmpDependencyLib.h index 1110eefa9a54..c732903425b4 100644 --- a/FmpDevicePkg/Include/Library/FmpDependencyLib.h +++ b/FmpDevicePkg/Include/Library/FmpDependencyLib.h @@ -2,6 +2,7 @@ Fmp Capsule Dependency support functions for Firmware Management Protoco= l based firmware updates. =20 + Copyright (c) Microsoft Corporation.
Copyright (c) 2020, Intel Corporation. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent @@ -29,8 +30,8 @@ typedef struct { @param[in] MaxDepexSize Max size of the dependency. @param[out] DepexSize Size of dependency. =20 - @retval TRUE The capsule is valid. - @retval FALSE The capsule is invalid. + @retval TRUE The dependency expression is valid. + @retval FALSE The dependency expression is invalid. =20 **/ BOOLEAN --=20 2.27.0.windows.1