public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <michael.kubacki@outlook.com>
To: devel@edk2.groups.io, fengyunhua@byosoft.com.cn
Cc: gaoliming@byosoft.com.cn, bob.c.feng@intel.com
Subject: Re: [edk2-devel] [PATCH] BaseTools: Add EDKII_DSC_PLATFORM_GUID MACRO
Date: Sat, 10 Oct 2020 14:21:49 -0700	[thread overview]
Message-ID: <MWHPR07MB344061D0588CD5665A1E0FF7E9090@MWHPR07MB3440.namprd07.prod.outlook.com> (raw)
In-Reply-To: <000001d69eb2$6f3eeb10$4dbcc130$@byosoft.com.cn>

Tested-by: Michael Kubacki <michael.kubacki@microsoft.com>

It looks like you're only putting one space of indentation before the 
GUID is printed on the new line after EDKII_DSC_PLATFORM_GUID and there 
should be two.

#define EDKII_DSC_PLATFORM_GUID \\\n %s

Should be:

#define EDKII_DSC_PLATFORM_GUID \\\n  %s

Two spaces before GUID:
#define EFI_CALLER_ID_GUID \
   {0x1652B3C2, 0xA7A1, 0x46AC, {0xAF, 0x93, 0xDD, 0x6D, 0xEE, 0x44, 
0x66, 0x69}}

One space before GUID:
#define EDKII_DSC_PLATFORM_GUID \
  {0xC29BB610, 0x84F9, 0x448D, {0xA7, 0xDD, 0x5A, 0x04, 0xC5, 0xA5, 
0x4F, 0x52}}

On 10/9/2020 8:07 PM, fengyunhua wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2969
> 
> Add EDKII_DSC_PLATFORM_GUID MACRO
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
> ---
>   BaseTools/Source/Python/AutoGen/GenC.py | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py b/BaseTools/Source/Python/AutoGen/GenC.py
> index 5e0d11e165..5b63d278be 100755
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -1980,12 +1980,14 @@ def CreateHeaderCode(Info, AutoGenC, AutoGenH):
>           AutoGenH.Append("#include <Library/PcdLib.h>\n")
>   
>       AutoGenH.Append('\nextern GUID  gEfiCallerIdGuid;')
> +    AutoGenH.Append('\nextern GUID  gEdkiiDscPlatformGuid;')
>       AutoGenH.Append('\nextern CHAR8 *gEfiCallerBaseName;\n\n')
>   
>       if Info.IsLibrary:
>           return
>   
>       AutoGenH.Append("#define EFI_CALLER_ID_GUID \\\n  %s\n" % GuidStringToGuidStructureString(Info.Guid))
> +    AutoGenH.Append("#define EDKII_DSC_PLATFORM_GUID \\\n %s\n" % GuidStringToGuidStructureString(Info.PlatformInfo.Guid))
>   
>       if Info.IsLibrary:
>           return
> @@ -2002,6 +2004,7 @@ def CreateHeaderCode(Info, AutoGenC, AutoGenH):
>       # Publish the CallerId Guid
>       #
>       AutoGenC.Append('\nGLOBAL_REMOVE_IF_UNREFERENCED GUID gEfiCallerIdGuid = %s;\n' % GuidStringToGuidStructureString(Info.Guid))
> +    AutoGenC.Append('\nGLOBAL_REMOVE_IF_UNREFERENCED GUID gEdkiiDscPlatformGuid = %s;\n' % GuidStringToGuidStructureString(Info.PlatformInfo.Guid))
>       AutoGenC.Append('\nGLOBAL_REMOVE_IF_UNREFERENCED CHAR8 *gEfiCallerBaseName = "%s";\n' % Info.Name)
>   
>   ## Create common code for header file
> 

  parent reply	other threads:[~2020-10-10 21:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-10  3:07 [PATCH] BaseTools: Add EDKII_DSC_PLATFORM_GUID MACRO fengyunhua
2020-10-10  7:15 ` Bob Feng
2020-10-10 21:21 ` Michael Kubacki [this message]
2020-10-10 22:16   ` 回复: [edk2-devel] " fengyunhua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR07MB344061D0588CD5665A1E0FF7E9090@MWHPR07MB3440.namprd07.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox