From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.92.42.104]) by mx.groups.io with SMTP id smtpd.web12.18983.1586970604768037183 for ; Wed, 15 Apr 2020 10:10:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=XUXEELZo; spf=pass (domain: outlook.com, ip: 40.92.42.104, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ANGYQeApI4JZp0jLN8Ax8mOuhVH999CwcRV39UcdR+GP99r0l57p4yS/5OlbMh+HkWfIUH9QonN9hM+DUx8QNAdUv/gz6PR8cM9SFAXn0iV0JHEpJ3e95iokVCQiOoHpdSQ7SpmlfgZJ8fHFcsmfq4PEeZi+xpd/JiEV8RFiQarVKOsElU4DDhV0EGC0EFslnDqVLn6qa9tP9XjOCM9hyTmrQ4iwT+OpnUY3PcQxQpPGf27LPhXoWPUXIgL0i0qNJnur8A+8oGNCSwBVbhEREY1sk69AZjhVPmEhk5FUK6MzGVzDEOg+jHUju9SrRxAHrTo3LaOuGzSWp6FeBoIyCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6EsrQTv/Vmw58T4+3L+Tjk7oKViqTKt69ORu4C8l56E=; b=WPc4dFNPOnCP47fxRE9AnWGmA8qJcEPARefGN/R1eoOdSCsmGk1h4vbADl4LtFbJLi+y4WxsOU0Dd5MvMZZUdKvST61AllH4Rp9+vJ/O3FioNLzO1swIRbeokM5PPqmniAA/T8PtHjKA3G+nubc+uw2FxDW6akzaK4hSIxx6H3AQaHLVZ8FoyCqxXMV8jhdz46NhQSWf6710fMiVhUij5MuhMFEGmE3NLuPUwROahP+B/DkQsNYA52Z/+P2sg9Qs0rUPgERePy4RjVLvE1HmiCrTOrwMCDQvjD0Gj4jHu4rJWqlDwC5ePqgZWcVSbFvBh2OqJMP1O5nZthJV6nYG6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6EsrQTv/Vmw58T4+3L+Tjk7oKViqTKt69ORu4C8l56E=; b=XUXEELZoLkAvDSQisnnS/ugUGlUHBNcLlpAfLXV0LUcS6tCUY5/C2mqUHOo5CPT18XIMwbmSPAYycUILZgBQi8KZav6UVYTizxQgnXiDH0WiCGrr2rd7PRpTxffL0dRKdKyYMDlmzE1yN1uMGyzw5DJaSJoaSFNg8XASVnAkYGdOv+U4AMQQjGbhAxUPdS5iJF3rlU2UYLzrz6B4orPU58CeRsBp4+hzpk2EXmUV+i7wuHQEx2M4e07VL2VES5WfqniI+CZSFLVA8f7t/W/QXDT1z3fnJMBkllB13zOe5FbXoNWSEkbka2xPccRXgvTt2i8ZWYWoIBoIJCjjgWUwPQ== Received: from BN7NAM10FT028.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::48) by BN7NAM10HT040.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::260) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Wed, 15 Apr 2020 17:10:02 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:7e8f::49) by BN7NAM10FT028.mail.protection.outlook.com (2a01:111:e400:7e8f::237) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Wed, 15 Apr 2020 17:10:02 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:9534B9A135DC66339472E4EA7B2D68586FED10B49D5942EEBEF4CD65F4C5DCE2;UpperCasedChecksum:C4E781511C5BC618C72653FFB2F4CCDDF61CFFBDB03C8A662D8BF7CF686E77BF;SizeAsReceived:9274;Count:50 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3%6]) with mapi id 15.20.2900.028; Wed, 15 Apr 2020 17:10:02 +0000 Subject: Re: [PATCH v2 0/7] Add linked list iteration macros to BaseLib.h From: "Michael Kubacki" To: devel@edk2.groups.io, Chao Zhang , Dandan Bi , Hao A Wu , Jian J Wang , Liming Gao Cc: Michael D Kinney , Ray Ni , Sean Brogan References: Message-ID: Date: Wed, 15 Apr 2020 10:10:02 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 In-Reply-To: X-ClientProxiedBy: MWHPR15CA0069.namprd15.prod.outlook.com (2603:10b6:301:4c::31) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <4c7ab210-f43c-b598-5121-3965ae179ab6@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:85d:9dd0:66ae:3713] (2001:4898:80e8:9:887c:9dd0:66ae:3713) by MWHPR15CA0069.namprd15.prod.outlook.com (2603:10b6:301:4c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 17:10:02 +0000 X-Microsoft-Original-Message-ID: <4c7ab210-f43c-b598-5121-3965ae179ab6@outlook.com> X-TMN: [pVIgQYktVPAnEUjz89LGxJ4JLvcnCJJ8JQ1s8MM6diE09U83SQbQXH71A4Q5pueF] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 870a2449-80ef-4d05-a824-08d7e15fd5ef X-MS-TrafficTypeDiagnostic: BN7NAM10HT040: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1MMtNYeMHRL7eF3krnXwdLcpCj5FeRpalgr2ewJD7FGPQJ+B+NW2HZp6/jTm0cbY+vh92fuA9Bu8im2ETLR+v+11yDMIVpvz7Bjebw3Job6rjal7GvYAPcNJUhJiaGdqpdJVyJuX0Yoem8ERITOWxw6at0DzoUuFqtJiv8VQJSqqGdAIJd5UoODuQLOnC/At3S3zAfQKz9qd0m4R11yMNWR2AngnpbIYCNY+SClzWlY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: rqNnm54pnL0lI2MEEnWjqmVeHMBUvlGXYbEhUIW27kE+0G4VyqLVj2u4Sl8RsrDsFf80WyciYpWbnJHFpU3RmMkqOVhejfGcFdXRcSI/bP7j72duzQN6n6989SBbjxKFegbDBWNqUElFFXEu/3bOU/ty5MMC+5n6ssx3AJOkuEgn714hMOQge239rFHgTFVd39tQI05UCPJQj/2hsjS1Ow== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 870a2449-80ef-4d05-a824-08d7e15fd5ef X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 17:10:02.5659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT040 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I saw Bret gave an R-b to the v2 series since it was sent. In addition to the R-bs already captured from v1, is there anything else needed for the series to be pushed? Thanks, Michael On 4/10/2020 1:02 PM, michael.kubacki@outlook.com wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959 > > V2 changes: > * Add explicit dependency to EhciPei on BaseLib > > The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been > duplicated across several drivers such as: > > * EhciPei > * EhciDxe > * HddPasswordDxe > * RamDiskDxe > * UfsPassThruDxe > * XhciDxe > > These macros have proven useful and established a commonly used pattern > for linked list iteration. > > This patch series consolidates the definitions to a single definition in > BaseLib.h so they are maintained alongside other pre-existing generic > linked list macros and functions. > > Note: Another commonly used generic linked list macro is EFI_LIST_CONTAINER. > I'm considering consolidating that to BaseLib.h as well but that is not > done in this patch series since it satisfies a separate use case than the > iteration macros and the change can be made independently. > > On a separate note, shallow threading might not work on this patch series > due to changes made by the SMTP server. Please bear with me while I am > investigating if this can be changed. > > Cc: Chao Zhang > Cc: Dandan Bi > Cc: Hao A Wu > Cc: Jian J Wang > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Ray Ni > Cc: Sean Brogan > Signed-off-by: Michael Kubacki > > Michael Kubacki (7): > MdePkg/BaseLib: Add linked list iteration macros > MdeModulePkg/EhciDxe: Use BaseLib linked list iteration macros > MdeModulePkg/EhciPei: Use BaseLib linked list iteration macros > MdeModulePkg/XhciDxe: Use BaseLib linked list iteration macros > MdeModulePkg/UfsPassThruDxe: Use BaseLib linked list iteration macros > MdeModulePkg/RamDiskDxe: Use BaseLib linked list iteration macros > SecurityPkg/HddPassword: Use BaseLib linked list iteration macros > > MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 3 ++- > MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 11 ++++---- > MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 5 ++-- > MdeModulePkg/Bus/Pci/EhciPei/EhciSched.c | 3 ++- > MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 5 ++-- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 9 ++++--- > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 3 ++- > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 3 ++- > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 3 ++- > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 9 ++++--- > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c | 5 ++-- > SecurityPkg/HddPassword/HddPasswordDxe.c | 13 +++++----- > MdeModulePkg/Bus/Pci/EhciDxe/Ehci.h | 15 +---------- > MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h | 16 ++---------- > MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf | 2 ++ > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h | 9 +------ > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h | 9 +------ > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.h | 15 +---------- > MdePkg/Include/Library/BaseLib.h | 27 ++++++++++++++++++++ > SecurityPkg/HddPassword/HddPasswordDxe.h | 7 +---- > 20 files changed, 78 insertions(+), 94 deletions(-) >