From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.92.22.109]) by mx.groups.io with SMTP id smtpd.web10.449.1596663617448107179 for ; Wed, 05 Aug 2020 14:40:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=j0hQsCQt; spf=pass (domain: outlook.com, ip: 40.92.22.109, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CrRseloUoms3WEW25RKIHoYFfzKclLPZarS556MbWWNVRio1VpzISSkAfXWGg3NVOUgBOZ7oM8zkcuu6PjSCYX2cLEi/jNraJJwC63m5emFowTf0zULgdXSYGdF+6eGtxH9z8uF5RRh8eudvgKkVHwMM3TpWkMhBZat3LKr480OdklbdJ/zVPiTW+byTG58G8uMY9r42GDU3DJ9aZw5Uv8nqc/dBFgNK735F8eosKe2niWv3yVb1/YGjhK9NIj/DcV10jW1qubHZ17rkZVMtZOdfK1z4sHA4CZsN+nCJSGIykxAi4GRSACD8onSTz0IfOJFAOVu0O17ZFXsdeWQdog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8R5736OI3LGBOJYVUYf92uRWoW9wUdgK7xDVMDCaCso=; b=gFVC2SGIhTx4LLOkSatSpHCA7iIDNVfc8ka4RxV4KpMqku67c+qe/vnlYZETRJV74IfL/HXlwmzWWhxY1AkMUrGSsP3OG80iYics74kOGamdLajWR1kMXdc+pMn5gCVpML8A0QLMCYdiEFfkzN8s936MBFGL1GhnM0XMSMnDLuSjnIuCTiMDoWRoM+9VFmqxZEG259RZqDzbx6G8NtAQQe5wF6zkgfYam6e2ASPcouQwRQFbINZPBAAPFkWEGKSXqgpS4Jf5r7Y6E1h0iWWF+dy+MFjZlHwSElzDqnRizxlVAzZc3bUkjZuET+X3J0HKCvCnfKyfGu3Eb/pca11fOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8R5736OI3LGBOJYVUYf92uRWoW9wUdgK7xDVMDCaCso=; b=j0hQsCQt4IT7R9cvYGEYDKUwbhbt+DLH7CpB7tfaVIqCDD2rCNtIkWAUuSp1KFMpK3mH08QeEOypsxIyQvSZqRQd9l3SvmBU2zRCD4sHMs/TjQgntrKJ6yVeR1uvhD1bqL2rRDoVcUQcmnPUkJA8pFNisY1QTZ92Uh6d8N3Keeh1sgQO5o+tfjBC2synPaWx9Jq4YluYN6Kib6rT+IRV9StEhfoaF7B+hfXVFgo9eWo049ZKtkYWFpA6hBUb1Kzr9FmFGhfUbx8N5C4VE2WE3vJFHASqpGGv5/F6TQvcKp+C66Jt6HH3hJO0+UaKXNJPQmMYmsawvYx6geWQc1DQ6g== Received: from MW2NAM12FT045.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::4a) by MW2NAM12HT250.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.10; Wed, 5 Aug 2020 21:40:16 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:fc65::42) by MW2NAM12FT045.mail.protection.outlook.com (2a01:111:e400:fc65::268) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.10 via Frontend Transport; Wed, 5 Aug 2020 21:40:16 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:ABCD6B3D31135E491FD377664F76CFF1A576A3020FFC99D07FDA0ADDBC439128;UpperCasedChecksum:04C90632EF573322D63540404C58C5D6B306A63456D3533AF96B5F146F8DF076;SizeAsReceived:7806;Count:49 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e%7]) with mapi id 15.20.3239.022; Wed, 5 Aug 2020 21:40:16 +0000 From: "Michael Kubacki" To: devel@edk2.groups.io CC: Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu Subject: [PATCH v2 1/7] FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency() documentation Date: Wed, 5 Aug 2020 14:39:38 -0700 Message-ID: X-Mailer: git-send-email 2.27.0.windows.1 In-Reply-To: <20200805213944.1811-1-michael.kubacki@outlook.com> References: <20200805213944.1811-1-michael.kubacki@outlook.com> X-ClientProxiedBy: MWHPR2001CA0014.namprd20.prod.outlook.com (2603:10b6:301:15::24) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <20200805213944.1811-2-michael.kubacki@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2001:4898:80e8:a:f5bb:f844:3092:4e93) by MWHPR2001CA0014.namprd20.prod.outlook.com (2603:10b6:301:15::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Wed, 5 Aug 2020 21:40:15 +0000 X-Mailer: git-send-email 2.27.0.windows.1 X-Microsoft-Original-Message-ID: <20200805213944.1811-2-michael.kubacki@outlook.com> X-TMN: [kSw3OFbsbBfKCh5Mfe7BhJ8UVwZV8x1Qu11JbBMPcMoxndkEtaygk84VRaN+VtIA] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 001a520c-efdf-4dcc-28f8-08d83988244e X-MS-TrafficTypeDiagnostic: MW2NAM12HT250: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y/xXmwHU5XLVLGtCvgJ3/R3SeZbvbFEYL+ddX1pnDBVg09YOAgn3o8+iT8TrwTELFEPPVTzvd/eLdHpwm48zL/0XMg4+ncA+RPMGeAQoUJH4aP1eFxT5xmiVJ1VLZ6pykyFwEhpEYAx0bCv4PLywPsjiPXu/5jpE5Gli3rQh3rPvsFbeQ2RglUoG3cbKbtHfVq1fYOig5aA9nt1eUhkv2A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: WEFW5m4RnU1blET/g1DfkaKCb4CBrGaQXETPaRLwBWG+d6c+zxDnqxa5JZCcVoBaDpO8Mz32rFJrk4rVhEOgPmw/XLPQZsmMa4/rJl31HtXA8lsB1nNZp8OP6cOpcPQSJ1K3gct3nDv8RBBh+B0Ek5XhDoEcO9Tof56yQb2CobLCAP1qvqiBovRv7KWXzWFv2IE0VhMKojs9kXMfSKXIlA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 001a520c-efdf-4dcc-28f8-08d83988244e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2020 21:40:16.2731 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT045.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT250 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Michael Kubacki Modifies the return value documentation to state that the BOOLEAN value indicates whether a given dependency expression is valid not a capsule. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney Reviewed-by: Guomin Jiang Reviewed-by: Wei6 Xu --- FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 5 +++-- FmpDevicePkg/Include/Library/FmpDependencyLib.h | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c b/Fmp= DevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c index 91dc0b9abd33..28358069950a 100644 --- a/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c +++ b/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c @@ -1,6 +1,7 @@ /** @file Supports Fmp Capsule Dependency Expression. =20 + Copyright (c) Microsoft Corporation.
Copyright (c) 2020, Intel Corporation. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent @@ -433,8 +434,8 @@ EvaluateDependency ( @param[in] MaxDepexSize Max size of the dependency. @param[out] DepexSize Size of dependency. =20 - @retval TRUE The capsule is valid. - @retval FALSE The capsule is invalid. + @retval TRUE The dependency expression is valid. + @retval FALSE The dependency expression is invalid. =20 **/ BOOLEAN diff --git a/FmpDevicePkg/Include/Library/FmpDependencyLib.h b/FmpDevicePkg= /Include/Library/FmpDependencyLib.h index 1110eefa9a54..c732903425b4 100644 --- a/FmpDevicePkg/Include/Library/FmpDependencyLib.h +++ b/FmpDevicePkg/Include/Library/FmpDependencyLib.h @@ -2,6 +2,7 @@ Fmp Capsule Dependency support functions for Firmware Management Protoco= l based firmware updates. =20 + Copyright (c) Microsoft Corporation.
Copyright (c) 2020, Intel Corporation. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent @@ -29,8 +30,8 @@ typedef struct { @param[in] MaxDepexSize Max size of the dependency. @param[out] DepexSize Size of dependency. =20 - @retval TRUE The capsule is valid. - @retval FALSE The capsule is invalid. + @retval TRUE The dependency expression is valid. + @retval FALSE The dependency expression is invalid. =20 **/ BOOLEAN --=20 2.27.0.windows.1