From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.92.42.92]) by mx.groups.io with SMTP id smtpd.web10.2008.1587669843880149197 for ; Thu, 23 Apr 2020 12:24:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=Z7bH72wI; spf=pass (domain: outlook.com, ip: 40.92.42.92, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l5RhXtcWUHJD42lf1wJlKOqFBOYQIk71mnQQGiDNTWHD48o/V+csbGQa0F49LOkXRoyun4aGc1qdF1Y6n6eGkl7GuMXEYT7/JYBI6MEM4pOYIJb2hrxtZmrXUNO31ve9PnjU9Y1LjaJgWVGYIOZvI/5z63ZlbN3Pbefb3ZqQHVsDRDqhYEKD6nHiy6j0nTqCU6RS3two72tiLmaVxQd8T4/+p73UH9VpRfmcCM9cgSOWV7hVhXmFH6w4OHSkXO4TgpSVpXFZ5p/xn0HdSK4HljsGQM8HlAP94MsNZEGjt9O/zuCy0XOK9vsepqVccfyKvf+hQ1ZmV7VBXggKiy18sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vwVWNuX85790P9NfnRkn+gLjVMyTcbOzQj560s6KVYE=; b=RS6fiVVnNuU0rqayZt6ecWOzmp9rkqrbkmVwwPmJojYlo89kt1JSNDetXm3Cff0sRx4/ivTikE4UV1aSzqVGrxw2x2Eknf3/xohwpdHGc8XyJe5OTJUaRzKO3FgOjYjUD6wi3L12vlUTeTyXAVB/RKGZXuCpHOPdxKJ3ZfD37pwHr/S9fP70swic4Cpzi2BfgzK+t545AsXc7a/OeEi+jJ/s0jE3CQjz5rlXhRBrskiM88m/iWicOC9fiEITqj09mYOxu5E5b3bRpl8M1AAkd3T31b0h9WQfvyqRzrMiMSElvgpecZW3aWSKWlK54tKwgCXdjrtWbRREHgkn+DbEAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vwVWNuX85790P9NfnRkn+gLjVMyTcbOzQj560s6KVYE=; b=Z7bH72wI+98DiJhDjP/qHfBDKFJhSvIaa0X7ekXcnskZOLj9vGiTvVf/noBfb44Dc35mvDHm+bdouePJYY4NGaadkr6CX1PrCMKZO8eyoLLRmRE4zVrVZv1a2PlHRjWmwueOIpa0jUaxBh3VNEZwX6fypB0B72wT+ppBHSpWcZ5aikLFZ5lTWSeK4cLzY8KQeGtY7LH/SyzI4Ebm8BFwiUGIXxAd5jTNzOSOf08UWpx3S3fpPzpkFh5tqM8CVzXGw54hV3wJg6GAjkEJbZs55Xo91T/Mx28sIjVvQaSVmGPELU0eHWFMqAx55cHGYhOPNkoL7J7O4V3j2t2v+ZALcA== Received: from BN7NAM10FT030.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::4e) by BN7NAM10HT080.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.15; Thu, 23 Apr 2020 19:24:01 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:7e8f::46) by BN7NAM10FT030.mail.protection.outlook.com (2a01:111:e400:7e8f::101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.15 via Frontend Transport; Thu, 23 Apr 2020 19:24:01 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:2FEEBD5BB268F833217204CD8D4F3CAB979EDB7FD4632DEB43EE933086B9166E;UpperCasedChecksum:F93F384E26F5F4F4894EACD0D0D1C6882657EF244B5A98ED5CDB8E42F48D2BA2;SizeAsReceived:9168;Count:50 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3%6]) with mapi id 15.20.2921.030; Thu, 23 Apr 2020 19:24:01 +0000 Subject: Re: [edk2-devel] [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove temporary build workaround To: devel@edk2.groups.io, heng.luo@intel.com Cc: Michael Kubacki , Liming Gao , Eric Dong , Ray Ni References: <20200423084258.1100-1-heng.luo@intel.com> <20200423084258.1100-2-heng.luo@intel.com> From: "Michael Kubacki" Message-ID: Date: Thu, 23 Apr 2020 12:24:01 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 In-Reply-To: <20200423084258.1100-2-heng.luo@intel.com> X-ClientProxiedBy: MW2PR2101CA0023.namprd21.prod.outlook.com (2603:10b6:302:1::36) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <5df9b46a-4b21-8056-bea7-fcdc2cded749@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:3ca8:b84e:3eea:df33] (2001:4898:80e8:3:bccd:b84e:3eea:df33) by MW2PR2101CA0023.namprd21.prod.outlook.com (2603:10b6:302:1::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.2 via Frontend Transport; Thu, 23 Apr 2020 19:24:01 +0000 X-Microsoft-Original-Message-ID: <5df9b46a-4b21-8056-bea7-fcdc2cded749@outlook.com> X-TMN: [qaiS4p2gV6xVjc9YgMKX4WvmA/F5QqYF7XI4Y7JO87XBmJQx6Bcq1p0XmNE8q8Jm] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 403c6a0b-5b28-4116-7217-08d7e7bbe0c0 X-MS-TrafficTypeDiagnostic: BN7NAM10HT080: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 06HxAquUaVCjVD/oYjpSQFhhqPbnFEyQEZ9dmpNAsM/k7Mvt7oZNFimlht4Doyi3wKatZbCJOwqIrZYP9bWAeoQQVk2MJqtjSzEbAXm5vHz5qCrJlcVbjIQ5pjiIX1wNSOZ8q1ZeRFOcJAbJrqC3I0rZCMipv20M2bMqv0LQwZq6woXeYWhrzjy6ilmXAZhr9FX07SWGRUx/XPk80vGdgcduXeRm+b9+pLMpFYkG/EgHL0qBIo0foITHCnBEIgS6 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: 58zMvwMf9eLqdC4trlw1aNKY3wOSBbkd7FHR84b4Xg1M184accVd0gPVp4TxwwzQp59eEpHQJfr82wfrFtaRWOqn+T3b3cHPedbIyzx3NWtGHJCgLeeK4fcUlswcuQPzXKA8d7YFWvoercyddQqIQc1fvHe9YSahT3/tJRW97h63ly/TN57//go0yoM90CUEYhSXankeJgRn7gz4kKP9Gw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 403c6a0b-5b28-4116-7217-08d7e7bbe0c0 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2020 19:24:01.4142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT080 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I think the series cover letter should have been filled out but this seems reasonable to me for removal of the temporary workaround. Reviewed-by: Michael Kubacki On 4/23/2020 1:42 AM, Heng Luo wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2688 > > Remove Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround, > Add Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > to support Feature PCDs. > > Cc: Michael Kubacki > Cc: Liming Gao > Cc: Eric Dong > Cc: Ray Ni > Signed-off-by: Heng Luo > --- > Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 2 +- > Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc | 41 +++++++++++++++++++++++++++++++++++++++++ > Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.c | 31 ------------------------------- > Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc | 76 ---------------------------------------------------------------------------- > Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.inf | 60 ------------------------------------------------------------ > 5 files changed, 42 insertions(+), 168 deletions(-) > > diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > index ea879680ba..e509ef3e1b 100644 > --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > @@ -30,7 +30,7 @@ > PEI_ARCH = IA32 > > DXE_ARCH = X64 > > > > -!include AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc > > +!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > > > ################################################################################ > > # > > diff --git a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > new file mode 100644 > index 0000000000..2eacec18a0 > --- /dev/null > +++ b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > @@ -0,0 +1,41 @@ > +## @file > > +# DSC file for defining Pcd of advanced features. > > +# > > +# This file is intended to be included into another package so advanced features > > +# can be conditionally built by enabling the respective feature via its FeaturePCD. > > +# > > +# Copyright (c) 2020, Intel Corporation. All rights reserved.
> > +# > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > +# > > +## > > + > > +# > > +# The section references the package DEC files, > > +# it allow a FeaturePCD to be used in a conditional statement > > +# > > +[Packages] > > + MdePkg/MdePkg.dec > > + AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec > > + Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec > > + NetworkFeaturePkg/NetworkFeaturePkg.dec > > + IpmiFeaturePkg/IpmiFeaturePkg.dec > > + S3FeaturePkg/S3FeaturePkg.dec > > + SmbiosFeaturePkg/SmbiosFeaturePkg.dec > > + UserAuthFeaturePkg/UserAuthFeaturePkg.dec > > + LogoFeaturePkg/LogoFeaturePkg.dec > > + > > +# > > +# The section below sets all PCDs to FALSE in this DSC file so the feature is not enabled by default. > > +# Board can set PCDs to TRUE in its DSC file to enable a subset of advanced features > > +# > > +[PcdsFeatureFlag] > > + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable |FALSE > > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |FALSE > > + gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable |FALSE > > + gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable |FALSE > > + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable |FALSE > > + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable |FALSE > > + gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable |FALSE > > + gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable |FALSE > > + gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable |FALSE > > diff --git a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.c b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.c > deleted file mode 100644 > index 2cd91b06f0..0000000000 > --- a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.c > +++ /dev/null > @@ -1,31 +0,0 @@ > -/** @file > > - Source code file for a temporary build workaround. > > - > > - The purpose of this workaround is described in the module INF file. > > - > > -Copyright (c) 2019, Intel Corporation. All rights reserved.
> > -SPDX-License-Identifier: BSD-2-Clause-Patent > > - > > -**/ > > - > > -#include > > -#include > > - > > -/** > > - An empty entry point function. > > - > > - @param FileHandle Handle of the file being invoked. > > - @param PeiServices Describes the list of possible PEI Services. > > - > > - @retval EFI_SUCCESS This function always returns EFI_SUCCESS. > > - > > -**/ > > -EFI_STATUS > > -EFIAPI > > -TemporaryBuildWorkaroundEntry ( > > - IN EFI_PEI_FILE_HANDLE FileHandle, > > - IN CONST EFI_PEI_SERVICES **PeiServices > > - ) > > -{ > > - return EFI_SUCCESS; > > -} > > diff --git a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc > deleted file mode 100644 > index c62f9ecc6e..0000000000 > --- a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc > +++ /dev/null > @@ -1,76 +0,0 @@ > -## @file > > -# Build description file for a temporary build workaround. > > -# > > -# The feature enable PCD for advanced features must be referenced in an INF > > -# to be referenced in DSC/FDF files. This DSC only exists in the build to > > -# allow the PCDs to be referenced. This workaround does not affect the final > > -# flash image or boot in any way. > > -# > > -# The request to update BaseTools to allow a PCD to be referenced in DSC/FDF > > -# files without requiring the PCD to be referenced in an INF file is tracked > > -# here: https://bugzilla.tianocore.org/show_bug.cgi?id=2270 > > -# > > -# When the BaseTools update is complete, this file can entirely be removed > > -# from this package. > > -# > > -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
> > -# > > -# SPDX-License-Identifier: BSD-2-Clause-Patent > > -# > > -## > > - > > -# > > -# BEGIN:Temporary Build Workaround (resolution: https://bugzilla.tianocore.org/show_bug.cgi?id=2270) > > -# > > - > > -# THIS FILE IS TEMPORARY. PLEASE TRY TO LOOK PAST THE "HACKS" ASSOCIATED WITH IT. > > -# > > -# With the BaseTools change requested, the changes needed to move to the end state are simply: > > -# 1. Remove the !include for this file in AdvancedFeatures.dsc > > -# 2. Remove this directory > > - > > -!if $(PLATFORM_NAME) != AdvancedFeaturePkg > > -# > > -# AdvancedFeaturePkg initializes all FeaturePCDs to TRUE so they can conveniently be built in one package. > > -# Board packages will normally only enable (and therefore reference) a small subset of advanced features > > -# relative to the board. If an INF does not reference a package DEC file (which will be the case if the > > -# feature is not enabled) then the DSC must set ("define") the PCD for the conditional statements based > > -# on the PCD to work. > > -# > > -# AdvancedFeaturePkg has no problem as it naturally has a need to set al PCDs to TRUE for build. > > -# The section below sets all PCDs to FALSE in the DSC file so if the feature is not enabled by a board, > > -# the build will still be successful. > > -# > > -[PcdsFeatureFlag] > > - gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable |FALSE > > - gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |FALSE > > - gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable |FALSE > > - gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable |FALSE > > - gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable |FALSE > > - gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable |FALSE > > - gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable |FALSE > > - gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable |FALSE > > - gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable |FALSE > > -!endif > > - > > -# > > -# The LibraryClasses required to build TemporaryBuildWorkaround.inf > > -# (mostly libraries requiring other libraries) > > -# > > -[LibraryClasses] > > - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > > - BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf > > - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > > - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > - PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > > - PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > - PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf > > - > > -# > > -# The driver that references all feature PCDs to satsify current build limitations > > -# > > -[Components] > > - AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.inf > > -# > > -# END:Temporary Build Workaround (resolution: https://bugzilla.tianocore.org/show_bug.cgi?id=2270) > > -# > > diff --git a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.inf b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.inf > deleted file mode 100644 > index 00818fbe0a..0000000000 > --- a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.inf > +++ /dev/null > @@ -1,60 +0,0 @@ > -### @file > > -# Component information file for a temporary build workaround. > > -# > > -# The feature enable PCD for this package must be referenced in an INF to be > > -# referenced in DSC/FDF files. This driver is only included in the build to > > -# allow the PCD to be referenced. This driver is not included in the flash > > -# image and does not affect the boot in any way. > > -# > > -# The request to update BaseTools to allow a PCD to be referenced in DSC/FDF > > -# files without requiring the PCD to be referenced in an INF file is tracked > > -# here: https://bugzilla.tianocore.org/show_bug.cgi?id=2270 > > -# > > -# When the BaseTools update is complete, this file can entirely be removed > > -# from this package. > > -# > > -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
> > -# > > -# SPDX-License-Identifier: BSD-2-Clause-Patent > > -# > > -### > > - > > -[Defines] > > - INF_VERSION = 0x00010017 > > - BASE_NAME = TemporaryBuildWorkaround > > - FILE_GUID = 8846A81E-F552-4917-81F5-80B62E4EFBAC > > - VERSION_STRING = 1.0 > > - MODULE_TYPE = PEIM > > - ENTRY_POINT = TemporaryBuildWorkaroundEntry > > - > > -[LibraryClasses] > > - BaseLib > > - PeimEntryPoint > > - > > -[Packages] > > - MdePkg/MdePkg.dec > > - Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec > > - Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec > > - Network/NetworkFeaturePkg/NetworkFeaturePkg.dec > > - OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > > - PowerManagement/S3FeaturePkg/S3FeaturePkg.dec > > - SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec > > - UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dec > > - UserInterface/LogoFeaturePkg/LogoFeaturePkg.dec > > - > > -[FeaturePcd] > > - gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable > > - gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable > > - gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable > > - gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable > > - gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable > > - gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable > > - gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable > > - gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable > > - gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable > > - > > -[Sources] > > - TemporaryBuildWorkaround.c > > - > > -[Depex] > > - TRUE >