From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (NAM02-CY1-obe.outbound.protection.outlook.com [40.92.4.42]) by mx.groups.io with SMTP id smtpd.web11.13680.1596740790390509339 for ; Thu, 06 Aug 2020 12:06:30 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=Sf39jN8O; spf=pass (domain: outlook.com, ip: 40.92.4.42, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VKCTMiWkYgB19/AZ+BeNHgyT6uPVdoHFFJw/4Xm+4ql++o6oleTILABEbjnqsiU/HkbFvC/pFAVp7L5+kPFOLwcbD5Mkg2JjzlEcFDvsJfpHC3Vv1JWXtw/2yXS3KncDeA9jUQgcyNUFWWo/xy1Q1qEItdx4DfJ2YPgENFJZLCNVpMuJEEopLIoIwdBjn1Xryf9kmaZ90odQnMPC+jBk3S2JaV+nmp5KaBfWiE6Q9pnwsnHaaDWhHilEuBMn+CUcnMGSuIbsH6n+/zj4qygVgGs2ozhJnCwJfTivpaYMJlH0bVefdnLSZXs3fbzqP/ex2Z4roTfaOV3ADY3/ADw9ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6Xy3VCOIifBLpWDptTrS5K+8lilaOiLJd8pK/JZ1II=; b=iUn2OFXzO2t6hd0PJHAqkXR7lV1dGeF1pylpd7ymmxMooP4qa39ORSkJ5iZ8pRN82+atVB70XbMqZH2Y3HX0EE3dbQ0Jt3DdHI4qWeUenWzad2WF253BxKcOlR8cj8wr0inT4ltmM9jkfNFk/0GSpNAvx/BURP1rLBmV1eP2a87AR3u/66A1huxp771bDrqMRqnHz+epI0qhEGFxhEKf65TZmX3TtjQVYPEJZ5hq+RviVY71b/31v+i65jrdco/eIlKJt2wDMifemZr7BKb8Ue/I3Mx8peYwqpyVYsHXPMODE2bfcR5h/2c+btN58jFV4cAITx+OEg8gler9jiAa3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6Xy3VCOIifBLpWDptTrS5K+8lilaOiLJd8pK/JZ1II=; b=Sf39jN8Oxmzc79HGapySvWjh4Fzrqa38NhWJCIQqVfqo+KSPppRZCP8R5F10eE7pYNkCP71zyH7wiH9xIjN0HyVlxoOhNIsQKwacuKB2UlMID4G0IwrF8McACfsptP6tJgw1cKvn1UEA1zat6FKHtYPSsiCXZ5im6Dcn+ICeho40jgjamfuIhFVbfl2nEMNobF1yrDIkSXz9ZOZ04agIQsBOPNObLl4QR0F+u2WpbiISVuFjCs4iqf32ofPeoM4SLk/EfUQoGP+DowuBK6GFCvP2+gY2Bu0sVvR1yDTp8OvPGp2b11tkB+dLZUef+KuV/v2tUZ/8dNWPoNUEj8RHVQ== Received: from BL2NAM02FT035.eop-nam02.prod.protection.outlook.com (10.152.76.51) by BL2NAM02HT174.eop-nam02.prod.protection.outlook.com (10.152.77.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Thu, 6 Aug 2020 19:06:29 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:7e46::41) by BL2NAM02FT035.mail.protection.outlook.com (2a01:111:e400:7e46::413) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19 via Frontend Transport; Thu, 6 Aug 2020 19:06:29 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:ECAC925EC26A6C619F880FD5EF48A2BA467D0CF234FAE0C0949289A983B669E9;UpperCasedChecksum:1E55CA521DFE5392CCAA08FEB83DE44826F06381B2AAC64D6FE32E4D0645F0EC;SizeAsReceived:7791;Count:49 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e%7]) with mapi id 15.20.3261.019; Thu, 6 Aug 2020 19:06:29 +0000 From: "Michael Kubacki" To: devel@edk2.groups.io CC: Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu Subject: [PATCH v3 6/7] FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName Date: Thu, 6 Aug 2020 12:05:41 -0700 Message-ID: X-Mailer: git-send-email 2.27.0.windows.1 In-Reply-To: <20200806190542.959-1-michael.kubacki@outlook.com> References: <20200806190542.959-1-michael.kubacki@outlook.com> X-ClientProxiedBy: MW2PR16CA0055.namprd16.prod.outlook.com (2603:10b6:907:1::32) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <20200806190542.959-7-michael.kubacki@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2001:4898:80e8:9:a161:5170:12c:6904) by MW2PR16CA0055.namprd16.prod.outlook.com (2603:10b6:907:1::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.18 via Frontend Transport; Thu, 6 Aug 2020 19:06:28 +0000 X-Mailer: git-send-email 2.27.0.windows.1 X-Microsoft-Original-Message-ID: <20200806190542.959-7-michael.kubacki@outlook.com> X-TMN: [nlThjxRyxSCHx91EGlUrfg/wu45+gASl6G4tcl1JFVSNq2VYhRgJeDOD/Ynos/j0] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: d75db0f2-cf5b-48b5-aafe-08d83a3bd2d0 X-MS-TrafficTypeDiagnostic: BL2NAM02HT174: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iq0OfJNRV2CcyRY7i39g8T6hTQ2wA8KAi8DMfiUnBR27dlOOMWyo87JD72YSBc50/d48Sj5bn72W1nMFPh+8jnSASz2LGAnHEx1rHKecFr9RbetSqVB5LMEkUEyIg71znCkZ9j4jZZsxROCHWTfVqm1DGZLL417vdQprYowBZAFKWujpkDT1CiBmfY2jdquiiMCIhuA8VbCk8gZl/O0eBA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: hHegr5naI/FMdFx8Z/5l1DBPM3UVo82CNG6ctHEzGcanq29kyOURvI24MbsPFc3uEIyqHBq7s4XKunIDFibrIujZ8ypCG47H3jvr6TwZAiKcVLO2Fuax9fPnbSvhKX72OHcWBKLnE8UTAT2y6LjO/Vosq/YQyXmZFGUxk6hBNJPKSYba/DJhf5+taXDmaHiFFIw9aBME9c62Tk2rAGTAXA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d75db0f2-cf5b-48b5-aafe-08d83a3bd2d0 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2020 19:06:29.2844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BL2NAM02FT035.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM02HT174 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Michael Kubacki Updates the debug error message to include the GUID of the FMP instance that encountered the issue to help the user better isolate the problem. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney Reviewed-by: Guomin Jiang Reviewed-by: Wei6 Xu --- FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index 14994ce4ee0e..a3e342591936 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -1679,7 +1679,7 @@ FmpDxeEntryPoint ( // // PcdFmpDeviceImageIdName must be set to a non-empty Unicode string // - DEBUG ((DEBUG_ERROR, "FmpDxe: PcdFmpDeviceImageIdName is an empty stri= ng.\n")); + DEBUG ((DEBUG_ERROR, "FmpDxe(%g): PcdFmpDeviceImageIdName is an empty = string.\n", &gEfiCallerIdGuid)); ASSERT (FALSE); return EFI_UNSUPPORTED; } --=20 2.27.0.windows.1