public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <michael.kubacki@outlook.com>
To: devel@edk2.groups.io
Cc: Liming Gao <liming.gao@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Guomin Jiang <guomin.jiang@intel.com>,
	Wei6 Xu <wei6.xu@intel.com>
Subject: [PATCH v3 0/7] FmpDevicePkg Minor Fixes
Date: Thu,  6 Aug 2020 12:05:35 -0700	[thread overview]
Message-ID: <MWHPR07MB34408CCE5D7D1BFFB341882FE9480@MWHPR07MB3440.namprd07.prod.outlook.com> (raw)

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869

This patch series makes minor fixes and enhancements in
FmpDevicePkg. None of the issues impact functionality in a
major way.

These are smaller sets of changes that are being submitted prior
to a larger future patch series that will cover functional changes
for BZ2802.

Note: The v3 series with Reviewed-bys is on the following branch.
https://github.com/makubacki/edk2/tree/fmpdevicepkg_minor_fixes

V3 changes:
1. 1. [PATCH v2 7/7]:
   * Reverted retval descriptions in FmpDxe FMP functions back
   to the original description. These will be updated collectively
   to match the latest text in the UEFI Spec 2.8B in the future.

V2 changes:
1. [PATCH v1 7/7]:
   * Added a DEBUG_ERROR message if the Image parameter is NULL in
   GetAllHeaderSize()
   * Updated the EFI_INVALID_PARAMETER retval description for
   functions that accept an ImageIndex to indicate the status code
   could be returned if ImageIndex is invalid.
   * Updated CheckTheImage() to return EFI_INVALID_PARAMETER if
   ImageIndex is invalid.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Wei6 Xu <wei6.xu@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
Reviewed-by: Wei6 Xu <wei6.xu@intel.com>

Michael Kubacki (7):
  FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency()
    documentation
  FmpDevicePkg/FmpDependencyLib: Fix "exression" typo
  FmpDevicePkg/FmpDependencyLib: Handle version string overflow
  FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle
    failure
  FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig
  FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName
  FmpDevicePkg/FmpDxe: Improve function parameter validation

 FmpDevicePkg/FmpDxe/FmpDxe.c                                       | 57 +++++++++++++++++---
 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c |  2 +
 FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c           |  8 +--
 FmpDevicePkg/Include/Library/FmpDependencyLib.h                    |  5 +-
 4 files changed, 60 insertions(+), 12 deletions(-)

-- 
2.27.0.windows.1


             reply	other threads:[~2020-08-06 19:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06 19:05 Michael Kubacki [this message]
2020-08-06 21:07 ` [PATCH v3 0/7] FmpDevicePkg Minor Fixes Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR07MB34408CCE5D7D1BFFB341882FE9480@MWHPR07MB3440.namprd07.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox