From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (NAM02-BL2-obe.outbound.protection.outlook.com [40.92.3.46]) by mx.groups.io with SMTP id smtpd.web10.13696.1596740770409234565 for ; Thu, 06 Aug 2020 12:06:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=KPebgiZo; spf=pass (domain: outlook.com, ip: 40.92.3.46, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dn2u98CRS6loWiqicm/hfFeaS7J/q5txffAChAn7mFvOQYT63OvXzUlQ5ZRR+3vxT1MbyxGY86FhHp4eiw6T61IC8hqBseYP0ExyCnR3tCFO8oaok5u0rxGF9P+fH+UhyvySVXknT+z0Am+L/UOOUc7HaZYNIlixBNxK+ezPeDnJDjtVUfvim7EB28LEv4l/wu2nZJNIkGaywJZuvvzScGA5Ih+lsZYCLhzsRcOxeUM1LdLk0fWFBoERnLDDre956Q+WBbAWLtXaQ7meWTdPib2TFtMZQhXC1rFb3KUYT27Y7jV8Nubm6CQ4MyEX5sZCrM1R+2cKzsVvuWff5qnSBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RT7hXFJ1bGMQkldaxE1kyd65xEaAFNb5n4Jr90LDPcE=; b=XNAY717bTUnb0E/iMwAc8yamvA7Bgks0BM6UedR1T0hI+byhRqrkTX+ZW+I4JvNqujynIgtYfO7EI5uZqR2623JeHd/C6eqtBVY4rqxCPI4xhnhHfYpMCRLrmh66SPfqry8QTPDgwqKUuZ2/vN2Rv9G9yLdxOsvidFjlbRqyX74SGYzaFvsYIo/dIQkRqeCCXJ8HwAc6SjgNOTnov0fxGdl92fx7AXtGu1p53LNsjpq/PpKilyR5e/ZQqO9stn8r7ERyIk64WwWhQUGfJUVukfRHJ3m4bbQ1hJ+Wbx4ZZGXl6GXHazAPUz3Ez/4RB0Fq+e3NIA1yJrxVLTgQz7JgVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RT7hXFJ1bGMQkldaxE1kyd65xEaAFNb5n4Jr90LDPcE=; b=KPebgiZoCHZ59clHhogsiS6xkuwtuWPa61RCMVcbj2HFC732RqOhWQI5wv3G+Ei2MLMdpZK6Il9zXYj8lZ2Xq0+/9hdiMGDr47nQTIaU2KPzRGAP53CI4rX+PYqA0aomq2I/87W1JbqK8SBQTcBN2NO6JAw3G1IGFji0KABUBPIhqzLohdlgdOLXxLxe4+jgGO9yw1L92Wc+tmag9vo4GEJIS51qblv/STomHr4vVcA2/ZzMmDUEzIsbO9X5vAabGRLOR8e57xJcWJi+a8cRACyt8f2jWdrugRY3sDeYTuB8G/DDX5jS1GimPFsMfG+twVXguwpQH2OQa3op58Vc1g== Received: from BL2NAM02FT035.eop-nam02.prod.protection.outlook.com (10.152.76.53) by BL2NAM02HT206.eop-nam02.prod.protection.outlook.com (10.152.77.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Thu, 6 Aug 2020 19:06:08 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:7e46::41) by BL2NAM02FT035.mail.protection.outlook.com (2a01:111:e400:7e46::413) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19 via Frontend Transport; Thu, 6 Aug 2020 19:06:08 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:5AFE8CCC8AB49240A476DD6B9D2D5E90B8E0FD6741DA66749DED9D8F347D0621;UpperCasedChecksum:7A03C8442A8043BBAF1A904E629F27806D3DF3ADE68F4A0D6923DB41A4566029;SizeAsReceived:7624;Count:47 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e%7]) with mapi id 15.20.3261.019; Thu, 6 Aug 2020 19:06:08 +0000 From: "Michael Kubacki" To: devel@edk2.groups.io CC: Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu Subject: [PATCH v3 0/7] FmpDevicePkg Minor Fixes Date: Thu, 6 Aug 2020 12:05:35 -0700 Message-ID: X-Mailer: git-send-email 2.27.0.windows.1 X-ClientProxiedBy: MW2PR16CA0055.namprd16.prod.outlook.com (2603:10b6:907:1::32) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <20200806190542.959-1-michael.kubacki@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2001:4898:80e8:9:a161:5170:12c:6904) by MW2PR16CA0055.namprd16.prod.outlook.com (2603:10b6:907:1::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.18 via Frontend Transport; Thu, 6 Aug 2020 19:06:07 +0000 X-Mailer: git-send-email 2.27.0.windows.1 X-Microsoft-Original-Message-ID: <20200806190542.959-1-michael.kubacki@outlook.com> X-TMN: [yPis0gF4pGtXdfzyTuxEm2FWKFuWH55rvxEBVH6gKVcTp6keHZ2o09wcJIIp2qAF] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: d542a555-65f8-4628-7614-08d83a3bc672 X-MS-TrafficTypeDiagnostic: BL2NAM02HT206: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I+x2S2DG2ifgH7rzroBSbjkZVGTw0UfrtC2L47sJl9Zj0mz32ob0LS6HGzYAUL452IgEvYAZU9qC3JYQ5Z51IyVfAYBTnCieqXwE1NfHgvA6KMwgxQw5xqmOsgeUteRhFPJLSidzDX3Z0hC2GZk1b/8pgTsmQXFe5EbGxhy9xWHRRhVpjWsncgMExQMcpPCxjuXms2ydCJPKzTChKG3FDfD32ShevwYFTAi+248AgBsuGtyW7de58MlhCI60cn7y X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: ytiVdR7Os6sKQE7Sc8kaBdMQRYHH6+lV2grI6LylOSuTymSMw78bBt904grRL6Q7KSVmGgdB1ePD5zsIZ2aJD7k+cxUdMw1xNgUvD3PGUSubNjOg66beTtEdzDheOTJdm3qXXQwdv6z03aF1poXECKw0mS2zMHb7nmbiwRI8mzTQvYJ6M/6mJ7I7JvXAFXxY4gWqYNGy7WzQW+x31HP+vw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d542a555-65f8-4628-7614-08d83a3bc672 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2020 19:06:08.5423 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BL2NAM02FT035.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM02HT206 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2869 This patch series makes minor fixes and enhancements in FmpDevicePkg. None of the issues impact functionality in a major way. These are smaller sets of changes that are being submitted prior to a larger future patch series that will cover functional changes for BZ2802. Note: The v3 series with Reviewed-bys is on the following branch. https://github.com/makubacki/edk2/tree/fmpdevicepkg_minor_fixes V3 changes: 1. 1. [PATCH v2 7/7]: * Reverted retval descriptions in FmpDxe FMP functions back to the original description. These will be updated collectively to match the latest text in the UEFI Spec 2.8B in the future. V2 changes: 1. [PATCH v1 7/7]: * Added a DEBUG_ERROR message if the Image parameter is NULL in GetAllHeaderSize() * Updated the EFI_INVALID_PARAMETER retval description for functions that accept an ImageIndex to indicate the status code could be returned if ImageIndex is invalid. * Updated CheckTheImage() to return EFI_INVALID_PARAMETER if ImageIndex is invalid. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney Reviewed-by: Guomin Jiang Reviewed-by: Wei6 Xu Michael Kubacki (7): FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency() documentation FmpDevicePkg/FmpDependencyLib: Fix "exression" typo FmpDevicePkg/FmpDependencyLib: Handle version string overflow FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle failure FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName FmpDevicePkg/FmpDxe: Improve function parameter validation FmpDevicePkg/FmpDxe/FmpDxe.c | 57 ++= +++++++++++++++--- FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c | 2 + FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 8 +-= - FmpDevicePkg/Include/Library/FmpDependencyLib.h | 5 +- 4 files changed, 60 insertions(+), 12 deletions(-) --=20 2.27.0.windows.1