[PATCH v3 0/7] FmpDevicePkg Minor Fixes

[PATCH v3 0/7] FmpDevicePkg Minor Fixes

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869

This patch series makes minor fixes and enhancements in
FmpDevicePkg. None of the issues impact functionality in a
major way.

These are smaller sets of changes that are being submitted prior
to a larger future patch series that will cover functional changes
for BZ2802.

Note: The v3 series with Reviewed-bys is on the following branch.
https://github.com/makubacki/edk2/tree/fmpdevicepkg_minor_fixes

V3 changes:
1. 1. [PATCH v2 7/7]:
   * Reverted retval descriptions in FmpDxe FMP functions back
   to the original description. These will be updated collectively
   to match the latest text in the UEFI Spec 2.8B in the future.

V2 changes:
1. [PATCH v1 7/7]:
   * Added a DEBUG_ERROR message if the Image parameter is NULL in
   GetAllHeaderSize()
   * Updated the EFI_INVALID_PARAMETER retval description for
   functions that accept an ImageIndex to indicate the status code
   could be returned if ImageIndex is invalid.
   * Updated CheckTheImage() to return EFI_INVALID_PARAMETER if
   ImageIndex is invalid.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Wei6 Xu <wei6.xu@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
Reviewed-by: Wei6 Xu <wei6.xu@intel.com>

Michael Kubacki (7):
  FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency()
    documentation
  FmpDevicePkg/FmpDependencyLib: Fix "exression" typo
  FmpDevicePkg/FmpDependencyLib: Handle version string overflow
  FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle
    failure
  FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig
  FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName
  FmpDevicePkg/FmpDxe: Improve function parameter validation

 FmpDevicePkg/FmpDxe/FmpDxe.c                                       | 57 +++++++++++++++++---
 FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c |  2 +
 FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c           |  8 +--
 FmpDevicePkg/Include/Library/FmpDependencyLib.h                    |  5 +-
 4 files changed, 60 insertions(+), 12 deletions(-)

-- 
2.27.0.windows.1

Re: [PATCH v3 0/7] FmpDevicePkg Minor Fixes

[Michael D Kinney]

Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike


> -----Original Message-----
> From: michael.kubacki@outlook.com <michael.kubacki@outlook.com>
> Sent: Thursday, August 6, 2020 12:06 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Jiang, Guomin
> <guomin.jiang@intel.com>; Xu, Wei6 <wei6.xu@intel.com>
> Subject: [PATCH v3 0/7] FmpDevicePkg Minor Fixes
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869
> 
> This patch series makes minor fixes and enhancements in
> FmpDevicePkg. None of the issues impact functionality in a
> major way.
> 
> These are smaller sets of changes that are being submitted prior
> to a larger future patch series that will cover functional changes
> for BZ2802.
> 
> Note: The v3 series with Reviewed-bys is on the following branch.
> https://github.com/makubacki/edk2/tree/fmpdevicepkg_minor_fixes
> 
> V3 changes:
> 1. 1. [PATCH v2 7/7]:
>    * Reverted retval descriptions in FmpDxe FMP functions back
>    to the original description. These will be updated collectively
>    to match the latest text in the UEFI Spec 2.8B in the future.
> 
> V2 changes:
> 1. [PATCH v1 7/7]:
>    * Added a DEBUG_ERROR message if the Image parameter is NULL in
>    GetAllHeaderSize()
>    * Updated the EFI_INVALID_PARAMETER retval description for
>    functions that accept an ImageIndex to indicate the status code
>    could be returned if ImageIndex is invalid.
>    * Updated CheckTheImage() to return EFI_INVALID_PARAMETER if
>    ImageIndex is invalid.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Wei6 Xu <wei6.xu@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
> Reviewed-by: Wei6 Xu <wei6.xu@intel.com>
> 
> Michael Kubacki (7):
>   FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency()
>     documentation
>   FmpDevicePkg/FmpDependencyLib: Fix "exression" typo
>   FmpDevicePkg/FmpDependencyLib: Handle version string overflow
>   FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle
>     failure
>   FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig
>   FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName
>   FmpDevicePkg/FmpDxe: Improve function parameter validation
> 
>  FmpDevicePkg/FmpDxe/FmpDxe.c                                       | 57 +++++++++++++++++---
>  FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c |  2 +
>  FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c           |  8 +--
>  FmpDevicePkg/Include/Library/FmpDependencyLib.h                    |  5 +-
>  4 files changed, 60 insertions(+), 12 deletions(-)
> 
> --
> 2.27.0.windows.1