From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.92.21.33]) by mx.groups.io with SMTP id smtpd.web11.10885.1596165334748291990 for ; Thu, 30 Jul 2020 20:15:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=H5nhkxph; spf=pass (domain: outlook.com, ip: 40.92.21.33, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kZJoelHsag+/wRXZbX2kYZ0CrICpVMPnzmEpdQeE4/9bLnVGopfkf2olC0V66BrhxWGC4Igpod3A+AhjhcUcpw1wJnipoii7GvfvlQbs8FyKWMO1FDsYfEDKO4Ym6Uis3IaJLM7WuRiy924XijYV9Jl5LivO5kuuQb8q8vGdjUeAUvjXa1sIzOm8j8fEI33J8Sa/tbAiZzLQ5ltiOZT+A4hqkk3FXfiL3nd1GH7cwggZDUuV3MQEpWbTYMugxYP1iJtiN/5I2RTOVhHViIp5fmzprfLDsQM1va79fhMF3z/h25XruXDKeGNCdC22sHW4j8oKQbdhWSg3R+UyjST6+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6zN5xP2qfpZwZImcEaZbT9BeCUekYSdNySk3XoINfc=; b=dhDnsUwfZBVxONRRwkgx84G92inb2S4o4gnjo9Jt+f+8Z6oS6cAdUMWt8ZSCnqViskWvegRyg7zdMN6M+XR/JC3bjTF6WH9EYK1eCooOlzJUKBWo2xUTLAIlKWle6reqLMsIajJ60fO8T/s+k6YIlV8WYMt1lErHEPtowTzb1fqLdU2axsd3gVdLzwSGFe69nqTzy3AwDra2Kh6IxQO1dUFtBS6lsmg5tay1r2kNWBmsEgcNI0ArlNcvGrBo1qiG3Ap9YJL84Wqkd1y57IgbehUiQNMv7m18NDZtkMwrcQjEeHEKePQS3u+2vxNxvb4uv/a5k8JVPdL9XF8x/YgT4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6zN5xP2qfpZwZImcEaZbT9BeCUekYSdNySk3XoINfc=; b=H5nhkxphMfmZ4Joum3fEDbGDgWJxOpwi8Ib/yKFC7MSgLqE2gQmWJYsMcnoL+nQiywS08K/73SteNVG+50UweQr8UQaeBZfxzu4rITbzkn8323THO1iTQEn5oyDKlDjX8elnGI5gD3bsZo+/BKCShb10shFdf5EGHSoiXrihjQ7WBdWoHvtUMMxc43jzOpplm7W486iNBDIdKaonHn6uXyUXcvc2/4yalNa0zpZ3kT39YJnOrPAaa7nApI8b7y8G2M6d6W3ZBccywPA3AV2ZL0kZtKcyTEIYvN0+p4RELzAJd/AbKD4JBCWR88TEj7Owlcrm54oqKatTnqueHQTK/g== Received: from MW2NAM12FT019.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::47) by MW2NAM12HT079.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::314) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.14; Fri, 31 Jul 2020 03:15:33 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:fc65::4c) by MW2NAM12FT019.mail.protection.outlook.com (2a01:111:e400:fc65::86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.14 via Frontend Transport; Fri, 31 Jul 2020 03:15:33 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:A1186772B06AED8E5BF9C41294F9ECFD6D9A101E9061EF9CF17F0F0A39BDD496;UpperCasedChecksum:FC09DE658DB18D038B8D5CF5FD12CC037F3B4D9AF5FF1A74C46279B4AAACC7B3;SizeAsReceived:7738;Count:49 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e%7]) with mapi id 15.20.3216.033; Fri, 31 Jul 2020 03:15:33 +0000 From: "Michael Kubacki" To: devel@edk2.groups.io CC: Liming Gao , Michael D Kinney Subject: [PATCH v1 1/7] FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency() documentation Date: Thu, 30 Jul 2020 20:14:42 -0700 Message-ID: X-Mailer: git-send-email 2.27.0.windows.1 In-Reply-To: <20200731031448.1103-1-michael.kubacki@outlook.com> References: <20200731031448.1103-1-michael.kubacki@outlook.com> X-ClientProxiedBy: CO2PR04CA0115.namprd04.prod.outlook.com (2603:10b6:104:7::17) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <20200731031448.1103-2-michael.kubacki@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2001:4898:80e8:0:8072:23b8:48ea:d2c1) by CO2PR04CA0115.namprd04.prod.outlook.com (2603:10b6:104:7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.18 via Frontend Transport; Fri, 31 Jul 2020 03:15:33 +0000 X-Mailer: git-send-email 2.27.0.windows.1 X-Microsoft-Original-Message-ID: <20200731031448.1103-2-michael.kubacki@outlook.com> X-TMN: [s86iAeexP5JH5+C1EL0Yi4YmZmFHTaPKLhu1P1d5REJLDFM1ppbZKM/MScZSguAt] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 86c570f4-3684-41fa-838f-08d834fffc96 X-MS-TrafficTypeDiagnostic: MW2NAM12HT079: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /GFf2M/RU79UDM7mIdW0Cqnwiyizxb3iuJZsx1Cn/bEzj1D9FpjaY1pdxMI97PxP9m/3je0hjGYPd7edHDHwa3aar/aQ0SMHPFcrV/RUujkJVLe2xUYH5zRqaZN+Cz1n8X179MZ3wlFP/YpgzH0NU7CzlM7halS0iw/Ek7FtLEZAE73Yi+vEMlXm5rmVfbVexLE3Dyicu5rw8Az4Mo6rBA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: XYSfLkVr9XVbP87eRwJTqFFOAlP0owmBPmA0vUSAkBjqtF5tbmmXmjVZqrYrdDhGZsOgcP2BR+c3TO8ywyk43sYoULeLG9VwMN7N1i2QFzXmC/8c5EWK05GSrLXo009qzTTJ4cx7epT19vpJpJL2Ttixq2vA+6v6dE2fTxlc9Rs4v1mVP7+3FBUG9GwKuMeba4XGl2z7ZNr+DkcMmJWfIw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86c570f4-3684-41fa-838f-08d834fffc96 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2020 03:15:33.3711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT019.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT079 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Michael Kubacki Modifies the return value documentation to state that the BOOLEAN value indicates whether a given dependency expression is valid not a capsule. Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Michael Kubacki --- FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 5 +++-- FmpDevicePkg/Include/Library/FmpDependencyLib.h | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c b/Fmp= DevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c index 91dc0b9abd33..28358069950a 100644 --- a/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c +++ b/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c @@ -1,6 +1,7 @@ /** @file Supports Fmp Capsule Dependency Expression. =20 + Copyright (c) Microsoft Corporation.
Copyright (c) 2020, Intel Corporation. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent @@ -433,8 +434,8 @@ EvaluateDependency ( @param[in] MaxDepexSize Max size of the dependency. @param[out] DepexSize Size of dependency. =20 - @retval TRUE The capsule is valid. - @retval FALSE The capsule is invalid. + @retval TRUE The dependency expression is valid. + @retval FALSE The dependency expression is invalid. =20 **/ BOOLEAN diff --git a/FmpDevicePkg/Include/Library/FmpDependencyLib.h b/FmpDevicePkg= /Include/Library/FmpDependencyLib.h index 1110eefa9a54..c732903425b4 100644 --- a/FmpDevicePkg/Include/Library/FmpDependencyLib.h +++ b/FmpDevicePkg/Include/Library/FmpDependencyLib.h @@ -2,6 +2,7 @@ Fmp Capsule Dependency support functions for Firmware Management Protoco= l based firmware updates. =20 + Copyright (c) Microsoft Corporation.
Copyright (c) 2020, Intel Corporation. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent @@ -29,8 +30,8 @@ typedef struct { @param[in] MaxDepexSize Max size of the dependency. @param[out] DepexSize Size of dependency. =20 - @retval TRUE The capsule is valid. - @retval FALSE The capsule is invalid. + @retval TRUE The dependency expression is valid. + @retval FALSE The dependency expression is invalid. =20 **/ BOOLEAN --=20 2.27.0.windows.1