From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.92.19.50]) by mx.groups.io with SMTP id smtpd.web10.2513.1585703738142589079 for ; Tue, 31 Mar 2020 18:15:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=BWmCuQSw; spf=pass (domain: outlook.com, ip: 40.92.19.50, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g5l4a4rZXiFFml8rKmY3x1acER/Qo7lrCnlBCGJvFW2/N+hrRk1eiZx6qdpNuKx533/sD9suv47R+7vUuVUdS2eoQp8bu/U8voPIl/pOin1O8V3slNWyOa700wtL3OiJmbsGkLmZ/b+HMgYM/1kCUDsHZVArf8QfbR+phgRxR/RF6VngKpD5nnlANvXwz+xdBS5MvBraDYvkAOqVFwQfW6yNR7r/Z+fEVV6ztImDPKmwj6rcZO0rJkcgY7iyLRF9CdLaJ5U3nfETV53SYPOs92lOsoo7XarXXPGJMg0Bn4PQn4km9EvT2U8BWx9ofJJ/iJ9y9iKQN6TaSzCGBuu16g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dSnTUNyg3Gyx5rV8UBXF+IHhENWxlMGv/fiC9G3QL5I=; b=oKQPXnawfWRnAe7Z4JbZvFEMNyBhTC5BGPIhDzEbYjJqERnBbrvk4WTpDkLglRWyYsGbkAMXCef+lCbUd3VsK66Kc/QmXx4laqkyu+zgS2Zw9ph5CJBkzqTnbgxSg2XA1GZGLmNn0d9DcoHI+KGjm6VIBvWJev/SbSKP0aMMV5EHYutfxCs8OcAcgF5x+E4wKzh908r6wa/bphAS4DfGZJrup/Y2AgcsR9CqrA3BYiuseq5wwvf7cb2aqnK9Yf6yMJWANFpM1ael3miSRi2CUIzdL6CKdytf9dTx+jgRTUkK3NqoI+MOlGsyxBRO8KrIznh1Ngxivf3qpkZaCHGZdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dSnTUNyg3Gyx5rV8UBXF+IHhENWxlMGv/fiC9G3QL5I=; b=BWmCuQSwQkcV+2vnUlueUVA82hWQfglBlvn6xW8nmNPeOyi81hjmbbXikiK4evcNsFN+6+KVuJpVV399PDqhHZwWEyi680hfZzDqBR9AeYVnN4YaYo5tqd5mnV9T6lGDm6KVDu+jzUJNR/qUmMZ4XkuiZMrLPwAihDsWoWqjBCVHRYTu5IIWUV7DuOoCAGiPm4auyOWZvtKF0z2qhlV6WdMncqIE8LsRxLRT6rJygYyYqDKwW5hgGWuV315WMHdH5TEwsW4ciwt3mFlK4Xq0Q91JQ0r920mXULHongXzU1RIXqiYS7pmbj6RkjhTVVj45dOjtXpqsteisIBbYMbCug== Received: from DM6NAM11FT031.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4d::51) by DM6NAM11HT066.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4d::448) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Wed, 1 Apr 2020 01:15:37 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:fc4d::50) by DM6NAM11FT031.mail.protection.outlook.com (2a01:111:e400:fc4d::203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Wed, 1 Apr 2020 01:15:37 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:96E32D929F501B2378F699A804734372AEEC762FB653ACC53FF46E45FB399E52;UpperCasedChecksum:A75DBA971E918BF9A132DB94E05D87C7CD2C0165D7B266F17B50702E184177E0;SizeAsReceived:9367;Count:50 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::f5a7:e51b:e22a:959f]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::f5a7:e51b:e22a:959f%7]) with mapi id 15.20.2835.023; Wed, 1 Apr 2020 01:15:37 +0000 Subject: Re: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL To: Laszlo Ersek , devel@edk2.groups.io Cc: Bret Barkelew , Siyuan Fu , Liming Gao , Michael D Kinney , Maciej Rabeda , Jian J Wang , Jiaxin Wu , Hao A Wu References: <58fc3ce6-b279-3974-a43d-803fe75bd964@redhat.com> From: "Michael Kubacki" Message-ID: Date: Tue, 31 Mar 2020 18:15:36 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 In-Reply-To: <58fc3ce6-b279-3974-a43d-803fe75bd964@redhat.com> X-ClientProxiedBy: MWHPR10CA0065.namprd10.prod.outlook.com (2603:10b6:300:2c::27) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <946fe71a-290a-2eb6-d99d-ecd65ac4bf33@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:50d6:50cb:50e5:a060] (2001:4898:80e8:b:d0f3:50cb:50e5:a060) by MWHPR10CA0065.namprd10.prod.outlook.com (2603:10b6:300:2c::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Wed, 1 Apr 2020 01:15:36 +0000 X-Microsoft-Original-Message-ID: <946fe71a-290a-2eb6-d99d-ecd65ac4bf33@outlook.com> X-TMN: [/u5x4Z3m5nEqPoWNw0zhvfPIqOv6gsqd7GxI8VE+yWgCum6wucjwJBenVZNZtNg/] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 971e720c-058c-4969-7999-08d7d5da2f34 X-MS-TrafficTypeDiagnostic: DM6NAM11HT066: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fEmonThmedgYIWdfQw99jEvHMORBaG0gIsqvO+p9IyA7n/AUutYCCLYT5vTxqdHB+8jKskQZWgKuFSissTRPBgPFyKYm47Khponw9eYMBc0zzithldH3ja8N+oW8qxMlcXLj2eemQGLgQwCbZrJU6oUaO+E+OhUAXeTWahxOsOUCMbeSW8BGHtfhyYrqcunt X-MS-Exchange-AntiSpam-MessageData: q59XIySuIGoO9399TVJvmknaO5Dfh0RTVufX0CSl93Bxm5Syt1mgWcaesvIRX1+X9CCvoEZJZ8mYzuUZJ8bF98E43ZGIqZe+q3YMQaiFb7FwuHOHmKz2wyk+3BHv8tlZM+gihO1AxwvGJtMb1+bQ+NhkHf1ibNLbv72GWu9hihlkKyAbL+oEkEax+S8RLRwfooYBKlzHQpkWwzv3u9aMAA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 971e720c-058c-4969-7999-08d7d5da2f34 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2020 01:15:37.1306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM11HT066 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I have those options set correctly in git config. After a quick look, as far as I can tell, this is because the Message-Id in my email is modified such the the In-Reply-To and References headers do not refer to the actual Message-Id in the cover letter: Cover letter: Subject: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL Date: Fri, 27 Mar 2020 14:55:33 -0700 Message-Id: <160047F24E1D38F5.15390@groups.io> The original Message-Id in the cover letter was moved to X-Microsoft-Original-Message-Id: X-Microsoft-Original-Message-ID: <20200327215536.9556-1-michael.kubacki@outlook.com> The first patch in the series: Subject: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL Date: Fri, 27 Mar 2020 14:55:34 -0700 Message-Id: <160047F33E58AD06.17905@groups.io> In-Reply-To: <20200327215536.9556-1-michael.kubacki@outlook.com> References: <20200327215536.9556-1-michael.kubacki@outlook.com> Please let me know if you have suggestions. I'll look into it more. Thanks, Michael On 3/31/2020 4:55 PM, Laszlo Ersek wrote: > Hi Michael, > > On 03/27/20 22:55, Michael Kubacki wrote: >> From: Michael Kubacki >> >> This patch series updates the GetVariable() implementation >> to return Attributes in the case EFI_BUFFER_TOO_SMALL is returned. >> >> * [PATCH v3 1/3] Makes the functional change in the DXE/MM variable driver. >> * [PATCH v3 2/3] Makes the functional change in the PEI variable driver. >> * [PATCH v3 3/3] Removes a change made in NetworkPkg that worked around the >> previous behavior when EFI_BUFFER_TOO_SMALL is returned. >> >> V3 changes: >> * Apply the same GetVariable() behavior in VariablePei so it is consistent >> with the DXE/MM variable driver implementation. > > Can you please configure your git-send-email machinery to post patch > series with "shallow threading"? Otherwise the patch emails are not > linked under the cover letter, and they fly apart. > > I'm asking in particular because this series modifies both MdeModulePkg > and NetworkPkg. In such cases usually one of the affected maintainers > volunteers for merging the full set (once review is complete for the > entire set). And collecting the individual patches without proper > shallow threading is very difficult. > > The git options are the following: > > git config sendemail.chainreplyto false > git config sendemail.thread true > > They are also put in place (with many other useful settings) by > "BaseTools/Scripts/SetupGit.py". > > Or is there another problem with posting the patches? (I assume you post > the full set with a single git-send-email invocation.) > > Thanks! > Laszlo >