From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.92.19.32]) by mx.groups.io with SMTP id smtpd.web11.1226.1587579306606681619 for ; Wed, 22 Apr 2020 11:15:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=bvpU0Y5+; spf=pass (domain: outlook.com, ip: 40.92.19.32, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mJExOa9xgSAQjaRM0KCyZTzNpL4h3EC7N2/XhdXTKRrL7CCB2iMJ/rboLXXpIixrdL0azmWdsbFczlH4bFLbiXgv3nZICT75u7Q0Hhh1KfmH6cWGcxcrQKBLYIw0Go9q75EUE1yUEbLh9AN4Bis/3Iz/HxCrGeL1mB9w3N4L7YFk3Nw58p05FFzHdw6N/CCRVuO/E3h68j/LDwS6oeVP3Ar6y99h+CxpA7QhvxDCiHQzjpd0oBj2lyt2ZMbQWLALzi86OqtoTlXja/Pf7z3mg0OoU+/1ByKtxsCKARCOS32oONjc9g72ZUi614oSQaUcmh5eU6p4+OXHAXj4r4BFVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6oCSJNxsdzHLHhXHeX97gvgghXHa5nc5DiQObeEAkAQ=; b=TfuvB/lprQ+pQIt7H0kPcrX1IxiTtEA4Zd/V3ovlMgDQJ4hV+WOvgQLmLMY3ukcXpuZGJ4Lz2j8unGs25n0wNUsSCmVPPk9ityhS6vJHO11Z4N7sxP42WhDh+/oW0HM+W/jb0oexiTDxbrZc07U/Q30TwDDlQoHcqR2hqA/zElpWvnBr5hmItcwAPdOouk0dThOuLR3I9dGQ+wRwG/6f42wDBbBJ/7uhMpPKE4vkFtKUG/BSi+X8ZsaWstNPvuFxbAocKnTBrIyKTT+ed4FOT5+l1VY04dFnFILCHpbTdu0BM9p8SjmwoH0FGq9HdiJd8RuIYpbhiC4FEwW80gD8PA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6oCSJNxsdzHLHhXHeX97gvgghXHa5nc5DiQObeEAkAQ=; b=bvpU0Y5+r82zu5xPeZDUvz56KgE6XyBa5atrZJQ9Og9sgrEoeuHz4vSqoniNn/504tajyWXV2ftR/GTVZUWuxkaeWWTI1M7DllQjF0S/K67sIXdImGWePg8FU3rP64ArrD/7vHVLMU3oGe/R0X/jVdwtL/Qee4IR1Ohui7owywBvTGI7qrN8NzDbcfdTVAKsvU2Ioa13/6e+g3rV1ex43n98PhE141BWca0SEf3wqXJzYv75AzdeHxbCW0fCLQV8PtdhgcmdkHpXLVGAeLKv54jCVuzZ6VcwGkkl5pMEgFh0cJ1CWISyVbKHqKSiGWOfNTDNogQldD2kEgBtioVyhw== Received: from CO1NAM11FT019.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::40) by CO1NAM11HT197.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::325) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.15; Wed, 22 Apr 2020 18:15:05 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:3861::4d) by CO1NAM11FT019.mail.protection.outlook.com (2a01:111:e400:3861::313) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.15 via Frontend Transport; Wed, 22 Apr 2020 18:15:05 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:E46DE3E8633134CA73BC31829E339E3BDFDE65FCB2085300F2249193E2570650;UpperCasedChecksum:771D6828B914404D211B42767BF5BDBFCAA7171C2299FD4FCE7A1CAF7BCFA858;SizeAsReceived:9252;Count:50 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3%6]) with mapi id 15.20.2921.030; Wed, 22 Apr 2020 18:15:05 +0000 Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com Cc: Chasel Chiu , Rangasai V Chaganty , Prince Agyeman , Michael Kubacki References: <20200421204028.10410-1-nathaniel.l.desimone@intel.com> <20200421204028.10410-3-nathaniel.l.desimone@intel.com> From: "Michael Kubacki" Message-ID: Date: Wed, 22 Apr 2020 11:15:04 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 In-Reply-To: <20200421204028.10410-3-nathaniel.l.desimone@intel.com> X-ClientProxiedBy: MWHPR1601CA0023.namprd16.prod.outlook.com (2603:10b6:300:da::33) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:90d1:2af2:f899:a90] (2001:4898:80e8:0:10fa:2af2:f899:a90) by MWHPR1601CA0023.namprd16.prod.outlook.com (2603:10b6:300:da::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Wed, 22 Apr 2020 18:15:04 +0000 X-Microsoft-Original-Message-ID: X-TMN: [i1encBtnMdMWmvpo6Sr0KjITu+hBqo5eVYeX43YyT7q2jaJugjhO6yRfUSv2CG7Z] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: a44cad21-f35a-4f54-9766-08d7e6e914ab X-MS-TrafficTypeDiagnostic: CO1NAM11HT197: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AMQGIa7NJ34gts4g3dY/Gj+bs9SpE3PSNo5nBYChM49RMyJ+QNqq1uRpl18WmrBUihehkvuGEY3cc8N5Z7LzK80OJytk0wd4H9Bn4GoeiS0GOjtCfHiahiObDNirF8mcQ6louuLtK7yTqA1GRNWrG+x4QvF7I2eUCa7F1x/z7RRG9Pj2rIRCzqh54PUJ6BVq58QWV/AX8d0htfU1RvpvuNBesM0+y00vFGgU+zXLTlFWEOITyG2yl7n1IpGXfSyt X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: CLylHJGqlm15XlkcVEeVSkn8hQTfZS/z/JWCUSSJI5dleT0EAKs9bhABdcJiIBfvfQRR//EfpTm5stKDAs5oZPTtPCUd3Hnr1rKV8aRagtC7mmXsv6QR2d4anrc7n+llqFumI7k70UDNN21fM0bZrR0KHzpjJdRhwheLIYv43tF1td2etXprEnzC8tv9SteDGNLVfpSGRq3gI6sJpZl2Pw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a44cad21-f35a-4f54-9766-08d7e6e914ab X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2020 18:15:04.7970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM11HT197 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Reviewed-by: Michael Kubacki On 4/21/2020 1:40 PM, Nate DeSimone wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 > > Added a DXE driver that registers the minimum platform > BDS hook points, to WhiskeylakeURvp board. > These hooks are triggered on the BDS hook events > > What was done: > > * Included an instance of BdsHookLib and BoardBootManagerLib > from BoardModulePkg > > * Included BdsHookDxe to register the callbacks implemented > in BdsHookLib > > Signed-off-by: Nate DeSimone > Cc: Chasel Chiu > Cc: Rangasai V Chaganty > Cc: Prince Agyeman > Cc: Michael Kubacki > --- > .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 4 ++++ > .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > index 2ab9cb03ea..536ed7fb09 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > @@ -224,6 +224,8 @@ > ####################################### > DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyUpdateLib/DxePolicyUpdateLib.inf > DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtPolicyLib/DxeTbtPolicyLib.inf > + BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf > + BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf > > ####################################### > # Board-specific > @@ -446,3 +448,5 @@ > $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf > !endif > BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > + > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf > index 199e3876bf..0d99114961 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf > @@ -345,6 +345,7 @@ INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > > # > # eMMC/SD Card >