* [PATCH v2 0/7] Add linked list iteration macros to BaseLib.h
@ 2020-04-10 20:02 Michael Kubacki
2020-04-15 17:10 ` Michael Kubacki
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kubacki @ 2020-04-10 20:02 UTC (permalink / raw)
To: devel
Cc: Chao Zhang, Dandan Bi, Hao A Wu, Jian J Wang, Liming Gao,
Michael D Kinney, Ray Ni, Sean Brogan
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
V2 changes:
* Add explicit dependency to EhciPei on BaseLib
The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been
duplicated across several drivers such as:
* EhciPei
* EhciDxe
* HddPasswordDxe
* RamDiskDxe
* UfsPassThruDxe
* XhciDxe
These macros have proven useful and established a commonly used pattern
for linked list iteration.
This patch series consolidates the definitions to a single definition in
BaseLib.h so they are maintained alongside other pre-existing generic
linked list macros and functions.
Note: Another commonly used generic linked list macro is EFI_LIST_CONTAINER.
I'm considering consolidating that to BaseLib.h as well but that is not
done in this patch series since it satisfies a separate use case than the
iteration macros and the change can be made independently.
On a separate note, shallow threading might not work on this patch series
due to changes made by the SMTP server. Please bear with me while I am
investigating if this can be changed.
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Michael Kubacki (7):
MdePkg/BaseLib: Add linked list iteration macros
MdeModulePkg/EhciDxe: Use BaseLib linked list iteration macros
MdeModulePkg/EhciPei: Use BaseLib linked list iteration macros
MdeModulePkg/XhciDxe: Use BaseLib linked list iteration macros
MdeModulePkg/UfsPassThruDxe: Use BaseLib linked list iteration macros
MdeModulePkg/RamDiskDxe: Use BaseLib linked list iteration macros
SecurityPkg/HddPassword: Use BaseLib linked list iteration macros
MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 3 ++-
MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 11 ++++----
MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 5 ++--
MdeModulePkg/Bus/Pci/EhciPei/EhciSched.c | 3 ++-
MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 5 ++--
MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 9 ++++---
MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 3 ++-
MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 3 ++-
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 3 ++-
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 9 ++++---
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c | 5 ++--
SecurityPkg/HddPassword/HddPasswordDxe.c | 13 +++++-----
MdeModulePkg/Bus/Pci/EhciDxe/Ehci.h | 15 +----------
MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h | 16 ++----------
MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf | 2 ++
MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h | 9 +------
MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h | 9 +------
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.h | 15 +----------
MdePkg/Include/Library/BaseLib.h | 27 ++++++++++++++++++++
SecurityPkg/HddPassword/HddPasswordDxe.h | 7 +----
20 files changed, 78 insertions(+), 94 deletions(-)
--
2.16.3.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 0/7] Add linked list iteration macros to BaseLib.h
2020-04-10 20:02 [PATCH v2 0/7] Add linked list iteration macros to BaseLib.h Michael Kubacki
@ 2020-04-15 17:10 ` Michael Kubacki
2020-04-20 23:50 ` Liming Gao
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kubacki @ 2020-04-15 17:10 UTC (permalink / raw)
To: devel, Chao Zhang, Dandan Bi, Hao A Wu, Jian J Wang, Liming Gao
Cc: Michael D Kinney, Ray Ni, Sean Brogan
I saw Bret gave an R-b to the v2 series since it was sent. In addition
to the R-bs already captured from v1, is there anything else needed for
the series to be pushed?
Thanks,
Michael
On 4/10/2020 1:02 PM, michael.kubacki@outlook.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
>
> V2 changes:
> * Add explicit dependency to EhciPei on BaseLib
>
> The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been
> duplicated across several drivers such as:
>
> * EhciPei
> * EhciDxe
> * HddPasswordDxe
> * RamDiskDxe
> * UfsPassThruDxe
> * XhciDxe
>
> These macros have proven useful and established a commonly used pattern
> for linked list iteration.
>
> This patch series consolidates the definitions to a single definition in
> BaseLib.h so they are maintained alongside other pre-existing generic
> linked list macros and functions.
>
> Note: Another commonly used generic linked list macro is EFI_LIST_CONTAINER.
> I'm considering consolidating that to BaseLib.h as well but that is not
> done in this patch series since it satisfies a separate use case than the
> iteration macros and the change can be made independently.
>
> On a separate note, shallow threading might not work on this patch series
> due to changes made by the SMTP server. Please bear with me while I am
> investigating if this can be changed.
>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (7):
> MdePkg/BaseLib: Add linked list iteration macros
> MdeModulePkg/EhciDxe: Use BaseLib linked list iteration macros
> MdeModulePkg/EhciPei: Use BaseLib linked list iteration macros
> MdeModulePkg/XhciDxe: Use BaseLib linked list iteration macros
> MdeModulePkg/UfsPassThruDxe: Use BaseLib linked list iteration macros
> MdeModulePkg/RamDiskDxe: Use BaseLib linked list iteration macros
> SecurityPkg/HddPassword: Use BaseLib linked list iteration macros
>
> MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 3 ++-
> MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 11 ++++----
> MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 5 ++--
> MdeModulePkg/Bus/Pci/EhciPei/EhciSched.c | 3 ++-
> MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 5 ++--
> MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 9 ++++---
> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 3 ++-
> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 3 ++-
> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 3 ++-
> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 9 ++++---
> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c | 5 ++--
> SecurityPkg/HddPassword/HddPasswordDxe.c | 13 +++++-----
> MdeModulePkg/Bus/Pci/EhciDxe/Ehci.h | 15 +----------
> MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h | 16 ++----------
> MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf | 2 ++
> MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h | 9 +------
> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h | 9 +------
> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.h | 15 +----------
> MdePkg/Include/Library/BaseLib.h | 27 ++++++++++++++++++++
> SecurityPkg/HddPassword/HddPasswordDxe.h | 7 +----
> 20 files changed, 78 insertions(+), 94 deletions(-)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 0/7] Add linked list iteration macros to BaseLib.h
2020-04-15 17:10 ` Michael Kubacki
@ 2020-04-20 23:50 ` Liming Gao
0 siblings, 0 replies; 3+ messages in thread
From: Liming Gao @ 2020-04-20 23:50 UTC (permalink / raw)
To: Michael Kubacki, devel@edk2.groups.io, Zhang, Chao B, Bi, Dandan,
Wu, Hao A, Wang, Jian J
Cc: Kinney, Michael D, Ni, Ray, Sean Brogan
Reviewed-by: Liming Gao <liming.gao@intel.com> for this patch set.
-----Original Message-----
From: Michael Kubacki <michael.kubacki@outlook.com>
Sent: 2020年4月16日 1:10
To: devel@edk2.groups.io; Zhang, Chao B <chao.b.zhang@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <liming.gao@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [PATCH v2 0/7] Add linked list iteration macros to BaseLib.h
I saw Bret gave an R-b to the v2 series since it was sent. In addition to the R-bs already captured from v1, is there anything else needed for the series to be pushed?
Thanks,
Michael
On 4/10/2020 1:02 PM, michael.kubacki@outlook.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
>
> V2 changes:
> * Add explicit dependency to EhciPei on BaseLib
>
> The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been
> duplicated across several drivers such as:
>
> * EhciPei
> * EhciDxe
> * HddPasswordDxe
> * RamDiskDxe
> * UfsPassThruDxe
> * XhciDxe
>
> These macros have proven useful and established a commonly used
> pattern for linked list iteration.
>
> This patch series consolidates the definitions to a single definition
> in BaseLib.h so they are maintained alongside other pre-existing
> generic linked list macros and functions.
>
> Note: Another commonly used generic linked list macro is EFI_LIST_CONTAINER.
> I'm considering consolidating that to BaseLib.h as well but that is
> not done in this patch series since it satisfies a separate use case
> than the iteration macros and the change can be made independently.
>
> On a separate note, shallow threading might not work on this patch
> series due to changes made by the SMTP server. Please bear with me
> while I am investigating if this can be changed.
>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (7):
> MdePkg/BaseLib: Add linked list iteration macros
> MdeModulePkg/EhciDxe: Use BaseLib linked list iteration macros
> MdeModulePkg/EhciPei: Use BaseLib linked list iteration macros
> MdeModulePkg/XhciDxe: Use BaseLib linked list iteration macros
> MdeModulePkg/UfsPassThruDxe: Use BaseLib linked list iteration macros
> MdeModulePkg/RamDiskDxe: Use BaseLib linked list iteration macros
> SecurityPkg/HddPassword: Use BaseLib linked list iteration macros
>
> MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 3 ++-
> MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 11 ++++----
> MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 5 ++--
> MdeModulePkg/Bus/Pci/EhciPei/EhciSched.c | 3 ++-
> MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 5 ++--
> MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 9 ++++---
> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 3 ++-
> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 3 ++-
> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 3 ++-
> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 9 ++++---
> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c | 5 ++--
> SecurityPkg/HddPassword/HddPasswordDxe.c | 13 +++++-----
> MdeModulePkg/Bus/Pci/EhciDxe/Ehci.h | 15 +----------
> MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h | 16 ++----------
> MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf | 2 ++
> MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h | 9 +------
> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h | 9 +------
> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.h | 15 +----------
> MdePkg/Include/Library/BaseLib.h | 27 ++++++++++++++++++++
> SecurityPkg/HddPassword/HddPasswordDxe.h | 7 +----
> 20 files changed, 78 insertions(+), 94 deletions(-)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-20 23:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-10 20:02 [PATCH v2 0/7] Add linked list iteration macros to BaseLib.h Michael Kubacki
2020-04-15 17:10 ` Michael Kubacki
2020-04-20 23:50 ` Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox