From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.92.20.44]) by mx.groups.io with SMTP id smtpd.web12.2527.1596824034290552926 for ; Fri, 07 Aug 2020 11:13:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=WZOyTtG7; spf=pass (domain: outlook.com, ip: 40.92.20.44, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bz2WS2r4ZU5DLemhhAPcVPqyrK4SXs8Ybl0cevQwCxRbdCUA9x7OPuOmRbmPh/f/OFo7doh7cRQNCb/cIBTyJ7QcoPLvVId4SY+7dPeJaTi4higjxxgobEJnvjZx/qJCKfWeJ5Xn7V9SBLhdxRkDSrCL3lcMkq1VAYlTpeYmWfj5B1nrxw1WP0XSNE5zWlPCaT+109uudxlo+uPN5K28zXFclx/R8t1iRJBEgXrlDE3DHCnI+PHE6hgK8S057QnjJdYRibji8Lwq+Qg8ngiMAV3Nb5eHPyBQbHmR2bvriOEh6czWPx8l/sJ4OU8JMPOHZQ2RuAVnc2gj+hNjlgERtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HzdjOvWfDq3QTVGliK/vMxXQ3fxj5wQNI7VA6wO3Hz4=; b=Rw2HwczROg/9+Tx5lHcDHCen5ch07JT8aIWBN6hTOy5GNHovU+Ynt5TY3C+2MClkKkpK1xyaLO2h8urdR9XhWd19VY8sEOqGxiCZoUB1c473p1MI/b7NaO40KJj4WuddTkHKSiU0Ej7v79aS6O68NYqnzRPVxDB4bC+W4ybivJJ6jqKoqMiuhkYl3acQdwuiGHW/rgb278o8FllfkZHQU+rQAyOoCS1c9SoPLOo8fMjELtr6vYG+h6TJhkgliDSs4YHLxOaseJbyU5ObNhoUWBWvrZm/six7JZA2qI8i1CxtX4W19kMNQ7X2pKRSRWbDAm80nfZWe3Bf6W5chfBYmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HzdjOvWfDq3QTVGliK/vMxXQ3fxj5wQNI7VA6wO3Hz4=; b=WZOyTtG71haWlveCUv3Z0X2mikJGqoMUSwrfXTUxT0tWl4yMj/nGlJAkZBKEeI8hGaRXYYgeP4nnN8BCLOKAnVndDdl+2CVR+85Rk1k3qiKPivfkiDoGiWi6TBkSiLwh+n7EU7VY8vEVzfglj6p20UFqYMl+u4cHj/02SVazoay9yrZbeXbm7QiQcbTB8VMZ2Pdm4wHjY0ZW1ef8BVjrgKh0BlDYrbnXFO3T33x+8mCtUvie3Sp/ifNtzbNwtG45R89dn7drtgpK4zRlMJHbH5ZqQNXFAdI/noIDu2xqfNby41DnB3795CHK1eqVsIN/4nIOmLMNqkPCEnyTGp0Oqw== Received: from BN8NAM11FT043.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::43) by BN8NAM11HT113.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::284) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16; Fri, 7 Aug 2020 18:13:52 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:fc4b::48) by BN8NAM11FT043.mail.protection.outlook.com (2a01:111:e400:fc4b::474) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16 via Frontend Transport; Fri, 7 Aug 2020 18:13:52 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:C83FE1209DFA5E3DA3B39A6822FE9DC604560539A80D7D6BE6560A39C66AAC4A;UpperCasedChecksum:6BCA8B18EC62371DC8079FD1F4F05E07ADEFA0EE9F282B337E316ED2DECFF7E4;SizeAsReceived:9183;Count:49 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e%7]) with mapi id 15.20.3261.019; Fri, 7 Aug 2020 18:13:52 +0000 Subject: Re: [PATCH v1 0/7] Extend Last Attempt Status Usage To: "Kinney, Michael D" , "devel@edk2.groups.io" Cc: "Gao, Liming" , "Jiang, Guomin" , "Xu, Wei6" References: From: "Michael Kubacki" Message-ID: Date: Fri, 7 Aug 2020 11:13:51 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 In-Reply-To: X-ClientProxiedBy: MWHPR04CA0054.namprd04.prod.outlook.com (2603:10b6:300:6c::16) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <938a47cb-6e73-f451-7a03-a890583f84e0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:2d9d:8e69:1fd3:409e] (2001:4898:80e8:2:adc3:8e69:1fd3:409e) by MWHPR04CA0054.namprd04.prod.outlook.com (2603:10b6:300:6c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.18 via Frontend Transport; Fri, 7 Aug 2020 18:13:52 +0000 X-Microsoft-Original-Message-ID: <938a47cb-6e73-f451-7a03-a890583f84e0@outlook.com> X-TMN: [/lCn9BMOaiSNB0HtU/0MMPDk5dQnV9msxHmgDIgSvkYDIrr/OiGgmOhWmLUz3JzQ] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 4c7db780-5701-49ff-9ba5-08d83afda3d1 X-MS-TrafficTypeDiagnostic: BN8NAM11HT113: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4POISRYb+Jc81bG40t9KLAwTyWObzF6IgsOrE5j7muZkhu1+Ih8hfxXFvRlWh8u3DaZj1zYaNflmj8KbATcxAF/b9/IyL3Zdhm0NKX5nBQEi9PanH/Tk/Ff2a54XCj6zUrTGhdeuOj0bpXJj8YPsWIjYjxD0iY1Z1eE5flLSMfsWfB3u2WE21ZJXu4iGA7xPlqLhos5cNlRTkIqgVprvLGmD2MN7VS5GjjVJoYTEYXBCZvgt/BY+C0sfbs/dISN/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: lA+xu20IeQBSrJ2bO+DR3PunwM8rQwGM1PbT3xdN1bOpPI+9KPey6J+2gtlmjNL00yjL1LJB1lAd/5NYwJ/eDb6jx6i/Pqq/J12mom6cztbLmWCfd1Bj/Jhk+VC7snPZ5QhYD6ihlflGtkSy2/c0iRxpGfosCrykdvmW2SychNephKpL4ywGWDyFtS8iW8rhb/9MRBb7iSrHdB5ndIzZow== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c7db780-5701-49ff-9ba5-08d83afda3d1 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2020 18:13:52.5943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT043.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM11HT113 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Mike, I considered just adding LastAttemptStatus.h in its final state in patch 2/7 but I wanted to better connect its contents to C file usage across the review (and commits that leverage those status codes). I'd be happy to move the contents in final form to patch 2 though if that's preferred. I agree that the file is more appropriate in a PrivateInclude and I'll make that change in v2. Thanks, Michael On 8/7/2020 9:56 AM, Kinney, Michael D wrote: > Hi Michael, > > I see multiple patches in this series that modify LasAttempStatus.h. > > Would it make more sense to add this include file with all the > values in one patch, and then the subsequent patches use the > new values? > > Also, should LastAttemptStatus.h start out as a PrivateInclude > since it is only used by components in the FmpDevicePkg? > > Thanks, > > Mike > >> -----Original Message----- >> From: michael.kubacki@outlook.com >> Sent: Friday, August 7, 2020 12:15 AM >> To: devel@edk2.groups.io >> Cc: Gao, Liming ; Kinney, Michael D ; Jiang, Guomin >> ; Xu, Wei6 >> Subject: [PATCH v1 0/7] Extend Last Attempt Status Usage >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2802 >> >> This patch series adds more granularity to Last Attempt Status >> codes reported during FMP check image and set image operations >> that greatly improve precision of the status codes. >> >> The vendor range (0x1000 - 0x4000) was introduced in UEFI >> Specification 2.8. That range is used within this patch series >> to define three subranges: >> 1. FMP driver codes >> 2. FMP dependency related codes >> 3. FMP device library codes >> >> Most of the vendor range remains allocated to vendor device >> library codes. There might be a preference to move some of >> these codes explicitly to the UEFI Specification or other >> ranges in the Last Attempt Status space. That is left open >> to feedback to the series. >> >> Cc: Liming Gao >> Cc: Michael D Kinney >> Cc: Guomin Jiang >> Cc: Wei6 Xu >> Signed-off-by: Michael Kubacki >> >> Michael Kubacki (7): >> FmpDevicePkg/SystemResourceTable.h: Add vendor range values >> FmpDevicePkg: Add LastAttemptStatus.h >> FmpDevicePkg/FmpDxe: Add check image path Last Attempt Status >> capability >> FmpDevicePkg/FmpDxe: Improve set image path Last Attempt Status >> granularity >> FmpDevicePkg/LastAttemptStatus.h: Add dependency range codes >> FmpDevicePkg: Add Last Attempt Status support to dependency libs >> FmpDevicePkg/FmpDeviceLib: Add Last Attempt Status to Check/Set API >> >> FmpDevicePkg/FmpDxe/FmpDxe.c | 180 +++++++++++++++++--- >> FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c | 38 +++-- >> FmpDevicePkg/Library/FmpDependencyCheckLibNull/FmpDependencyCheckLibNull.c | 9 +- >> FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 95 +++++++++-- >> FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c | 42 +++-- >> FmpDevicePkg/Test/UnitTest/Library/FmpDependencyLib/EvaluateDependencyUnitTest.c | 7 +- >> FmpDevicePkg/FmpDxe/FmpDxe.h | 1 + >> FmpDevicePkg/Include/LastAttemptStatus.h | 81 +++++++++ >> FmpDevicePkg/Include/Library/FmpDependencyCheckLib.h | 8 +- >> FmpDevicePkg/Include/Library/FmpDependencyLib.h | 44 +++-- >> FmpDevicePkg/Include/Library/FmpDeviceLib.h | 44 +++-- >> MdePkg/Include/Guid/SystemResourceTable.h | 4 + >> 12 files changed, 461 insertions(+), 92 deletions(-) >> create mode 100644 FmpDevicePkg/Include/LastAttemptStatus.h >> >> -- >> 2.28.0.windows.1 >