From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.92.42.32]) by mx.groups.io with SMTP id smtpd.web10.12499.1596568313889551264 for ; Tue, 04 Aug 2020 12:11:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=Ser+tmr0; spf=pass (domain: outlook.com, ip: 40.92.42.32, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdWm/Q90KNCcJGdtRnR88HwZ1kCXkteWzby29j2TsDcLy26oHyjegDCmwYA314JWdAy4s856NXeyHwq/DMzksMu4+LbLI3bGGcNp4/23EFtnArt+12E745ykGWKVPu0hjeJOqxVN+W/J+WN9YaaBewixgMOcjnxCmYpCUEdwZePGDYRnxloKxV2MlrZB6hIvCvi/u/SKNT7PkuyZV7NP5Ru55NQpU3JRKv2j9JnZWvC/bKvP1G/uA8xI3j6s5WnZA9CMlr8UjAI1vx1kqOR/BaomDz2Xw+nNvf5HXT/UZulgj7Lld/cv3cX5Oy9a0YM1jk10bqpChjkNb/r6tT6Fmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0N8d3Yofj/YSN/OCtvwMdIRizbUo3Vsy2hE4YpkJpzA=; b=YzzBZGq9w8NFESGXoLdroKopltge4ZBO7NZG06BEuxhycRC4UTtxeX+qTG8hn59KUKuZxQd4DL6tOXg5vF/M33Uo8OMptqiBQ6Ck6WTSFBrZGqr9XSaOAYCLqdTG4pOtplLSUskgZuX38fYBwd3fVxj7iaoBE4DkETmrnHseh7KRqs0yfdhHZojRdbQBA50dEH1lAcni+lQd8k+THJl8ktt38Cz36pffZmEVLdQuUl1Px8YnMUiKNoSb/3HIcGvwhxHi5gIbb4XyZPJxdus2cWfBvI90bpY1AKstBnaswJhYQCtEpVL43wEtxlcynumBn4ktEEcJ8n2fG3pTDUbC6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0N8d3Yofj/YSN/OCtvwMdIRizbUo3Vsy2hE4YpkJpzA=; b=Ser+tmr004PrzeEJIDGvwlCkwiwphX16rOm3NOa226zOJPzZ+/Ey8956CX2AoXdof6T4oJdGPd7qY1eGFs0SworLzWCKiwR2Lw24LqcBuslttLklw8fraP3y1PeZilaf+sCkd0/uwOgjQLhsuomEYiL8DGrAcsGT8cY8hKfGWycWPpLN51f274JuUEpYoOcnnDhKfHCQKRczNkD1jWkd9797jRSRhYpo0jmzLS9SPBWz9C9HF/FCRZlNp+Sqds+luzFZbCzzJcxfjeaVVsfzW3fxhQY3vPKMFxi9ldbLYZ6g3eaFTfw8z2YOfmTTqcuUYtGzZbGbEg8eiFHAHLYmKA== Received: from MW2NAM10FT061.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::4f) by MW2NAM10HT029.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.20; Tue, 4 Aug 2020 19:11:52 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:7e87::53) by MW2NAM10FT061.mail.protection.outlook.com (2a01:111:e400:7e87::266) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Tue, 4 Aug 2020 19:11:52 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:48219FBD9FF7FAF77617D3A6570013542C6CC2676A94C71EDC5758882014DC14;UpperCasedChecksum:DA6F806C9CBDF72B0C4D48B7F7707A4479A507B8C055074894BF1E324049C631;SizeAsReceived:8958;Count:49 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e%7]) with mapi id 15.20.3239.022; Tue, 4 Aug 2020 19:11:52 +0000 Subject: Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes From: "Michael Kubacki" To: devel@edk2.groups.io, Liming Gao , Michael D Kinney Reply-To: devel@edk2.groups.io, michael.kubacki@outlook.com References: <1626B7E87C6880F1.8866@groups.io> Message-ID: Date: Tue, 4 Aug 2020 12:11:51 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 In-Reply-To: <1626B7E87C6880F1.8866@groups.io> X-ClientProxiedBy: CO2PR06CA0065.namprd06.prod.outlook.com (2603:10b6:104:3::23) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:f05c:7e15:756f:472a] (2001:4898:80e8:f:7076:7e15:756f:472a) by CO2PR06CA0065.namprd06.prod.outlook.com (2603:10b6:104:3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Tue, 4 Aug 2020 19:11:52 +0000 X-Microsoft-Original-Message-ID: X-TMN: [UYju41+an1iuR6nWDWHIDHoZISROnxiHw2lDVPhRENUxgxcOW0FLz99wqcmtDOHT] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: ec8caf5b-461f-4240-5032-08d838aa3ebf X-MS-TrafficTypeDiagnostic: MW2NAM10HT029: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GNLLe3QdeMBB8ikp1WPQ7QO3519t9MNEZZZeFK23ErMM8ybFoWK6XG88AFI/JAiistzLiZVYv7bhOMpcM0XP86DKvX2tFf3VjM/8DqAu+OvdV/qtfo7mLCzWCS3dkUsa3ImDFSpMaA8wbDO87jKpopPUJ5ps7YB6983K/lgzUj3HIyrJeYHd8z99UsuymAYOwtnvdwA+qRyRF9HcEoE1rROkVQTWUYQbFEVB1z+K1CVmK6MA1IIlEkUTOUoY2LHR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: NfkOP5WE3AuS16iUfl+KXi7/24wr14hh+fbTKMBSFFuE1cu5HvM0IU2l3xZYCGSMbEGzx8dYW7OmawNJ8BGjsBuXnbvDQ4b5PM1py/cFEriA18xwV7ogG0tg45ff3DZRMAGDCHzbVfnSaxGjjprIJCJF3ZOStYm0xsVDgLN3pDlNrnvJAeZPsxHz+/b2Tj6SRZ6sVfINv7azQwq/qDO39A== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec8caf5b-461f-4240-5032-08d838aa3ebf X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2020 19:11:52.6533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT061.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM10HT029 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I saw one R-b for the series from Wei6 Xu. Could the remaining reviewers please help with review? I have a larger series that is based on it that I'd like to send once this series is merged. Thanks, Michael On 7/30/2020 8:14 PM, Michael Kubacki wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869 > > This patch series makes minor fixes and enhancements in > FmpDevicePkg. None of the issues impact functionality in a > major way. > > These are smaller sets of changes that are being submitted prior > to a larger future patch series that will cover functional changes > for BZ2802. > > Please check the git notes in patch 3 and patch 5. > > Cc: Liming Gao > Cc: Michael D Kinney > Signed-off-by: Michael Kubacki > > Michael Kubacki (7): > FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency() > documentation > FmpDevicePkg/FmpDependencyLib: Fix "exression" typo > FmpDevicePkg/FmpDependencyLib: Handle version string overflow > FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle > failure > FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig > FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName > FmpDevicePkg/FmpDxe: Improve function parameter validation > > FmpDevicePkg/FmpDxe/FmpDxe.c | 62 ++++++++++++++++---- > FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c | 2 + > FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 8 ++- > FmpDevicePkg/FmpDxe/FmpDxe.h | 10 ++-- > FmpDevicePkg/Include/Library/FmpDependencyLib.h | 5 +- > 5 files changed, 67 insertions(+), 20 deletions(-) >