From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.92.19.26]) by mx.groups.io with SMTP id smtpd.web12.967.1587494131438709208 for ; Tue, 21 Apr 2020 11:35:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=o828PKb/; spf=pass (domain: outlook.com, ip: 40.92.19.26, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VTYxvH1qdoucpuKZFc2KOrfKImqYawwljrbnIhAwCxcOemXBjsbpEO5kwyhfYCFqA7NEJ8wOitDfrhdnAjAksek559Z0fQ6TzCCDu2GcxPBjy7QmfxAlC4qOBiXDzCdZTYftDg6JTuvoOnFPMG1gQbkGQj+EvLS8rE9Zs3EQOqAXrPcmJyztsNry6nmkrYpSDUSiU7tzyWr+FFlrEAaeUSrGmsk8g2cbWkgpwuPXN0MA7FXiKerBAa2BK8BKR5JPfsLrq/5n+UUWecsIPLP/TQnMlVW9kR3hmttqDLE9HH9QtTQiOuMrZiFq/TDb1R2x4R4EyuRGJzn6w2Feo/2ixw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a9r6jPp4lzbKnmNbGIBVQevfTOVvAA3zmC1OnR1MxiI=; b=hLOjiAd9erydrsyYm4eJ3u87vM4yVbBRJ9J0LZB58DcYvmuX2xszQ+m3xgd+KqeMRlEM9VNZRnqzqaB91IdJQcMiskAbyH2XoFakvo5vVDPhnXSLSlIeeAFXfn+ZtMerXS9M9ZhE6pgGPo64Y2qBvEXav9fmR0jxtDhmc3VysoD/wkqScSQ8af8dZX+IpM+sqpDlJisma0+r3hjpyiJAIJcSz0iqJSoQ9qltt4Wa+ymRsxu8NDioNZPB+ZAd6+Cgyv90W/UDPDjwoIQj9nw7o5iPH6avmL5Lel0rz6HtsV9cmRqkOjZ+YxvSbic82UvWgf9WV10d+z6iPMYfOcTH8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a9r6jPp4lzbKnmNbGIBVQevfTOVvAA3zmC1OnR1MxiI=; b=o828PKb/caXyeLEtBHardX6NVv/xer5Z7kKFvKPFkzV1SQWJNzd/cBw8cmZrWc4egf5jL7f3VxVg94SYo1kBOXtLTuo2Sr+wNjjZ3rEfFeoWewx4yTGBggWhzJijJANDcBOB9Gkr51EZ0UBSBp3EmRgWMTvvA1oUlNwYEHgd6LnYDagaIQntNkdwxAQDceJrxwQ9j67YQpBkO1yFrsUWwmuhLmHKNsZHU70yYjFxxzqfJ2Kpf8aDk0DntYU7avdd0I8ZKo0+FRJaVcwWUyi4scKi88SICgWUVURl/6rl7xtUMIulH176BZ+4AfMZrtZLNu2AoEnUL4ryT+UBq397Aw== Received: from DM6NAM11FT059.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4d::53) by DM6NAM11HT229.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4d::72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Tue, 21 Apr 2020 18:35:30 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:fc4d::4c) by DM6NAM11FT059.mail.protection.outlook.com (2a01:111:e400:fc4d::92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Tue, 21 Apr 2020 18:35:30 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:AD4C1575C68FA04CA651F870A6177A2B76781B0199CA4BD06F8E4ACF1A1958A5;UpperCasedChecksum:512DCBF831912D40C32A4C0B08B34B8EEBE7672C62FA791B7488C02C585C4720;SizeAsReceived:7810;Count:49 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3%6]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 18:35:30 +0000 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Bret Barkelew , Liming Gao , Michael D Kinney Subject: [PATCH v1 1/2] MdePkg/UnitTestLib.h: Drop FrameworkHandle param from SaveFrameworkState() Date: Tue, 21 Apr 2020 11:35:01 -0700 Message-ID: X-Mailer: git-send-email 2.16.3.windows.1 In-Reply-To: <20200421183502.39876-1-michael.kubacki@outlook.com> References: <20200421183502.39876-1-michael.kubacki@outlook.com> X-ClientProxiedBy: MWHPR19CA0085.namprd19.prod.outlook.com (2603:10b6:320:1f::23) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <20200421183502.39876-2-michael.kubacki@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2001:4898:80e8:b:3907:8d1b:5bae:c73c) by MWHPR19CA0085.namprd19.prod.outlook.com (2603:10b6:320:1f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Tue, 21 Apr 2020 18:35:29 +0000 X-Mailer: git-send-email 2.16.3.windows.1 X-Microsoft-Original-Message-ID: <20200421183502.39876-2-michael.kubacki@outlook.com> X-TMN: [7eEW93FWSIYrhDIDpHpNabdzytp05isnvCMfBuH/Hfltkst8OXrlcDUqS3oN9tvL] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 501be7d2-7dc8-4bd4-637e-08d7e622c443 X-MS-TrafficTypeDiagnostic: DM6NAM11HT229: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B3InDt0UDt0k2zhU3SlXlgKV5DEy5weubLrdaJzj5++sUfiaJSXzWFNf9ph54Xp8xwZXcKCyVQmqufWOP9s4klFlGC/P4k0p6YPguprhlpHhSE6PQ7DnSgds69Dg6WxMi3u/uSJ9HPY9CUzn2vS0fRCtkytbq5h0uoY5z2GeI3pgh3eFJ1wBFBFwCaNQTRS2wuGx4qMJyTpnn0Zvq4Jzo1WlYQIchSAMH6rEWWWXpx/d6O71Ogk7G9P6D05lKV8u X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: r+49Uc9MVG3hJwZbZOIqT2+/8bZFPfnOIubce4z9KbcQIGx7TY2p5QqPooU2StqcjUqAJubkPgs3IDJk/rFZovl/N3Jb0F1FZzuNBNO2kB5ookauIcoZMPwd2z5VI6SGzXFRRpors3O9g3RhPtJtA9y31ml8VciJlFeSNQu1CicGQpcnibr+FnUVKAVXGYyD8jHYk81YZyI3UkMtrVhrxQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 501be7d2-7dc8-4bd4-637e-08d7e622c443 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2020 18:35:30.3215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM11HT229 Content-Type: text/plain From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2612 The framework handle can be retrieved from GetActiveFrameworkHandle() internal to SaveFrameworkState() so this change removes the parameter from the function signature. Cc: Bret Barkelew Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Michael Kubacki --- MdePkg/Include/Library/UnitTestLib.h | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/MdePkg/Include/Library/UnitTestLib.h b/MdePkg/Include/Library/UnitTestLib.h index c06c36bea5aa..a4374580a8d5 100644 --- a/MdePkg/Include/Library/UnitTestLib.h +++ b/MdePkg/Include/Library/UnitTestLib.h @@ -313,11 +313,9 @@ FreeUnitTestFramework ( at least the current execution count) which will be saved by the framework and passed to the test case upon resume. - Generally called from within a test case prior to quitting or rebooting. + This should be called while the current test framework is valid and active. It is + generally called from within a test case prior to quitting or rebooting. - @param[in] FrameworkHandle A handle to the current running framework that - dispatched the test. Necessary for recording - certain test events with the framework. @param[in] ContextToSave A buffer of test case-specific data to be saved along with framework state. Will be passed as "Context" to the test case upon resume. This @@ -325,7 +323,7 @@ FreeUnitTestFramework ( @param[in] ContextToSaveSize Size of the ContextToSave buffer. @retval EFI_SUCCESS The framework state and context were saved. - @retval EFI_INVALID_PARAMETER FrameworkHandle is NULL. + @retval EFI_NOT_FOUND An active framework handle was not found. @retval EFI_INVALID_PARAMETER ContextToSave is not NULL and ContextToSaveSize is 0. @retval EFI_INVALID_PARAMETER ContextToSave is >= 4GB. @@ -338,7 +336,6 @@ FreeUnitTestFramework ( EFI_STATUS EFIAPI SaveFrameworkState ( - IN UNIT_TEST_FRAMEWORK_HANDLE FrameworkHandle, IN UNIT_TEST_CONTEXT ContextToSave OPTIONAL, IN UINTN ContextToSaveSize ); -- 2.16.3.windows.1