From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.63]) by mx.groups.io with SMTP id smtpd.web11.33313.1661486892766600045 for ; Thu, 25 Aug 2022 21:08:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=TpMZ6rcD; spf=pass (domain: ami.com, ip: 40.107.96.63, mailfrom: prakashk@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m0vsSD/Psh2STPqjsATzwItQ2gEsfdrI6yK8cNR2nE7dZQIzb/aA24O1fJQ3uE7MWUDJHcIdS8ZsXIJFTjl1C6n0vDi5sY1B+fPzHRtXZlyQ4qYZ4EF3mm4Mc+S3otX0hGNmP94+8QqMp8R2tpmKotfKS9eEWsV/7pvXBG2EKn5wH2/JicSOQ8/bCscOTKfjZrx8pdNzsaFmeR32RLkf6E6gyXIyQCmiSfNJ7BPxdm9nWfjvU4cqmUewc7kA/ZutO4WFkWMX54LZaQCt4JRfaGYctguuLWo5WektNqMe0oHXYumRHctT3QseduCd6DMdrXjNnUbRimK7tbfsSiUUDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rZJDMg77iDqUMKFjNuw56XHmn8ZW5NjJ2CBP599HG1Q=; b=POY3wiQbMj0AggC9X+jV7bAg9b2ePWZCGkuPzHSJPG4VBqfiIXdfABT42/miZSuhT7uo6OMjkrJKSuO33fsnmRcqYL8o+JM3FKSW8nJBR6KWxjdnE6LEEYE2PpFxhMn3bG4BqyCyYATfo68CeXUkStyMvrStqbmPPhPDvvy4Biq1LslQ7UeAzV8grigQgVphIOtHdCNVf3BPZJ1IVgHBL2EyVof0JO4V/MOJaw6vWqKGmhXdA8VmeVuN9DKCJT1hv8eDc9t1zTTHWRUlf/6Pa37bq5Wn7HRyrt9LKRBC60pOdpczIhzBkgPW8v1jit+DZelP0MSyMAmX45bEePhUGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rZJDMg77iDqUMKFjNuw56XHmn8ZW5NjJ2CBP599HG1Q=; b=TpMZ6rcDFmOtfI+3IYlSuagZc3UXCN7FDhIr75Oav7KNk6aukCHf7xpVW50+tAouSmBbD5HCK491v9ls+67CYmbu7azJfay2+CZcpBw4VS5SMEDQ3lNT1CmXlqOPp+Tnu7pZtl4Slapd6k7s7F1axBT3hF2jDmur4FnPLJ55uDc= Received: from MWHPR10MB1599.namprd10.prod.outlook.com (2603:10b6:300:28::19) by SJ0PR10MB4798.namprd10.prod.outlook.com (2603:10b6:a03:2df::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Fri, 26 Aug 2022 04:08:10 +0000 Received: from MWHPR10MB1599.namprd10.prod.outlook.com ([fe80::a18d:1d2c:4f03:5555]) by MWHPR10MB1599.namprd10.prod.outlook.com ([fe80::a18d:1d2c:4f03:5555%6]) with mapi id 15.20.5546.025; Fri, 26 Aug 2022 04:08:10 +0000 From: prakashk@ami.com To: "gaoliming@byosoft.com.cn" , "devel@edk2.groups.io" CC: Vasudevan Sambandan , Sundaresan S , Gayathri Thunuguntla Subject: FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner Thread-Topic: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner Thread-Index: AQHX/KyOONDOgOmxnkKSHbrVo/LMwq3CCCOw Date: Fri, 26 Aug 2022 04:08:09 +0000 Message-ID: References: <20211229120641.540-1-prakashk@ami.com> In-Reply-To: <20211229120641.540-1-prakashk@ami.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3953c5ec-58a0-4f37-60aa-08da87189686 x-ms-traffictypediagnostic: SJ0PR10MB4798:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jk+F9FgWRRl7h8AvFnKK2/m2DwcbBQFVyYa7sHZFF7au59Grn4HD47EDyOlzHj4ZIJxjxYQ3Dk5uvKAL/vp9FsXoGuCD2Bhm1UpsMkQtZOpbiztcrKSxO/Z3wiSTjHdkKkgpQ9hgHsICzUDFP+s7WfV9CkEtdrythizhtIipAk0due8c4FfLBCk7u9dPXhSIebPFpOBRuyzF/I/jE4zlv0eeShwIciSx4kmU5Bq5y73yuavIZtDHA6DiisFAsfx/l+ldEuv2VVz333F3zvThDdY9je9722ccy5UZP8COIRmVtHEx1BuWjpsVE6vV65Bao8HSdPgGXlAswhFLgfq/OKF34j5E8jRIevHKTjyb8KkbKqKvKqPl/Gf5B4CsGrNWnOUp/7CjL5PS62p8i3LAPJb9xkyExO+iwF/UlA6fVcXRoIzm7aidj5su0F7YI+hws+dfROseDqHbvIvylT/T3JU3wNfrRsY5x7kx6P6nrvJJhUdtRMVWOm1lLPf8gc/v09Jm4+AE3LtySY8RooZ6Mg3Hotz3J6Y410U4YY1amHwSVPRdfAUTWc82RakJ+HYKAuveyRiohu4bw51PODp6Qcvj0sv2aJJb/jARhHd2U7u2sFlhoJFa9tNYFhZb8Zwiq2MIqtOTXp+5dP0JhlPW+WIbc55gOHwFVTukAja28ROuFTw1hONplWqXAC1KI9ce7UqwwXQ0f+7OYH5mKcpmUa9wJI0s3q0/dvT5x7b/y0pbdIgvQTp3HXZvaU2TBtNg x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1599.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(39850400004)(136003)(346002)(376002)(54906003)(110136005)(52536014)(8936002)(41300700001)(5660300002)(122000001)(4326008)(478600001)(316002)(64756008)(66446008)(76116006)(66946007)(66476007)(8676002)(71200400001)(66556008)(6506007)(40140700001)(26005)(33656002)(7696005)(55236004)(2906002)(53546011)(9686003)(83380400001)(86362001)(38100700002)(38070700005)(55016003)(186003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R0e/QanZkWJGwaZ+MOf+2S2Ntx7rlg8d03bHYcngZVrlHctl0Nrkt8UjucHe?= =?us-ascii?Q?pNs6cBBIQrjT3xEr+ujjYtSWcFw6D8iLLYZVH/jc99fp9VTKcovolFr05IWW?= =?us-ascii?Q?QwbcT6Xk20IGa7KLO3XpJZGO2T2p99Zyymlm0aGvz094VyPVl9Ft19i3yQsa?= =?us-ascii?Q?8SMANOktzBnvJbpkGPLvJFhLzsfXwwX+rZNX9xxltsQMrI//PV1BOFik3zoZ?= =?us-ascii?Q?054ExgiCjhyBb8wYee9hmTp2UPolQ5xDgkC+pw07E6KnvS7vQln4PEhhDioY?= =?us-ascii?Q?j/qu4twoRQilv5YSuDjQm1Bh2qgviHVjec6W7F1sB+D059X5AQzCSwmKt3Ro?= =?us-ascii?Q?q6EJOvgfs/lRe49ym38AqlWObeYWZiZ8vodk5lz+eLXhrc9UllcJ5K8e1VwK?= =?us-ascii?Q?35djmd3Qp2hH+E68bk4qw1/Znfq+q/b31dqnj1KPGCB3uv3aN4wWsU008Ml8?= =?us-ascii?Q?kYBdjIXcPfN0G0JRQOsR5HoVfkCT5tBQclo4S0tBEllWYgswfu5maOYtfEue?= =?us-ascii?Q?SVH20rN7QNhUxZPi6ZyBhorTMXAEmEROivp7xQrEm1+Exeok7VaNie0j7nMr?= =?us-ascii?Q?nf7nV5uKOe/xGJa8AdTCdLTa7O84V5hmlLvH8jmAXIDW+7RzDpsMelYPJ563?= =?us-ascii?Q?BCiAJns5SYtDAdl4LUKKclTkJrjw0Jk3XK8GUaesThMoSJGuJnMiIR0lkID4?= =?us-ascii?Q?OvgvdX1FlpQRrwLF4n7OylZmlPhL2vFUTZBqetRA+2aLGGCzo7K0nf4Y2/ua?= =?us-ascii?Q?oRkgi4Y7y9JTgm+ZtOX1IWGrXP8HTMmmYF8kDnvGIfGNUntfqH90jvuuOdt0?= =?us-ascii?Q?E5j8yosh4ANoKO3OQaQaZVi1QUdgIil32SzSogBF23wjwgaoAOZiNxilocpi?= =?us-ascii?Q?8pPGpYU3j4HeG01WIj9hngRyL3bHUBq147JVtQ/hl2434zpf4c7NPLoxGY1Q?= =?us-ascii?Q?O0akEHXKziGknt2KRfkgn7aLY4/JnLjU1Cp8xGy255QI7hKbPJIFF0qtgvi/?= =?us-ascii?Q?eskfbCNmEWTDx9z1sbBoe1SwcD4mN5OeFOYMEgiEvwAaIAmtdKwDm3FXDRIb?= =?us-ascii?Q?kaHyDgx8nYmI0xV68rnuMDhQltaHu2NPh73kyn2HERv+y3Z1acuQ86sXqHCo?= =?us-ascii?Q?l4NBgEjY+v8MZBXg1Py9Jk9cUFYilp5rkpPGMSvRUS+mqMtSPAZKTHqmBoCn?= =?us-ascii?Q?wVMU1BKnzWt/DFuvrSZuvlISGuzyU2tpjN3yosImkWgBsQMdGSOVULYhAOE7?= =?us-ascii?Q?xsfILtIDr1drLJz0RoEatxv8tpgEgvDCpSgQSs46HYOyMgIQO1Al5pnGCQI1?= =?us-ascii?Q?gsr1lKvGB7bCDCfGaH/JQKU69MZ1Rh64VNKVO20XLg+LAJ3cqDtyzX8OhExx?= =?us-ascii?Q?Fw55s5Vr8n0mPzHK6qjL3PD38hXwi2dY2vacRMvfzoIUhJKpNE48OcWP4Cuf?= =?us-ascii?Q?0Ju7jG6QY1xfJACxgFtwhsElOlrMBEriNZpzA1Rx662xtSNbxobbbmmrIQKe?= =?us-ascii?Q?4WXqWjGKPNB1Gml8R7t03l4IYTQkqdsocCAr31U4QaL7olQ1bQakff7gdFQZ?= =?us-ascii?Q?357MMj0vQjMkRAFhDfk=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1599.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3953c5ec-58a0-4f37-60aa-08da87189686 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 04:08:10.0387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QoQ5Qxptd/kFIPH5ZOWhPHPRef7LcAuGznJwuMi7vh80qoDcD4XFbEiEYbu/MZW4rSjpdsCSngSPnlxi22DNIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4798 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gaoliming Regarding Bugzilla Bug 3755, I have sent the patch to devel@edk2.groups.io = and you have updated that you have received the patch. But the changes are = not merged into EDK2 source. The sent patch is in the below mail thread. Kindly let us know the status of Bug 3755. Thanks, Prakash K -----Original Message----- From: Prakash K Sent: Wednesday, December 29, 2021 5:37 PM To: devel@edk2.groups.io; Prakash K Cc: Vasudevan Sambandan ; Sundaresan S ; Gayathri Thunuguntla Subject: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted man= ner In smbiosview command, modified the below SMBIOS Type38 fields to display i= n formatted manner 1. Base Address 2. IPMI Specification Version 3. NV Stor= age Device Address 4. I2C Slave Address Signed-off-by: Prakash K --- .../SmbiosView/PrintInfo.c | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintIn= fo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index b144600a25..0a8dd4afba 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -1158,10 +1158,22 @@ SmbiosPrintStructure ( // case 38: DisplayIPMIDIBMCInterfaceType (Struct->Type38->InterfaceType, Option= ); - PRINT_STRUCT_VALUE_H (Struct, Type38, IPMISpecificationRevision); - PRINT_STRUCT_VALUE_H (Struct, Type38, I2CSlaveAddress); - PRINT_STRUCT_VALUE_H (Struct, Type38, NVStorageDeviceAddress); - PRINT_STRUCT_VALUE_LH (Struct, Type38, BaseAddress); + ShellPrintEx(-1,-1,L"IPMISpecificationRevision: %d.%d\n", + Struct->Type38->IPMISpecificationRevision >> 4, + + Struct->Type38->IPMISpecificationRevision & 0x0F); + + ShellPrintEx(-1, -1,L"I2CSlaveAddress: 0x%x\n",Struct-> + Type38->I2CSlaveAddress >>1); + + if (Struct->Type38->NVStorageDeviceAddress =3D=3D 0xFF) { + ShellPrintEx(-1,-1,L"NVStorageDevice: Not Present\n"); + } else { + PRINT_STRUCT_VALUE_H (Struct, Type38, NVStorageDeviceAddress); + } + + if (Struct->Type38->InterfaceType =3D=3D + IPMIDeviceInfoInterfaceTypeSSIF) { + ShellPrintEx(-1, -1,L"BaseAddress: 0x%x\n",Struct-> Type38-> + BaseAddress >>1); + } else { + PRINT_STRUCT_VALUE_LH (Struct, Type38, BaseAddress); + } break; // -- 2.18.0.windows.1 This e-mail is intended for the use of the addressee only and may contain p= rivileged, confidential, or proprietary information that is exempt from dis= closure under law. If you have received this message in error, please infor= m us promptly by reply e-mail, then delete the e-mail and destroy any print= ed copy. Thank you. -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .