From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.922.1583208253739219324 for ; Mon, 02 Mar 2020 20:04:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=OTCyUGfF; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: miki.shindo@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 20:04:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,510,1574150400"; d="scan'208";a="319325415" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga001.jf.intel.com with ESMTP; 02 Mar 2020 20:04:13 -0800 Received: from orsmsx115.amr.corp.intel.com (10.22.240.11) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Mar 2020 20:04:12 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX115.amr.corp.intel.com (10.22.240.11) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Mar 2020 20:04:12 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Mar 2020 20:04:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dI780dl2rCkrI+S/GpojRzMzNHaoKiXkDQVRb/qBzw/B2ai+K58yfHCrJT0oLVOJEjtJsiZqssBT/5uPEzvvYUkvSOESxMlkjYxNnWtnfRWrNBTPi7Iotxk0yCfYCnB2L5qU4xgDQD3EZWn/pgzI9XVi43AbiQE0zXWdBf22DDvfiy18voY+baNpL449naESQTDRFckwNWNOotj+xY9a2C57mPviGZXDSNDk2GeBhN0a3Obc3KadtF4hXjObisEALZD15knCfh3+314+IXzP7Jdo6ICLOxxArzAV+yEjZzy+26I7Yf5i2NeCgGc3XJ23fi7X+Kd6A+S7n1yp3QHGdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TBuumQFzZNBdg1mLpvOEemeoua7ipbfE3YU+RQwMFGY=; b=FGEar6AdwnWGSahsoCoZqZaJPCn7i5fHFIa0Hiy3u6o7FS/7vVNX2b9izezSQnePbHExCRZuYv6NgtLvEjciVaDxscLirAMG3tUCOLO5KfO9sHKnGzYpI6F+NYxqju34Nex9o+5qzBvJBSV33AinZmNhYN8KglkknjDUrNwpLUR2QU3XBKQR37ONrIp1YWQqRGTpG1GwLa/hecx10vNTAHYHB8aBaCLZKft9Pr+dInH6RbvfmnTqkg5tdGoXaf04A94M4bSlCdC4cYDeGU2OqSEgD8HWhtG4MQqOpOcBBZh8veAELh1v2WfQy5qdjWNuIIS3/2EZc3Gn3MVtOXimBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TBuumQFzZNBdg1mLpvOEemeoua7ipbfE3YU+RQwMFGY=; b=OTCyUGfFlGVvtySFUh8zvQgrJRogQgXREX79ag5ikzwnvjdFXO1p1+41OgGRSl6ICWyNW9Sd7O8sYH9N5CTdzW1p33dFnIUMWaFond3vJTtUcFdLyqoAMdHpMiN4ogp7qQypxNcjzyshjUaYWW4WqJVE6gpG6SR10QwfQz6ZkMc= Received: from MWHPR1101MB2159.namprd11.prod.outlook.com (2603:10b6:301:53::7) by MWHPR1101MB2302.namprd11.prod.outlook.com (2603:10b6:301:5a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15; Tue, 3 Mar 2020 04:04:10 +0000 Received: from MWHPR1101MB2159.namprd11.prod.outlook.com ([fe80::ad79:4254:9440:cdf1]) by MWHPR1101MB2159.namprd11.prod.outlook.com ([fe80::ad79:4254:9440:cdf1%4]) with mapi id 15.20.2772.019; Tue, 3 Mar 2020 04:04:10 +0000 From: "Miki Shindo" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Agyeman, Prince" , "Shindo, Miki" Subject: Re: [edk2-platform:PATCH v2] MinPlatformPkg/PeiReportFvLib: Remove redundant Fsp Fv installation Thread-Topic: [edk2-platform:PATCH v2] MinPlatformPkg/PeiReportFvLib: Remove redundant Fsp Fv installation Thread-Index: AQHV8P7ncpLKKN5JoEe1K71KJfGXMKg2PWVggAACBPA= Date: Tue, 3 Mar 2020 04:04:10 +0000 Message-ID: References: <20200303014945.25312-1-miki.shindo@intel.com> <3C3EFB470A303B4AB093197B6777CCEC506B1093@PGSMSX111.gar.corp.intel.com> In-Reply-To: <3C3EFB470A303B4AB093197B6777CCEC506B1093@PGSMSX111.gar.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=miki.shindo@intel.com; x-originating-ip: [134.134.136.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b291b4e-2c51-4939-a7ae-08d7bf27ed72 x-ms-traffictypediagnostic: MWHPR1101MB2302: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-forefront-prvs: 03319F6FEF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(136003)(39860400002)(396003)(376002)(346002)(366004)(189003)(199004)(26005)(66446008)(76116006)(66476007)(8936002)(66946007)(81156014)(2906002)(81166006)(8676002)(64756008)(66556008)(966005)(186003)(478600001)(19627235002)(5660300002)(52536014)(71200400001)(86362001)(33656002)(9686003)(107886003)(55016002)(110136005)(54906003)(316002)(53546011)(6506007)(4326008)(7696005);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR1101MB2302;H:MWHPR1101MB2159.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yiVGM3TfMXzosLK6uYwIJXeltSeKv2/4REjTDfe4/XyvcCjoccYAG36qvEKhJZMaLWQrKSQlTnmyx+cVOCEzPTy6bOlZJWiBzQvOuGIhWLxpbBnWTZ1ldohBDjPAD7qHWa/e8R+/2HqfX57V/mvDRz/wngRzkCfVNF9qMllzqEhioDr5YyIqPO46DiJEJxK/ENckCC183f6N9QBPmzcUJW68TPx1d/LJDYyiOE5Kk2ZbJFauSabkwuDDniEiJ7p9TojTuw/vt3AkypPIfh0ZAuJw2U1GmWyBN5w0fs8V+TASoJMyrsAk5x1OcQD4c+oSs1QOtu4jQ6UjnpWbtP36weOKgDf5TRSKSc9JPkLZXHIskIlPJeJyJaIIgh04qqBbNoDzNmCQcofVsHC500CeTHln6QZJxEIVn67LDzn5dI7Vo3baLvcQqHTFfdidbMDtsCxap1Ab7HXo16+XQMEYzHbV7Cs5KETGhKRrrPiyqyQVxOGpYRyrsWarNldi/vXukfblO6VXdeEB4wCFrdHIeA== x-ms-exchange-antispam-messagedata: /yta+JTuelqeOfm7t/2ZGBOnkS/IvIawzYRyoxckluGv21vJCbQGRBsmTyVy+8vceTqLU164AXTeOgnRlRsasXNBowFnx3AOh0nlg9N5BoK8Yz0MhY8KAM3DAG/tfmjb4bQB7oubM7zDyR4z+VxurQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5b291b4e-2c51-4939-a7ae-08d7bf27ed72 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2020 04:04:10.3099 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F7tyrqyKT8YuJn7tRWiKEAOEXPMA5Ct1z4fppQMTflh2Iy6/QFFuW7yg7btU2j1YysosFYu7j7tBKmN2zKks5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2302 Return-Path: miki.shindo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the feedback. I will send V3 patch.=20 I also make that correction in closed source.=20 -----Original Message----- From: Chiu, Chasel =20 Sent: Monday, March 2, 2020 7:59 PM To: Shindo, Miki ; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathani= el L ; Agyeman, Prince Subject: RE: [edk2-platform:PATCH v2] MinPlatformPkg/PeiReportFvLib: Remove= redundant Fsp Fv installation Hi Shindo, Please see my comments below inline. With that updated: Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: Shindo, Miki > Sent: Tuesday, March 3, 2020 9:50 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel=20 > ; Desimone, Nathaniel L=20 > ; Agyeman, Prince=20 > > Subject: [edk2-platform:PATCH v2] MinPlatformPkg/PeiReportFvLib:=20 > Remove redundant Fsp Fv installation >=20 > REF : https://bugzilla.tianocore.org/show_bug.cgi?id=3D2542 >=20 > ReportPreMemFv () has redundant calls to install Fsp FVs. > FSP-M, S, U FVs do not need to be installed when Fsp Wrapper Boot Mode=20 > is disabled. >=20 > Signed-off-by: Miki Shindo > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Prince Agyeman > --- >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRepo= rt > FvLib.c | 38 +++++++------------------------------- >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiR > eport > FvLib.inf | 6 ------ > 2 files changed, 7 insertions(+), 37 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/Pe > iRep > ortFvLib.c > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/Pe > iRep > ortFvLib.c > index 6158fc9412..1fad384cd6 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/Pe > iRep > ortFvLib.c > +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLi > +++ b/ > +++ PeiReportFvLib.c > @@ -20,17 +20,9 @@ ReportPreMemFv ( > VOID > ) > { > - if (!PcdGetBool(PcdFspWrapperBootMode)) { > - DEBUG ((DEBUG_INFO, "Install FlashFvFspM - 0x%x, 0x%x\n", PcdGet32 > (PcdFlashFvFspMBase), PcdGet32 (PcdFlashFvFspMSize))); > - PeiServicesInstallFvInfo2Ppi ( > - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 > (PcdFlashFvFspMBase))->FileSystemGuid), > - (VOID *) (UINTN) PcdGet32 (PcdFlashFvFspMBase), > - PcdGet32 (PcdFlashFvFspMSize), > - NULL, > - NULL, > - 0 > - ); > - } > + /// > + /// Note : FSP FVs except FSP-T FV are installed in=20 > + IntelFsp2Wrapper Pkg or > FspPkg in Dispatch mode. > + /// In Dispatch mode FSP FVs will be installed by IntelFsp2WrapperPkg, not FspP= kg, please correct comments for PostMem phase too. > if (PcdGetBool(PcdFspWrapperBootMode)) { > DEBUG ((DEBUG_INFO, "Install FlashFvFspT - 0x%x, 0x%x\n",=20 > PcdGet32 (PcdFlashFvFspTBase), PcdGet32 (PcdFlashFvFspTSize))); > PeiServicesInstallFvInfo2Ppi ( > @@ -80,6 +72,10 @@ ReportPostMemFv ( > Status =3D PeiServicesGetBootMode (&BootMode); > ASSERT_EFI_ERROR (Status); >=20 > + /// > + /// Note : FSP FVs except FSP-T FV are installed in=20 > + IntelFsp2Wrapper Pkg or > FspPkg in Dispatch mode. > + /// > + > /// > /// Build HOB for DXE > /// > @@ -97,26 +93,6 @@ ReportPostMemFv ( > NULL, > 0 > ); > - if (!PcdGetBool(PcdFspWrapperBootMode)) { > - DEBUG ((DEBUG_INFO, "Install FlashFvFspS - 0x%x, 0x%x\n", > PcdGet32 (PcdFlashFvFspSBase), PcdGet32 (PcdFlashFvFspSSize))); > - PeiServicesInstallFvInfo2Ppi ( > - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 > (PcdFlashFvFspSBase))->FileSystemGuid), > - (VOID *) (UINTN) PcdGet32 (PcdFlashFvFspSBase), > - PcdGet32 (PcdFlashFvFspSSize), > - NULL, > - NULL, > - 0 > - ); > - DEBUG ((DEBUG_INFO, "Install FlashFvFspU - 0x%x, 0x%x\n", > PcdGet32 (PcdFlashFvFspUBase), PcdGet32 (PcdFlashFvFspUSize))); > - PeiServicesInstallFvInfo2Ppi ( > - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 > (PcdFlashFvFspUBase))->FileSystemGuid), > - (VOID *) (UINTN) PcdGet32 (PcdFlashFvFspUBase), > - PcdGet32 (PcdFlashFvFspUSize), > - NULL, > - NULL, > - 0 > - ); > - } > DEBUG ((DEBUG_INFO, "Install FlashFvUefiBoot - 0x%x, 0x%x\n", > PcdGet32 (PcdFlashFvUefiBootBase), PcdGet32 (PcdFlashFvUefiBootSize))); > PeiServicesInstallFvInfo2Ppi ( > &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32=20 > (PcdFlashFvUefiBootBase))->FileSystemGuid), > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/Pe > iRep > ortFvLib.inf > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/Pe > iRep > ortFvLib.inf > index 79cd5ee1f7..4258d0f2e7 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/Pe > iRep > ortFvLib.inf > +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLi > +++ b/ > +++ PeiReportFvLib.inf > @@ -34,14 +34,8 @@ > gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMBase > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTBase > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSBase > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspUBase > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspUSize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemoryBase > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootBase > ## CONSUMES > -- > 2.16.2.windows.1