From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.1179.1628205282182684821 for ; Thu, 05 Aug 2021 16:14:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=cXFFndCk; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="299861704" X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="299861704" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 16:14:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="419998729" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 05 Aug 2021 16:14:40 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 16:14:39 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 5 Aug 2021 16:14:39 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 16:14:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WfFwLNwA7cW4dwcPGCu633hSb60aT6RVou8AEWF58n6IlXrO9unFoPd+Lit9Lriex72OX3W/8GjHQpVNSUXn86v3rhdQmFhzqzVTLU7jmhUOaqw6qls1Y5u9HnyjikJ3MM6YPivw2U+EzANL4ZOLPjv4C+1AcY5Tfw5+v8VMuNTqUkGgnnKgfPCwrln8UpmDHY4wVcE2PsbFCiCNG+XFLUeJYEoU3XwX4u8hvz142a5qc9qvTLFwmWJPy6gjZXRPFBa3rYJLZ3gxBCIgzkJatzaYvTSVKiu5BMrkTdymDCaspd9iIi5hNktf4V5yJ9NiKRWHrNhqsm/T3zSz/rbhCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zoW2GEBjPSdjvpYo+yL5vhuIcHzPREtOuFhQ+efD9/o=; b=BnaD38Lll0vrGsyHVlkC0H8QhHsRAHULktuoNbWsA3fyBfRBlqRQKRgVvgg7pPzHAk8+lEYdoxgyt7yfRUpTqxtFU4J06f3cCbxNZbV1ebnxXHsdsk3fy4+eMj+/EYKkI57y9vCRcmF/sNT+FVzY1JyJ6Xkf7GwlsWrNUtxunaZgkNvmBUL9Pp/hWmGYcVAQnUA1MbKAAYdzClk3HcEyPuiGdR+BbWVqjk2+2bz7pZVTvMT4Ts+mVvN/2XSZlnY3Vh6ovBfh2FKrpBRtVDpX3KTBvrW2XJDwVp/mxIASi9uFiELIHWb6jilbvlIod6stEeQYp2v51yP/R6QJWv5Nyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zoW2GEBjPSdjvpYo+yL5vhuIcHzPREtOuFhQ+efD9/o=; b=cXFFndCk0+kp17TJmV3kcjSabD0Husj8vnTSmZFWn4SUSiROID5vu1h7EIexvejhHxRY/ndDZCqi3ZHZOM+3AIBJoXtgEOlN2qdG/xkmddm/QS93j8XQOCVCyobCTkAK4OX+9lxLfVVdyz+ueubUMBl5YEMFctBcpSZE0xGPN4M= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1725.namprd11.prod.outlook.com (2603:10b6:300:2a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16; Thu, 5 Aug 2021 23:14:39 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4394.017; Thu, 5 Aug 2021 23:14:39 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-platforms][PATCH v1 2/5] MinPlatformPkg/TestPointCheckLib: Set required size field in protocol Thread-Topic: [edk2-platforms][PATCH v1 2/5] MinPlatformPkg/TestPointCheckLib: Set required size field in protocol Thread-Index: AQHXigpJDa2icU4s+EqskPQbMB3fuatliZTg Date: Thu, 5 Aug 2021 23:14:38 +0000 Message-ID: References: <20210805145706.2470-1-mikuback@linux.microsoft.com> <20210805145706.2470-3-mikuback@linux.microsoft.com> In-Reply-To: <20210805145706.2470-3-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ff670c8-53f5-45c9-21b9-08d95866cc7d x-ms-traffictypediagnostic: MWHPR11MB1725: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SdILgFu0SfZp/NtPYpQgjppJqu7HZ9uPo3CI4nCK25yGtmhiSSO2dN+xGYRqEg3/kHt6/LSpon46AQumkT41ZZku0E0clC/EA8typbKY6cAhFx6zKYj0mHqn2oMUxJftQs3D8dwducH9XOZDIt9p51P5qzgkG++XMR4LDcrRzkAXmOv5KyjSn+EhPpsA5lwkADSHSE16HjcuApgAqZnnqOVn/c06ZMM4C5zsigvArWc+BtNBczKlB4cnp6QQGoLjR0W89WPwlY6x47bz5BgZYKCC0aNuJivU2jIjucNf7F4YDp8i3KrvrPfVLnAJrTkTl/IwxLz58bY0QlrWJjGFsITkvjyqcQN3opSTOJqKqOPojQaSiQtVuC/6kDr7gG8+TuHQHwvh15KQ64zeGuIrSqJSqyNilX/C6SSF5EqHzg+hYNVEkMuTDT+VBcXLwxOEDjcxfXxqesaHdX02luuuEK2VL+iLMnduOfOuB94PZEwd31mfSU9tR0/vAOO9aZN+NKrtNRb4+qLn9me8rCT+1h9cPNXsQ5/f0VfnWA0L4c6FqH3NQQ3U4GCk0TMD/3NMPwD8t0Qjg02kLvap7kNdemhm6Ls6vWqh9jJzM3rtGExIytDrkw/obgGuJGp7sduakjwTeNZ+n54snZoXcCsipkNBDWlSM2A8Lewlv8NELKnizzlcOE2ikW8FUjl5L4R00b/2covGLAU5CEVzex4bu/4d+yTw8qBjuN7G5lN98IfuLV6FKX4c/FQ5qQL3dgNs9fRBWIM4vijSMbdNCyAjy3JcQBBeVyOh8EpxemaEML4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(508600001)(9686003)(186003)(26005)(316002)(7696005)(53546011)(110136005)(55016002)(2906002)(64756008)(8676002)(71200400001)(6506007)(5660300002)(66446008)(54906003)(8936002)(66476007)(66556008)(33656002)(38070700005)(4326008)(122000001)(107886003)(76116006)(83380400001)(52536014)(66946007)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GjgIKociiQFvnoVaiycJjeukWIKsfbG72sCfqA25sXnbcDvmDcPLk1ePQfi+?= =?us-ascii?Q?dUh0C5HMhzGElWlAGQNyE5HgChORXQxU8Oi9T5v1ZEH+GVOBe2mSpfUSduDZ?= =?us-ascii?Q?bUG5+uwwz6xnvQwilgiBeNaZdAH5TcE27co6X3eC/BzXcGrcVN1r7My2kB2n?= =?us-ascii?Q?+Oh1xE6KfeSZbEakXIiJURXNpRGN0/KPmbj/0lyTKQmaCRJ9O28umYSfdTJk?= =?us-ascii?Q?NrzVOgoqaHaqsuBQGgfuEyqb16JLfZVONsp3eWbmPNqXJzeiYgz2YgAOo8YI?= =?us-ascii?Q?UI1vzzufOnhhvJdkVAQ2AuCytaEgJ1kaNt4vKTGLv4V0uC8g6oranW+Z+m3e?= =?us-ascii?Q?Q9aK1nGwQf76PYoAEaCZUnNL4e9sWzymCuiU83QLB8Uoo3U3wTCu8kes/CAn?= =?us-ascii?Q?TbRjcObM+C9VMzou4NAS/tCQHiK/zQ/aW0fV3VtCP4qgDnHYv5RTmhGkPIMd?= =?us-ascii?Q?NevCYzkRxt2Ya4mFOjhArCSu9TLJpS5THi551+BJEs/9x1T3Zor0kxhFO32d?= =?us-ascii?Q?40QEfIXcyCVFEfUNHPK2bP0tNZaXKQ1qhTK5eZYzgqHI62FEgu2EhPdta13F?= =?us-ascii?Q?B8gYhaWT7qy3nLIOToEoDjoLqevg5+cTSFk6Th3/v+e5kcoB49dmzUXEeWCH?= =?us-ascii?Q?RYYcvNetWfrMLxMiPD0+CdFlDKsGlbMTKmb6fumoMEvy+nC2V7HybXCqKI9s?= =?us-ascii?Q?SGZ70imzjfYqTDmdfr/9vrO3ZbHdaN4TWdK6JRdoPvs/nsbit0WbtAFug84E?= =?us-ascii?Q?xjDSKzZvdb+NztvOw48sEqwDAzh5n7b3Lh+FAhFaZ2KO1YCS0QJs1HTwPwAD?= =?us-ascii?Q?JJG2Lxnzw7sR1wZf0q3ifwL7P043kf4pNZHetVGF7QqXrzRhd9qqggUOn0kW?= =?us-ascii?Q?+yDzhNt0zAtXOz0zotl1YM4YR6vw8HtWcOOn+vAeOYOA8xGVg3veJhYU16WK?= =?us-ascii?Q?ny1rQwA0i4DU/NUan4GnTlitL0lxQ8+w+6seR7S1zbAXvy9AWbv1x96vOpT1?= =?us-ascii?Q?ZKOuXQtXJluVz1LwMfxChS93fZaegZQomt+kK6QzlqoNKLb3gw+O9yco4Pir?= =?us-ascii?Q?LHIYw4GTMEgCssgqH6ggyY42QHvIgTTK2IXIqKYn/vDyttC/EXRKNo0gbJtv?= =?us-ascii?Q?pn7wrat4ZRAaIMEtVywFNZyGMQBawTQBH/hWXILpLVMf9cQu4owwHjmBZJeE?= =?us-ascii?Q?5EuTDYCVUWMf9v7fBZYd5Xzf35WbPBxUjfSEKSLwsa4dacnAauRBM9AdYlEf?= =?us-ascii?Q?prJ625WG9AljICDAwFK3KR8Dwi+fsyI0AAPIv9g5kgM3CP9XD3AZR4uXE8o3?= =?us-ascii?Q?H7fiLasJYHMacqJ3Vfexhv+W?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ff670c8-53f5-45c9-21b9-08d95866cc7d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 23:14:38.8947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wILRPKvy6/bgIGIpxEstSrM++CgvFP+WqWMRlIywEiWmMXA/4BMRqIimMZjbbJ48UURu/RPZ1IE9j6MQVM7s2S4ejtDSrBPEt7W3NWhiKtg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1725 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Comments are inline. Thanks, Nate > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Thursday, August 5, 2021 7:57 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1 2/5] > MinPlatformPkg/TestPointCheckLib: Set required size field in protocol >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3518 >=20 > Per the protocol definition, the caller must allocate the input structure= and > set the size field. TestPointCheckTcgTrustedBoot() does not do this which > can result in an EFI_BUFFER_TOO_SMALL error. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckTc > gTrustedBoot.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > TcgTrustedBoot.c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > TcgTrustedBoot.c > index 2a04f86fedac..7a8e3fed22f9 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > TcgTrustedBoot.c > +++ > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh > +++ eckTcgTrustedBoot.c > @@ -41,6 +41,7 @@ TestPointCheckTcgTrustedBoot ( > goto Done; > } >=20 > + ProtocolCapability.Size =3D (UINT8) sizeof (ProtocolCapability); I think we should also have a ZeroMem ((VOID *) &ProtocolCapability, sizeof= (ProtocolCapability)) before setting the size. > Status =3D Tcg2->GetCapability (Tcg2, &ProtocolCapability); > if (EFI_ERROR(Status)) { > DEBUG ((DEBUG_ERROR, "Tcg2->GetCapability - %r\n", Status)); > -- > 2.28.0.windows.1