From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.3948.1591821194955620176 for ; Wed, 10 Jun 2020 13:33:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=WmVWQb1n; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: oBEER+/8XoXXAyWNYAbGqxyaPSJXXm6DbUA/8RcssojvQsJbKWUdmygHCwcqhLY3YJxClc6oIV WrNe+X2V5hYg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2020 13:33:13 -0700 IronPort-SDR: Dfy2J54kePGahYJe4MvESkf9k4VbUAZQilsq/lwYuRgq6MyPjIH1g4iNbjJh0cEnAQHnGMJf1i M7/tXEQsnBzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,497,1583222400"; d="scan'208";a="306719092" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga008.jf.intel.com with ESMTP; 10 Jun 2020 13:33:13 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 13:33:13 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX152.amr.corp.intel.com (10.22.226.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 13:33:13 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 13:33:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c1Nidi3zd/NkK8ZJGV92r98c+hd0NVUM44Ug1PEzN4pM7n6jgDrCnVUFo++rhu1eGxCVuvNLLNoypgnCBnmZk/+khSvFkAMNBpBPNcjWYhsz11pxpogloFmVRIwhv3aS2QmbfH7RxgmOWFq2fFIb5zX/xfwCz2bWhdbf2ocIXqg5FbbyT5NGGIMyuwpmVcmr7/I63x/dGwefEZNRca+4UlTbgf+LaXJMelk22KO/kfKyHwCZKN/e7ge0w/3FW2pimHKdGBrAkY1cVgmSgCi+MmmImVriU6bHpAqe+F2bGeAQ0ecb0v3iNa73tw6+gvKJ4bQ2NKGYufnqDYajSRbNSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H0f+F9DJpHMJeGEvu54d8g+8PsyoxKWi0yyPVfWeOow=; b=DHwleWyURANrdjlU7OB6zcjerlhHlj3RECaOyC/14X/nJ5ZzbdaH0XTpQbsZrJQfUKhd0T3T705KDZgJ+Gjnp3HEpdLGUH9WSxpjc8gIukA4YDXDU825dFNUBQhtX/VZ/oTaaw2Mfz/mAafiOT8X/WkDWFU5zqd1q17bxoy8umjrwYtU4UjnytZdKVmQd9jNl8IQ4TOVqv5K1C2HnQFzm1jHk4CW69P8+rSZ5ZPpLHajifH5K2abH/IM2KRZlfk1m+EHmmI4i+X4CC8o4fe3qBXF5FXU6fOMZfBFyPE2vIMPNfSNnVeqziL07ED0LNTYhz+KO97lUwZY4PpPeQDS0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H0f+F9DJpHMJeGEvu54d8g+8PsyoxKWi0yyPVfWeOow=; b=WmVWQb1nAvYMaVB7BXO2K9kM6By6ZNFEns2pFXk5m3OVzR3ZOptl15kUbEddtIXb6ylbsWYhIuZxQooGe9BsXqVzl5TpciWwlzsOUqoG9SsOEo+dX3fK+YjH/+4zv6NbvHcQTUdExTbYqZWoHAkEQwEpGpmEd3It4/nMSchT3Ks= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR1101MB2158.namprd11.prod.outlook.com (2603:10b6:301:59::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Wed, 10 Jun 2020 20:33:10 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::889c:c0bd:5262:7c80]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::889c:c0bd:5262:7c80%8]) with mapi id 15.20.3088.018; Wed, 10 Jun 2020 20:33:10 +0000 From: "Nate DeSimone" To: "Tan, Ming" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PCDs type Thread-Topic: [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PCDs type Thread-Index: AQHWPlCPT4qsw7sQO0uaug0TmnF6XqjSUBGw Date: Wed, 10 Jun 2020 20:33:10 +0000 Message-ID: References: <20200609112353.20824-1-ming.tan@intel.com> <20200609112353.20824-6-ming.tan@intel.com> In-Reply-To: <20200609112353.20824-6-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Q1NzkzMmYtYzcxOC00MGEwLWE2ODEtOTg3ZTUyYTQ5ZjY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSG1iUXlRbmZVSDUyNU4wd3JjTWlmTTVJYVBMRlRud215R1NRSURTWkZKYTFmUlVxUVYra2hYZDgzWUdPWkd1TyJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 36ca4e63-6b89-4f24-2aa5-08d80d7d7dfa x-ms-traffictypediagnostic: MWHPR1101MB2158: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-forefront-prvs: 0430FA5CB7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f8bdC4zZpXNsicNJ1u3XZlCr40UCf65lK+w6lVINEBExjL130vpSlanQOUswjwBiixSEdNP/SpNbCqYhuDPIhsqhUpFiIujrZd/7rVKG+j01g552vyh9aGm39wXOvwzJM4VvKGA0DCLu47TU2+PrI4mu4RiSE1grEaWrdTW5IBoEbN8NSmc15MbQW4bB1cBxiN9lxpF8RWCQbxK9V+chhB2g11R6wHzZaNqAmg28fmVw+yQNVvTp9Z3PUrabl0gdD+DivsZPXo4biic4vUbM1jCBIAqIEMm+tzHfXu7erul1tPaRDLNHzc5AlDklFGKKTw0Z156BzxShNuTspByvJlIoV2tAnSe+79wqKo7gowdS9cBDEN/S3G27qPe1qhelyWVo2FJg8OKl5vuD5hlD9w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(376002)(346002)(39860400002)(366004)(396003)(86362001)(53546011)(107886003)(4326008)(26005)(2906002)(33656002)(186003)(6506007)(8676002)(55016002)(7696005)(66556008)(66446008)(71200400001)(83380400001)(8936002)(76116006)(66946007)(478600001)(110136005)(9686003)(66476007)(64756008)(966005)(52536014)(316002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: tT8cjKqpioAt8LudHc3WU3JM5U2w1+ZKtkKY9BNRKjcaitAkraXDbHctygW6Nrvm/Y+u47Vz4OFnPaxSub5iTnwD0o18rn5PZE9ntJFof1OCXBEcqHXSvR+RG61WbKalIWOn0/h9yU6o9G2NFvsM/uB/FiugbFhZMFRrPmg9IdFCUe0hEAcZuE0RBEPCMH0KIbId/54a4Wc6doZW7Q9rZASCaoJoRkibD9Oq1NYI8UhyiPa9fl5ClPfcyQB6p9yUBuHcOVvUz5Wk+Gz5FN3dgo0WyG8KU4/7W+gE90urwbADmg1OI0M7sWeM5irc0QPYReQzOt8EKkbK9Ee6sUoghGI+OxmWzST5pw5tM7hB8tqNQTcvGksMO2LFJPacj22O42BIFNmAEE7JkiuZmHkqR5BgUVRYNGzxgmNCXurw7QghZPJumUZdv09rCuB0s16B94PENnKRkIcH20AJH7TQreBwC7kREFy2KsN8Uzzk18+meLrntviQKLIvRpuMdmQR MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 36ca4e63-6b89-4f24-2aa5-08d80d7d7dfa X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 20:33:10.7005 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l5WRb1vnQ9GXKGm0oaTjGLgliP1Ri/jm4VZT6WmwbcqbVKthtw0I5sPm3aUSsXwsFViWjfDNclT3S/aHB7uYOr3sYLDenx/gcaqV+QaFu7s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2158 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Tan, Ming =20 Sent: Tuesday, June 9, 2020 4:24 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PC= Ds type REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2791 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeM= odulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedA= tBuild in dsc files. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Ming Tan --- .../UpXtreme/OpenBoardPkgPcd.dsc | 13 +++++++------ .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 14 +++++++------- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPc= d.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc index af548dc81b..d797ae9d94 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.ds +++ c @@ -71,12 +71,6 @@ # Edk2 Configuration ###################################### gEfiMdeM= odulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSectionFirst|FALSE- gE= fiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE-!if $(TARGET) =3D= =3D RELEASE- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!= else- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE-!endif = gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE gUefiCpuPkgTok= enSpaceGuid.PcdCpuSmmProfileEnable|FALSE gEfiMdeModulePkgTokenSpaceGuid.P= cdInstallAcpiSdtProtocol|TRUE@@ -216,6 +210,13 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALSE g= EfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|TRUE + gEfiMdeModulePkgToke= nSpaceGuid.PcdStatusCodeUseMemory|FALSE+!if $(TARGET) =3D=3D RELEASE+ gEfi= MdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE+!else+ gEfiMdeModu= lePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE+!endif+ gPcAtChipsetPkgTo= kenSpaceGuid.PcdAcpiIoBarEnableMask|0x80 gPcAtChipsetPkgTokenSpaceGuid.Pc= dAcpiIoPciBarRegisterOffset|0x00 gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoP= ciBusNumber|0x0diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Whiskeyl= akeURvp/OpenBoardPkgPcd.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/Whiske= ylakeURvp/OpenBoardPkgPcd.dsc index b3dc1ef501..5d769e8153 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPc= d.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk +++ gPcd.dsc @@ -1,7 +1,7 @@ ## @file # PCD configuration build description file for the WhiskeylakeUR= vp board. #-# Copyright (c) 2019, Intel Corporation. All rights reserved.+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
= # # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -71,12 +71,6 @@ # Edk2 Configuration ###################################### gEfiMdeM= odulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSectionFirst|FALSE- gE= fiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE-!if $(TARGET) =3D= =3D RELEASE- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!= else- gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE-!endif = gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE gUefiCpuPkgTok= enSpaceGuid.PcdCpuSmmProfileEnable|FALSE gEfiMdeModulePkgTokenSpaceGuid.P= cdInstallAcpiSdtProtocol|TRUE@@ -203,6 +197,12 @@ !if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHa= rdwareFlowControl|FALSE !endif+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCo= deUseMemory|FALSE+!if $(TARGET) =3D=3D RELEASE+ gEfiMdeModulePkgTokenSpace= Guid.PcdStatusCodeUseSerial|FALSE+!else+ gEfiMdeModulePkgTokenSpaceGuid.Pc= dStatusCodeUseSerial|TRUE+!endif gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIo= BarEnableMask|0x80 gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoPciBarRegisterO= ffset|0x00--=20 2.24.0.windows.2