Re: [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Return exit codes in edkrepo_entry_point.py

["Nate DeSimone" <nathaniel.l.desimone@intel.com>]

The use of parenthesis is a little odd since "return" is a keyword not a function... but what you have is valid Python syntax and it won't become a tuple since there is no comma.

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Friday, August 21, 2020 12:59 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Return exit codes in edkrepo_entry_point.py

Return the error codes generated by edkrepo_cli that is called in main()

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
---
 edkrepo/edkrepo_entry_point.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/edkrepo/edkrepo_entry_point.py b/edkrepo/edkrepo_entry_point.py index c2ff56a..f759022 100644
--- a/edkrepo/edkrepo_entry_point.py
+++ b/edkrepo/edkrepo_entry_point.py
@@ -91,12 +91,12 @@ def main():
     try:         mod = importlib.import_module(pref_entry)         func = getattr(mod, pref_entry_func)-        func()+        return(func())     except Exception as e:         print('Unable to launch preferred entry point. Launching default entry point edkrepo.edkrepo_cli.py')         traceback.print_exc()         import edkrepo.edkrepo_cli-        edkrepo.edkrepo_cli.main()+        return(edkrepo.edkrepo_cli.main())  if __name__ == "__main__":     try:-- 
2.26.2.windows.1