From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.62188.1598903773040007812 for ; Mon, 31 Aug 2020 12:56:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=iYzV7tQe; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: s6N+TYY6wNCfQiSQAo4gM9jyPaDfhcwFFfbVd7papj+8nrEgn8Oqmdpyys/v3YS0W4k9fKLXxp 8vooC7FNy3Gg== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="144796295" X-IronPort-AV: E=Sophos;i="5.76,376,1592895600"; d="scan'208";a="144796295" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 12:56:10 -0700 IronPort-SDR: olxAYJSyirHAciDgXptXETIChwvbWXi2gDjKGOg2wZIdZgdqLDARibiHaMM1YZArnyfAsEYS5y xZgstPO/S7vg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,376,1592895600"; d="scan'208";a="297035718" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga003.jf.intel.com with ESMTP; 31 Aug 2020 12:56:10 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 31 Aug 2020 12:55:51 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 31 Aug 2020 12:55:51 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.56) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 31 Aug 2020 12:55:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GsoRiNggMCXyeSeAFacsnczo9mEi47hc3jWUm2MiNgbVH2Oy2RCdpFTdMmqIHJoll7d5r3iINHvRJC8MkgfcQE5rnVAZ83j5muOEa++O4RK8TTMQT+tlszOjoLBB6DhMjRPt99Anx5kxptv31fEoK3mTcLGx0Mg29gzUMV6yzoNjoS4dY0nwB4Vou4gxe7OyxwVPBSOa/7JN1cz9BhWBkMNcsjhGJcK5TweTvYWHcq6y8QERNZfm7+QgHY+wuuuqJIbCh0gx2SYtL9Vu6G3z+qHrvh6hu30Ff0omNl5J20pSebIiqItrxiT8IpFrTshbkx/bQtqRJNyniBrhklLWfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/nCUuIyBQC5p4sajVckYc8QceXLz/7Vw9f3y1yEFhic=; b=mLvc/99n7iDscPvGTuyzTrcWFCxhMdbhJxCnfKSK/p8P+pDedeZqFEXfnZ8G+8oXJlJZw/yIBOjRzCDD5LKrNhA/uMwRN3EIYudND0///ZfLG6bB0360W65H/Tc9hmrJ47MaXophzleSVuysAOG32RErz4QsaTxQrT33A0o0FqD03NuNfuYISlHfwJCrYPAXqu/awmT63cIDwUCA3/loBIcqAv8C4fICqfGyGd59gDkmNVRnfsd2Y9vCuIftFDQ+jazAnFCVYyYkPms/HFHHFBkTJO0k1yUkDQa86LmfiQeewVkoyXQO+X3zlLvChkokV7wYHH6DDboql/d6E608Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/nCUuIyBQC5p4sajVckYc8QceXLz/7Vw9f3y1yEFhic=; b=iYzV7tQerAgWLY6NAuWLf7Wnqy+5a9DC7gv7O2ghJUv1iSlXbdF9IjGRK9tlaI31IuxmPO0+YQIH3bBr3sCsxzWlXaqZb6bG4iX46eFYqsGCHXD3RmbtfIscHhr5Bjp3W8I36uEo12eV+yGIc2CMWfwmYqUIhR9WuBtXGR8YqZ8= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1757.namprd11.prod.outlook.com (2603:10b6:300:109::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.23; Mon, 31 Aug 2020 19:55:49 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::24df:561d:46a:d33a]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::24df:561d:46a:d33a%4]) with mapi id 15.20.3326.025; Mon, 31 Aug 2020 19:55:49 +0000 From: "Nate DeSimone" To: "Desimone, Ashley E" , "devel@edk2.groups.io" CC: "Pandya, Puja" , Bret Barkelew , "Agyeman, Prince" , "Bjorge, Erik C" Subject: Re: [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Return exit codes in edkrepo_entry_point.py Thread-Topic: [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Return exit codes in edkrepo_entry_point.py Thread-Index: AQHWd/WUAWqi9/sa902hhkzRMSwVzalSsR9w Date: Mon, 31 Aug 2020 19:55:49 +0000 Message-ID: References: <20200821195918.875-1-ashley.e.desimone@intel.com> In-Reply-To: <20200821195918.875-1-ashley.e.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTcyMGRjZWYtNmM3ZC00ZGEzLTg4OGMtNTE0NTI3OTBkNjYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTERLMk9IY0xCeTFkZnlvVkN3QmNuSjI1ZEpYRStaQW5aOWZCeVZ6NmtwcGhUM0NcL05iZG4yQm1IZlkyaWdTV2wifQ== dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 46526be4-2479-48b4-bd99-08d84de7dbf0 x-ms-traffictypediagnostic: MWHPR11MB1757: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uTp7gAaxkH0WuElifUiy4f1aMi/+HUTrWcaln4LcFKpNgq59OLYdWuagbYnMC0dGTSMmq1Y7Tfk5FTvt6jCOkU1TAqw3vjTjbuVk/VM3ms1h+MG4QU1HQVr9/Il3kWI75bXSS560FctlSM87TqWFV1yjdwQoxs10TxGUpLniwTWfhYdkgPMUZCc+y8VucStC05KoQda2rmVk49P1OTeXED9U57MotOKR6PJR7cQsi1g8nyc7K8nkQ2Uj3KXcPXEApoYiuFvLlmcErfDzuLtH4k1vp0Rh2d+HRD0CVFifSCQyupmRlhvCf0gtymJrqxk5K1GFQDCIJJjnHZ+W+5yymg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(64756008)(66556008)(83380400001)(54906003)(76116006)(26005)(5660300002)(110136005)(66476007)(86362001)(53546011)(107886003)(7696005)(6506007)(316002)(52536014)(66446008)(66946007)(33656002)(186003)(9686003)(478600001)(55016002)(8676002)(71200400001)(4326008)(8936002)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: A0DFTyU86RSoiEW/okbCCRieNheO4chw9WMKYrl4jWXutrIBnClr/Roc4S2csW196AWEwtvwOvQu+c7+tRSxyMpBvhu4uEHyGMhJYM8brtGDf3itDEp4mN4nQTwSY/rXDZ/LggkhJvgI82/e2qJ3kp3EZ0pkXDQM+74ON+ovOmLYYppAatohPrNOTKHWqjNB65FZKzDuOP8wZnAjjrNe5woRa2IGxmN8JS+Kl5Q2y4i7S1mqV1YQww4QypPIU9DcmPx/z10XMKjrz6RFUc4GersqW+2L9t9Eqc5x7PWxVbeVbLzm4e6cjKXwl32aWa33Wfq5wL9yCshTx4jJvSiF5XfjVh0Oj0pbQ8G0zmsoxgUqO4oUsRahqD7J+/Y1O023vDwPfX+9OOGH5ZF3f35nX/s3QV/oQmLYuPCFSAmAgUnybgY7ZuYExRJCgFV9zOtZIpjanPzkommsLjugAfiqMxR4t9r8F5SZ10IpOaUZsw03Xwzx84w1HjPmxg/8MWd5kp75jH/1fNj2avIM68q7VXoeYROC43atfmzpSUWlea4xJDErG0O7a5NeVvCI+aqM/inyLQJQhJaHccauEp21WaS3P6ACftDaArjxFnaZg3vv6wgS1VF1RN8p9F5oD/SnWcKm/isCVJ8HEe8pzsnrzw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46526be4-2479-48b4-bd99-08d84de7dbf0 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2020 19:55:49.5007 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WJUjlBgzO3NooYIn8K0rRG5CjqedjiA8b6c5gpQ6qz65HNHphsSnmUO7kaiEqL5mZIIazq7pC+3Kb9VJTsLeDoyqvFM2eG0qaFlPc9HR0/Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1757 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The use of parenthesis is a little odd since "return" is a keyword not a fu= nction... but what you have is valid Python syntax and it won't become a tu= ple since there is no comma. Reviewed-by: Nate DeSimone -----Original Message----- From: Desimone, Ashley E =20 Sent: Friday, August 21, 2020 12:59 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman= , Prince ; Bjorge, Erik C Subject: [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Return exit codes in ed= krepo_entry_point.py Return the error codes generated by edkrepo_cli that is called in main() Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Ashley E Desimone --- edkrepo/edkrepo_entry_point.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/edkrepo/edkrepo_entry_point.py b/edkrepo/edkrepo_entry_point.p= y index c2ff56a..f759022 100644 --- a/edkrepo/edkrepo_entry_point.py +++ b/edkrepo/edkrepo_entry_point.py @@ -91,12 +91,12 @@ def main(): try: mod =3D importlib.import_module(pref_entry) func = =3D getattr(mod, pref_entry_func)- func()+ return(func()) = except Exception as e: print('Unable to launch preferred entry poi= nt. Launching default entry point edkrepo.edkrepo_cli.py') tracebac= k.print_exc() import edkrepo.edkrepo_cli- edkrepo.edkrepo_cl= i.main()+ return(edkrepo.edkrepo_cli.main()) if __name__ =3D=3D "__= main__": try:--=20 2.26.2.windows.1