From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.33487.1628838235864856532 for ; Fri, 13 Aug 2021 00:03:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XtJdHT8V; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="215244832" X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="215244832" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 00:03:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="504121518" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga001.jf.intel.com with ESMTP; 13 Aug 2021 00:03:54 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 00:03:54 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 00:03:54 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 13 Aug 2021 00:03:54 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 13 Aug 2021 00:03:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m4bvqqYhoW0KVxxGdebmSho8cpB2MaoRTwsfG93kNYu0anXmgsofHJWk7MJAz8FMsPU7crm+sPhIuVlPAbS05OugbpIDCjrBvkRHQvZo8H/iM8p/n74quoDG2abaMDQ5W57pUA+up++edFPOMqBLPSuDHB18f44O7BYQUtV8eTWHB/s56DSYa3TVcHuo3ZRgPwgunxFkSk6Yepwd8S+csoYezGTEGxI4iFb41Mp2znkiVghS7JMi5O46R02lIywm1zGo3hKbIOS+i/F+wgIokbcUVoV+nqZflrxw1CdciqICFIDPvIS+bCxrJqsoH58Hp3hvt5S9djyzcnJNIsiNSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7G4zTzxFhb9s2R1xJJ+I++II6Ti8FrIpgXxDVajLHc0=; b=Es65ai57KM3bvDpqPJFZu+W8DJQydyZJhTfb/d7pXVCIeBDAzQFd+GFex+E5BuBhiBI8dLs9Si1Ewvgn44arKzaRpTAiOBUOEuu3MeQLMMMMNLtBHl2BKqba6s+RDcJsSobrOzVHYtwFXr4WB+VGThhAags1vTMNuR+K6d0zr2K7KqKuCo3NJ2pZL4xiLnAouTvHmyjPNUWhpX6E/fZ+JySTxa0F+uvFSTnpq37amTTiR1e2/fOicgyNiSdu0ahpyAP9WDXneON/gZksIA96jqxK78XiJIDNg8uH6dNaZRKyCkHTlO9qyG3Ws2dw4JxhjSAiYa3MBYt1GbCRWbqKyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7G4zTzxFhb9s2R1xJJ+I++II6Ti8FrIpgXxDVajLHc0=; b=XtJdHT8VZhixP4mj9JhNI/RtcwA16yURmeJFXZkBAt4ADH0sdKoWlDgVRoQyrlieGkoR1Vhuz7IoCOH36rTkv5pVqaXul+hf4pyy5n6A9LUM8SYgTJ2trCg9M1nA7Cdn3bGx642S1FznE0tfxcnbb6iRsqG0BoiCnZEsNYSZb30= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR1101MB2093.namprd11.prod.outlook.com (2603:10b6:301:50::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Fri, 13 Aug 2021 07:03:53 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4415.016; Fri, 13 Aug 2021 07:03:53 +0000 From: "Nate DeSimone" To: Benjamin Doron , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Thread-Topic: [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Thread-Index: AQHXiWs2gUSii/nQGUCSVZlnJ5xmdKtxDdGA Date: Fri, 13 Aug 2021 07:03:53 +0000 Message-ID: References: <20210804195900.6373-1-benjamin.doron00@gmail.com> In-Reply-To: <20210804195900.6373-1-benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1b9e7db-b39a-481d-336e-08d95e2882af x-ms-traffictypediagnostic: MWHPR1101MB2093: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vcRuxhRkOX2y+sOmVcHwRHEq+qIB2pOSYflhU4hj4Gialbe1eKI8xvlIixcII0pPOzvNtBpGqnumgR3uKTyxNzU6hNFPcwonGmtGHUd1xyrospElSL1GGGI/Zph06XogUvcjaAfgLLbp560+S4ysjKa2R5OEGzXUBW4nsc5YMdglgtetBRMaqU4aqu2xiO0XWU7tuP9qcajKuf/ZQudfoguMN8C1DHid7NLI8zMwxFHnMWZ5oMjWHPp0VkECIE4qHThS3+8dI3/oXEbZ96EJ7SO7d9TzWqt00FflP7w3oQM8FogLX4zCmZYD1D58G8/46TE8QB5OAzr7wQiwh8GffB+Y4ag6WYC9QcHSyaJ9+6R70pa2OJaYw5IHmO1Kwiv77Lf1Ewqr5PcBQbzlLZdGFQK9qFoOIsHqgJhXlLw+Jooteo4Zv3/u0vUoYxcFARJeS4FRzygqC2QyWtf2VqP4jOJ/+dmgPygq+4UT2DALSH5u2u9c8lrvzl6zvXh8KtkR2ph/s2OadUbK2xC1a418qO3l2yTVj8WcGFIa6/6wChNQaDuTi64SFfoUd1xVJXPvwGq3yWTWiZQTUpcCNjonPEXinTauXS2AwvGDIw4YOv9xfACeHyfwBq5Hpbcl47MnBKT63RwAbSTbP3elxyllnncvH8bDC6RhCQvDwgkjiZWo7ph0ZhiePOzll/3ey6n1j7QJKsW1Uul4hzEbXYQRcl5KNiLar17ju6xAO77x9GE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(71200400001)(110136005)(186003)(26005)(76116006)(83380400001)(19627235002)(2906002)(4326008)(55016002)(8936002)(38070700005)(53546011)(52536014)(9686003)(66946007)(107886003)(122000001)(66556008)(38100700002)(8676002)(66476007)(6506007)(86362001)(64756008)(7696005)(316002)(33656002)(5660300002)(478600001)(66446008)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?H7h6NRDo/fDuWkzSXfD/rLwKdHF3OtfpJW9ubQAK3itx+KWfRkO+4Jo8B5Ul?= =?us-ascii?Q?pCfql/n1IUxH93lU276LaYDO2HnH1g0ZNO8yRpkRT5/YX2NVkr2cYNao+Rrl?= =?us-ascii?Q?4I53bJhuwuspPKrBvMCoSDoWhkbX2E2BlDZM4xQsI9L5eH9gkpicZd7zwBj8?= =?us-ascii?Q?zj6rEJweAiC2GofVMM9kdceJaH0RA1ky6K+G0WQA6Q1f1ck+sbSfpNeFj5BD?= =?us-ascii?Q?KBnLr6E+JXZ2l36KPGgkTCbOJa9a1lHvqX2P3BUGTIf/wzAnWPDKMhpbzJHM?= =?us-ascii?Q?4WIqFOcOUpNdsvB2FMg+ceufwDFRWJ+x4D2/MSOED6sWOoiCRJnjln3gRwxk?= =?us-ascii?Q?yBAzWJ8zQ9QQYnDLt9uXhEVx25zq2TZTYKk6qyZZDnsUOq6WI1Cf9q87ig8E?= =?us-ascii?Q?4T1Q4Q2C8HKDIvYJODjKOkdc7/cC6BJh+Q5qbdU6ZsMAaArg81BFtEBeojW+?= =?us-ascii?Q?mj0RNSJ0cuMqLyVOdfc36YIxYcds2mrwSTX2L+o4vtfBIiPoFTeRCkmGliFs?= =?us-ascii?Q?SyMayUCXRW+GK+NJxwyBMYLJWDjtvR+SacGz5DtEZDC5J+MYE5WezSP5sZWK?= =?us-ascii?Q?odCNrifkOe62Cal6hA+lVM49yO2GbHmuQ9E/wGtMmi3LZpmfgojbM/+yuzta?= =?us-ascii?Q?F/HmKIRyDpJDCajIRV7ZqURb1ehuOlW48XLHlOAmGIjVrDXrDQnQKtGtWtuO?= =?us-ascii?Q?MYIPi16FjburgdabmHxxZivonZ/QroHLvJ7hrQxtCm7BRnQFgA1TJur4QKME?= =?us-ascii?Q?kXWBUi9OAYS9sPrCTJu3bZ0QQ7DNsJx0nIYAQC81/GwnASD41B4pV834uWX9?= =?us-ascii?Q?zRL1uLM04W7dHCjhSPBQzyMNqvfLP6zE16mhxXbIFeNX63xQ4mP96KuA/Dl4?= =?us-ascii?Q?n6ssd2UJ0c9+CdnnvWnL2NFsEir9SvlZWt5GbosOdXhxGKxGR9nVklzKB+2V?= =?us-ascii?Q?hdR2CG7wKRUCKiqQUiUWHEZI2uieoSzZOchNZsSZZM5iuETlvl0ccchQ4zEz?= =?us-ascii?Q?RWsuSEJzTA2kZnATyQ4MoLKNtgWXj0AtXjAyLzkRHrLuCp5jnoj8ySDDEhzY?= =?us-ascii?Q?xMWIypyD+3lR3cqZeq9BJ0f6Fmok58MKOq3JYCizbIFiDngROmhCu1g45mFy?= =?us-ascii?Q?7TzHcuS/o5unaeXnwhcWPVuvXfckjFWlF6jnUMd17m2aY28mHVpS3bnMfm4s?= =?us-ascii?Q?w5yg5bOWIPl1yWoWFQnxZC5LfYyid9HhWYjnZtSkcPOS8G2DgSouVMCQaQij?= =?us-ascii?Q?n37BDxeHe4GJO/Hl73jWAZ+WuSCKOv3digMNSHhR3GKBE+eZkWyfm8XzSeJ4?= =?us-ascii?Q?Waba1HjR1SChBpAoBqXfkm5K?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1b9e7db-b39a-481d-336e-08d95e2882af X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2021 07:03:53.2209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qf431uAEAZDOZ4m9tkpy8au47dXcwB5J3ZhGPxiZORvU5BD7t1EDpiK9EYD13yZog8NjYsc+QWtrlA+4FAduM1F41yQtgxnjNazesr4T/oA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2093 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Benjamin, It would be good to add a check on the status code returned from PublishAcp= iTablesFromFv() to the debug log. Something like this: Status =3D PublishAcpiTablesFromFv (&gEfiCallerIdGuid); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCa= llerIdGuid, Status)); } Status =3D PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); if (EFI_ERROR (Status)) { DEBUG (( DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", PcdGetPtr (PcdAcpiTableStorageFile), Status )); } I know the original code doesn't do it, but I imagine this will be helpful = to some poor soul who is trying to debug issues with this later on. Thanks, Nate -----Original Message----- From: Benjamin Doron =20 Sent: Wednesday, August 4, 2021 12:59 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcp= iDxe also installs all PcdAcpiTableStorageFile Follow AcpiPlatformDxe (from which this module is derived) and install all = ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 1= + Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2= ++ 2 files changed, 3 insertions(+) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcp= iDxe.c b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe= .c index 0361ffc2fbf9..fd227d9b410e 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe +++ .c @@ -289,6 +289,7 @@ InstallAcpiBoard ( // Platform ACPI Tables // PublishAcpiTablesFromFv (&gEfiCallerIdGui= d);+ PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); // = // This protocol publish must be done after PublishAcpiTablesFromFv.diff = --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.= inf b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.in= f index 7d2e105e5447..4d7f5cdb3eeb 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.in= f +++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe +++ .inf @@ -59,6 +59,8 @@ gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints gKabyl= akeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints + gEfiMdeModule= PkgTokenSpaceGuid.PcdAcpiTableStorageFile+ [Depex] gEfiAcpiTableProtocolG= uid AND gEfiFirmwareVolume2ProtocolGuid AND--=20 2.31.1