From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.3173.1627519638466576486 for ; Wed, 28 Jul 2021 17:47:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=yGs9Om7n; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10059"; a="193056266" X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="193056266" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2021 17:47:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="435315187" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 28 Jul 2021 17:47:16 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 28 Jul 2021 17:47:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 28 Jul 2021 17:47:16 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 28 Jul 2021 17:47:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mRKQqwhKz6GFBWERW2BCqvTjjumDKgISxSCNLPQaDqaR76L58zbRUNsbnDjOBeao6XkAVZWkZdMy0mhFkQ4brK2LmQpx7R8Phi8RZsh53Zsd/ZxO1wOJmnkGigSvscb6KLPKXoBa8FLYfBbisy472I6+5dbB0vFXWDLQRP0OAUlf9lTxS1TWKj4NHLoZLdFCYvKu/gw/D9G/DTsYMgIGckVSMwSBQaZnJERAInDK/E+jOD4cNnNcc5zQJbfMOjC9TvJiu6KfrCWqPRVfiRtp5adZFmWz9CJyF/84OjKEUjpfOX4LIFQu+sxOfvBoPnhxv8EsjF2KdEWogEBvzKFpxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9U4t9ppvfAd0D6zL1NqYnqy0NsUe76kj8maV95ebqJw=; b=IDhOQ/48tDgs1rhwDH92d0+RZ3Mel8EQEoiCKKzW4SKmfQeihWU9yhqqH/Lb6EDuLMCcXxDW4AkU0HOtk+9Z15XyEB4nrVDedfZKUA45Dt4qzxYLwnCLTm4eq14tQCo3JLuoXY3TslFeSoI16KafmzOsIXsvg4S+3MR8Tf+ustfS+wdvTKBt6D0J4V4LpdpzUySzpSMpFM0jKYKIbbt+mC+Fo2gJJfdkC55gJUnYXvyC90rHuz3jL5KEVcZ1K9elzgixRLjZPpy01SnZcR6QR6ur/gML6yogCjcRZtY163Sx+3O8qbTMdDlOof6u7e6KLyvaUdh5g00TqLgsozYVwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9U4t9ppvfAd0D6zL1NqYnqy0NsUe76kj8maV95ebqJw=; b=yGs9Om7nIPjEdBY0wuQv3w1YH5CiFcmjsUbthVUSmAWU/bilSmA71tybGFBLZKJKDC1mzJqWFZbYmuvStKGzp3iuuzv6OkVflbZuTggCuFVwq7epUg0kfCOltVZIPDejTE8bqV1QLajH5/jNH+2KmpSt9QxYu59wuYlZSMNPIQI= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1392.namprd11.prod.outlook.com (2603:10b6:300:24::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.17; Thu, 29 Jul 2021 00:47:14 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::64ce:a6b0:9ae8:e644]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::64ce:a6b0:9ae8:e644%12]) with mapi id 15.20.4352.032; Thu, 29 Jul 2021 00:47:14 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms][PATCH v4 37/41] IntelSiliconPkg: Identify flash regions by GUID Thread-Topic: [edk2-platforms][PATCH v4 37/41] IntelSiliconPkg: Identify flash regions by GUID Thread-Index: AQHXaghLnsseVTr4vkGBhufi9iZgJqtZUmfQ Date: Thu, 29 Jul 2021 00:47:14 +0000 Message-ID: References: <20210625212120.235-1-mikuback@linux.microsoft.com> <20210625212120.235-38-mikuback@linux.microsoft.com> In-Reply-To: <20210625212120.235-38-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb896d42-b64d-4c8f-6836-08d9522a68a3 x-ms-traffictypediagnostic: MWHPR11MB1392: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QJ2wF5+vUXjvi7/GjDtUlnJPI7U+6TGkX+del9pYGDCMeaXL/M6XiGY4umrt3WFAEXn/7JpFgb+Th4flCgS832MfXre/qQJAoTniWxdUM9M9oIw7RscUEMWiGrsaylhpxDvjWVEghTn6ff7vvmvPUmi4QrpFWVge6uVgEiAMzeUImsjwEjcHdiHe5Fe9iR3JCcwPFLYziwyaJ/ab+PFVidwXy3j11KfFLEmiy+FtfRERJxiWvlBjTo/iUL5Sk4rw5v9f1oenhddfLlJRYsCOSqnvc3tDHiec4LeaZcE8qvphh6TyvFAV6PB1qOPRObMTKhPLhjx5W8HZtm1Y9e38W/2cvSQZg/9uZKsFaY8ySYEH6ocg4CCC5TV72M1A3ASJd84HTpCQpoXxGQYOpSBLboF67M7J+vCdD/WEICQwi82FXRelgBAATIPiYlv1oMqoudtGa59IyWZFY1Aa3iKTEOEX6JK5G1dG4w2ni/slj+f5ELRO1rBxyc3Yu268+fi9veozulIInl5WcW4sVgx3TaTbWdDogTwqc49iL08XM70DPNMrd6bebcUk1GnHqy4nBbz2azM9RW1dXbNg1bh0lB6RLA11MSciJ5E0FLNWGRGFl4MZfsVQQwkwN4Vs2hpqr+k2R5UbhJJVhXiIyqupAhi4kV5cSn5bQXcXNG/QUVdkOeglt97CGz2Q6WKe6LyusqZiWizayLASWupm2RVWA1bQNaUMeoALZ2607pZZ6NO859zaQVE+cz0lbKcvmcHm82W8JCulHL834c51c+tb6kYxWDpJZZsspMVDu3QZi54= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(136003)(376002)(346002)(39860400002)(107886003)(86362001)(8676002)(83380400001)(52536014)(2906002)(64756008)(66556008)(4326008)(66446008)(66476007)(316002)(122000001)(54906003)(76116006)(66946007)(38100700002)(110136005)(26005)(5660300002)(7696005)(478600001)(55016002)(53546011)(38070700005)(6506007)(9686003)(71200400001)(8936002)(186003)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EwCh88ENhrcpTa/vDlf7A6tAa+z/9Urz+aMip22GykUJZTWPnaxv3nLDppJD?= =?us-ascii?Q?fh/CwuKOlAxWfxMgZcjCw7i+f/jBc+1YPaYgLSZlEuAKs/XA3bYACxFSdfzw?= =?us-ascii?Q?l0d/h0IBl3WCvhb0ybmIw0tpFjDJIXCHYdQqH/RyfY2Q0EJp1ntNv4a64ilp?= =?us-ascii?Q?SLmc/VJY3JqT69q53bnHYSuX3/pnO8aqZl+7cnisDJvM9ITRMtdaOjWghSmQ?= =?us-ascii?Q?yj2NpfAc2327J2N9scac460s3bhR+0qwTv/uSl9TgTz4c3FnRrwAq9fDVqSm?= =?us-ascii?Q?LwAE16dxRJM5GfWermzJr5xWoselIe9PIGWoijl8UYCAcH/8TAFiPhuLjLjt?= =?us-ascii?Q?Y7KWTJ2yT6cPFnNw1tZ0ErpEu+ghYuEIBDRsRdUOX3kt6LCwneC8Sayv70df?= =?us-ascii?Q?fY7ACUYM6OCpc2h6F7jdDB2tus+P9FGqWqFhC75gq04vw6MslSk8lNCPXV8I?= =?us-ascii?Q?rUTLpDbBxkfjNPu73LypL+8+EPwGFjCl0/5+gnb50pD+tENbdJNgWWoMeWYi?= =?us-ascii?Q?0mlxdvL9lDwNSKlpZYCNAS9SFQRpk8Olsd/GrahKv3wqI4mvDZLflID1ugXl?= =?us-ascii?Q?h0H3KS8Bbwo6EBVr+xskQ10YukfPIvwmqJe7QE6vBOS4hTfRkMtkyZ9+Cou3?= =?us-ascii?Q?sxDqEuYZSF5jOFMLgW39b2HbG1UdffacZ94lbUNzgIv9oHPUIY/xfgLstmmA?= =?us-ascii?Q?7Lm2xBP1/SGY2wCdv/sMGUfCFMHbh3OgYVMGkLwnMahs5Z0YVUqi5RxRif46?= =?us-ascii?Q?4lAn5I2K5d6svITR1cpY+yjFTZkWNWeytj80dS8JAsUb3wG2v7E/yGF0AIg3?= =?us-ascii?Q?ZkfcEf7xj+GCha2wm6K1zKZaylotsqzf9DItaZtxHfIDeMKW+8D/7sq8bLb3?= =?us-ascii?Q?TTNrNMrQzdQmXBxAs0urZRF8C+oOHraILW0U/xckpsrj6+Q+c0Hirp/OPotZ?= =?us-ascii?Q?yaGgg3jBah9Tg6t2CyygIcvxGaRCm+pubCosH/x0alfUAWd2evzOiSc01gV2?= =?us-ascii?Q?8rR7c7FV55pzyJzkgJmqiu/klA5j9Z5DXlgjZHzC8lwcjLIvNqaoGj4TipIs?= =?us-ascii?Q?Uy9P0i33NFJmo2wIPv/1ziT8HxL6vlncpGmPRfNCj1uxX6U+FjZGuA5+jVIC?= =?us-ascii?Q?jFn4wBpt7wsp+AaC/0XT1a8d5aDxoz8onmuUzCRENJJCeuNsYW8/UmtqrZzc?= =?us-ascii?Q?ktkVzMTpkc+Lm0KYxcU0YELqSRUPFzTHXIWyla6JrpjC5D0wWnSTJSsMuShy?= =?us-ascii?Q?XzqqxXkP1x3HUlnfLkQxNN1eNx55qYyGGEouxXwIzydh6ievi0V8Iqd1pbTE?= =?us-ascii?Q?cluj3ngFCSvNC8HHT/tl4hYJ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb896d42-b64d-4c8f-6836-08d9522a68a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2021 00:47:14.5980 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mesVy2/Ls2QivEFZjMshHg1wJt33xi2w/rAn9oNYdpl2DIsGhXUdWTPRDlhalFNk5YH0IaEUiAxQvG4YT/+RTuFvGgP0d93zidaOVqqqIxk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1392 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Friday, June 25, 2021 2:21 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v4 37/41] IntelSiliconPkg: Identify flash > regions by GUID >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 >=20 > Updates the SPI protocol to identify flash regions by GUID instead of fix= ed > values defined in an enum. Packages consuming IntelSiliconPkg are able to > associate a given GUID with their chosen values based on their SPI flash > details as implemented in their PCH_SPI_PROTOCOL instance. >=20 > Cc: Ray Ni > Cc: Rangasai V Chaganty > Cc: Nate DeSimone > Signed-off-by: Michael Kubacki > --- >=20 > Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashC > ommonLib.c | 2 +- >=20 > Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SpiFlashComm > on.c | 4 +- > Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h = | 43 > ++++---------------- >=20 > Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashC > ommonLib.inf | 3 ++ > 4 files changed, 14 insertions(+), 38 deletions(-) >=20 > diff --git > a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlas > hCommonLib.c > b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlas > hCommonLib.c > index 7941b8f8720c..2c9c889e7f48 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlas > hCommonLib.c > +++ > b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF > +++ lashCommonLib.c > @@ -52,7 +52,7 @@ SmmSpiFlashCommonLibConstructor ( > ); > ASSERT_EFI_ERROR (Status); >=20 > - mSpiProtocol->GetRegionAddress (mSpiProtocol, FlashRegionBios, > &BaseAddr, &RegionSize); > + mSpiProtocol->GetRegionAddress (mSpiProtocol, &gFlashRegionBiosGuid, > + &BaseAddr, &RegionSize); > mBiosOffset =3D BaseAddr; > return Status; > } > diff --git > a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SpiFlashCom > mon.c > b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SpiFlashCom > mon.c > index daebaf8e5e33..62c1d099fc2c 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SpiFlashCom > mon.c > +++ b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SpiFlas > +++ hCommon.c > @@ -127,7 +127,7 @@ SpiFlashWrite ( > } > Status =3D mSpiProtocol->FlashWrite ( > mSpiProtocol, > - FlashRegionBios, > + &gFlashRegionBiosGuid, > (UINT32) Offset, > Length, > Buffer > @@ -201,7 +201,7 @@ SpiFlashBlockErase ( >=20 > Status =3D mSpiProtocol->FlashErase ( > mSpiProtocol, > - FlashRegionBios, > + &gFlashRegionBiosGuid, > (UINT32) Offset, > (UINT32) RemainingBytes > ); > diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h > b/Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h > index c13dc5a5f5f5..2b09ca1faf02 100644 > --- a/Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h > @@ -19,33 +19,6 @@ extern EFI_GUID gPchSmmSpiProtocolGu= id; > // > typedef struct _PCH_SPI_PROTOCOL PCH_SPI_PROTOCOL; >=20 > -// > -// SPI protocol data structures and definitions -// > - > -/** > - Flash Region Type > -**/ > -typedef enum { > - FlashRegionDescriptor, > - FlashRegionBios, > - FlashRegionMe, > - FlashRegionGbE, > - FlashRegionPlatformData, > - FlashRegionDer, > - FlashRegionSecondaryBios, > - FlashRegionuCodePatch, > - FlashRegionEC, > - FlashRegionDeviceExpansion2, > - FlashRegionIE, > - FlashRegion10Gbe_A, > - FlashRegion10Gbe_B, > - FlashRegion13, > - FlashRegion14, > - FlashRegion15, > - FlashRegionAll, > - FlashRegionMax > -} FLASH_REGION_TYPE; > // > // Protocol member functions > // > @@ -54,7 +27,7 @@ typedef enum { > Read data from the flash part. >=20 > @param[in] This Pointer to the PCH_SPI_PROTOCOL instan= ce. > - @param[in] FlashRegionType The Flash Region type for flash cycle = which > is listed in the Descriptor. > + @param[in] FlashRegionGuid The Flash Region GUID for flash cycle > which corresponds to the type in the descriptor. > @param[in] Address The Flash Linear Address must fall wit= hin a > region for which BIOS has access permissions. > @param[in] ByteCount Number of bytes in the data portion of= the SPI > cycle. > @param[out] Buffer The Pointer to caller-allocated buffer= containing > the dada received. > @@ -68,7 +41,7 @@ typedef > EFI_STATUS > (EFIAPI *PCH_SPI_FLASH_READ) ( > IN PCH_SPI_PROTOCOL *This, > - IN FLASH_REGION_TYPE FlashRegionType, > + IN EFI_GUID *FlashRegionGuid, > IN UINT32 Address, > IN UINT32 ByteCount, > OUT UINT8 *Buffer > @@ -78,7 +51,7 @@ EFI_STATUS > Write data to the flash part. Remark: Erase may be needed before write= to > the flash part. >=20 > @param[in] This Pointer to the PCH_SPI_PROTOCOL instan= ce. > - @param[in] FlashRegionType The Flash Region type for flash cycle = which > is listed in the Descriptor. > + @param[in] FlashRegionGuid The Flash Region GUID for flash cycle > which corresponds to the type in the descriptor. > @param[in] Address The Flash Linear Address must fall wit= hin a > region for which BIOS has access permissions. > @param[in] ByteCount Number of bytes in the data portion of= the SPI > cycle. > @param[in] Buffer Pointer to caller-allocated buffer con= taining the > data sent during the SPI cycle. > @@ -91,7 +64,7 @@ typedef > EFI_STATUS > (EFIAPI *PCH_SPI_FLASH_WRITE) ( > IN PCH_SPI_PROTOCOL *This, > - IN FLASH_REGION_TYPE FlashRegionType, > + IN EFI_GUID *FlashRegionGuid, > IN UINT32 Address, > IN UINT32 ByteCount, > IN UINT8 *Buffer > @@ -101,7 +74,7 @@ EFI_STATUS > Erase some area on the flash part. >=20 > @param[in] This Pointer to the PCH_SPI_PROTOCOL instan= ce. > - @param[in] FlashRegionType The Flash Region type for flash cycle = which > is listed in the Descriptor. > + @param[in] FlashRegionGuid The Flash Region GUID for flash cycle > which corresponds to the type in the descriptor. > @param[in] Address The Flash Linear Address must fall wit= hin a > region for which BIOS has access permissions. > @param[in] ByteCount Number of bytes in the data portion of= the SPI > cycle. >=20 > @@ -113,7 +86,7 @@ typedef > EFI_STATUS > (EFIAPI *PCH_SPI_FLASH_ERASE) ( > IN PCH_SPI_PROTOCOL *This, > - IN FLASH_REGION_TYPE FlashRegionType, > + IN EFI_GUID *FlashRegionGuid, > IN UINT32 Address, > IN UINT32 ByteCount > ); > @@ -206,7 +179,7 @@ EFI_STATUS > Get the SPI region base and size, based on the enum type >=20 > @param[in] This Pointer to the PCH_SPI_PROTOCOL instan= ce. > - @param[in] FlashRegionType The Flash Region type for for the base > address which is listed in the Descriptor. > + @param[in] FlashRegionGuid The Flash Region GUID for flash cycle > which corresponds to the type in the descriptor. > @param[out] BaseAddress The Flash Linear Address for the Regio= n 'n' > Base > @param[out] RegionSize The size for the Region 'n' >=20 > @@ -218,7 +191,7 @@ typedef > EFI_STATUS > (EFIAPI *PCH_SPI_GET_REGION_ADDRESS) ( > IN PCH_SPI_PROTOCOL *This, > - IN FLASH_REGION_TYPE FlashRegionType, > + IN EFI_GUID *FlashRegionGuid, > OUT UINT32 *BaseAddress, > OUT UINT32 *RegionSize > ); > diff --git > a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlas > hCommonLib.inf > b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlas > hCommonLib.inf > index f6a06351ace5..b28ea3c2719d 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlas > hCommonLib.inf > +++ > b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF > +++ lashCommonLib.inf > @@ -37,6 +37,9 @@ [Pcd] > gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress ## CONSUMES > gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize ## CONSUMES >=20 > +[Guids] > + gFlashRegionBiosGuid > + > [Sources] > SmmSpiFlashCommonLib.c > SpiFlashCommon.c > -- > 2.28.0.windows.1