From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.356.1622073464438360930 for ; Wed, 26 May 2021 16:57:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=mXNxsfju; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: 1DgrVHX8O49xxboJjR3YVVqmh+ZK7vtkNVMWqOWn7S0NIgr17d+0GH7dXmNDA6Hta1mHj1pHtB H1UeWtWyNM/Q== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="202373312" X-IronPort-AV: E=Sophos;i="5.82,333,1613462400"; d="scan'208";a="202373312" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2021 16:57:37 -0700 IronPort-SDR: dYJtaoqOQ4rdMxA8v1HTKWXebJopygNSiYOCliRfc0yuPrcv5gLRz5DEpyaYkHtvPoPaXTd8sH EB19JP1xz0UA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,333,1613462400"; d="scan'208";a="480323426" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 26 May 2021 16:57:36 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 26 May 2021 16:57:35 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 26 May 2021 16:57:35 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Wed, 26 May 2021 16:57:35 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Wed, 26 May 2021 16:57:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JKQAPtfNjqdrenVYPmkePrs2rC3bptfjmBsZEQpOxePmPDNcs8MCqs9qKQRAjnJjn+C2ppRPaJfUl9ceDRvhc9kLgob/Bs8Su1+BlhvNMLK44sM12HuNufgeyNhysuzCoY/klEUbvmPXcA2U63hYZmRPqVaRznyqQQFMj8iUmRez/r9I0OFoFyeNmrsr6fPrim4QP7LXunx1L/+76NdEfELRvcLRk8SiD401yoHeaJacqYKx7YRe3fmoi+NUPi4zk54sfMx7GTQv67Wr6dTRmPgHQXUSR1UNjC0uZf09ViPx68SbhbgGus+ca167JF3g63lLTOzshyp1Jwh4aIKGBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mBUWpROFez9Q9+DlvBfFedhJhhxiQaCSxNUZ2eYZ+7g=; b=P8Y6RHkCH7Qn0JPFcTGnZCU6AfcttqxhAsNxVwHTba942T1NV9tT0a7y8rq2FsmEetcPjiiRT/Uv1CyCeQ7TsEqMOI30l6xfdt//iTut7SYIBWqx0eNIJCMg++5eziwYPGEYq7BeyfH8QQM+Y3oZjQBfqHlfh8sfKDhpsjJcZbJppCiRbpo/N7RAGmU5kH4MZm4aI6E3QiO6QHYItXfDlfsEpAfZvqApPt7YviFZoOiunLWxRuCWyqQdWwIl9gobTnT8igFa7DhOnEJ93SUan4qt6NW81Wz8Zw2zi/UhUD1B+ErrzrC4CJ/9sEz5BGEXKg+gHDSrorhLR657GXCTWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mBUWpROFez9Q9+DlvBfFedhJhhxiQaCSxNUZ2eYZ+7g=; b=mXNxsfjuil/727UiGYjsAixmCwm3pnMTy6KSm9MUxhCQUxuVyWHIze8etc1Uf/B4JnRatqhSx0lbOLL0LImJBixXAoull+7BBQ5ey28AsMETZVaRTGY0GUOK8Q9VCO4wykGJllpcqDKU/ZI9R2rYLnFdOZRwoTyenxHdC5PCOUo= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB4836.namprd11.prod.outlook.com (2603:10b6:303:9d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.25; Wed, 26 May 2021 23:57:24 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::c8d6:1114:7da4:1d2c]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::c8d6:1114:7da4:1d2c%9]) with mapi id 15.20.4150.027; Wed, 26 May 2021 23:57:24 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Agyeman, Prince" , "Chiu, Chasel" , "Kethi Reddy, Deepika" , "Dong, Eric" , "Luo, Heng" , Jeremy Soller , "Esakkithevar, Kathappan" , Liming Gao , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms][PATCH v2 00/35] Consolidate SpiFlashCommonLib instances Thread-Topic: [edk2-platforms][PATCH v2 00/35] Consolidate SpiFlashCommonLib instances Thread-Index: AQHXTGOCCluQ4FuuqESqFQcUSWAb3qr2exoQ Date: Wed, 26 May 2021 23:57:24 +0000 Message-ID: References: <20210519035947.1234-1-mikuback@linux.microsoft.com> In-Reply-To: <20210519035947.1234-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a4a70752-e698-4949-2a6c-08d920a2025b x-ms-traffictypediagnostic: CO1PR11MB4836: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QEBajyhchlgVR9y6hO8NnpBIzyJi6GWyc6SBRMPMm4K+R1+wT1U/cyUr14e9uMVY66kuuldnRQfEGCgQ50JemEB/+yT/wOw/Al2igW2a4a8vu65HCTVZgioBNFEJHFo/Qzava+QZ42Uy304W7470Du7oG71tibnee/qTTIQqQ9iLmUE/FxwLVu4qD2FLYEd6Jlm/voJ5LlP6wRhEK2VB8vrJVrekMNXOdo7mI9c2LyxIQTuaB1GDJVp3Iq3+dWX1OPTx/y7ByNWBUCKfWg4Tb8d9MwSApm77Fu46QjdVeLMPRDI8aSas/kQCswj+OZGzNJyauXLw3iPqSGL2NiXu70GhdjBAEyLckRo44SG5QlhRvm5ipC7KUqK2Ihcn39sTFLazN+6nDzgNidQMS4TQUl4hc3wQ3Dkzd3hdNLOCNQRQQjZvYcycaj+PKgTsh8gWCv98Tv/hJnfSlZwzy+7teK+I9/oyLXfF4DRNS3zfM3Zi4e3rZ7KGlut1549+Oyo3x7q7xIoPNAslxtSXn2vYO4+sEopgQktsFa7YQyVVyFrF/QDoiSTJDIRKlDMoEVmPAkM7EhJO5wVFblp4kpDlAYgWS33U5tcQLdbihNYInk85AF9mF5VtId6m/4M3h1WI1Ns5lQ02cNh0jN58n/XYNEgXCaICVJsfISgrPiymdCvDkEMPfko9luDFQwZurm1EkpXh6UjMgtodfBZViSavnY8p3zwc/WSkdV87goGRXEo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(376002)(39860400002)(136003)(366004)(346002)(5660300002)(4326008)(8676002)(2906002)(316002)(38100700002)(76116006)(186003)(19627235002)(26005)(9686003)(966005)(110136005)(122000001)(66946007)(478600001)(107886003)(71200400001)(66476007)(6506007)(64756008)(54906003)(66556008)(66446008)(83380400001)(55016002)(52536014)(53546011)(8936002)(7696005)(30864003)(33656002)(86362001)(579004)(559001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?l4UpSNzPSn52Mpc9BA12kYM+QGCJQ3RNkmGTZfVZUWxCoYwkSl8rzwFcUGMu?= =?us-ascii?Q?aQ5xZDif4g/kswcqNXMuRfvZXtNF/Ypq3lRxZC8bDgLOE1NWf8YQ2kCft+RK?= =?us-ascii?Q?ySE/R0UAVELSOtAjDy9B6kdHmONQQgDRtRyXyt5kX5XM8Qx6d1NHxgQWa+I7?= =?us-ascii?Q?mvhSBKci0ZiUThhYBq0JmX4/gFOrmSfbT1oZVHETovGt1/17cFmEuB9iD0SA?= =?us-ascii?Q?J49Ay6nWTYL5hKrJJwq+Nq+Cicys+GjzfgYbXqQHnFvMKsKN1h6vWayB+zaM?= =?us-ascii?Q?k5jjIVnenmqCVPl/MA9rJPQOVFItNniOwKLFIL61xXieX9G65L9GrEPaZ3BQ?= =?us-ascii?Q?gIBBqwCkUs0RowZwMviyEoha+IW/qM3Jafc0Cx8NtOMSF/KYMUdvN1UCLp16?= =?us-ascii?Q?Ds180EH/dWGAoAewWUAfgi1Mqmek2XD8S5o1vrtrTznFjnPzyFQKJ3Gb7QsE?= =?us-ascii?Q?EWRd1BSlX7Re77rMSMuA3+8ex+ZY2IHwXgyaV7iBFaaW/Vm1rzTB77LxbE0C?= =?us-ascii?Q?kJv+zsRZC9FnNgqyerwXMKPUT1quPhnuEkDB/csp/9JChMOcuN5iPvnKXDu0?= =?us-ascii?Q?izckB8uVYwB4ywQDNxPpD8dMXTvRZnEBEPpvJFsMXxNE+QaT+ezrgu6/u8Ms?= =?us-ascii?Q?6zANjpsE1YJe/i7ts+gUxPKnBq+YFGjmp6rAK2B7FPwS5IdSEJhVJQj8Ha6d?= =?us-ascii?Q?usK8qa54DfqYoY9SU9FD4LBVV25zsMQouJzZiAZZC0YbGoG1RtfBLoVIUvD3?= =?us-ascii?Q?fA/HH8AdrdPkjVH7Noln5enqfrrYM38UXnCOpOA6VeXKLSYmh9OKKM+znZyy?= =?us-ascii?Q?yQCAbtPrdPA7wuREPu3KQGK8BiMH41YS+cXeB9VR+bMNZWXuANTYC6zB7xph?= =?us-ascii?Q?nd2LAvGQ9eBUuqCwqAl3UvOz6FxbxSfmH5m78pXF2x3sYLh1VyDUWzUza5C4?= =?us-ascii?Q?T9FPgxQLKggK6gFuR37nt3lXdIgvrCdBZt9Iwmzj6Ib1INaA4wXxpjUUO7wg?= =?us-ascii?Q?VEwDAhp1+ObsPrBQBKH/Jy3NJ8kxluDPcWCk7JjkGQ0fqfeiA2307oooo/jK?= =?us-ascii?Q?nl175GFwh4ReSnbknnCJZlYVBOPBf9nMrfHhjspwLItI1Fl/Dkmeki4BZoPX?= =?us-ascii?Q?lpDoz3KPJ4AsP6n6cTH/D8HekKEH8YRKUzABpJjh1ks4qovuU2wqVhW5Vim5?= =?us-ascii?Q?0d4OvK1OtV0L+q2FYvMT6H8TwiYjz91U/guNkFN66tMByFUik942Ki3tUrum?= =?us-ascii?Q?8AEMYH0l/dJt8OWbPyZ97hur2cVKKpxQubwn3IGNcHyMrrxUvApktXQAzQZf?= =?us-ascii?Q?+WtqrOAFaB8GWo1OcXhYCRPh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4a70752-e698-4949-2a6c-08d920a2025b X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2021 23:57:24.3316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rp4yDrBI32n+bgxyuYM8cI+pZfo2YG/IQoEsSVAJ3GrLwrqjDU/W6zNh0+H0mJ4/NTrLhOlO60S2WhcKkIZVG7EtSq7xQhrFqlwVzlhknNc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4836 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, I have been thinking about this more from a long-term maintainability stand= point. The IFWI region enum FLASH_REGION_TYPE looks pretty ripe for causing= issues years from now. We should probably convert each member of that enum= into a EFI_GUID so that regions can be added/removed as needed. Some of th= ose enum types probably don't belong in IntelSiliconPkg either, like FlashR= egion10Gbe_B for example. Thanks, Nate -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Tuesday, May 18, 2021 8:59 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Chiu, Chasel ; Kethi Reddy, Deepika ; Dong, Eric= ; Luo, Heng ; Jeremy Soller ; Esakkithevar, Kathappan ; Liming Gao ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: [edk2-platforms][PATCH v2 00/35] Consolidate SpiFlashCommonLib ins= tances From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 SpiFlashCommonLib is duplicated in multiple places across the MinPlatform d= esign in edk2-platforms. I'm planning to build some additional functionalit= y on top of SpiFlashCommonLib and, ideally, this duplication will be consol= idated into a single instance usable across all current library consumers. This patch series focuses on consolidating the various SpiFlashCommonLib in= stances as agreed upon in https://edk2.groups.io/g/devel/message/71701. Read the BZ for more general background around this series. I only have an UpXtreme board on hand so maintainers/reviewers of other boa= rd packages should test these changes on those boards. V2 changes: - Rebased patch series on current edk2-platforms master (32183bdaa91) Note: Patch series only received a couple review comments after being on th= e mailing list for over 1 month. Please be more prompt with v2. Cc: Agyeman Prince Cc: Chasel Chiu Cc: Deepika Kethi Reddy Cc: Eric Dong Cc: Heng Luo Cc: Jeremy Soller Cc: Kathappan Esakkithevar Cc: Liming Gao Cc: Nate DeSimone Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Michael Kubacki (35): CometlakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry WhiskeylakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Add missing GUID to INF IntelSiliconPkg: Add BIOS area base address and size PCDs IntelSiliconPkg: Add microcode FV PCDs IntelSiliconPkg: Add PCH SPI PPI IntelSiliconPkg: Add PCH SPI Protocol IntelSiliconPkg: Add SpiFlashCommonLib IntelSiliconPkg: Add SmmSpiFlashCommonLib IntelSiliconPkg: Add MM SPI FVB services CometlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs KabylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs SimicsOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs TigerlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs WhiskeylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs CoffeelakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs KabylakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs SimicsIch10Pkg: Use IntelSiliconPkg BIOS area and ucode PCDs TigerlakeSiliconPkg: Use IntelSiliconPkg BIOS are and ucode PCDs CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib SimicsOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib WhiskeylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib MinPlatformPkg: Remove SpiFvbService modules CoffeelakeSiliconPkg: Remove SmmSpiFlashCommonLib KabylakeSiliconPkg: Remove SmmSpiFlashCommonLib SimicsIch10Pkg: Remove SmmSpiFlashCommonLib TigerlakeOpenBoardPkg: Remove SmmSpiFlashCommonLib MinPlatformPkg: Remove SpiFlashCommonLibNull KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Add IntelSiliconPkg.dec CoffeelakeSiliconPkg: Remove PCH SPI PPI and Protocol from package KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from package SimicsIch10Pkg: Remove PCH SPI SMM Protocol from package TigerlakeSiliconPkg: Remove PCH SPI PPI and Protocol from package Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFla= shCommon.c = | 196 ------------- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFla= shCommonSmmLib.c = | 54 ---- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/FvbInfo.c = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceCommon.c = | 4 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceMm.c = | 8 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceStandaloneMm.c = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceTraditionalMm.c = | 0 Platform/Intel/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/SpiFlash= CommonSmmLib.c =3D> Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommon= Lib/SmmSpiFlashCommonLib.c | 0 {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSiliconPkg}/= Library/SmmSpiFlashCommonLib/SpiFlashCommon.c = | 3 +- {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconPkg}/L= ibrary/SpiFlashCommonLibNull/SpiFlashCommonLibNull.c = | 12 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlash= Common.c = | 196 ------------- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlash= CommonSmmLib.c = | 54 ---- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c= = | 194 ------------- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommonSm= mLib.c = | 54 ---- Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCommon.= c = | 26 +- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c = = | 4 +- Platform/Intel/CometlakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/Include/Fdf/FlashMapInc= lude.fdf = | 4 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf = = | 38 +-- Platform/Intel/CometlakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/Pei= PolicyUpdateLib.inf = | 2 +- Platform/Intel/CometlakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDxe.in= f = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude= .fdf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInclu= de.fdf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSilicon= PolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiSe= rialPortLibSpiFlash.inf = | 1 + Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h = = | 98 ------- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec = = | 2 - Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc = = | 6 - Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc = = | 6 +- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf = = | 2 +- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf.inc = = | 8 +- Platform/Intel/TigerlakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 8 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Include/Fdf/FlashMapInc= lude.fdf = | 4 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/WhiskeylakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPolicyUpdateLib.inf = | 1 - Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDxe.= inf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Fdf/FlashMapInclud= e.fdf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/BoardInitLib/PeiMu= ltiBoardInitPreMemLib.inf = | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf = = | 38 +-- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Include/Fdf/FlashMa= pInclude.fdf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.fdf = = | 38 +-- Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolic= yLib.inf = | 4 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Protocol/Spi.h = = | 295 -------------------- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf = = | 1 + Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/BasePchSpiCommonLib= /BasePchSpiCommonLib.inf = | 1 + Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpi= FlashCommonLib.inf = | 51 ---- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf = = | 1 + Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec = = | 8 - {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceCommon.h = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceMm.h = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceSmm.inf = | 6 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf = | 6 +- Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Libr= ary/SpiFlashCommonLib.h = | 2 +- Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Ppi/= Spi.h = | 4 +- Silicon/Intel/{TigerlakeSiliconPkg =3D> IntelSiliconPkg}/Include/Protocol/= Spi.h = | 0 Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec = = | 19 ++ Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc = = | 17 ++ {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSiliconPkg}/= Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf = | 21 +- {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconPkg}/L= ibrary/SpiFlashCommonLibNull/SpiFlashCommonLibNull.inf = | 3 +- Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyL= ib.inf = | 4 +- Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/HstiSiliconDxe.inf = = | 3 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCommonLib.h = = | 98 ------- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h = = | 26 -- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/Spi.h = = | 293 ------------------- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf = = | 1 + Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpiFl= ashCommonLib.inf = | 53 ---- Silicon/Intel/KabylakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf = = | 1 + Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec = = | 13 +- Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec = = | 11 - Silicon/Intel/SimicsIch10Pkg/Include/Library/SpiFlashCommonLib.h = = | 98 ------- Silicon/Intel/SimicsIch10Pkg/Include/Protocol/Spi.h = = | 295 -------------------- Silicon/Intel/SimicsIch10Pkg/IncludePrivate/Library/PchSpiCommonLib.h = = | 26 +- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommo= nLib.inf = | 50 ---- Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BasePchSpi= CommonLib.inf = | 5 +- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf = = | 3 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/LibraryPrivate/BaseSpiCommon= Lib/BaseSpiCommonLib.inf = | 1 + Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf = = | 1 + Silicon/Intel/TigerlakeSiliconPkg/Pch/PchInit/Dxe/PchInitDxeTgl.inf = = | 1 + Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec = = | 8 - 89 files changed, 303 insertions(+), 2392 deletions(-) delete mode 100644= Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFla= shCommon.c delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFl= ashCommonLib/SpiFlashCommonSmmLib.c rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/F= eature}/Flash/SpiFvbService/FvbInfo.c (100%) rename {Platform/Intel/MinPla= tformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/Sp= iFvbServiceCommon.c (96%) rename {Platform/Intel/MinPlatformPkg =3D> Silic= on/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceMm.c (94= %) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPk= g/Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.c (100%) rename {= Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}/F= lash/SpiFvbService/SpiFvbServiceTraditionalMm.c (100%) rename Platform/Int= el/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.= c =3D> Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFla= shCommonLib.c (100%) rename {Platform/Intel/TigerlakeOpenBoardPkg =3D> Sil= icon/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c (= 95%) rename {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelS= iliconPkg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.c (83%) del= ete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCom= monLib/SpiFlashCommon.c delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlas= hCommonLib/SpiFlashCommonSmmLib.c delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonL= ib/SpiFlashCommon.c delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonL= ib/SpiFlashCommonSmmLib.c delete mode 100644 Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashC= ommonLib.h delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Protocol= /Spi.h delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFl= ashCommonLib/SmmSpiFlashCommonLib.inf rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/F= eature}/Flash/SpiFvbService/SpiFvbServiceCommon.h (100%) rename {Platform/= Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiF= vbService/SpiFvbServiceMm.h (100%) rename {Platform/Intel/MinPlatformPkg = =3D> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServi= ceSmm.inf (88%) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/I= ntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf (= 88%) rename Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/= Include/Library/SpiFlashCommonLib.h (96%) rename Silicon/Intel/{Coffeelake= SiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Ppi/Spi.h (85%) rename Silico= n/Intel/{TigerlakeSiliconPkg =3D> IntelSiliconPkg}/Include/Protocol/Spi.h (= 100%) rename {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/Inte= lSiliconPkg}/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf (69%) r= ename {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconP= kg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.inf (91%) delete m= ode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCom= monLib.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/S= pi.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlas= hCommonLib/SmmSpiFlashCommonLib.inf delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Include/Library/SpiFlashCo= mmonLib.h delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Include/Protocol/Spi.h delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonL= ib/SmmSpiFlashCommonLib.inf -- 2.28.0.windows.1