public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: Takuto Naito <naitaku@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	"Luo, Heng" <heng.luo@intel.com>
Subject: Re: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5
Date: Wed, 24 Feb 2021 02:18:08 +0000	[thread overview]
Message-ID: <MWHPR1101MB2160111260B416181D7D9245CD9F9@MWHPR1101MB2160.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210224013736.74815-1-naitaku@gmail.com>

Thank You Takuto!

For the series... Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Takuto Naito <naitaku@gmail.com>
> Sent: Tuesday, February 23, 2021 5:38 PM
> To: devel@edk2.groups.io
> Cc: Takuto Naito <naitaku@gmail.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
> Subject: [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build
> error with GCC5
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224
> 
> Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5.
> These build errors occur only with DEBUG target because
> RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but
> DEBUG_GCC5_X64_CC_FLAGS doesn't.
> 
> https://github.com/naitaku/edk2-platforms/tree/tigerlake_fix_unused-but-
> set-variable_v1
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> 
> Takuto Naito (2):
>   TigerlakeSiliconPkg: Fix build error with GCC5
>   TigerlakeOpenBoardPkg: Fix build error with GCC5
> 
>  .../Library/BasePlatformHookLib/BasePlatformHookLib.c     | 8 --------
>  .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c  | 2 ++
>  .../LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c      | 2 --
>  .../Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c      | 5 -----
>  .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c         | 2 --
>  5 files changed, 2 insertions(+), 17 deletions(-)
> 
> --
> 2.30.1


  parent reply	other threads:[~2021-02-24  2:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  1:37 [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Takuto Naito
2021-02-24  1:37 ` [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: " Takuto Naito
2021-02-24  2:24   ` [edk2-devel] " Heng Luo
2021-02-24  1:37 ` [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: " Takuto Naito
2021-02-24  2:24   ` [edk2-devel] " Heng Luo
2021-02-24  2:18 ` Nate DeSimone [this message]
2021-02-24  2:24 ` [PATCH edk2-platforms v1 0/2] " Heng Luo
2021-02-25  2:18 ` Nate DeSimone
2021-02-27 14:40   ` Takuto Naito
2021-03-02  2:47     ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR1101MB2160111260B416181D7D9245CD9F9@MWHPR1101MB2160.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox