From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web08.1191.1628205333998047666 for ; Thu, 05 Aug 2021 16:15:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=dYbGJTgi; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="214255741" X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="214255741" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 16:15:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="437968336" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga002.jf.intel.com with ESMTP; 05 Aug 2021 16:15:32 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 16:15:32 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 16:15:31 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 5 Aug 2021 16:15:31 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 16:15:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WpgpY0tsVMATrFQkJOrO817+xnbvEQZ7RhhvhkYNFCQ7RzM1PlkS6caetWKtbXESushtylN2V8aUK5fAkoDAjSh/lk9jW8wKqxOuBb9mvURhjep5/ADkvY05nGYOn76hqsvZpn5BDXK5L7sjJm6U9Nu3pe7OkrsQQvVyGRmjcgXwiRlKkJwKAiN32cdHgoH8PedkeIxvscbPkPIOS/rRjlzs7as7z3p+8M2RW7qzmcmFIPmBSrxi7Kky7k1aicH+qYaNybGDcPeciLMHWeQhW/4aRFSZ2+099G940fCn9LmdXp31tp5EDjLy/xkYSbYHAVp7GwP4AESDS+Q48KGRwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MQRotLdv6rkxIIzKSJbxvXTSYYniMbQT4VyzIYTH7Yo=; b=QCqiISiYy587LcWNyKX8XMDUSQvoWIv006zuwo7G0jXXGlFj4KVcqAj3T2OejSrP2D5bLk2pWIt3h91YMsTIXKk/si+L6D5pwOM7kMYoyWHri+wqWXMu2FfXI6NLFOB7MiTkw4af2wgx/LHs6fJJVjWXd3kqDumW/RJi+RCU5X2XZQxKm5/Rz3uQV3NicT8DLb0PuodUaaiQonEyvfXxE61zaHHv2B58T+nCJ1e7BySHiJcAbLnsMKH6TJ8l+JjVfPcLqddo34yTYOMaAUU0zJ1deBwIW2dDnLycBXmWgcUuPW/sK1BMW+onSpZsWBnbq4rRX9xuXLSzqdM97uKwQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MQRotLdv6rkxIIzKSJbxvXTSYYniMbQT4VyzIYTH7Yo=; b=dYbGJTgiYUp7+QhDkVM3uTiLqpriPHgzgQeYN8wecw1GX7dtf2tYl2WC83B2RoNYwSl26pdGpDIuafCsFsXa8JcglLYk9Ys9U+TKE1w0ygqTlHS+OWCgS/TrZ1AKs6gyGPD7W1ImOqLFASBdsdtkbfe22kOl68VFCTMYMILs2wY= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB4787.namprd11.prod.outlook.com (2603:10b6:303:6e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15; Thu, 5 Aug 2021 23:15:30 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4394.017; Thu, 5 Aug 2021 23:15:30 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 5/5] MinPlatformPkg/TestPointCheckLib: Make OutTable parameter optional Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 5/5] MinPlatformPkg/TestPointCheckLib: Make OutTable parameter optional Thread-Index: AQHXigpFiEBRlY3tAUmkz991vyNuDKtli1AQ Date: Thu, 5 Aug 2021 23:15:30 +0000 Message-ID: References: <20210805145706.2470-1-mikuback@linux.microsoft.com> <20210805145706.2470-6-mikuback@linux.microsoft.com> In-Reply-To: <20210805145706.2470-6-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2785b478-c4d8-4eaa-d133-08d95866eb62 x-ms-traffictypediagnostic: CO1PR11MB4787: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rz22D7ETmU8trT34DomjOgOsBiSL+BVU2uVJyjykRB/nngeRJRAtnUe/mb7HgAfDCoT4wdmbINJRYy27SG8r/WybE52e5SX8O+4MjJI5P6+R24H8rEm0OONMd1EhJbFQ4kMJK8qfE+ONAjyfZIoJAgzDuJnQpcbkDcei8qmuRuiOlOMVwhC/qsdE4VRMNUeQhoeWR1nsWPlBK4487DY6X6Mbhsg971zkrU1oroIQmv+WB4uH1KZGnxHNIschLJQ9JL8C2UXtqrMs/bYhpBH8lyhrinliWn1X+RU6z/DxtwkSh0vHyNRI/u6fCNVr7O6WJN4kBrapOYPWqMtMZw5fn3k3mXmlki9GikrYa6SJxLWxTPQSnxibqNDIT7g9MeMkFlY0Q4gymPRxKFsLmh808VPsxJPJHDfEiMrdVe2JMMUY7F/CBHoNvmdfGrPHCBAHqlQ21dyCnM+6J3kOoxEod1TMao4MCvZ7hqEuQCc3xiqFP0zMuDaJ8/53tnXLQ6EWAnjMChhXiWP/3G0scoG456lF4/OVPBGOck/KK4nRFPsAFbV1xhtK0k7x4bBoBI1qMB66NQKUWm3IWc5OGXYfNsD/fNGnk5Hh1kwGZ1dqEK2S9z4DeOkli0yH4tHt6MHz8OBLs0oqp8HAvEf4E8O+4luxPogFKMPYN0MXkbOcNv6ruljgqKtRyd6R0biV7MELdHl0Lhm+E7qLNhLzQiCxcIhKwXMNOJjsV3/mkhbK2rU2yaGGrZCRp8rnQJYjRJm8+aTlVCoua/Nr1nhfbtBemwE93mtg4pmZXZRbZUH+b7gSeGRGFqDTuFy8coSGlomFpPWVrMaz9oI65KbpGKSw2g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(186003)(38070700005)(83380400001)(33656002)(38100700002)(66946007)(86362001)(966005)(26005)(2906002)(8676002)(122000001)(8936002)(4326008)(6506007)(53546011)(52536014)(107886003)(7696005)(9686003)(110136005)(316002)(54906003)(5660300002)(76116006)(508600001)(64756008)(55016002)(66476007)(66556008)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qqOxyE1TaFM7UE+6rq23dnUyvkQqmntVCMu3YDru6WaPPiFiDqhuZY+JYPRV?= =?us-ascii?Q?WN96mNgtnDz5yXlpKkLtdW4kDQaMcjOg1+fjXzw/huXN1y5YupFGw8bbfQXz?= =?us-ascii?Q?s9OhAk0OebVx1SomkASPpNglLHv/6c9lf8b3dIsrXXEorxkMQTcKX+u/UhCS?= =?us-ascii?Q?XmofRVRHmJtJrT7A651zoyD+AcQ0cd/2iWuMlaYp+5mISr6V9Lq9haxSxit5?= =?us-ascii?Q?i/7o0ugxsDcGgioZ40+buiYxtLsXZHN5+x2o9KRnICKB/7tsOOEKYnIg9/I9?= =?us-ascii?Q?GiNq/prc68yXxDxYEjQBDRvyxIqdx8PugTnLaC/zjjyastG1gk7/shTiiVN8?= =?us-ascii?Q?vlWS8D2ESqnLMLwApDJcud4n8CuuGG3kf++0eH+kEV92OMaFywOOA+t72Bk7?= =?us-ascii?Q?PxbUxGne073lGc8GQdcDfTtvTUP+EY1S+aBUs/jlGglT6D4HHPCFb6k6wIvP?= =?us-ascii?Q?pIzZjLgdqjYtWFxpaIalRwuRU5ESHGg/JtR+z+T8EqgG/CCkUrO7G9sukJx2?= =?us-ascii?Q?23bDWUM6s+y2m0GcIUQIgN2InrBj1tTBjmRdOTWSGMp0PRRCZi94YkibXyIT?= =?us-ascii?Q?X3BKB8DO08FS/7D/0Q8n6cxHCb96E2Fs3YBbF24kLuIJSDGZsjDaan0qPg2Y?= =?us-ascii?Q?VJc4FWGaFGzCWwIy9gLVuZBgzlTVnrplN/JRjJeqF6alJ7uHoiv2pPSy5uYR?= =?us-ascii?Q?wnn+tXK86w/q7KxL7QJIfw8olvLpR1cai5PKnkP/ehKuwTt0fuLLMab3MnOw?= =?us-ascii?Q?Ky2+q4SNh8TGbgSBsa0luQEs9uu17ht8qruOIP1kj9Tfk0iPNEy0+VwEgwZU?= =?us-ascii?Q?I3Mtjky8Vra1sW6iIBRGs6+RrjENhA2cjnA4Wo97nBINIFD5lEsLPjoxAj1B?= =?us-ascii?Q?Q9fl+/QnfBH0Pb2juF4HkBAP3KOmie2/ZcayczbcOWaFL2WN14UTBCFCNIQv?= =?us-ascii?Q?RHtAk+IcmQ66Fji/FlYXFjzWWZQJTSCKO0MB7cFPRvT8ZNZ/vQPf5QyhUwVk?= =?us-ascii?Q?kUAqPYB5HWah1Wf6cEvQ+CxVUShPLvvBkXouCZdy1ShvzSBzpA1F7v7vaVkF?= =?us-ascii?Q?mTmMn3x/z/AshjM8lUUtzsJ00+AYJPL/j1VQ8CA5DmnWX4swB1nXMTCg46RQ?= =?us-ascii?Q?vVhKlapXgo9K4UWnLfNQLiT6ZfkS/aRSYb3EN5MnAwyvImICSIlhVuDv810f?= =?us-ascii?Q?txp4YaHZmn6yo6seD0My9pTwUPGAyZgLg73IddKPwmkcZ75BqyySqaS4q1Xg?= =?us-ascii?Q?zmlb/4UF6Kjo4Sx4LVIS+9bSbmxicQbRY1SAajY+Edf9r5lcSCOjekRv684V?= =?us-ascii?Q?jZe8BRlphJRmM5lO8FO+OhP4?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2785b478-c4d8-4eaa-d133-08d95866eb62 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 23:15:30.7846 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vCDIiEpPcqlRjERmIWHZ/546ODhER9eETeL7mJEQB3TecvGr1WHoHS/9uf65cLRxTm+ZLqNj/ffMNNzCkgksdsNZUQh/hYaoBO+OyzsPQUU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4787 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Thursday, August 5, 2021 7:57 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-devel] [edk2-platforms][PATCH v1 5/5] > MinPlatformPkg/TestPointCheckLib: Make OutTable parameter optional >=20 > From: Michael Kubacki >=20 > Makes the OutTable parameter in DumpAcpiRsdt() and DumpAcpiXsdt() > optional since the pointer passed can be NULL if the Signature pointer is= also > NULL. >=20 > Can fix a potential failure in TestPointCheckAcpi(). >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA > cpi.c | 32 ++++++++++---------- > 1 file changed, 16 insertions(+), 16 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > Acpi.c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > Acpi.c > index cd8f538f7f3f..3d75e5012a4c 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > Acpi.c > +++ > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh > +++ eckAcpi.c > @@ -477,7 +477,7 @@ DumpAcpiTable ( > ) > { > EFI_ACPI_5_0_FIXED_ACPI_DESCRIPTION_TABLE *Fadt; > - > + > if (Table =3D=3D NULL) { > return ; > } > @@ -535,7 +535,7 @@ CheckAcpiTableResource ( > ) > { > EFI_ACPI_5_0_FIXED_ACPI_DESCRIPTION_TABLE *Fadt; > - > + > if (Table =3D=3D NULL) { > return EFI_INVALID_PARAMETER; > } > @@ -592,7 +592,7 @@ EFI_STATUS > DumpAcpiRsdt ( > IN EFI_ACPI_DESCRIPTION_HEADER *Rsdt, > IN UINT32 *Signature, OPTIONAL > - OUT VOID **OutTable, > + OUT VOID **OutTable, OPTIONAL > IN BOOLEAN DumpPrint, > IN BOOLEAN CheckResource > ) > @@ -610,7 +610,7 @@ DumpAcpiRsdt ( >=20 > if (OutTable !=3D NULL) { > *OutTable =3D NULL; > - } else { > + } else if ((OutTable =3D=3D NULL) && (Signature !=3D NULL)) { > return EFI_INVALID_PARAMETER; > } >=20 > @@ -632,7 +632,7 @@ DumpAcpiRsdt ( > *OutTable =3D Table; > } > } > - > + > if (OutTable !=3D NULL) { > if (*OutTable =3D=3D NULL) { > return EFI_NOT_FOUND; > @@ -646,7 +646,7 @@ EFI_STATUS > DumpAcpiXsdt ( > IN EFI_ACPI_DESCRIPTION_HEADER *Xsdt, > IN UINT32 *Signature, OPTIONAL > - OUT VOID **OutTable, > + OUT VOID **OutTable, OPTIONAL > IN BOOLEAN DumpPrint, > IN BOOLEAN CheckResource > ) > @@ -662,16 +662,16 @@ DumpAcpiXsdt ( > if (Xsdt =3D=3D NULL) { > return EFI_INVALID_PARAMETER; > } > - > + > if (OutTable !=3D NULL) { > *OutTable =3D NULL; > - } else { > + } else if ((OutTable =3D=3D NULL) && (Signature !=3D NULL)) { > return EFI_INVALID_PARAMETER; > } >=20 > ReturnStatus =3D EFI_SUCCESS; > EntryCount =3D (Xsdt->Length - sizeof (EFI_ACPI_DESCRIPTION_HEADER)) / > sizeof(UINT64); > - > + > BasePtr =3D (UINTN)(Xsdt + 1); > for (Index =3D 0; Index < EntryCount; Index ++) { > CopyMem (&EntryPtr, (VOID *)(BasePtr + Index * sizeof(UINT64)), > sizeof(UINT64)); @@ -783,7 +783,7 @@ TestPointCheckAcpi ( > if (Status =3D=3D EFI_NOT_FOUND) { > Status =3D DumpAcpiWithGuid (&gEfiAcpi10TableGuid, NULL, NULL, TRUE, > FALSE); > } > - > + > if (EFI_ERROR(Status)) { > DEBUG ((DEBUG_ERROR, "No ACPI table\n")); > TestPointLibAppendErrorString ( > @@ -796,7 +796,7 @@ TestPointCheckAcpi ( > } >=20 > DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckAcpi - Exit\n")); > - > + > return Status; > } >=20 > @@ -806,9 +806,9 @@ TestPointCheckAcpiGcdResource ( > ) > { > EFI_STATUS Status; > - > + > DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckAcpiGcdResource - > Enter\n")); > - > + > // > // Check the ACPI existence > // > @@ -816,7 +816,7 @@ TestPointCheckAcpiGcdResource ( > if (Status =3D=3D EFI_NOT_FOUND) { > Status =3D DumpAcpiWithGuid (&gEfiAcpi10TableGuid, NULL, NULL, FALSE= , > FALSE); > } > - > + > if (!EFI_ERROR(Status)) { > // > // Then check resource in ACPI and GCD @@ -828,7 +828,7 @@ > TestPointCheckAcpiGcdResource ( > Status =3D DumpAcpiWithGuid (&gEfiAcpi10TableGuid, NULL, NULL, FAL= SE, > TRUE); > } > } > - > + > if (EFI_ERROR(Status)) { > DEBUG ((DEBUG_ERROR, "ACPI table resource not in GCD\n")); > TestPointLibAppendErrorString ( > @@ -840,7 +840,7 @@ TestPointCheckAcpiGcdResource ( > ); > } > DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckAcpiGcdResource - Exit= \n")); > - > + > return Status; > } >=20 > -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#78715): https://edk2.groups.io/g/devel/message/78715 > Mute This Topic: https://groups.io/mt/84686310/1767664 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [nathaniel.l.desimone@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20