* [PATCH] SpcrFeaturePkg: Close the event after first callback.
@ 2021-07-26 7:30 Abdul Lateef Attar
2021-10-11 22:00 ` Nate DeSimone
2021-10-11 22:01 ` Nate DeSimone
0 siblings, 2 replies; 3+ messages in thread
From: Abdul Lateef Attar @ 2021-07-26 7:30 UTC (permalink / raw)
To: devel; +Cc: Abdul Lateef Attar, Isaac Oram, Nate DeSimone, Liming Gao
Adds CloseEvent in callback routine OutOfBandACPITableConstruction(),
to avoid multiple installation of SPCR table.
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
---
.../OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c
index 85ac48cfa5..86c40e90b8 100644
--- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c
+++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c
@@ -368,6 +368,8 @@ OutOfBandACPITableConstruction (
Handle = NULL;
+ gBS->CloseEvent (Event);
+
SavedDevicePath = GetSpcrDevice();
if (SavedDevicePath == NULL) {
return;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] SpcrFeaturePkg: Close the event after first callback.
2021-07-26 7:30 [PATCH] SpcrFeaturePkg: Close the event after first callback Abdul Lateef Attar
@ 2021-10-11 22:00 ` Nate DeSimone
2021-10-11 22:01 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2021-10-11 22:00 UTC (permalink / raw)
To: Abdul Lateef Attar, devel@edk2.groups.io; +Cc: Oram, Isaac W, Liming Gao
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Monday, July 26, 2021 12:30 AM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [PATCH] SpcrFeaturePkg: Close the event after first callback.
>
> Adds CloseEvent in callback routine OutOfBandACPITableConstruction(), to
> avoid multiple installation of SPCR table.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
> .../OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spc
> rAcpi.c
> b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Sp
> crAcpi.c
> index 85ac48cfa5..86c40e90b8 100644
> ---
> a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spc
> rAcpi.c
> +++
> b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Sp
> cr
> +++ Acpi.c
> @@ -368,6 +368,8 @@ OutOfBandACPITableConstruction (
>
> Handle = NULL;
>
> + gBS->CloseEvent (Event);
> +
> SavedDevicePath = GetSpcrDevice();
> if (SavedDevicePath == NULL) {
> return;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SpcrFeaturePkg: Close the event after first callback.
2021-07-26 7:30 [PATCH] SpcrFeaturePkg: Close the event after first callback Abdul Lateef Attar
2021-10-11 22:00 ` Nate DeSimone
@ 2021-10-11 22:01 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2021-10-11 22:01 UTC (permalink / raw)
To: Abdul Lateef Attar, devel@edk2.groups.io; +Cc: Oram, Isaac W, Liming Gao
Pushed: https://github.com/tianocore/edk2-platforms/commit/f539647
> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Monday, July 26, 2021 12:30 AM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [PATCH] SpcrFeaturePkg: Close the event after first callback.
>
> Adds CloseEvent in callback routine OutOfBandACPITableConstruction(), to
> avoid multiple installation of SPCR table.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
> .../OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spc
> rAcpi.c
> b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Sp
> crAcpi.c
> index 85ac48cfa5..86c40e90b8 100644
> ---
> a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spc
> rAcpi.c
> +++
> b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Sp
> cr
> +++ Acpi.c
> @@ -368,6 +368,8 @@ OutOfBandACPITableConstruction (
>
> Handle = NULL;
>
> + gBS->CloseEvent (Event);
> +
> SavedDevicePath = GetSpcrDevice();
> if (SavedDevicePath == NULL) {
> return;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-11 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-26 7:30 [PATCH] SpcrFeaturePkg: Close the event after first callback Abdul Lateef Attar
2021-10-11 22:00 ` Nate DeSimone
2021-10-11 22:01 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox