From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.773.1630200768490290529 for ; Sat, 28 Aug 2021 18:32:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=EabNUqUW; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10090"; a="303706089" X-IronPort-AV: E=Sophos;i="5.84,360,1620716400"; d="scan'208";a="303706089" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2021 18:32:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,360,1620716400"; d="scan'208";a="458526191" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 28 Aug 2021 18:32:47 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sat, 28 Aug 2021 18:32:47 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sat, 28 Aug 2021 18:32:47 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sat, 28 Aug 2021 18:32:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PzvocMtelutNGlp7/nJg+lfuxy4Vd2TZJ5GwmrjcG4x6pJneySX5i1I6ge6QJG1+0EB8QNJjUjVqjoJNmtQpycBIWg+P6Xd58UisL7/45N7eU8uoCso3IRQuGUR5yEMBYuIJcFionzAQty85DyYza7Aj1w6qPgXbNxR0GyFYvPO2WQ+mwIyNnCAsYGh1wDUsh5W79l3G9ONVRyaEYC/Mc8C1b+LKweNpX7G36FoX14VmulbDDryEzv6gfoDfEIh+UkcPcly2fH7sjDabdSeyc29VL+qJfCRpDYEFlvJtdCMyvqLkSgqgwUbqSkjsoJLWIJT5Ii3cPoOqKVUIGpn6Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z9VGWg3LfTmzAt7xaZAp5EoquMgGDZGeRIlVwgMzN3o=; b=J5WxuOzEn22S3oJIcRRB5E11X5hhi45cVGWTnPKLUorHv508gytAYGYEKWwmusyRduwmv8Dt2irk8Nwlloihjb+y81pTkwiVqi3fQi+Rmub5K2cqJ01J1Ox9+DhXjRRsJPbIHCwyZ/recVSy3rDKwgGQmSGfxH38QOOIEXPEGR78v+1nAy+N9I1koeb77FhKh22Em4eTw5jfLN6jfbx75fE4X/UfFlJUKQLiRSAb/gYjBtZIrPQIpy7ehXqN8Y19Hs85lgt2uu3nygZF/RmAjkyiMgNV/JG6teZ+99A7yh23+J5VxqT4ZmnycHNYBocWSEADbPmT9PVHUrUXEOjPOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z9VGWg3LfTmzAt7xaZAp5EoquMgGDZGeRIlVwgMzN3o=; b=EabNUqUWcq4syn9lHkbCM6eZksPBPrn3bY++uiN/3LPKEfKajL5pnOLjEemix0XrMosIp3BhWF1Rzup2u+WfoC2vdaF2etblMhPfi6+qquSrhOjM88sJwTMcxH3Xk8AYZ+omqHmmb2otspreY9tEpnkP1ss7KbjK1c1bp1KpR30= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MW3PR11MB4603.namprd11.prod.outlook.com (2603:10b6:303:5e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Sun, 29 Aug 2021 01:32:46 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::4421:2284:94aa:8d3a]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::4421:2284:94aa:8d3a%3]) with mapi id 15.20.4436.024; Sun, 29 Aug 2021 01:32:46 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "benjamin.doron00@gmail.com" CC: "Dong, Eric" , Liming Gao Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Fix mSetupOptionNumber check Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Fix mSetupOptionNumber check Thread-Index: AQHXnETTOewLAPSWHUCAA/7P8VTr06uJsvmA Date: Sun, 29 Aug 2021 01:32:46 +0000 Message-ID: References: <20210828194205.6083-1-benjamin.doron00@gmail.com> In-Reply-To: <20210828194205.6083-1-benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 91ec934e-c54d-403f-a5b6-08d96a8ce7ab x-ms-traffictypediagnostic: MW3PR11MB4603: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:226; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zmukv4Z7V+LFXkdRING294CvXktppuSE6Dkwc4UuFV/TntReoGwqW8cnadMJS03AMWeLmporrTAIJhp5HcrZkBy43l4Z8yO7TGMk0gh+MPx2V5twRkki7RRhoqKrVFwddPcLvSHcN/fvEZsKdJ1T0nHBEQ4Pogzp+z15/jSru1z2/05MYEj9VOxW/tETMVjBBWi4BR7PoCP7qUt7rtKaZB7X2Qv1IITTecl+eVTXG8CdvmWmG8BHujNlq87IVrK2nq5yuFzBZNY52t9gxRIciNnnoR5IZsqsUKU7nwuonoH5uBz/g+3fVwNrWmVi6TVrg0KFQGiNac5ceFc64EIIPZ/W68MlWjeaY1mUai8x15lc6FkY8Eh8FzgMmk0+4CMkE2Az2ADiO/L9VYTzj3DH2w7XEu2RzAELLLfA1gTdQPtk+HGCewtDOryw1r447QW9Hif3nDH05lc6/u7FCwMgkTJbR/tLLDZ6Ou6YUgE6cGDS12LlmP+E8xkqKo7fXhgTYOJU13s3Zr1DmziVDi+BqRpiJn3jDH89GhSEhISdHQ/Rh+bSJhdUq+j1sdhLeJvrunQjMtY2yWxdjRkAu4CLgYmdhW1c3/+/71RSoAtZBv5+We5LoLSLokFN9umrjHAfergZ9zP7J+EHRFe2hGbOWNmBaE3pDUFH//uXlpot/n4IjKlB7v0umn8aMXWEQwZA0JOZIFv8O18ekX+keJir3fFZbn+quGdsz/uTEC0xckrXiGYSV7Rfs8HgBX71+kHSDsjqqsCpYUGwjoLNVqoP2yN4GU4f85YOzIp/1ruJ8YqPmMns95EE/hY0jljDO2RP4RoKxruFNjYsKYmIoXHVffQGqOCXNGGbp0jVIZ3JU2M= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(366004)(39860400002)(346002)(136003)(76116006)(122000001)(2906002)(66476007)(66556008)(966005)(52536014)(64756008)(66946007)(66446008)(33656002)(83380400001)(316002)(55016002)(4326008)(19627235002)(8936002)(38100700002)(8676002)(5660300002)(38070700005)(110136005)(54906003)(9686003)(53546011)(6506007)(186003)(7696005)(478600001)(26005)(86362001)(71200400001)(145543001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QHf/jKbt06vrw7Cb0PGlgSjsvFwESVlOEIlziUMQQK1lLmlCYA2bxEumJMkB?= =?us-ascii?Q?hQIa6wOK57Dfz3GapC3Xo8ATXAq866ESUD62tanFg30SZD7r3ZNztbuqqVX3?= =?us-ascii?Q?WToZBnv2brOSplqBAC8fp+YTW7hTMbCLYGESLmAfDQAqlZ6UM77UQ195EPZE?= =?us-ascii?Q?mLd8z1UM/hGffKBVachXjGXj1HmOJiJHSqlxIgKWCF8vTKd9JzPF8hStfSPr?= =?us-ascii?Q?INCUIhWMm9Nm0APsHsMFyYZ4dL9Gj8PK9s9wCOLJGRu4Nd+jlyyAfBTVeH2Y?= =?us-ascii?Q?CgWlKTTzex2/BgfwmvNmY4PzneE7yweKyTsQcIjC2CgAHGD0QLR+HAxl2gT5?= =?us-ascii?Q?kOKDrInpusuxVCYcLT9KjEal3KUXiyxVxTo/a3w6nOp+0Muz+mi4BwzYUtC2?= =?us-ascii?Q?X/f1FIfdjx7OT7AXTIYZHAAauRrXhvIWsrphmlhCP3AL7Qoca7HK9Ojj/gAK?= =?us-ascii?Q?TMwyVrAuzHy6O6mxz7orcPNLOZJ8MONDFu1KouldcQy92crm9VeB8K4cR6iY?= =?us-ascii?Q?vD5HHHT30cYV4rX4+c4lQTDutu6RhHMIcwNtqr14o3Ejf6tCHmHu+d4vMoyc?= =?us-ascii?Q?QyOLC12LHwsF7niBilea/Zg3D0EVRynsb076kQ9YDHFVeFzafcOojiqj06T1?= =?us-ascii?Q?0SVFz8WZxdEKtbhHhXXf9pwe8PXPLJLwWkeYS1WVGlH0rYMqyHj2+FRzIHAY?= =?us-ascii?Q?bFr6jEynno8wsGO8f7Rp7o5q2BFyRdDi1Z84WfXjZt+FvxjOvDQ5hRdbBO1T?= =?us-ascii?Q?kn6MoNnbKW1qS9gXiRZ1rGB7ThFkgtxZsHf1nyvykWK32mOHC/Nl6YISpPjO?= =?us-ascii?Q?eHSjI9K84Usfw7YRtm7dPZ4NUAkPWXADlux/v4mMJ5k+HyVhNVNek7khAFQE?= =?us-ascii?Q?R2Qr65+mGTWWqdZtXGp/xEa4nD7su6tmUBMTH4sXJc2ny5W8mFhEIprPg6+b?= =?us-ascii?Q?K/MMv0WiiYssOPbeh3l3XuphdGH1IpPhJvL+9bHWETLd6hmCfKqS/3UmIYW5?= =?us-ascii?Q?8FeAXZr9Cjl0Oz5CDHGPgNjy6SgWwUpSh73suz29Bc01usrmXI4W72WKmSBL?= =?us-ascii?Q?8ocjtDSWAHOPfflerCVKgzj9Re1VI+kOwaXWrlJi8fqZ2f5n7otNVbun9Z3x?= =?us-ascii?Q?taAqpJuJsW/wQcYw+2HEQf9/Xxf+J9lyhiky1cr5okPvgWE6oAcF1Mks8uVv?= =?us-ascii?Q?Fc5YjI1J7i5RXNtPaR0qKIZpzz+MrR0YX6jSOTGIWg82sw5qZTK+06VsMEfZ?= =?us-ascii?Q?ZIpeeRoO4ZAKVH6d94gCGrhwb8oBNKJpYTKBntsu54c6JZF8ZH/pXIiye8iG?= =?us-ascii?Q?JAfJgZKxLkur8mdDcCKdmnvB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91ec934e-c54d-403f-a5b6-08d96a8ce7ab X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2021 01:32:46.2488 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LojW0HTtanJtkJaNhZk0swhfVq2AcQhISqtDLBgWhVvZLerJsLJsdgPYEiiINOBRK3tlo6+cTM8HEk6p7vpomcEcxJqb6TECGh1XmbH8Pio= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4603 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/4060974 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Benjamin Dor= on Sent: Saturday, August 28, 2021 12:42 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Liming Gao = ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHoo= kLib: Fix mSetupOptionNumber check If CreateFvBootOption() fails, RegisterFvBootOption() will return LoadOptio= nNumberUnassigned, which is non-zero. Therefore, correct the check when att= empting to register hotkeys, to be able to detect if UiApp is not present. Cc: Eric Dong Cc: Liming Gao Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c | = 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBoo= tOption.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBoot= Option.c index a07abb214913..1fd0de3961cc 100644 --- a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption= .c +++ b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOpt +++ ion.c @@ -440,7 +440,7 @@ RegisterStaticHotkey ( // // [F2]/[F7] //- if (mSetupOptionNumber) {+ if (mSetupOptionNum= ber !=3D LoadOptionNumberUnassigned) { F2.Key.ScanCode =3D SCAN_F2; = F2.Key.UnicodeChar =3D CHAR_NULL; F2.KeyState.KeyShiftState =3D EFI= _SHIFT_STATE_VALID;--=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79914): https://edk2.groups.io/g/devel/message/79914 Mute This Topic: https://groups.io/mt/85215635/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@int= el.com] -=3D-=3D-=3D-=3D-=3D-=3D