From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.3301.1628653697396979607 for ; Tue, 10 Aug 2021 20:48:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=L4xrWAbg; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="237063883" X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="237063883" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 20:48:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="484661512" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 10 Aug 2021 20:48:16 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 10 Aug 2021 20:48:16 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 10 Aug 2021 20:48:16 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 10 Aug 2021 20:48:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L8WjWOBZmRw0Tn/uBiUd28OZh7IaztlLqh135KJLRVa8Yc4zqh0GVylNIoQWjGmOsESnECCLpURiDdzqtDTn5vNGCly/8EG5U6He4Zrj7ykHSOx/rkbb5sL0wMQgf4SgceN1KRruMuX63bjubcVPHmCHMk0ULp9CWlYNQUtUZy/8Q2c44uwLS2yE4PkFyvTVlpFTHqNmjWTlL+dvIJokMoUCv3AeJ/FQ8vCzMol7dWeBZuKk9wmcaalqtaTcA6mnOkPovyu4LMkm2okGXNO5YJk/7RiBzgjhVttymLVTkXwMPrkRTgSOF4YrYQrL3qZ9oY7N0VpqGjw89jNB2s551Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duFsTnGm5J1Oqp8NWq6QI7RRTsBtZX06Sz5eW8GpCL4=; b=SoOQHJmJ3tZWSMlpUJ9loTqFbiDR5hjLxRldECp4fp8wdK2NSQ7ZgptpPort7AZW7tYb4eMG+AIwNb6lwrqIEkuxL/4JS9/GttN7Ix4BAumKg81C5aUPRl2V8GBzhPHakc8XYtqDvB445tZ+2PqBdAv51N1JBJRAFGe8cUU4J3WlfqzVE0TXErZBi7zp98QicN46+UmJk2w9E+GLZkBhUGVnurmthNQ/BSPZ8JfAIWJ9xFewh1Kbv2sh5ly1AeUrFJd/4Se7VVOVXh4B8Wf4laAeJ2kELx/cpAvv+pq0FKKap93KIxEHzewD3w/S6CksYEmeWJhWFs2oeiuujVXwfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=duFsTnGm5J1Oqp8NWq6QI7RRTsBtZX06Sz5eW8GpCL4=; b=L4xrWAbg65I2NDjZj5dC5VTh2/khnvQsrHleM3R+Dn39wFZSFq+70OWd7DBWcG3y1bQK0ZLukeXgGw/BG1iCUPKuwnT2G+PXA2kTKCnSIqAw1D4lUDrUA9F9Q97Gv50HUZW4HTDXp7D0gYkEgz3ZxjjwfJrrRyLV4+nQxBoE+Dk= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB5057.namprd11.prod.outlook.com (2603:10b6:303:6c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.23; Wed, 11 Aug 2021 03:48:14 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4415.014; Wed, 11 Aug 2021 03:48:14 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: Michael Kubacki , Benjamin Doron Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS Thread-Index: AQHXjjqCAnkwC+4xxkyYDQJRxrTXEqtti6PwgAALU6CAABPOUA== Date: Wed, 11 Aug 2021 03:48:14 +0000 Message-ID: References: <20210810225309.27112-1-nathaniel.l.desimone@intel.com> <169A1DCEF9C635BF.17558@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: be0e6252-83ec-46ab-6cd6-08d95c7ad8d7 x-ms-traffictypediagnostic: CO1PR11MB5057: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JpPcWC1lkCYaMeIl+q2B9tv1jrsGva1Kt8W76+fZ2YAve0Mes3H1jXMfwzhjCfz3idKygXE0XpyveFa+4oiE/rBtR9MWfFul0SFkpgaKBUN6QSgloW11GEW9h0ugqEYiqZhbJvqvE7WMPAD5NptWaKC1DAnLPMZgQ/nbrWiocmDv2aLIxeRNj9lny9O7ZwXtwOD0274XeYQpNd7P3jeeMxrccVVQ2cNaIatxo5HQ/+fBUN/24AHKScsBQS6IQCJfy4Qkhs61O9M881ne1diOaoQRqryJcSFsob0SW59fz1+EqSBKvh/bUonNX2/OcRVZRwaqAG7YwjFLksZsH8gsMfC52k7Ld+UyUFpZ2ccbt3zBxlc6cfv70ne21hefWkAu1hYxHC7/h96A/xanCx1SAyu1jum/C95uCBlIcMjui8pvZkyTZWMtiPDckhGUauTZb/9FRXRhl7Zx9CiKuBCRb6UQvolYT+U58isXZWvj1HEmH14nQEMIT+AU4WyWNjAgnnMSwxfMR80J58AhF/ouxi6dYoOK6w/N4s7o/luWNoPgbUJERK4vUWQC5vFaaPytCetZKCh+7TH0f+a40oj+53EBgng2fxd39+9EZWzTvELoPs/YSrfsyDXRUTWN3tyQ22KuC5opct0RnCUYLRxN22Ak2JtZnmLSrG21RqpvZo32G9CmBCQndrng+K5T/QKmrdnwBWIi49cFi60OY67WEglF+2VB4Fz/XrCddR1P3fUgWZnBZ2KFZ1Fwh9LqCENMMhkI8ZcnpHpwZtsPXGdRD62aTQbfhzvMy+XHHUiw+WjUOgjJd9gR3+ZSNXHlpyT8j9Py1np/Hxpk4q951wge1w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(316002)(33656002)(8676002)(38100700002)(83380400001)(186003)(966005)(55016002)(5660300002)(9686003)(71200400001)(66446008)(66946007)(110136005)(7696005)(64756008)(66556008)(478600001)(19627235002)(52536014)(66476007)(26005)(38070700005)(54906003)(4326008)(2906002)(53546011)(122000001)(6506007)(8936002)(76116006)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W8Uwiy94B9riuTq/vAhnD48xmgMPBVNVt75qqa6oExgUSBoRZcYqk2zKJHbl?= =?us-ascii?Q?Z36wQ76pgbRBmC7N5t0rHhc0YGokHB7Bv2SJgOHD1QO1725BnDM9RiErvxYx?= =?us-ascii?Q?EnnDXia7+k3uw4U1R65Rjg3EFBgwavOEKXcL1JuiUVKenlP8VjLuKDje+nP/?= =?us-ascii?Q?4M3YdstDpRtG13rnEocjO8cNDfCD4qZkxzgGeA5EK0DdzMhFlFZ/flvarUy/?= =?us-ascii?Q?SoOUOjV0J/hMTfYDIFY5cSnN/X5cODDdphlGYstMbkGZ1tXY1u1gALC1poOO?= =?us-ascii?Q?4aeCMQqZiXvbr4VJG9pOYru6cX59lGCLYANTKXkN52Ekij+Kw+ldZvARUc9q?= =?us-ascii?Q?N5PwMBv761jCiHZxwF8YTteU6zkmZ0AOJE/hgXy6fISUc6V9i4AY6xmOrGGF?= =?us-ascii?Q?xnHV242M9h7seMGNnF3OL2lotis62FQ8mARYYlDG9XVedGi3YKbql91Iiw7L?= =?us-ascii?Q?br8ZNFyFIMu3fzdp3zzaWO2YkBSMh4rQ2CAvqlhaoVGPSNZknv4eVZ4qrVz8?= =?us-ascii?Q?JH2Vnc98Az8ZXD4scMg8tRWduDff+QSU9jXI304EFjamL/gfQ7PBoMLsxhUa?= =?us-ascii?Q?aFAtMc15z58Ch0byaCKdFvpC838FS+T6xExMeuMpbNyDQXWhvdfUiS7SL9hV?= =?us-ascii?Q?XBn8Lgt8ONaxtdvStK7nSzjvdn1so6CpfBnDJvOr78aIHS7bK3wc27GKFHLn?= =?us-ascii?Q?OBuIg8225k7FYVPVLVw7JVc7keVevTP5I8i9LCuXk+fXE6LgpwnDRFuyJNNw?= =?us-ascii?Q?uPbKUnQEEZcbIeLCszfFKmCa7R4wJmbSz7UvBBlSlweMHmXwKBSD8jr0Mo7S?= =?us-ascii?Q?KNynwryQewFeJsTfEMh+07QlRs1qWc/LwNskwWeJz/xk4veCJkYs5dtRtd4Z?= =?us-ascii?Q?NiX0auLrBK0EQjph//rxjJNm0F11YEnrmTtfQMV/svwQvJ1A8Yujsum+P4Ax?= =?us-ascii?Q?SsbJYjYqAGsedzsjvrapC+a4dD0qxUsIal4+I1ejY5gziCLi0rg8ScjzmWlW?= =?us-ascii?Q?TfPx/jo9E4LzsTACOxI9Dz5rY/eUD9o2/pRR7XuVXovsN8x/7CQNnLppx+md?= =?us-ascii?Q?5Mz+Xl9RGdzlJv+T0+Oopcp+U5d6vR3ygGpVSEMCdeJ/hrtfnRwWgJ/7W9+I?= =?us-ascii?Q?dNcbzjoy+E7NElPoVSOS8w3pggrpA3gqBGIII19sjix1EJP3FYHq1E3bwAPo?= =?us-ascii?Q?300LzYVlLprHrG7fvlduIv+D8EQ+cweVhReZBx0c2QN5kR05qzx83Ztso/Cn?= =?us-ascii?Q?D+NKZnX2OsiDlgpy7QDL1X48IUBfEph2YK6sGT7thZ5EDY3Ya9TcCl6H/RkO?= =?us-ascii?Q?N/epEQut91f549AZhRnX7as1?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be0e6252-83ec-46ab-6cd6-08d95c7ad8d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2021 03:48:14.1818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0LjV/hf5aiWXaSglDoV3Fq8c1ZoBRWObuONP0AzdfOC4tapVoafYy3NpCqS1EEQ1tkNWfecZgbv3+SPkvaP7vX9dV0LXvKdzAPypydAlyzU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5057 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you for letting me know Chasel, please see PATCH V2 for the fix. Thanks, Nate -----Original Message----- From: Chiu, Chasel =20 Sent: Tuesday, August 10, 2021 8:25 PM To: devel@edk2.groups.io; Chiu, Chasel ; Desimone, N= athaniel L Cc: Michael Kubacki ; Benjamin Doron Subject: RE: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg:= Add MMIO Base/Length to SA GNVS Hi Nate, Internal test case failed, please see below inline for comments. Thanks, Chasel > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu,=20 > Chasel > Sent: Wednesday, August 11, 2021 9:56 AM > To: Desimone, Nathaniel L ;=20 > devel@edk2.groups.io > Cc: Michael Kubacki ; Benjamin Doron=20 > > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1] > KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS >=20 >=20 > Reviewed-by: Chasel Chiu >=20 > > -----Original Message----- > > From: Desimone, Nathaniel L > > Sent: Wednesday, August 11, 2021 6:53 AM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Michael Kubacki=20 > > ; Benjamin Doron=20 > > > > Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO=20 > > Base/Length to SA GNVS > > > > The SA GNVS Area contains fields for the MMIO region base address=20 > > and length. This implements code to populate those fields. The MMIO=20 > > Base/Length are used by ASL at runtime and must be populated for=20 > > normal system operation. > > > > Cc: Chasel Chiu > > Cc: Michael Kubacki > > Cc: Benjamin Doron > > Signed-off-by: Nate DeSimone > > --- > > .../Acpi/BoardAcpiDxe/AcpiGnvsInit.c | 57 ++++++++++++++++++- > > .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 12 +++- > > 2 files changed, 63 insertions(+), 6 deletions(-) > > > > diff --git > > > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit.c > > > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit. > > c > > index 0d9d217e38..b09b92f2e6 100644 > > --- > > > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit.c > > +++ > > > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit > > +++ .c > > @@ -1,7 +1,7 @@ > > /** @file > > Acpi Gnvs Init Library. > > > > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> > +Copyright (c) 2017 - 2021, Intel Corporation. All rights=20 > > +reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -11,11 +11,51 @@ SPDX-License-Identifier: BSD-2-Clause-Patent=20 > > #include #include #include=20 > > > > +#include > > #include > > > > #include > > #include #include=20 > > > > +#include > > + > > +/** > > + A protocol callback which updates MMIO Base and Length in SA GNVS=20 > > +area > > + > > + @param[in] Event - The triggered event. > > + @param[in] Context - Context for this event. > > + > > +**/ > > +VOID > > +UpdateSaGnvsForMmioResourceBaseLength ( > > + IN EFI_EVENT Event, > > + IN VOID *Context > > + ) Should we add EFIAPI to this function? > > +{ > > + EFI_STATUS Status; > > + SYSTEM_AGENT_GLOBAL_NVS_AREA_PROTOCOL > > *SaGlobalNvsAreaProtocol; > > + > > + Status =3D gBS->LocateProtocol (&gSaGlobalNvsAreaProtocolGuid,=20 > > + NULL, (VOID **) &SaGlobalNvsAreaProtocol); if (Status !=3D EFI_SUCCE= SS) { > > + return; > > + } > > + gBS->CloseEvent (Event); > > + > > + // > > + // Configure MMIO Base/Length. This logic is only valid for=20 > > + platforms that > > use PciHostBridgeLibSimple. > > + // > > + DEBUG ((DEBUG_INFO, "[BoardAcpiDxe] Update SA GNVS Area.\n")); > > + SaGlobalNvsAreaProtocol->Area->Mmio32Base =3D PcdGet32=20 > > +(PcdPciReservedMemBase); > > + if (PcdGet32 (PcdPciReservedMemLimit) !=3D 0) { > > + SaGlobalNvsAreaProtocol->Area->Mmio32Length =3D PcdGet32 > > +(PcdPciReservedMemLimit) - PcdGet32 (PcdPciReservedMemBase) + 1; > > + } else { > > + SaGlobalNvsAreaProtocol->Area->Mmio32Length =3D ((UINT32)=20 > > +PcdGet64 > > +(PcdPciExpressBaseAddress)) - PcdGet32 (PcdPciReservedMemBase); > > + } > > + if (PcdGet64 (PcdPciReservedMemAbove4GBLimit) > PcdGet64 > > (PcdPciReservedMemAbove4GBBase)) { > > + SaGlobalNvsAreaProtocol->Area->Mmio64Base =3D PcdGet64 > > (PcdPciReservedMemAbove4GBBase); > > + SaGlobalNvsAreaProtocol->Area->Mmio64Length =3D PcdGet64 > > +(PcdPciReservedMemAbove4GBLimit) - PcdGet64 > > +(PcdPciReservedMemAbove4GBBase) + 1; > > + } > > +} > > > > /** > > @brief > > @@ -39,6 +79,7 @@ AcpiGnvsInit ( > > EFI_MP_SERVICES_PROTOCOL *MpService; > > UINTN NumberOfCPUs; > > UINTN NumberOfEnabledCPUs; > > + VOID *SaGlobalNvsRegistration; > > > > Pages =3D EFI_SIZE_TO_PAGES (sizeof (EFI_GLOBAL_NVS_AREA)); > > Address =3D 0xffffffff; // allocate address below 4G. > > @@ -53,7 +94,7 @@ AcpiGnvsInit ( > > if (EFI_ERROR(Status)) { > > return Status; > > } > > - > > + > > // > > // Locate the MP services protocol > > // Find the MP Protocol. This is an MP platform, so MP protocol=20 > > must be there. > > @@ -90,6 +131,16 @@ AcpiGnvsInit ( > > GNVS->Area->PL1LimitCS =3D 0; > > GNVS->Area->PL1LimitCSValue =3D 4500; > > > > + // > > + // Update SA GNVS with MMIO Base/Length //=20 > > + EfiCreateProtocolNotifyEvent ( > > + &gSaGlobalNvsAreaProtocolGuid, > > + TPL_CALLBACK, > > + UpdateSaGnvsForMmioResourceBaseLength, > > + NULL, > > + &SaGlobalNvsRegistration > > + ); The build failure is here, please help to fix it: /edk2-platforms/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiG= nvsInit.c:140:5: error: passing argument 3 of 'EfiCreateProtocolNotifyEvent= ' from incompatible pointer type [-Werror=3Dincompatible-pointer-types]/edk= 2-platforms/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsI= nit.c:14:0: /edk2/MdePkg/Include/Library/UefiLib.h:168:1: note: expected 'EFI_EVENT_NOT= IFY' but argument is of type 'void (*)(void *, void *)' EfiCreateProtocolNotifyEvent( > > + > > return EFI_SUCCESS; > > } > > - > > diff --git > > > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > > .inf > > > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > > .inf > > index 7d2e105e54..5d3d4c3a2b 100644 > > --- > > > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > > .inf > > +++ > > > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > > +++ .inf > > @@ -1,7 +1,7 @@ > > ### @file > > # Component information file for AcpiPlatform module # -#=20 > > Copyright > > (c) > > 2017 - 2019, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2017 - 2021, Intel Corporation. All rights=20 > > +reserved.
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -38,6 +38,7 @@ > > PcdLib > > UefiBootServicesTableLib > > UefiRuntimeServicesTableLib > > + UefiLib > > BaseMemoryLib > > HobLib > > AslUpdateLib > > @@ -48,8 +49,15 @@ > > gEfiFirmwareVolume2ProtocolGuid ## CONSUMES > > gEfiMpServiceProtocolGuid ## CONSUMES > > gEfiGlobalNvsAreaProtocolGuid > > + gSaGlobalNvsAreaProtocolGuid ## CONSUMES > > > > [Pcd] > > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase > > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit > > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemAbove4GBBase > > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemAbove4GBLimit > > + > > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiGnvsAddress > > > > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiSleepState > > @@ -65,5 +73,3 @@ > > gEfiPciRootBridgeIoProtocolGuid AND > > gEfiVariableArchProtocolGuid AND > > gEfiVariableWriteArchProtocolGuid > > - > > - > > -- > > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20