From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.3329.1634259220598705539 for ; Thu, 14 Oct 2021 17:53:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lFhVp4Z4; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="291306669" X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="291306669" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 17:53:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="487647038" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 14 Oct 2021 17:53:39 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 17:53:39 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 17:53:39 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 17:53:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nLFkWGWmz0i1rPC85b+b8Odp033xL7E+qt9PaGHLyYdB4fwQeD388znhB4JFeKDe87/Fe8nj03udo8Ic9lPqc0VUdMr0PpvoIiKVDF2vXs6SeM7Jj7KbTHF2h2klVwy77E2uNpeA81YfqoXX9wtmzI62XWRfTRCSxBW847xkpD0LCiPJf+McGgEf8gxaFjW7Cu+AJiZT6bIk+mNxFQETgTzrQ7zN+n6T0DN1K9n0GwwTQ9JMOM+bvxJB1h0LY51GY/MAGiNgDWLyTkb/sH8Y10sm30WmkqOy222Zos/BG8qVKSeFrLzE2ip8U3Re5mQ/uo83aM20coaDuMdd4x5PAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5+imK5C8Ll8h0PbSR84iToksxgOAULd2m5DT7ypO04Y=; b=DWo8QcGI88OqMEmEhD4PDrg4d/3JGjnukqvPFmF6/eTvNI76vPTs2w8kP+6uVdG5n2T4qBORLHLOjvTi+dJdPjU/wW0bvcnHELHMz2ZecrUnilYgvcEfqz3hz2Jl8MphOrqGvT1sjMR8Be4GCI4B3o0+p9DbArLP51nQZLbp0E2aRsPlPQ0xUPniHW8cdSKGBxzjKxBeI5+JOEQ0s13welcRJJlGWGeVnFgokv4ws6+c+O9f2GQwVESBsXRPtuN9H3JZmChQHJOE0+FBDyZ9Ig280TLv17noxUfipjxmLmTIGxCgxrRBqwkudc//AeT9cEKstZF61eRLVFWaS2FY6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5+imK5C8Ll8h0PbSR84iToksxgOAULd2m5DT7ypO04Y=; b=lFhVp4Z4Sf9aZuwzkzutBOEGI1IIpfONtOWPHBp+bUKM+Hi3WsFAjOBqykef7NY/J+zP3kv7BtikLuOjowEY607JFDD8kXVFevI3oDXzJ1lrIcPSU7YA+mGOcRsz4QSE7Y+gUvqJZHcP/EuarapoJMyH/2QRXA8w+M/B/IZib64= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1760.namprd11.prod.outlook.com (2603:10b6:300:10e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 15 Oct 2021 00:53:36 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed%11]) with mapi id 15.20.4587.030; Fri, 15 Oct 2021 00:53:36 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "KARPAGAVINAYAGAM, MANICKAVASAKAM" CC: "Oram, Isaac W" , "Felixp@ami.com" , "DOPPALAPUDI, HARIKRISHNA" , "Jha, Manish" , "Bobroff, Zachary" Subject: Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro Thread-Topic: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro Thread-Index: AQHXwUsLUHvwBcPWyU+4enaG0or3S6vTO45Q Date: Fri, 15 Oct 2021 00:53:36 +0000 Message-ID: References: <20211014222952.1651-1-manickavasakamk@ami.com> In-Reply-To: <20211014222952.1651-1-manickavasakamk@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 51680ec2-0963-483d-1e76-08d98f76387b x-ms-traffictypediagnostic: MWHPR11MB1760: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:475; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jXfH+p2nHmfe6T+t1npHMTjtGi9cSx7GvYdhNoL7Q1ysPEuezTfPjyuXqLWx6NuewnaICbeEy1skz/fdCojUKptuxzD9wBBEIWlY3iZQdXpc2AXNvFx62gei/H1RLWZ+X6YL3XmxJPBMReMAYwuUED+MYCpUQkFCOvCaA2/vxjCK5Tw8yn8fte9/8+m8Es/cf6lgI7c1+pawN5P7k0VlHVLhwzhs1lbs5g/Y88Yb5fWJtkH2WtsnMw8Zn0HOGuZflOmYeOQgYNqbbPZV9FZ5VPcfmR2s6RzMqB2Escpn2r8xtPnqIcIZqnsjxBnbyaZXA051ZSJJUCF8LYCYEUGqih9IBO9q2NdLYEsedUNGKJnLke/hbZTlW2HjNqRC9J0S5GgWCEfxnOIwupOY6Mr3naumyvXjwSjDEzhwLnyXB64NGJG9H+sF7l4WDPPtdyYBV3ESCv75aGkf6iczPalOy2uGtWYfXWuYVJ9KQ+VcyE9FlsberICe88zBkT0i+IaV0TsoT9Ww2s2JLFDv+bVoGcnrGFtD9kh9VA96ASlTFG2Zg0Y2vm157Cjs2R6iiwkyazdDpsXyyyBBeRoWrHBnGfkweN8LzoE3jXPBks+cfBPePfNf3h05Xb9CTSh56Y9PKIfMHaHoPA5i2R4r2YurSIWlQ06GL8buVGBceirw6y/jIlhBIvDXS9IA7fv7ykaTFt2HB6aUNLoOy9+Gf/qbBuwfsuAP6qx+Dr1AcMDeBGx5eiatCpJJQcaTbCXLsuDHeE1Xpk3liW7xu8cIvII9qXccH1mccCiDwKLFpjH/NoFW/zDCjp6UHxys6Wodlw5HrafsJ3+OIFvoKirY/R2yXQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(40140700001)(38100700002)(33656002)(38070700005)(86362001)(82960400001)(52536014)(110136005)(64756008)(4326008)(55016002)(2906002)(54906003)(9686003)(7696005)(53546011)(66556008)(66476007)(5660300002)(26005)(316002)(66446008)(508600001)(71200400001)(966005)(8676002)(6506007)(186003)(83380400001)(76116006)(66946007)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R1A6o6FdQogpDSV+NYpCB/mML6XHgBX3o4eKJCo099KEx72UzRhEUw5KLb1f?= =?us-ascii?Q?LyaOHyIi9PN+jGEFvsy5XU8O/gXxZlGnOThdGRK4XR63uRsaX5urx/aWCFhc?= =?us-ascii?Q?CP+jCHTpi2Exm4uj+Je8H1pS7ELBYLseBA07MFRSZ7n+/jhy+W2vy95lalRG?= =?us-ascii?Q?8jkh6E2WyKLhyYfpjhWVaSuShj3BV333/B8UK86nOmQmql245vk8IomaQ/mE?= =?us-ascii?Q?hg9PAJW/Ba/+a6U4WIW79shbGApP4h5SGs0mnHdDLBukjflFMNdhEznZ1YAs?= =?us-ascii?Q?fVoktRS8TJPUocO7ELfCTBUbM+Q+0BBDMcaHOk/v1ikex7bJ8pWbI5Sb13cj?= =?us-ascii?Q?QPbBRqTTRSnPhRwvGOEQs+kPuiq+OAaObVMvho+HHmUAAAeYaFw7knkCD1Hg?= =?us-ascii?Q?+wGOGZPmZDvRB1FEGEZIHHTVo4RN+I446P9qlwSl7eqCmgONSGrrq0Jdx+3x?= =?us-ascii?Q?vgGLUWiYiaT0yFMssa3lqzd71x8mxVyQWevJ7SsTAhAZ7Qq8/MY0F0DpKbSn?= =?us-ascii?Q?mede1SxH+kB3BhjE6TwD8LUZVNEkFwzXR9jridIMz1i4/BqP3oUf2aXXO6E8?= =?us-ascii?Q?SsTjrxycZqQbuDSCj+CmwTDmfv99964f/DoYDd3AVdUYqtxP4A+vqCRco5Bw?= =?us-ascii?Q?ofRT/dl/xgOWXfgN+2xJvpLK/Yuro7rybM8Prdw0xHHTDWEcwWtqiMg0ryMU?= =?us-ascii?Q?J06L8XNgNQJC+QQBFgAxZvRbmahyBhc5sSiFC6mJmJKgAzSX7g367zE2WWNi?= =?us-ascii?Q?DEk39JVkkdzadF1Sa/Sehl7Srf/LFFZRwIyvG2M0fp55/cs63TMY9zrwTk4H?= =?us-ascii?Q?N6Tltg3VcVpRCKy62Nl45UlCVbUweFMjX+lPtW0s3jeLpixTD6QmrR7FghLI?= =?us-ascii?Q?XTgoyje/aM0+SSJrIqQVYnlSXlIwdOFPbKUFAbY4zzptTkSy3KONoD+xhcye?= =?us-ascii?Q?wEXHqxusn9MKL5YKPA6CapESaIvlI3dbM0WPIuSexY1G9rYD6/6Te3Bq7sS9?= =?us-ascii?Q?gq9UY5s+zMERqbkOYFHtKBdyi0q0VMpLTk+j8zowr7YFBrCZYzmhwT9EMV1k?= =?us-ascii?Q?E2a1bJqVU8Si6m4omdz7sh3kG/58VehPMWRHU2hHkKFD+M7fInUyMhdaeOmN?= =?us-ascii?Q?TVP7fBqKw6sSmGsX28hyMNAl6FV0uSqDgCfKa+faz6PtCEop5AWV+Z8Npjkm?= =?us-ascii?Q?m6C8XHZPAkNQ6dCAuSwdwojzXao190CgeLo1y8k0BKA5lD0KhZf1s17mVQ84?= =?us-ascii?Q?V+5CEQKMu9w5Cg4hZ14eaHp2x7YCxKWMyGdCphAlYENwGqX/SgzglbJEKTIG?= =?us-ascii?Q?iEzZ8vkQMttQSuYlgJTpgivT?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51680ec2-0963-483d-1e76-08d98f76387b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 00:53:36.4172 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jvT+Kq6RfVty/eF5GT7Ac75L4CmRDhx1ls9dVEtf8yzr/l4m77Y+y98eZHLM/Ud2XZA2hfe6kO4uuJ7gSlCpyLUDJAfiUwE9pALkZgX1wd0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1760 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/86916cb > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > manickavasakam karpagavinayagam via groups.io > Sent: Thursday, October 14, 2021 3:30 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; Felixp@ami.com; DOPPALAPUDI, > HARIKRISHNA ; Jha, Manish ; > Bobroff, Zachary ; KARPAGAVINAYAGAM, > MANICKAVASAKAM > Subject: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for > WilsonCitySMT OS boot issue & using proper ASSERT macro >=20 > Fix to resolve the OS boot issue when booting on WilsonCitySMT board. > ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status > code and not with TRUE or FALSE. > Replaced ASSERT_EFI_ERROR with ASSERT. >=20 > Signed-off-by: Manickavasakam Karpagavinayagam > > --- > Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c | > 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) >=20 > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > index d8274fa7ad..212103f483 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > +++ > b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > @@ -68,6 +68,16 @@ BoardInitDxeDriverEntry ( > ASSERT_EFI_ERROR (Status); >=20 > break; >=20 >=20 >=20 > + case TypeWilsonCitySMT: >=20 > + Status =3D gBS->InstallProtocolInterface( >=20 > + &Handle, >=20 > + &gEfiPlatformTypeWilsonCitySMTProtocolGuid, >=20 > + EFI_NATIVE_INTERFACE, >=20 > + NULL >=20 > + ); >=20 > + ASSERT_EFI_ERROR(Status); >=20 > + break; >=20 > + >=20 > case TypeCooperCityRP: >=20 > Status =3D gBS->InstallProtocolInterface ( >=20 > &Handle, >=20 > @@ -80,7 +90,7 @@ BoardInitDxeDriverEntry ( >=20 >=20 > default: >=20 > // CAN'T GO TO HERE. >=20 > - ASSERT_EFI_ERROR (FALSE); >=20 > + ASSERT (FALSE); >=20 > } >=20 >=20 >=20 > return Status; >=20 > -- > 2.25.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. >=20 >=20 >=20 >=20