From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.1473.1630456945006833471 for ; Tue, 31 Aug 2021 17:42:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lzPBBxcZ; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10093"; a="240865049" X-IronPort-AV: E=Sophos;i="5.84,368,1620716400"; d="scan'208";a="240865049" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2021 17:42:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,368,1620716400"; d="scan'208";a="531417372" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 31 Aug 2021 17:42:10 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 31 Aug 2021 17:42:10 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 31 Aug 2021 17:42:09 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 31 Aug 2021 17:42:09 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 31 Aug 2021 17:42:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GljDKgZNbo64ZsmM5OSPb3B8QCfXSC6H0W0XnYsrli4CwbKlTOj5ZIhxFHCsi4EXv28W61bDIfHeLVVEd/6Q5Cnj6KLO0TGiyWYshZU6c5KbBQFUQkf2CMadmaIOpdRuatBfJPsY60dPYpe1PcBbbEAcTChuVYNgMLPXqv1aQKtQHCq+CZ4VwhbdqzvK+PrTOoIrxqvVrgf4ccP3vWyKlsrN+/8bc1PxCvMTLe6DfbuP46wMylL6Cpsg94S+uFbkCfu5WUrSAljefBNC8iRrDTgmncuXeUAyTJGM4+J6PHOw0WGr2a/qHJ9R4hI6FG+5JccJ9/gmBP+MTi40rurHIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/EjsjEkIQA1eAIM7PMEBeI7fAVkPP/CljRLPe2jrEls=; b=U8VZfoGAwzdLWSAqUtPBANU0n/16Sh7oVfJb8oH4cZFDyxCq5LZFQsCm6KOK5ZgcMEY/ctB9pOGBvgAQ0eldgfV47+HXO/y5CFPTI5iDZ8Cg9XuruK2ZzOKs9lMPKbAJwSXpjVl5hgg3/yg4mNsfSI+JV5QnCS+udE02qJs+XE+qfneUyWopmCLCSLhXYk40p3qDaisPwB/vHbmg7BucD1LcE8dK2NKtQDOwYFMvORgmFxcfF8MExgubc6SjPg7AEoCweF02ez1Aov0HkeUTYmN+4JCU7dl88RVsDwNWX28QZqMbYsm8/I5xPnSC8NS+regxMudYYgHPGA6m/9vQOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/EjsjEkIQA1eAIM7PMEBeI7fAVkPP/CljRLPe2jrEls=; b=lzPBBxcZqNRSIFUW6qbK5Iayjx0rfvb7veyrKqn/jIVtpphoEsQs4WXqFWWdaxpH/YcOfGCab0d5d/z/RarFY7cjHbP2dTfgpg1hN0V1hRCQi9qSkVhPD70XbZxduM9+fGvT13S2XWwAhcnX+vOnZOhNlI34TY2oGdvLkgGl8Ac= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MW3PR11MB4729.namprd11.prod.outlook.com (2603:10b6:303:5d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Wed, 1 Sep 2021 00:42:08 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed%11]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 00:42:08 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Desimone, Nathaniel L" CC: "Chiu, Chasel" , Michael Kubacki , Benjamin Doron Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Document EcLib return value Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Document EcLib return value Thread-Index: AQHXmi5Nzu1LswwyxUCdK/5U4OBek6uOX/7A Date: Wed, 1 Sep 2021 00:42:08 +0000 Message-ID: References: <169EBF06ABFC78AA.6361@groups.io> In-Reply-To: <169EBF06ABFC78AA.6361@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3d89213d-ffd8-45b7-7b81-08d96ce1542f x-ms-traffictypediagnostic: MW3PR11MB4729: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:331; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nd6v4KT3EYskHv9oDubHBN0oWSA3UG5AT+60xgrq8Z01DGbetET8j7n4dagsSS6KVXVbrXtKYKt8sDt/IFFHSVXoLuX/SAwOsZoliy05yaiAMY2ToY7GXjsyzoiALp9rL+c/xn3f3gbEobGdBqpk3TvdHp1nnSQbkiifzz9ykfXd9TpBB8yEn38MLcTBjB5K1eO0ffsvoLwVAVP2ZmfITdzcLep7zsbdPOIq7x30vTBjFpef2eUUswiF2TA8YCEM7Ay/XIBb3SsfUEPVb0Oq4amo3RZPyea61drBXfU0z6NAvHqGwX27FtnCBEfLyoJrAe0K6WeTr71MnsLZYP2iIY8td8/X8MkJr/xgxGVr0vPLQ3JeR0rIimUV/pof830vgJavAfPjUrK+MjlmiAo4HpckoEje3UiQIM9NHasNsiNf8tt+vFmW55OsYc/SZbqgptxwSKxOSK4K3VZJllLxR4wcTYG3ZAyzdpNo/DooZFLGrdc1KnfQwoRQ+UTpQtNQtHqY2B0y9tawt/aEvFiPh3dcSDkSJu3Gz8U7jUrnJVpN7e1s63MZ1p/4d240Zgys7E3uHJyPM8uK4KR2MxTW6V8PUxlBmT/YDllwQ/+/+TfSSJ82UAcN4LMLef8X6+cy8/aKdu8RVdODPnS77/rpbMHcUCueELdHPGaMtYVPim8YrsSdi67gGQqYCApwgpJo7IZVmb3rK5RjxRiksTMRDBjZ/d1sWHZfsExpKyw9JakcNz/bhQ6wL3UIx5MppqsMyTWDNIpqP+Ahi5Ndyxei0IzP8gYuwkvYWlBmcFKKrFSr1Amp7fOXnSmznhWherOnZFM8FaUY3zL20v0vo+SJqQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(346002)(39860400002)(376002)(136003)(396003)(38070700005)(2906002)(66446008)(53546011)(6506007)(316002)(122000001)(478600001)(8676002)(8936002)(4326008)(66556008)(7696005)(52536014)(64756008)(5660300002)(966005)(66946007)(26005)(71200400001)(186003)(76116006)(66476007)(38100700002)(54906003)(9686003)(55016002)(110136005)(83380400001)(33656002)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ye02HONvEmnofOIriIzITSSTjcwF63SJoVDmEzCmuO6kQiozmFQ0L0GR0JqN?= =?us-ascii?Q?pViamOkgTbek7hQ/8UZuZ7HuJA2cE4p7zjTZLHkFl6HvGb4hWGf4Kp4/kNa2?= =?us-ascii?Q?mPyj/ULDLDdgoo7i3dM0NpNIoqeWmH9kamsILdg6OI8xjnIlARvBrSnZiSSl?= =?us-ascii?Q?JHJIjXMq75soh5pmwpNsnetPCVBjy2Xcum9Mo/b3h61wa2wU/RpXGeX5fqEA?= =?us-ascii?Q?vuNDwbVCxFx4tllS5TekDczkgPCgLXA3YVYIlYaK6yIZf7bhMXlUNDXMoAMe?= =?us-ascii?Q?teatvOoFEFyAfvyZi2l2qEc8ukCX1C1TQLxVdOrfK8+GpSdmkRuZUG8GImdD?= =?us-ascii?Q?bbCIbCDIktJ4Em+wkZlzn47hG15O/qX3B2s4qmwQXKDK07Jqo7nAsnKcqfwE?= =?us-ascii?Q?MSwxEFoRZ3pJGnkBoPPk+Aby9F0RItgUvBWUEBcE50pzAsRPNV1AeDmQEbuv?= =?us-ascii?Q?DUKsPSmNhgn0TPg7nrx/kcjjMPOaojTQ+zUYx7T+e2xQ6M+36flsqJcG2AO8?= =?us-ascii?Q?uPb0wRgEKenNjzKf22maLyVEaL387xOC9PY0KolXEhA3mN+8J6z3VtzKd+4U?= =?us-ascii?Q?EHkpO9z/I3Fbu4FYl88MAxj4WJWHnkBkWNDBogBUYMjHRr5z5VldlYOMDiUj?= =?us-ascii?Q?6eFXcqFnTg6QSo6qGoAjqS3o2dZq74nn2zNaQZKHrgsK+k+axp1sE96c6E4z?= =?us-ascii?Q?06Xv/t0vpAaq2iZdyollvOqElnIjRyyUvUYJYySzSfC4KEOOSKqtD8VshGaS?= =?us-ascii?Q?6YT9eEOkQpdVoDUCiAFcYCXRvKmjDHgqYVvx0fQ1+SgE8PV/Oz8MOCAh1NJL?= =?us-ascii?Q?J3mNMHa4sp+skru8PYgC/rjFYv95eNCmPOtWAEObV1A52cbKesmSM6t5pMln?= =?us-ascii?Q?swyBMx5XaFp4IN50U7NJntxJQ6O3wkxFDp+rFd4gA+m9idvXz5ft/FqA8Beg?= =?us-ascii?Q?mMP+aD4SWCgWJLeA8X+m5n0/7FF4KCYKVnrebNFBvB0Dj522bxuly+n1ci7b?= =?us-ascii?Q?RBNZFkQTiHFI5lEqIwPUJEFgeMufbEdMPRW7hUK8Orr5EjZi5tJJKMooZaym?= =?us-ascii?Q?AB//8xZj6/nLKan+t7CR6J2CkT3oZJZccNO8+XENJEKGX5wAVHoHcDxAEArb?= =?us-ascii?Q?mt7U0Lj3j27yGT4mTRAB3zQu/kqXGoL5gT860m2186N/PCjqMlfJwTPnYa1m?= =?us-ascii?Q?J6mM9nCftFODaU4YYUm5mPINzJ8LEDlgb0c6GEtvZOKW+POGIkGUYMw7AU5U?= =?us-ascii?Q?HyfDP0h2F9Blt5e7ME49xpE8gRLWyLj0/V3YjmETkXMft+2G2TQRAwDhQmPr?= =?us-ascii?Q?IILLoSlgFOYuQl96CIt56toI?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d89213d-ffd8-45b7-7b81-08d96ce1542f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 00:42:08.4615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BkMfytG8l0gQfsdLElBnjTPq2n9gufHAVFYI9NnpGt/hEPZgDbFbtt3h+yOYvk0oFvqF1t0sKGzJaNdjMWyY2aTZ77rbBfoJLIyf1mSZ5a4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4729 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/6e68849 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Nate DeSimon= e Sent: Wednesday, August 25, 2021 8:56 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Michael Kubacki ; Benjamin Doron Subject: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Doc= ument EcLib return value Added EFI_INVALID_PARAMETER to the EcRead() function's list of return value= s. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Benjamin Doron Signed-off-by: Nate DeSimone --- .../Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h | 9 +++++---- .../KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h b/= Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h index 7c58e592d9..e95accc465 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h +++ b/Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h @@ -7,7 +7,7 @@ Make sure you meet the requirements for the library (protocol dependenci= es, use restrictions, etc). =20 -Copyright (c) 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -109,9 +109,10 @@ LpcEcInterface ( @param[in] Address Address to read @param[out] Data Data received =20 - @retval EFI_SUCCESS Command success - @retval EFI_DEVICE_ERROR Command error - @retval EFI_TIMEOUT Command timeout + @retval EFI_SUCCESS Command success + @retval EFI_INVALID_PARAMETER Data is NULL + @retval EFI_DEVICE_ERROR Command error + @retval EFI_TIMEOUT Command timeout **/ EFI_STATUS EcRead ( diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcComman= ds.c b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c index d14edb75de..14a746172b 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c @@ -1,7 +1,7 @@ /** @file Common EC commands. =20 -Copyright (c) 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -16,9 +16,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent @param[in] Address Address to read @param[out] Data Data received =20 - @retval EFI_SUCCESS Command success - @retval EFI_DEVICE_ERROR Command error - @retval EFI_TIMEOUT Command timeout + @retval EFI_SUCCESS Command success + @retval EFI_INVALID_PARAMETER Data is NULL + @retval EFI_DEVICE_ERROR Command error + @retval EFI_TIMEOUT Command timeout **/ EFI_STATUS EcRead ( -- 2.27.0.windows.1