From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.1387.1618003214799920851 for ; Fri, 09 Apr 2021 14:20:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=svbEwXHg; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: fryGBkXswS61gklwpmTUHwB/r11FI3rvAM2wf9LWfX2xco8Y5Skye94Z2eaiju3/lvN38DoMYK XD9eYi0RgEHQ== X-IronPort-AV: E=McAfee;i="6000,8403,9949"; a="255172826" X-IronPort-AV: E=Sophos;i="5.82,210,1613462400"; d="scan'208";a="255172826" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2021 14:20:12 -0700 IronPort-SDR: xwd4r8XxZktdv1qElXw6L90wy8maXPmzqw9pKVHbXUwQcceEu+o5KDIyB1k8ZGcTipCPoMiQj1 2ltALZbuUr5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,210,1613462400"; d="scan'208";a="450407290" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 09 Apr 2021 14:20:12 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 9 Apr 2021 14:20:12 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Fri, 9 Apr 2021 14:20:12 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Fri, 9 Apr 2021 14:20:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L5G/Tg0jot1V8Pt1yOv0YqHXQH3EQTFj2f/7iH/F0ReBoJsGpprintw6SuSI/VCq7PVLPxneAt55+yTlebTa8p87qOd8Jz+VqhVfanzl9YzatopOPBD4zYP0UGsL9Qbe07uK9SUQFljZAbkXD9PnhZD8nxphf2P+Qv3urJ64f/w/CcInB00J84bA5c1ATZ5H+9+as+0gfOvVgbEbUJM/dtPW9GkTQmX82yMV6UCC3wjyrZ/dJj0MXTbCSXJxHVSHCTmF8aLCGbCvCHGmSTaVohX71ntdMAARJrEMEThq2JJxcpvl3q6kkDgLMBH1WvNC5lHVBXg9A3caoiWlnd5FcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P2Q4Iu4dk7G/9HFNBFo1mqLW9oKwb8sz6EYjz5UkIPo=; b=Ele4KBMgXTxlHvFUXqSlALiCBh2eALf3klT+h+gKAV05QbceKrOahRCTSB3JNpn//ttmcH98RjV1EqkeIp6c5Ystl0ydq+TwVK/38WhLEzfOKLvu562+gUnNLKUqYrmkK7kkpkL1Ss2IZlhQbl6DMuWNlHkzuDXlVraj8iZ4NENqM35//4AtTlf1F9lUPRJ2jwILWjCjyWRsnUkz4A3Sfs5FYP77wg3zPDHLfP4wpGceVR3VoLP0Ws0+Zdpj4JIxXzjOGwRd16yg6slNoajZysGW6p2H0+nGLQlIutJ5qXHeoqCPs6kX/K5BDRfUU1+Vb9eqMcc8FnE5on8M/CEuTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P2Q4Iu4dk7G/9HFNBFo1mqLW9oKwb8sz6EYjz5UkIPo=; b=svbEwXHghf2ZMpC2ENC4nxHgf9JXrTMQvVHTH7nVBVKaR+8PqRJs6RxZUcpgh43UinfazseIizR0z5aXpZWrxOMWD8Vh2jrRtxogrCSim1ywlGhwPhcIE3qcQ9kQZXgo8iHS5/9eR4IxnEbnNbndsn0e7KB6dTeaNXd5wT4yApc= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB2047.namprd11.prod.outlook.com (2603:10b6:300:2a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Fri, 9 Apr 2021 21:19:50 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::6540:bca7:645a:6788]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::6540:bca7:645a:6788%5]) with mapi id 15.20.4020.021; Fri, 9 Apr 2021 21:19:50 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improve NULL ACPI table lib maintainability Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improve NULL ACPI table lib maintainability Thread-Index: AQHXLL2qEya+AojJgU24UM5kagb0saqsspYQ Date: Fri, 9 Apr 2021 21:19:50 +0000 Message-ID: References: <20210408212433.632-1-mikuback@linux.microsoft.com> In-Reply-To: <20210408212433.632-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6181ece2-7f7e-4f30-50cb-08d8fb9d35af x-ms-traffictypediagnostic: MWHPR11MB2047: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8dlees3cwPxvLW5SuFkQNaiSBzKUW3EsNBkjHQ/MeJJ7zZd8DiLkmireBZqfKqanbgMl2sZ6n+lIEpDfgYrVFyTwmzoKaeh5Zi3NWDZvP3YK2eR9WLqRz8Y0cpdPiSTe7zA37mV4+D0pGzwv9p4QtjGoZJbDaonZt4c94H4Lf9r7b39nn2mrGt3OHOrrJ/pgk6rtPmUM2Nj7VGmsHApvbPG+S4rQkf9nPIyAvdznBGMbU1wB/IWsPL85TsbUK04wo2/Ip9eihcqXjdMAFzDpm8+VGUPySDYsva3uMqchNpwghLR3mbJxt8TLtYzalhP4aB4EoffAnJV/dBgvZ9zH+jenYiCZPuhgZEFf72iPkE+0+Ibvqdei01I7BRJ2hqCv0/jaIJt4guHiemV29gVm0fsaMB2vxsN3KiCaeoNnD7aH/GIB8jOUkZySXeY4CmIlgHwSQRJ9vMhJ0Vls4bLyv4w5XN99FT/+C08Iyq1Zzckh0NoFR44oxN821/ZKJra0cdnDco1N1YTZD/a2Wg6YQQ5WkI7ey2t/LDCveQoA6SOyCMUkTWCKCu9gaz7c5RddOw+OL4v0Adlq/gfIoA7brlcnM/gOKIO+Ohy4ogQgUIcxrZYPvuqJw5SxZZTqWj/xYpcEiuGJNLMq0oc3z2olR4nptgmRFkRTfH5GMpIRpG34+Ag90ad0L8XwufKFDvp3K9WK7uQgKeyB83x/3+cl2ESwAJ5MIFg0ftp5AFuTbdw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(136003)(366004)(376002)(346002)(4326008)(107886003)(38100700001)(83380400001)(66946007)(33656002)(64756008)(66476007)(5660300002)(186003)(76116006)(66446008)(66556008)(86362001)(26005)(2906002)(9686003)(53546011)(478600001)(6506007)(7696005)(71200400001)(52536014)(8676002)(8936002)(110136005)(54906003)(316002)(966005)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?FqcdEYoY8CaE4LUoHiGFncRtNpa1unF+kpLyzs1vkbOFs0pSdVZ9ghe/2szG?= =?us-ascii?Q?Bk8txJqBhzm8Q/vodK7B/hgd1IC6I6lTagChzG8yn9pV3xAwesubQ/qIEBCG?= =?us-ascii?Q?ATHLn2YfbgQX2MLdM4rMYtPrTTAJ6Ukza8eMBl0FotWyDP633PAdMNi4KrB4?= =?us-ascii?Q?6KoDFlMphZ3F+nBen9Hhj1xxtJf+3bRNJo3xFCbojXQiwaKdyaq2o30iWcAN?= =?us-ascii?Q?6IetACadXndPj4npAV7uoLDNob4wPWtkPMbmeMgs/N05ti4zhJL/0Ke2ZB2E?= =?us-ascii?Q?C39sBoHuwY7Vdhub7fu6XnreK/ena9Ns0SAL0c0//ThGyKVV7sMMT5mTGGla?= =?us-ascii?Q?fCMTX4FokeJncBu9NYVbhot4hLLFom5ctLaD/rXaixMWTXcAnbXzi474pI8k?= =?us-ascii?Q?cfQQe00vYvV6mZTk31DQZqoSFfTgRludMX02tko75N1iCyFfTCv5DcLVQQGy?= =?us-ascii?Q?ghnoPSRiwXuJk123Rwj/Y8g/S7ZSaw2RmqIWfDKmfr8xnxyfHHHawMIrYcDd?= =?us-ascii?Q?jGugbHZdoN9pH6vFStB0ydZUPRMNOezPC6IVycqDl/G0wGllas5QBDiOMOte?= =?us-ascii?Q?H9JmnuOn+X3/JnUxU91ILZJgBJKIfRnauj5vEQZXrQW9RZnEsIG5HTYz0xg7?= =?us-ascii?Q?3e2jy+dD9UW/1B34EY5JADVm48YJTmpv829SgOO6G7ZNfeXlaYlJfarkXkZG?= =?us-ascii?Q?URFB0rmopPajUmiYdqrtdzGFaJ1xPvQSEtq1p2Kpu4pTmV6zY1kQR9WZTGsj?= =?us-ascii?Q?3Vr3rFKdOAGEfQpN0attuzwcuGIyInRjzCo7CGawK4MvzUZNOQCdaQ67wJ1j?= =?us-ascii?Q?eokSoRwZX9F9WvyGVjJrdIMbISvqX9WgQAeMOgFNMoBRjdCJMKZIA42Suejx?= =?us-ascii?Q?oMnYBJ0w22v8rzUECDByhNje2XXSfw5ZqdJhA9ub4VmYI5aZ9GUdkl2XWJhN?= =?us-ascii?Q?gYfJQ+FoQ2PIKKnPQSWK6ASJf8cTVdwK5xBqJ6tA+ECt1oVIjw+o4gH8dcu/?= =?us-ascii?Q?kOKeWYgT6ai3Gor28dGt9xLXYUh6hTkJDa1N8dV4onrYCIIg1dptw+t9kCta?= =?us-ascii?Q?VPAUVlHe7lbJyWMG9WGVTEQNf+FkIqesAEAW04igioyQYl5ZpjE/uYk7IzI/?= =?us-ascii?Q?gsdUsHPFq6DqM6yajkzN7zvm64+MCBJitpIx0NcvUNhhXNVb9iBv99+cc48Q?= =?us-ascii?Q?aDKXCM+tKPGBk14PwP6m76Bf9PFl9DPtHF8KHD8jwjI8HuwDvvU1dnRHY0BQ?= =?us-ascii?Q?vPn5rX7kSHYPY24MyS9ZyfpuoEiuq5sFYA+LA1QE713asRO/pUMjkZ+3Vho7?= =?us-ascii?Q?4PT6l2jZLfW4SuABytKGa2bA?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6181ece2-7f7e-4f30-50cb-08d8fb9d35af X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2021 21:19:50.0714 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uCAqUIK5y/BossGNIk97+rooeeKm8jnEayCYmTEnDdjsB+TTx0cAJqYEtb1s+c8Kmofkhu2kma1Nw+v7c+6GpB0UYCUGalBS83Im+XYNVFo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2047 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the series... Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Michael Kuba= cki Sent: Thursday, April 8, 2021 2:25 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improv= e NULL ACPI table lib maintainability From: Michael Kubacki This series makes some simple changes to the organization of BoardAcpiEnabl= eLibNull and BoardAcpiTableLibNull to better align the library instances wi= th patterns typically used so they are easier to integrate into platforms. The following issues are resolved: 1. Sharing of a directory with another unrelated library instance. 2. The directory name "BoardAcpiLibNull" is not directly related to either library instance name in the directory. 3. The library instances have unnecessary dependencies. 4. The BASE_NAME does not indicate the library instance is the NULL instance. 5. The C source file names do not match the INF file name making finding the C source by search more cumbersome than needed. V2 changes: 1. Remove Base.h from BoardAcpiEnableLibNull.c and BoardAcpiTableLibNull.c Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki Michael Kubacki (2): MinPlatformPkg/BoardAcpiEnableLibNull: Improve maintainability MinPlatformPkg/BoardAcpiTableLibNull: Improve maintainability Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiEnab= leLib.c =3D> BoardAcpiEnableLibNull/BoardAcpiEnableLibNull.c} | 3 --- Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiTabl= eLib.c =3D> BoardAcpiTableLibNull/BoardAcpiTableLibNull.c} | 3 --- Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull =3D> BoardAcp= iEnableLibNull}/BoardAcpiEnableLibNull.inf | 12 ++++----= ---- Platform/Intel/MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull =3D> BoardAcp= iTableLibNull}/BoardAcpiTableLibNull.inf | 12 ++++----= ---- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc = | 8 ++++---- 5 files changed, 12 insertions(+), 26 deletions(-) rename Platform/Intel/= MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiEnableLib.c =3D> Boa= rdAcpiEnableLibNull/BoardAcpiEnableLibNull.c} (73%) rename Platform/Intel/= MinPlatformPkg/Acpi/Library/{BoardAcpiLibNull/BoardAcpiTableLib.c =3D> Boar= dAcpiTableLibNull/BoardAcpiTableLibNull.c} (73%) rename Platform/Intel/Min= PlatformPkg/Acpi/Library/{BoardAcpiLibNull =3D> BoardAcpiEnableLibNull}/Boa= rdAcpiEnableLibNull.inf (67%) rename Platform/Intel/MinPlatformPkg/Acpi/Li= brary/{BoardAcpiLibNull =3D> BoardAcpiTableLibNull}/BoardAcpiTableLibNull.i= nf (67%) -- 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73880): https://edk2.groups.io/g/devel/message/73880 Mute This Topic: https://groups.io/mt/81953909/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@int= el.com] -=3D-=3D-=3D-=3D-=3D-=3D