From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.1186.1628205279247733998 for ; Thu, 05 Aug 2021 16:14:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jIOUAgoJ; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="201445152" X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="201445152" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 16:14:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="669187268" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 05 Aug 2021 16:14:38 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 16:14:37 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 16:14:37 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 5 Aug 2021 16:14:37 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 16:14:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QC3xqxtBVGYnYY9jAppxPb32/RG11Lu7wn28PxWPoio6ReMydVKsk08fDqL3eTz6eXo0RtsS68Z0ayxtRX+Ugnen5jzKT4+LDwgKq7iDlIv3uTBo9GFLOhjHfBrdMwIqo6ONRCWMLVssFS4fQIvZzsW8BZjt24Gfb9v7TGkyp57sEdJV4JX31T4gS8GnQk4HAf4GoitxZcxKLvslBjkvoyW97gICJ+SD3u3Lg100AJai4U6p7GvNQDkT/vYM8nA2m4tgaFZ0N5G5kEoWVSq/M9EMfVBk5CxL3KoM7pvbs+1JfdUCTHOp7KJt8Bq2fTxQkpLW9wWW8vOq5IFCUjFZYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KzkdT2qT9ecw0v44HY1/7kNkR55SCGUKpiQM93bnaFU=; b=JfurVNM/sU7/rZ6PltT3ZiY5WWIZTf84dr6y5sbUF6dAjLnOQEGkFV3neKkOk9Z6H8+Xio0uNy3ImxMN+wx5idGoh1pZB3LeShD2Cr8y8D0G2eWT5IPlCFh/+6itBxz5QAmn6UoAE7IONX07G6YoGB/cQQFg04EX2dPuHlq2ZJ2lpK8yPFysTPqQbC5qqN23ZIIWHQxmyuEPVNhohtlWEJF9A/b9Kvkcm07ZZKyAOYHLm9kk2nsXFdDFAtDeRls8JaWYNgO2sDn0ruwFnbOGO7GdXaVcnjE5HCymOQZphFzeZM8rWKTEHA/TWv+xjDtFZLctWfjECjPZ/owwcI+v6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KzkdT2qT9ecw0v44HY1/7kNkR55SCGUKpiQM93bnaFU=; b=jIOUAgoJMOaRBfla3KNkfmcnzhUBgJJiGP0eSTSTKi44Ei10Ab8x5ibEfE9TVbOHz/1ZGE4RQo6QiX5xliN7U1Jzh0KvA8VkxJ6YeCwAIjadami1oXRdIgfMhGr+bD5cDX1Z/p3lqhXhqqPsPq/0fTzO1fKTn9NSOTBkBLeeaL8= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB1725.namprd11.prod.outlook.com (2603:10b6:300:2a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16; Thu, 5 Aug 2021 23:14:36 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4394.017; Thu, 5 Aug 2021 23:14:36 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 0/5] MinPlatformPkg: TestPointCheckLib bug fixes and improvements Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 0/5] MinPlatformPkg: TestPointCheckLib bug fixes and improvements Thread-Index: AQHXigo+m9EhKcUCTUe/YHRrH0IHqatlilSw Date: Thu, 5 Aug 2021 23:14:36 +0000 Message-ID: References: <20210805145706.2470-1-mikuback@linux.microsoft.com> In-Reply-To: <20210805145706.2470-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fafb041b-05a2-4e69-e2c6-08d95866cae7 x-ms-traffictypediagnostic: MWHPR11MB1725: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PKSrgEmG4av+/fVYqippTd57W8EyDEyYR06ufJHcpL5HgBmRRfpYiNLChVjiY1jt65Zfy2hO74oNL7zUxbd+NJaaToVNUWa+8y6oi6X/jaxEttirMAdyH5chDRShQOeRXJi3OsR9SKaTcrDpbb7ue0mLtwxJLfkpI7t+45fe89ANHAwhfJMe6SHPxvv5GnBOwos4A0sjQmXlTdPTEkLFjQd4RM4SCZjO8fpVf7N1EzllJOXEeFVe5XAsmK8bncpnRZonzKJfDnMSvG9EtaF8H0qclY6Sd1fRVgdfXF/K+IQMThPcjpSFEiGYXtwkDFJpTAU4HNlFmbFw80wMZvgdHrtGeYcEbmTxzSY0yyCJHzGUz45uexeY6dx0vnJmkLO7omVt0Itjy9ruOKknqpDblCaFFonoFzzTz47xDRcx0ZZ4S+7ldWesiND0GFQPNQQdzFgvqYb4aJ3YbyQIg06hZoUMEt/C0Kni+ZcYbUXp84SQEC1DscVbs9LJFtRY0aKPCy6RIQOBoEoMRDELwSC6RuIZWuQEm05rQRsiUhG9fImMzp/lB/Qkd9J3YodPGN+OMRPMzv+k8wXEaMhyqfJMiq40Jrxr7mIu3IJWZvR0CLB8OJ+zdtChv62EMPIdCulmNnhD0b5+ACBuTrKW4BsIhUb7JUfR4VtTzVaDBCogHtZKoKK9dPRDqpafe8VXHmQrtVuDWdgE+2TCF7OXvRRlO0r/OX8sS9QY23Zbg8qFNUCjI0T+niIYWXa+StRKG8gZ8V0/Yss9tRm1yFzvQ2oYgoMr4gDW/FhNghcpRniF56Cg8vQDBPLNCVOEqTBYXvV12Xq3HY5UdcioEN5wizHDcg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(508600001)(9686003)(186003)(26005)(316002)(7696005)(53546011)(110136005)(55016002)(2906002)(64756008)(8676002)(71200400001)(6506007)(966005)(5660300002)(66446008)(54906003)(8936002)(66476007)(66556008)(33656002)(38070700005)(4326008)(122000001)(107886003)(76116006)(83380400001)(52536014)(66946007)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7DYXtwKOMiglYIpromnLIX3WEG3aWJy0ST7kGNwW5BrCbSUIA2DAjcqJb6fp?= =?us-ascii?Q?sH6dFynhIT2AGk+i3hCvVQk9EE8uz/MZTpaMi5fNOMX55Qv6WxWMeHiPgq+G?= =?us-ascii?Q?twCxjcmBBIDWN4A3KQDvJZM4/77n88+SS4OMGbhMythMh6aapoKcCvLgtCCP?= =?us-ascii?Q?YH7qn0kBb0E+8WENeTqidPFyH6GSl+I8p2tXklhjqfNHsdJYm+hFp8Lch9r0?= =?us-ascii?Q?VOO32uuWdvDymTw40nC9J0s7k6gEn8tpugTSkYLOkW6L7Fu713o4P/ZeZfmI?= =?us-ascii?Q?t5o+IfqMiEAeoE82Tq5f6YOpch4X/yTHXGjOCyw0n4gZq2Y8U3QWfXVwKxde?= =?us-ascii?Q?EMpV+p5rD8D297NYRDn4LoE6828mz8FlLfXFvcB2pb5nhW57+Okks4Khh2PE?= =?us-ascii?Q?vOUhlQ2gNzFAxenZVp/ul83c1pd0ETF6Yg7Hp4no93bO2QmZSkFQby4rYzmZ?= =?us-ascii?Q?d7Nsa/6osYH4uJts6M6kCL2RwFcqfM/UoqdHb+vOcMQYyaJQtjjEPB4Qytai?= =?us-ascii?Q?yZloK4lqE8SwlJDlNQFBzQSoWqcdRUslua3BSGbOmIBuueSPgNf2tic8EG8j?= =?us-ascii?Q?945cvAXr/ssF3n795x0yo/RcGCn+g/wy7Krp+gwXXxoyTOnz69FIPNnTlQUQ?= =?us-ascii?Q?DhWk4dQq0yizcqYWi8Os2SSFoUnvPCwAgOUs/ycpkFj/2jOqnz+uz5Wb4mBM?= =?us-ascii?Q?a7O2KP3BpemOgT4gExXRdQsXEhhhGok9p/o5DhjMwtHEDeVo4ZOtEJv9btDz?= =?us-ascii?Q?cI2RwpgBTJCIPzVPhBJE4x/1DQv7k/tATNkOlEIWwZ/hgrvWq9rPxBwiSAKf?= =?us-ascii?Q?qBlLZH9yjB8kW9ujD+XWYiScudQ2JidW51ic83zoSFP+cu6gD3uvygDnembA?= =?us-ascii?Q?5BSQts/dFudx/WlsrHjpnIVrLYZO6JBFfDsv0gHaPw6a6Nqfxgx0mTzDn/gH?= =?us-ascii?Q?x9N8o55Bl+k4A+3dtC6uEhSJCtK3BsPvOVaEjFwnaF8tl4WWVrYw3adY7Tn0?= =?us-ascii?Q?a5aAZ2cu4E//+9Rv75Ab7i6JNBeUdwfRTYGhjMRrY7CBxt7VBkLAViAdNmv8?= =?us-ascii?Q?NUT+r/Mz26dpcBdx8uUjKiC2mtrlzr11bVRVrD9g8gY4OuL8MJE9gzcUEW8u?= =?us-ascii?Q?xoVtEr7gLgzfhPiXoGzb0Nu35bpZKeu+OTjvqmD5LTUuLIHRUnB5zJiq9pf6?= =?us-ascii?Q?fReez8O3z0+1/8RREiLG5czCMCaudvHBfi8Ngs7aB6cfVjlRk+8uJNnwY2mP?= =?us-ascii?Q?e2SiRIiX6/cO+r+T8EYt+2LdgClvF8HZ95nzlCd3HthYkU54F3uv5pGPnPU5?= =?us-ascii?Q?bkfTIBVe8cPU3u5nRSm46drZ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fafb041b-05a2-4e69-e2c6-08d95866cae7 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 23:14:36.2409 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8yPvUUUhoiO5MWJGa5hlgDhWudfDfTwVyI2cR4EtF0Rh1UYyXAzjysfrqstyShhSV0F3EVXXn9hRrj17RrsbEoDcyoaukRRXu4AilU77cO0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1725 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Here is a summary of my feedback: 1. Patch 2/5: DxeCheckTcgTrustedBoot.c: line 44 - I think we should also = have a ZeroMem ((VOID *) &ProtocolCapability, sizeof (ProtocolCapability)) = before setting the size. 2. Patch 3/5: SmmTestPointCheckLib.c: line 112 - I think we should have a= #define that describes whatever "6" means in this context. Everything else looks good! Thanks, Nate > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Thursday, August 5, 2021 7:57 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-devel] [edk2-platforms][PATCH v1 0/5] MinPlatformPkg: > TestPointCheckLib bug fixes and improvements >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3531 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3518 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3520 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3521 >=20 > This patch series groups together several bug fixes and improvements to > TestPointCheckLib. The first patch is required for the others since it fi= xes a > MinPlatformPkg build issue that occurs with the current edk2/master branc= h. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki >=20 > Michael Kubacki (5): > MinPlatformPkg/TestPointCheckLib: Fix MessageLength cast issue > MinPlatformPkg/TestPointCheckLib: Set required size field in protocol > MinPlatformPkg/TestPointCheckLib: Fix incorrect array index > MinPlatformPkg/TestPointCheckLib: Improve adjacent region checking > MinPlatformPkg/TestPointCheckLib: Make OutTable parameter optional >=20 >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA > cpi.c | 32 +++++------ >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS > miHandlerInstrument.c | 4 +- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS > mmInfo.c | 56 ++++++++++---------- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckTc > gTrustedBoot.c | 1 + >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.c | 15 +++++- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo > intCheckLib.c | 4 +- > Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.c > | 10 ++-- >=20 > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.inf | 1 + > 8 files changed, 70 insertions(+), 53 deletions(-) >=20 > -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#78710): https://edk2.groups.io/g/devel/message/78710 > Mute This Topic: https://groups.io/mt/84686301/1767664 > Group Owner: mailto:devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [nathaniel.l.desimone@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20