From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.4501.1607508813054216393 for ; Wed, 09 Dec 2020 02:13:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jFJmmV+T; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: 6CqjwVT8XQpLjvRRr0llh4dbQpca9GdMIVEdsrKrlRYsKpz071jf0rYu7Zl64P3px3q+pxiPLO b8pv7BVygzSA== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="161105660" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="161105660" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 02:13:31 -0800 IronPort-SDR: NZvsLdZ767rN+j+sSCUTEgwoyppkfwAnDl/KMyRN7MQeOC+eOUcOCQQR18s/xcX2o071ef7zvX eDNM8O7OMBSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="375493783" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 09 Dec 2020 02:13:30 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 02:13:30 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Dec 2020 02:13:30 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Dec 2020 02:13:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cr6LIE5lNo0uUqWN4XeBmz8sSexPPrCrhRT6ocJimxM2vRIeH72B6krkVnYAPGOiEwbB2NsMjKhhz7x+izOaN3XHXppQmbUJJVHpaQObAaUWmXPtHFRCakCsE0c1vJ+Zyj2nTCfpb+CN5DbOG5VcuZ3/qe4rKBNpB8wgtQGZUoXouyuxU1Wwrhw+7ya+5dmeCVFbxAH60k74OOhCDjqvgllkTe1Cs8IJcM+Z2+Z+HA3ienHb1zaTmirNikJG62NREIoO39tjbMe/DGLNHCXRHFqOXJ8PCbgT+a5N0UBFO/vGgDH+eX19z2xXbzvB3v2rQAd8G/MJU6hbuVXcTqBMLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xItMpDnPm0RLc11gzvv/kCg/jW4lgMirGZ5tqbxBpw=; b=Uq4Mreu8zoaxnw2zq02yZWlXF0WQQwLhCAyEZa41FCGrlgzfKKUwQoxfRt/hC6toM6R0azSR8sJowXZtGRERsIfCgVlW8/n7jN1wLJ75LDc7A5IUEJMQXHnB9DTkCEYC6CYKPteewf/UQnaAT48vECt/ZPL5RF8urcEo0mM9OSRHqk6lOxQ7dNyF+aYTuREC1yhW+9YBg6+8WXbgrFhwXK9YJzWzkkpk2DO/s9FulIZbEkelqc+n8HKLzdvCGXKIXr3aJ6UzjxBwL3CYooLBdfhDvAmZBIVa4NCd3F3IrsYPq16a08rBvtnnOmTgVNILIk9giTh0whkZHNEYc9INHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xItMpDnPm0RLc11gzvv/kCg/jW4lgMirGZ5tqbxBpw=; b=jFJmmV+T9iniOIJhwVkrkwdUQkCFNdPg1mp/Cwdy17SiKIoehQRYVwlWpFnhOtvubqaVTxnck4zkCUB632jGpb8clj3lmQrw3gKlfc5dWiYNLySwVfkCOJt6X+sRME8q+YNaNsWAa3muBix95Wk4N29WJdiyrsvks7TETkL1PLk= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB5203.namprd11.prod.outlook.com (2603:10b6:303:95::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Wed, 9 Dec 2020 10:13:29 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::3161:c00f:c5c5:f710%8]) with mapi id 15.20.3654.012; Wed, 9 Dec 2020 10:13:29 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Ma, Maurice" , "Zeng, Star" Subject: Re: [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Incremental build with UPD in sub DSC. Thread-Topic: [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Incremental build with UPD in sub DSC. Thread-Index: AQHWzQgpvJB1MNZd1Ue+YdKnWMzRV6nujbew Date: Wed, 9 Dec 2020 10:13:28 +0000 Message-ID: References: <20201208021553.1348-1-chasel.chiu@intel.com> In-Reply-To: <20201208021553.1348-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a5a4d497-2e53-46e5-c59c-08d89c2b1316 x-ms-traffictypediagnostic: CO1PR11MB5203: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fmpYwTjqnRYf4a2Cvz/heQ0Mpbzx3V263vnmTOV6IJIqbTy27x9fj19BSYTTTUUPb++O0c/6pys7Mf8Fxd2wj7h1XXSRIA/NkQMGyt3qNGugXzAWiPAjmeGYV7YW0Kve9f5L602NRgjLsYMGocbLydqTvLTJ/p1TU3UJVbz380CeGuHQrDFTx/3Fp987LorUAoiJcq+IEwSCtFyHFGdc8epv315IWbzkY2NF9LGr6qiISE3lujijTM3wnsyZz3U+3WXruOdpVupeED7UbTWVjcSrxQFdt4BESQra+af+Zy+MnjaRD3AQLa3PDWjt3umZsqTkLAvQCDL/sW4ayCNL15bjwc7QnOUU/KK4bWmzuyiPwK8fcphfhJsxjFuJwbfKnFM8WZEC+P1MdXSYv3gBFQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(346002)(26005)(8676002)(186003)(107886003)(76116006)(53546011)(110136005)(66446008)(66476007)(55016002)(86362001)(7696005)(4326008)(6506007)(64756008)(54906003)(66556008)(52536014)(508600001)(9686003)(8936002)(5660300002)(83380400001)(66946007)(2906002)(19627235002)(966005)(33656002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?8qtfKu5X8EX0DWHk6rGu778tFCJLKQL/RMZbTIaU2pHMCDvyp1WS/uuIOZDc?= =?us-ascii?Q?/VO4vPIvVCW0lu8zHxjxYN/FBYhM63w7AMYSCKxVA8WQJ6fl/ko1JXYfZG8U?= =?us-ascii?Q?EQlMnhw2lYnW8ewhaJUEdPDnZtpPxFTFeHEEiSyazj3WfhZUrrCozojpE00Y?= =?us-ascii?Q?ygQcKgShaUhhT3nX9F2EN8BDegCOQE/J0GBJK7N+UyY8JziuUOnwDQlvvHB3?= =?us-ascii?Q?wHu77s1ZrpnKvVOycgrRT29eOXnFfo5sUK9Sqf8dGjCLhMr2bzwnW845BJoG?= =?us-ascii?Q?GuGHtu0sldr/cUlmaxt45kDycMdHrSjPnE4SMOnFIZk4i7uf93l4CvZYwNRh?= =?us-ascii?Q?JOvFQa/+BfArITniz6Ya6xXkol/S2XIDhAQwKxl/w3lFD4g7B6ooZvJYAV7n?= =?us-ascii?Q?3tPXCh93hRaMo/uTXZXCSCS7+rD49+Rs5pNxUOBSlO9SG66GP7cXyTaqlKye?= =?us-ascii?Q?QNJEwX+Doy0CaWFVn0mMhoDgMU/TkvGi8ZPxlwdTU2/N2zp0QpOb/rSrPqvQ?= =?us-ascii?Q?HZd4S+nZZhKapMRRzk7EPaYRwe8X0uYWv10oVsB8kE9ZIUYJJ4fyILMvnVs1?= =?us-ascii?Q?kPRfBHyrDXtdSHUwQprowmETnB5ie0lYXyDizhsjQMpFGLiaxWawrvR1XwRP?= =?us-ascii?Q?0gaDUGPMYV75E94U2wv/wqtTwxjgw+topwKMAJa81YrjKe3K8DGUH2cTdvKw?= =?us-ascii?Q?ceJ5FouYFWC2yClwAL3eNcIhi0ay6OZasikSKcchahawbtLZyYsrtcAxeHA3?= =?us-ascii?Q?HpS9WEw0zyEGmyHFnsnU5qc2m9AI/3/gbo1R6xT9ghr0wVG8VJiq+dZNs7qc?= =?us-ascii?Q?Z5EE8MXJ9EA5R3LJBiVyfR+W++vjDpra0zimCrqMN9TZLfWpre+3dC1LyVOU?= =?us-ascii?Q?01xv5LAn0+YkYhTwFrR2ccua3NonsWPmqFP8mF5c4/cz8+fEcm35OnsOZCRH?= =?us-ascii?Q?4jlvm0t9cNZMfdX9g+vcwhEovMM3OdUlRZzXUh4uOII=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5a4d497-2e53-46e5-c59c-08d89c2b1316 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 10:13:28.8832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dD92Q/BkuEC2jPyK+zBDojhqEHoUQrXQf8NYPY2vNvPzOiLLLV5Gt3nErJ05C3xo6gHpzFZJIDiOf5o4xQizUExE3csSrDXNifDz3dfWRqk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5203 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Chasel Chiu > Sent: Monday, December 7, 2020 6:16 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Incremental build with UPD in > sub DSC. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3107 >=20 > Current script only compares main DSC and output file datetime to > determine if re-generation required or not. > When UPD defined in sub DSC and was modified current script cannot detect > and will not re-generate output files which caused incremental build issu= e. >=20 > Since UPD can be defined in any sub DSC the script has been updated to > compare all DSC datetime with output files to determine re-generation is > needed or not. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/Tools/GenCfgOpt.py | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py > b/IntelFsp2Pkg/Tools/GenCfgOpt.py index af7e14a10a..a0b8bba81e 100644 > --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py > +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py > @@ -313,6 +313,7 @@ EndList > self._DscFile =3D '' self._FvDir =3D '' = self._MapVer =3D 0+ > self._DscTime =3D 0 def ParseMacros (self, MacroDefStr): = # ['-DABC=3D1', > '-D', 'CFG_DEBUG=3D1', '-D', 'CFG_OUTDIR=3DBuild']@@ -423,6 +424,9 @@ > EndList > self._DscFile =3D DscFile self._FvDir =3D FvDi= r + # Initial DSC time > is parent DSC time.+ self._DscTime =3D os.path.getmtime(DscFil= e)+ > IsDefSect =3D False IsPcdSect =3D False IsUpd= Sect =3D False@@ - > 530,6 +534,12 @@ EndList > if IncludeDsc =3D=3D None: > print("ERROR: Cannot open file '%s'" % IncludeFilePath) > raise SystemExit++ # Update DscTim= e when newer DSC > time found.+ CurrentDscTime =3D > os.path.getmtime(os.path.realpath(IncludeDsc.name))+ > if CurrentDscTime > self._DscTime:+ = self._DscTime =3D > CurrentDscTime+ NewDscLines =3D I= ncludeDsc.readlines() > IncludeDsc.close() DscLines =3D N= ewDscLines + > DscLines@@ -815,9 +825,8 @@ EndList > if not os.path.exists(OutPutFile): NoFileChange =3D = False else:- > DscTime =3D os.path.getmtime(self._DscFile) OutputTime =3D > os.path.getmtime(OutPutFile)- if DscTime > OutputTime:+ = if > self._DscTime > OutputTime: NoFileChange =3D False = return > NoFileChange -- > 2.28.0.windows.1