From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.1221.1603735213159196723 for ; Mon, 26 Oct 2020 11:00:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=igXgX2eq; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: nathaniel.l.desimone@intel.com) IronPort-SDR: LTrtOFlXKh6vyfR6ulnP6GYwL2YdHCK3En9+zoJg+uTzBFkIluyRst4OIinCeo4iQNzUyZxsS/ ZN4PtvtAuXOw== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="155745431" X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="155745431" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 11:00:11 -0700 IronPort-SDR: PXYATsR8xD/M2X9P+bBs8ygLQpQn5AQx5ydQy/kv/xGCV4unxBEjblxS7JJskiql6z/MFQwPcF 2BpE8JWmptQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="361080895" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 26 Oct 2020 11:00:11 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 11:00:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 26 Oct 2020 11:00:11 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 26 Oct 2020 10:59:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPPnRFJsCj5yfAfTK+RMBp9Oa0YFfjsTjRPUhO0S8sI6yw50CO4BRbEAAEKtjn+F7gfvxAimOsmZoV6WsVP8/XQJNjBpRLNm3rJ5HudHkMkhqps0gXizL/wfEO4eG9CiOC60Phx/BL9kYcwfgA6gYBkKLOiRRnqKw40shWu8AhLFtXhB9xun6/CnArKXnQP9ZFYEdmOziBn3zVy8Zflb3XdTKJ8JJLXhpFCGOEs8pZ0/vS53ytIs0KKqg+D8+7XGfxlSkSkGq3M/tmGoMwQHrzf8m3ucGd8u20Nuk89S3kTjDzZPq20WLQN21RdWY+Mj6bUDOpSPwguz/05BE2xtLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GuAOyhKJHPyIApmW99j2b1BEbCM7r2KyM8SCDKMBLrc=; b=jn/qiv5MNRYIM1l/6E1ewE+hxgZR+TCnhRnOehgAOfD4IzZakbGp7WOVFp/T+l1d2eo6++YdTlNAtW/q8y2saHLEP4Cug6W/7JL8TrbmmtOeBIO3GSDLG3y7FsjzyzUji6PGt8TP0h+7WcuC8nc5U/vUThox7WG165F4hgbpaTzjFVxq65hko4AiqUhQW24AwS8XskPyl31uBMo9uW83OlEgW2Sjo5Vev1DdaUt0CPLysJyeHhJALcm4KL+SvM8ZKLOTz7QZ3DoJZBFzEXMSTAVjQscdPf+5Pj8I6hSgwPgsUFG3W2o1vaQQdO0dixBmGP52Fj90byai0Q4QCrXY1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GuAOyhKJHPyIApmW99j2b1BEbCM7r2KyM8SCDKMBLrc=; b=igXgX2eqCf1LYZCqkb7C/sJ/t0hdd2xYGbY/GAGwEAVelisEgwJ0E8j9jztjhr0aSih9Xal2K72jBNONxfyC/nmJ6RFbo0k8Oah9Ha63Sg6SbHCdwbCb5mUlLkc/6KUicOhaFiygHhJdhKqNLESvu1y97STm11l0trL/6S4Qezs= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MW3PR11MB4729.namprd11.prod.outlook.com (2603:10b6:303:5d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.22; Mon, 26 Oct 2020 17:59:31 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::75c9:81e9:2646:791c]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::75c9:81e9:2646:791c%4]) with mapi id 15.20.3477.029; Mon, 26 Oct 2020 17:59:31 +0000 From: "Nate DeSimone" To: "Lai, Cosmo" , "devel@edk2.groups.io" CC: "Lai, Cosmo" , "Ma, Maurice" , "Zeng, Star" , "Chiu, Chasel" Subject: Re: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed with padding in FV. Thread-Topic: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed with padding in FV. Thread-Index: AQHWqB5Mp3Sl6EddOES+FMsxTG7r76mqMy0Q Date: Mon, 26 Oct 2020 17:59:31 +0000 Message-ID: References: <20201022025127.1136-1-cosmo.lai@intel.com> In-Reply-To: <20201022025127.1136-1-cosmo.lai@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzkwM2EyNGUtMjQ2My00NDNmLWFiMzctNDM4ODNkM2IwNDJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidVwvcjByRVAyNXVpVmpOUGhpY1BhVjVpM3Y4NjFBWnowazBzQW5OTDVWSWM2SlwvdzljY0xOVkhic2VEalpWR2NVIn0= dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.53.190.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e7fe222a-0762-4306-bb43-08d879d8e3b6 x-ms-traffictypediagnostic: MW3PR11MB4729: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1122; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mlWwtB20bISdVFTTcRi0rbKnQ9C/Ujkq/EmcrpZ901YJMXI+XO+goYwYYnMpPMVPAevMyqOyao3G5VrIqz1Oz4VhPEHB8J3qgTORGY7jA997tVQ+7/mrFPKcfyh6uOiyKMi1HtIbehwwYkXhQyVfd/sBK74YWmr4dNdQaUZGbrsCR2czvELUQz07YLsAt82dR25UT3t/fBqjnb0eoZ3XKwWNZkdCcQWD7nakRQosinKYZ9YF7nR8rFIaBOjVRmTeadcHNAX1blh2tfbR3y9SUgmcLCimXDO4m6SWG4++fugyDrHWp7d8LrPXv43hFGpSo0KCPgXCQSChQc976suFKueiYcvRvmUjoIuPk4tYvDNuReWcxoWk7VuFOfpmH4zQtBKFiTROS+L9lR2NRWL0ew== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(366004)(376002)(136003)(396003)(186003)(55016002)(966005)(316002)(8936002)(76116006)(86362001)(66556008)(64756008)(33656002)(83380400001)(9686003)(66446008)(2906002)(66476007)(110136005)(107886003)(66946007)(19627235002)(71200400001)(7696005)(8676002)(4326008)(26005)(54906003)(6506007)(53546011)(478600001)(52536014)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 24F2RFVWmY4AztctcpEPnkfuvlc8jBQRMIdF9mkzdXH0jlMLj0GxyIEDa5vHs99d1pG6BkSGbp2obxz/8H1IFDQden1SJdJ52zuY+3vwnmcw9R35tN9f/kWpeL37q4RtJcvDE0u/Li2oyvZLP0D1A7NjAg6F0A9fpQrnuq6w7SWAIHsR9lFLO7N6T44ywxVbqXeI/5PoMH69+CunIymzTRHMEWCzsaI1wG7jqP6AuDib+MnE7lUy4fE3XrtyYTQ4aHu2Nrq/jq6AzjLldnPK0lpkKPLArj3ncBPlqAnRAgorr15X3gJOrD2o7RFSrXSpQwcHRBBCZRGBZzrO7jOsu0EuI7WR5dpUkgCPA6CuKsvRk0WE13wbZU60FvoOwcIobPjZCjJGp5TRM5XaxVvFXOdlKGgtdL3GM9wnfSJgiBbeB5UqfMkT/CKXb0aDJ0qS1opwnKeElcvyltl4xT3P2SUgD/b/C4e5n8vh23me4mnahZKtlHy/Eb48ZUOZUANFGKumt8gDtNOM2czcq/Ogb3Eg7TTzbbGg7AqffGdQfCAPYQkJj8y7PgBR9K9PPPnkKeaJyPuKNT8BYx+Wg8Ao+81h0QoYGjIkTCwcg0iyR8XlZVKHQjGLoY5ORAocPe1iQe9ShJlq6gQma9W0sOYJvw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7fe222a-0762-4306-bb43-08d879d8e3b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2020 17:59:31.2435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BZ3XNuGQtEP6dQqmclbz+BvjZBvX2H6hSY/0yXYBp3W+5Pf6lmFUitQgLS/dHVMH+8HrGNPMJ2Nd3ts8xHg931LDQd11H/DlWjxT3Dt/y5Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4729 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Cosmo Lai > Sent: Wednesday, October 21, 2020 7:51 PM > To: devel@edk2.groups.io > Cc: Lai, Cosmo ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Subject: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed > with padding in FV. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3017 >=20 > Platform microcode FV may have padding between each version of > microcode binary, and current FSP-T/LoadMicrocodeDefault() cannot handle > this case and return not_found unexpectedly. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Chasel Chiu > Signed-off-by: Cosmo Lai > --- > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > index 7934eab6d7..7fd3d6d843 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > @@ -307,10 +307,6 @@ AdvanceFixedSize: > add esi, dword 1024 >=20 > CheckAddress: > - ; Is valid Microcode start point ? > - cmp dword [esi + MicrocodeHdr.MicrocodeHdrVersion], 0ffffffffh > - jz Done > - > ; Check UPD header revision > cmp byte [esp + LoadMicrocodeParamsFsp22.FspUpdHeaderRevision], 2 > jae Fsp22UpdHeader1 > @@ -341,6 +337,10 @@ Fsp22UpdHeader1: > jmp CheckMainHeader >=20 > LoadMicrocodeDefault4: > + ; Is valid Microcode start point ? > + cmp dword [esi + MicrocodeHdr.MicrocodeHdrVersion], 0ffffffffh > + jz Done > + > LoadCheck: > ; Get the revision of the current microcode update loaded > mov ecx, MSR_IA32_BIOS_SIGN_ID > -- > 2.16.2.windows.1