From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.5182.1633988820397676826 for ; Mon, 11 Oct 2021 14:47:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=vWeBZ0s0; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="207781044" X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="207781044" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 14:47:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="562369658" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by FMSMGA003.fm.intel.com with ESMTP; 11 Oct 2021 14:47:03 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 14:47:02 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 14:47:02 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 14:47:02 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 11 Oct 2021 14:47:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uc3+MfwgE/KMABmAVyH6N9+hFOIuSxHUn8ygGn6WPEFVJ0IHCciZqkearo7aeyR7MldZ6BFK5rz7nFoANRFRQNprXMjYg5GsNZgLZPy052iuoikIRM9H8bxHGtU8Ql3/+g4rSUABAwMoThHvzMoZehOkjKhzkdP1r3ztb6vLyspGrJoZDSP5eFpXWgTjbY2drN6x0oFP1/GAqyWCjK39F2ZSaMq5zSMA0ZMfeFYNUSG6HS7bgTJD4oeiLW55OJ6Qq9YyoKih+rjx4S6efGibg6pRLJZvxS61ZTRnVHyI+vNvVqF+rIISIssohkebPJ0w+RoTREAKQB5K+weRl2MZOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=52KMuZeDWVbuL6J5RobAN2lJ0V/URN7iDxAvIioFeDo=; b=VbkJO/EHnoKI+XE2RMhRIuJ9xYtRS/CnFfhPOtzHidDmU4WquGum2MRqcsAaogB5m7NEiadAV0M5oOkDYE7hafuBcVRKsFJO5FTGQYuV38NhD1MSTrquU3MySq2LgCh4luwkF5RS6N0d2phKAcBqskIQmqgsokm3VCBJ03sCVm61TNE8Lm/V0EGD3NurOMLUchWEuu/g0Y1Ok8wtmSdWGB8i1XzXgPHWfpSoMdmBH7EiwQ15YjsIyU+BviPUyziCnVdASRjjjebzwFMQsuJ4VWB1f7Lgb/tUfKB/+M6HHpox9qyYFXzGK/lgx1uzHYXWoSbfZdwlUuJpY8f+Au2iGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=52KMuZeDWVbuL6J5RobAN2lJ0V/URN7iDxAvIioFeDo=; b=vWeBZ0s0zklp7HEXYeXBj2MeoK6jtT0VxW2Isvudz6oEYFTINyBKS35ezl1DWm4hxDj9C2oMRKDEeihw7lCeO9+MOK4LwQje2CRlOsKjgk0Fua7YttEMy17YWwnM+ClwpkcqgpNtJyOo20wCwyLruMz+hFn/rFtsCOa5ysbR8fI= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB5057.namprd11.prod.outlook.com (2603:10b6:303:6c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Mon, 11 Oct 2021 21:47:01 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed%11]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 21:47:01 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Oram, Isaac W" Subject: Re: [edk2-platforms: PATCH v3 9/9] WhitleySiliconPkg: Use same variable name for FspNvsHob. Thread-Topic: [edk2-platforms: PATCH v3 9/9] WhitleySiliconPkg: Use same variable name for FspNvsHob. Thread-Index: AQHXvA/bxhLVJsSZqUSMyDY+l67rB6vOWrqA Date: Mon, 11 Oct 2021 21:47:01 +0000 Message-ID: References: <20211008064317.1371-1-chasel.chiu@intel.com> <20211008064317.1371-10-chasel.chiu@intel.com> In-Reply-To: <20211008064317.1371-10-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9de8a236-1a44-4939-31a5-08d98d00a882 x-ms-traffictypediagnostic: CO1PR11MB5057: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 34G2W1NeRy1wzJNRr7i3LEj83W39/xMMJ234BRKwQiwG6Pa8Aq/OERfvv0byy2T3RrRI5vptTsKm7o2yttPK6fCjplOTtksjXTXQ6/i8tr4FUAnm1L7MwjicX2y8zmTV6dANXIO5eYMKpBitRB3lFXelydeD2e9lh53VTvYeKTWDpjsnYhw1IXK3MfBH9sJ+9rBhKZMKM64YWYv2mkvO+ycD5/mabZ6TkAuAGurWNfBxG251ZO3TEUNGRVKNu6nejDeY32eiJRJlD3poHfOJlAE2liBtWDkHlh3Ew4NXFlVqcThZbJnYevcqFtHLkMRJH5ZlAUi3+nSBU8yHmPweBG1QKMjnYcjHs0n+nSdKAHmhWdxVnc5XEDP3F9j67QTV6OX462rTDbJ/a/ZNlWc04vhogGIxUmtux2CaIrTRVgFE2TfeHXZeVIWGvQpsoF4/qPQ1kPRCS+lyZHuWi2xM6F1+41C+2fbsgthekvy0tiKsq8aGh85d88uGk/K0xZKccAXXPG7uDxjKj8Jw/pwkDzhfd2a6t0jop32K4eq6OKFpKhHlD4c/7FY//e3TlRXldWQCypQcvuDIrvJTLNI+syU3v+6B8eWFPOjGxH4dmPcaOpsx40GjjfIuVg+gkFZLT/+dpvLtKs4BFij0R478c7pBUBgJ4rPHfyz4V3jV9uYNHDg1C9nXeetxbUOHpYVEulc6T9jp1Z8YjHCl9C7GefSzGP1cNnEp95+rQi05kFToh/bcjwg9m7O7YkuFL+CngniP8J75Qie+WdEs0pHicihRkKKAhTNzWCet4awpS0k= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(64756008)(38070700005)(33656002)(83380400001)(186003)(8936002)(66556008)(4326008)(2906002)(66476007)(107886003)(122000001)(26005)(66946007)(52536014)(7696005)(5660300002)(316002)(8676002)(9686003)(76116006)(71200400001)(6506007)(55016002)(966005)(38100700002)(508600001)(53546011)(66446008)(19627235002)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ClcVdcq3ieXKE/ForHookHsmYAKIMQbfWl0b7qF/wcx4nznAZyNnvikGgDpR?= =?us-ascii?Q?AGt9s3Dw1FL8bR0fSr7chmIYUO/9o5Thq6NGXoTacWlTgmrr9PE10YDZJu4J?= =?us-ascii?Q?puPJRYTK7xyL7PGY2zic4uKT8029urorI3Ab7X9RgDBuSCscAMv7KOc/EFVm?= =?us-ascii?Q?C8FLFbAQCzQqfDs8YQh+UAFTS/1jVQzBJJVwtGOHAG6i0Ru1t8rEWc4JaOvi?= =?us-ascii?Q?CN1xA9KGJ6B3qMl8t1mZj7HLJuLVNbXV5gI3lf3bY6JIYFVL8sB+xbTLjO6N?= =?us-ascii?Q?ygxgezYhY/TYwF+B4bnLwqufZYWlEDLcFcnZ55Z4yhDxnXxFC1AK7QFOPc9t?= =?us-ascii?Q?ohYz1BHOpl8DU+4RLNPz9YTxmUlWivA0pEYqMlXsbVYBHDAYlZT1iJ3Ne9fV?= =?us-ascii?Q?7CrohEmBuF5LBXmB6zfZvooY21IVwT4I2uox1zAkdWzWTNgiFJcGVY/INL9a?= =?us-ascii?Q?WdrcRT25a+AD5/ErVXBBq9wrKi3QUo0PPnM/zk5Rb8wMl8+pt0ZV2PsSslK4?= =?us-ascii?Q?zQwbpN2z9875NSqVimIj4YEdrq8rX3sdAL92zLe4KwthDlx7OrAxhmvyARQt?= =?us-ascii?Q?cgaMt2HNI8vanvbwsm1Foa0kvzqzSFsj1iJuO/juTEXbBufxP6WwQmSqmaGa?= =?us-ascii?Q?xtm7H2fSuWKWFOfgwQZAN7IJlA9HJzCcbsoeB225t2K8n2wcGz6U1LLcKetD?= =?us-ascii?Q?zvzQLDum6JWQiAWgk7z9lo774to6i7COksGM5+wu5kCnFkQQSLuQCO92h5Nq?= =?us-ascii?Q?zcwEfkSd7rZPJVUMWrdaeEoR0g8JgVnmF11VMEAcfRC2ohtYXMo3vytC8Y6K?= =?us-ascii?Q?/QjGYVr+rxbepRl+YRZEnSJzWVMce1I/5HPk2b/RS1WwYOFCA10Rpo7N/8MI?= =?us-ascii?Q?ULWtCZYmjgxm9kquVM++U7K3XBZX0UDRzO0BwIlJSQ61fHBvBxGZxlzHcJI1?= =?us-ascii?Q?z3o76azMGHhAyG/8bPn7M6/Gn11DpSkZ+0mAHU+ywEUzEIoXD3+ju6XamdaQ?= =?us-ascii?Q?nwOwvO6y1P/cJl4/Zdzx8Tbax4cbqDfJbWh5sptRdSUBpIPz24fx+vg9OqjH?= =?us-ascii?Q?lEMof3v6JFT3IBtBO639B6y5ufGNw30pTMRJZRNsIO777nXhxB0xbgUNvB8o?= =?us-ascii?Q?1amnhGnpqJFhq1T97j3pNM9bgbujtlQkhUXesT5d2XKYim4lf9Lfa2K1jpJN?= =?us-ascii?Q?wIUuXXzuURLV9RS3Dp6T79Iy3i0FJcNfB4jfNVnDlQO6guNSBOR3gWDRx0xQ?= =?us-ascii?Q?ghaYo19/xJ572D9jCRZL4Vcd8VulBy/mMIBtAnIqMD9ST+7iHhKC7JLI9ojJ?= =?us-ascii?Q?eelQ3nK3+Gw1jfkyDr2GdCkn?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9de8a236-1a44-4939-31a5-08d98d00a882 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 21:47:01.4647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PD5FWzBu++RW+OMxKOAMJeZukL1dwQykxWm6BLTXXgJdtzXBHNaVgYJsUB5+OzwhnO3/vQlnbvqWwqk5o/lvuKwObC60HSvaeoAYsWnOSnM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5057 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Chiu, Chasel > Sent: Thursday, October 7, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Oram, Isaac W > ; Desimone, Nathaniel L > > Subject: [edk2-platforms: PATCH v3 9/9] WhitleySiliconPkg: Use same > variable name for FspNvsHob. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3678 >=20 > To simplify the implementation the variable Name/GUID has been changed > to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the > data from FSP_NON_VOLATILE_STORAGE_HOB2 or > FSP_NON_VOLATILE_STORAGE_HOB. >=20 > Cc: Isaac Oram > Cc: Nate DeSimone > Signed-off-by: Chasel Chiu > --- >=20 > Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapper > PlatformLib.c | 35 +++++++++-------------------------- >=20 > Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapper > PlatformLib.inf | 3 ++- > 2 files changed, 11 insertions(+), 27 deletions(-) >=20 > diff --git > a/Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapp > erPlatformLib.c > b/Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapp > erPlatformLib.c > index a6196a78b0..95a1f2a33c 100644 > --- > a/Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapp > erPlatformLib.c > +++ b/Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspW > +++ rapperPlatformLib.c > @@ -13,7 +13,7 @@ > #include #include > #include -+#include > #include #include #include > @@ -24,39 +24,22 @@ GetFspNvsBuffer ( > ) { EFI_STATUS Status;- UINTN FspNvsBuff= erSize;- VOID > *FspNvsBufferPtr;+ UINTN FspNvsBufferSize;+ VOID > *FspNvsBufferPtr; FspNvsBufferPtr =3D NULL; FspNvsBufferSize =3D = 0;- > Status =3D GetLargeVariable (L"FspNvsBuffer", > &gFspNonVolatileStorageHobGuid, &FspNvsBufferSize, NULL);- if (Status = =3D=3D > EFI_BUFFER_TOO_SMALL) {- DEBUG ((DEBUG_INFO, "FspNvsBuffer Size =3D > %d\n", FspNvsBufferSize));- FspNvsBufferPtr =3D AllocateZeroPool > (FspNvsBufferSize);- if (FspNvsBufferPtr =3D=3D NULL) {- DEBUG > ((DEBUG_ERROR, "Error: Cannot create FspNvsBuffer, out of memory!\n"));- > ASSERT (FALSE);- return NULL;- }- Status =3D GetLargeVariable > (L"FspNvsBuffer", &gFspNonVolatileStorageHobGuid, &FspNvsBufferSize, > FspNvsBufferPtr);- if (EFI_ERROR (Status)) {- DEBUG ((DEBUG_ERROR= , > "Error: Unable to read FspNvsBuffer UEFI variable Status: %r\n", Status))= ;- > ASSERT_EFI_ERROR (Status);- return NULL;- }-+ Status =3D > PeiGetLargeVariable (L"FspNvsBuffer", &gFspNvsBufferVariableGuid, > &FspNvsBufferPtr, &FspNvsBufferSize);+ if (Status =3D=3D EFI_SUCCESS) { > return FspNvsBufferPtr;-- } else if (Status =3D=3D EFI_NOT_FOUND) {- = DEBUG > ((DEBUG_INFO, "Cannot create FSP NVS Buffer, UEFI variable does not exist > (this is likely a first boot)\n")); } else {- DEBUG ((DEBUG_ERROR, "= Error: > Unable to read FspNvsBuffer UEFI variable Status: %r\n", Status));- > ASSERT_EFI_ERROR (Status);- }-+ DEBUG ((DEBUG_INFO, "Cannot create > FSP NVS Buffer, UEFI variable does not exist (this is likely a first boot= )\n")); > return NULL; } ++}+ VOID EFIAPI UpdateFspmUpdData (diff --git > a/Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapp > erPlatformLib.inf > b/Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapp > erPlatformLib.inf > index 3e80ea670c..6ee15ea55f 100644 > --- > a/Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapp > erPlatformLib.inf > +++ b/Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspW > +++ rapperPlatformLib.inf > @@ -58,11 +58,12 @@ > [Guids] gEfiPlatformInfoGuid- gFspNonVolatileStorageHobGuid+ > gFspNvsBufferVariableGuid # CONSUMES [LibraryClasses] PeiServices= Lib > LargeVariableReadLib+ PeiLib [Pcd] > gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES-- > 2.28.0.windows.1