From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.20408.1629091342016839351 for ; Sun, 15 Aug 2021 22:22:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=mtT5vIsp; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="301380960" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="301380960" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2021 22:22:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="519381361" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 15 Aug 2021 22:22:21 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 15 Aug 2021 22:22:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sun, 15 Aug 2021 22:22:20 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 15 Aug 2021 22:22:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jF3lQwNDmEpZJLgL+g82kFtOQ8WwIMmQtYiRGwVifkxFZfaTIVIAYll4oSr9obJDNAU58+aoIoWwKxjMkyCuEO5CQVYeFZPsflCwAYeJAzd1qLL1CV6A976D6I7BmRHHz9OedJu7JGBI7VRy/wDEJ6n+iNugDXestCpVO2L2YUk6lA6y/r3yUtAtE0GPKaXz8AwYDBzEypjODzWLIymH4pkL9Dje0/HtC5oTDBxKfoQm94XozIxqvhE6rkiWzhXwvvj/vD+Ts7Ukn848sQqo7S1SETztb4XbanlyxHonn1yeSiQNEtz+84DgIsODc/cGGAwlPw2MP9sumriGgbiN7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZkxMqO/3rs/l5HviY778uvd0yobniP/2fvxhDPpBlQ=; b=kBmCtwAqRBGPw2UrrHLEz0TaHoIQMqpm0bQfCzJ66/M0Ke29LkP59oxQ/m4fNzDnBzLhCbjN02E3hnV9DgYE1Q4L2E5VGQs3EWH6PFeIEByW+L6uvHy67slP8hdeG0YCoWtWhtE4ZZUhJ0GTdNlTZ+Q8xCyBi1iWfYIsco+n/hvn5NqeuRHPfGlkS5XSF5rQAov0er2LWVFwo3T9hkUYq2JmZpmpwcn+jHj6M3Vk5hG76Y19Gnwxo4gxAMPJ/np4RPm0tsT2Q858qPacvS3LhG5f7qZVVg6g5C+nvq5EZOTQ8cKtvhLmMF/L5qLfGh6/tVG/3HHzf+wlwNP7QoDoGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZkxMqO/3rs/l5HviY778uvd0yobniP/2fvxhDPpBlQ=; b=mtT5vIspePMUvON35lzzlFLCLYy9s+EXSG+PjzAORjodICGjdH9FytmBPOqUJQ3KpryvaTcOKk2S6caZpX7DfuSIiFT9OZsDYIGKgh8/X0HLSEOCx9eJ/gPZptI2Y48cdnoCnXTJgnudXzaDHroNCRJngiMj+L/7M3VFTmb+QRo= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by MWHPR11MB0016.namprd11.prod.outlook.com (2603:10b6:301:63::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Mon, 16 Aug 2021 05:22:19 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::546c:f20e:35d2:65a7%5]) with mapi id 15.20.4415.023; Mon, 16 Aug 2021 05:22:18 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "benjamin.doron00@gmail.com" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v2 0/5] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Thread-Index: AQHXkKLa1ww7ZUSHkUW/M42rxf6CXat1mMJw Date: Mon, 16 Aug 2021 05:22:18 +0000 Message-ID: References: <20210804203630.7080-1-benjamin.doron00@gmail.com> <20210814002445.10084-1-benjamin.doron00@gmail.com> In-Reply-To: <20210814002445.10084-1-benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: baf3cc72-0d06-4549-d457-08d96075d14e x-ms-traffictypediagnostic: MWHPR11MB0016: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v7C9U1usKFII9vuqwX325vQzkzMZVMJ1LjPzNLF0xKssfgEV1413ZpYR+zyVt92YX3jcGNE68849seJAJpYgWStTkqId3cYGvBB0TtEUUQlgYcAxBrsDaG3ybDzjN0N+z88VQS+dmhdbft1uIVPy5unybwU/GJD8y2DluCrLQ1QM7vaGHIWVill8L7k209XC12TLreBuIWjz0vs/yoz5+pCHHq93m9fgHNzvIbTUiOAYLXa4nrLJTINBhEyioP+08pKoZad5LDKP/LKisNX67nw0mBpictBN4CI5jgR+h9YLhhn5t40MPj2LC4P0bV/UA8kz6jE4dUp9lAj6VySwbCjowewSt6HkbNvoKa6VzuhgiJUZw9CnTXn/v4T4pmbHufDCURDzgnY1fX8t3RH72vYYynnTsRy4oPDgxwtwH4qxK0o8ck6mCtD/VbJP6nEHsPiFG2tPQpqsEU/dh8G0B/gZzHbnC7hhN8WtzwESaIigqqMQ7oWEAdOgNmt762iBViVK311PjvROjwVz2Dcx0vJLnH85/mvg5jFw2DedlAHn47ON4e/JXcYUhsTrxT2gel2HODEmoZ7ep3dZCEV7aQXIbM6v/G5GIpYTo69/N81F0fqdcH6UJHiZ8S1Y/GVo3HVe4owlTTTLezp70WbIpD1DxWCEZfdzODdGpfZ1uRJRfRa1W/RB5zTTy3hu1C5lTgFSNAEO+oZ4kmLPHU+WalePlp1l0WwiBVxAPLwpBNB8RXG9F5OY7ps7wWxnmuAdi475mpJUaI8P+pOrZHpA/B6nP3915LgbEAdkCb4wNjAdno83toq0qnT+IaQG1t8nkevEIVJLfFEUw7y5uZoA4Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(19627235002)(76116006)(122000001)(71200400001)(186003)(8936002)(30864003)(38100700002)(38070700005)(8676002)(33656002)(83380400001)(53546011)(55016002)(6506007)(52536014)(9686003)(86362001)(7696005)(66476007)(66556008)(64756008)(66446008)(478600001)(66946007)(316002)(26005)(966005)(2906002)(110136005)(5660300002)(559001)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RL3MDBXnLV5IsMcApvDoTDXvcdl2XdQKx6Zgpfmdc4hfUdlQ5Qpf1XtWEo3l?= =?us-ascii?Q?pBGvzcsuhzq2lks0+TaE7J/8dwrIN1xYzQEjWhbo23AB+lesdFudXGHJ+vSr?= =?us-ascii?Q?KDIz+h2w2bTmvuUp9OTTdLbsyPtpmthpm7/NCW0Clg0Ks6JIbJEQhmFm0Eyi?= =?us-ascii?Q?HIxpjsDuKNEpz9ybLZmBg4HlosFl8UurTBFb+AQzMbcNRqeOfQN8ZvTGGYso?= =?us-ascii?Q?kCjkRNGEHuFjQWSIVoGBo3UNJXPjyqk6kRehLA0XNKP4OYA0+V5ZUUk3t03D?= =?us-ascii?Q?Ds/JHOSToCIgfePGgiqTocViGveAXP9YCzGaS08vT3t4x4bxqfp+AC14vfz3?= =?us-ascii?Q?FFqCvYmpsTBM+oG23mkX1b7bJVdTNHBg/Wzh7ymya3bWgCQtr/exvrdZvpZt?= =?us-ascii?Q?CTaJom2njUXXMxtuW5VuEPSi1bwTSEzGaoBzOzJb/OQhS9HoOMDU3vDVNNwg?= =?us-ascii?Q?wteIEBSDNwuLO90ku36YBT+GNbd2LElcitggQMmffnGTMnKG5tVYSxwsM2+7?= =?us-ascii?Q?gP62H6GOQ38OPjIGgRfUq28fqd1wTYaslsa/bcp7f2C2y7wYlaG4cIg41I75?= =?us-ascii?Q?AWvZGzYzb+0JZgVzaZ9Q7fU7aNuT5T1tW/+T9kqk7HeBS8JfdtFZ682KVdcE?= =?us-ascii?Q?B+WaDcGVRtgP9Pe0kuOUpTg1NKLr730lK+e4Qt9T73V0J6SlsLBnq0Hk9c0a?= =?us-ascii?Q?ofr4WxijiUZnVD2TYdo9/AO8+h1HTkwL0VbFNRBehao4KQdLPYYSM15lGcpr?= =?us-ascii?Q?VyZK6OVMH9QCj+xSAw4bpQXYT2BpPgj/SBSigSQHc4mEX+9POH9nNMpwYCv7?= =?us-ascii?Q?qJH52e/QCvjweAV2fHpQXTivSfk5kIUugglrv1Iq3mhPpigOLWixAKt6QMRf?= =?us-ascii?Q?/SnatJybp4IpgA8Dhi9iU2qPxHdut5wxatzSwOW83X8/7P0lnQuZkRyl3uvk?= =?us-ascii?Q?wswXCd4Vgo2JgIOkriN4ePr70Ryvt0uCQFehi0D+YHUhz1vGyhqiTZh2gUWK?= =?us-ascii?Q?HpArg/TbxkQB0r2Zv9bqHZBavh129+4Q/qd7+HDsQdcnjeVrDS2EZTQGcOuU?= =?us-ascii?Q?MOprMXoakYoCYI8IewPVDW3lYHYMSIbDzhXkOURAu1cHwNWsYPgXKD5yI99O?= =?us-ascii?Q?9IBa6gcwJM2pQnfUYsMzF5OqG2t+fxWXsUaVBYKdeE3n9tzBSE2AVPBOzQA6?= =?us-ascii?Q?JOKNyzIGBfcWSZfiVFGL26tLvW8qcigihHQ8P/hmtVDEtx1jcy8NElx5Gl/L?= =?us-ascii?Q?PRkILNdKDuFayMGRGGgkyjNNmLx46hObBx/HoeAPr+Tvwy6XmRwwWNb4og7k?= =?us-ascii?Q?Cr8BKaRISfVFQ/qgsngwb8kD?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: baf3cc72-0d06-4549-d457-08d96075d14e X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 05:22:18.7610 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3sEoqoR8J5fPnDmfqo3o+4+0P9nzDCEe805/Mo00T8ZR3hXZ7qYevW2KI+uZR2jJI9+NbjZokweBoS9igAL2zZ5FPZa+r1yYBQ1bc+w187g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0016 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Benjamin, First of all this is fantastic work, it is very clear that you have put a l= ot of effort into this. Thank you for doing so! I do have some minor code r= eview comments for you. Here is a summary of my feedback: 1. KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPoli= cyUpdateLibFsp/PcieDeviceTable.c: Line 16: I think it would be a good idea to file a Bugzilla for this. Could you p= lease do so? 2. KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPoli= cyUpdateLibFsp/PeiBoardPolicyUpdate.c A lot of this code in this file demonstrates that is probably makes sens= e to create a top level PolicyUpdateLib in KabylakeOpenBoardPkg that the va= rious board ports import because most of these settings look either identic= al to RVP3/GalagoPro3 or they come from PCDs and hence the code will always= be generic. Definitely not something you need to do for this patch series, but somethin= g to think about for a future enhancement. 2(a). Line 49: I find the whole situation with PchHpetBusNumber, PchHpetBusDeviceNumber= , PchHpetFunctionNumber, PchHpetBdfValid to be very odd. I looked though the FSP source code to see what these policy options do = and it boils down to if(PchHpetBdfValid) then the FSP will program the foll= owing register: https://edc.intel.com/content/www/us/en/design/products-and-solutions/pr= ocessors-and-chipsets/comet-lake-u/intel-400-series-chipset-on-package-plat= form-controller-hub-register-database/hpet-bus-device-function-hbdf-offset-= 70/ I can confirm that in the FSP source code that the default FSP UPD value= s differ from the default config block values. Moreover, the reference BIOS= takes the config blocks and converts them into FSP UPDs just like the open= source code, so most of the testing for KBL FSP was actually done without = the default UPD values. We consider cases like this where the UPD and the c= onfig block defaults don't match to be a bug, but given the age of the KBL = FSP getting that bug fixed is difficult at this point. Have you tried booting these settings? PchHpetBdfValid =3D 0 PchHpetBusNumber =3D 0 PchHpetBusDeviceNumber =3D 0 PchHpetFunctionNumber =3D 0 That is what the reference BIOS uses. The equivalent UPD and Config Block defaults for I/O APIC do match. 2(b). Line 50: The default for PeciC10Reset should totally be 1. Good catch! I have created a patch to fix the properly. Please merge https://edk2.gr= oups.io/g/devel/message/79328 Then we should be able to remove this line. 2(c). Line 97: This is OK for your initial patch series but please make sure work on a = follow up patch series that moves this to a setup option since it is insecu= re to have this be the default. 2(d). Line 107: From what I remember the VN-572G only supports S3 and not S0ix. In which= case setting PchPmSlpS0VmEnable =3D 0 would be mandatory because that feat= ure only works in S0ix mode. Historically most systems with switchable grap= hics have opted for S3 instead of S0ix because power state transitions are = more difficult to implement correctly in S0ix. Please add a comment that describes this. 2(e). Line 198: Please create a #define for "3" that describes why these settings are si= gnificant for only the first 3 USB2 ports. Also, using a variable called "i" as the index variable of a for loop do= es not comply with EDK II coding style guidelines, please use "Index" inste= ad. 2(f) Line 205: Please create a #define for "9" that describes why these settings are si= gnificant for USB2 ports 3-9. Also, using a variable called "i" as the index variable of a for loop do= es not comply with EDK II coding style guidelines, please use "Index" inste= ad. 2(g) Line 212: Please create a #define for the number of populated USB3 ports. Also, using a variable called "i" as the index variable of a for loop do= es not comply with EDK II coding style guidelines, please use "Index" inste= ad. 2(h). Line 219: Please use PCH_LP_XHCI_MAX_USB2_PORTS instead of 12. Also, using a variable called "i" as the index variable of a for loop do= es not comply with EDK II coding style guidelines, please use "Index" inste= ad. 2(i). Line 222: Please use PCH_LP_XHCI_MAX_USB3_PORTS instead of 6. Also, using a variable called "i" as the index variable of a for loop do= es not comply with EDK II coding style guidelines, please use "Index" inste= ad. 3. KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/EcCommands.h: Line 45: We have this in the original code for triggering some board-specific wor= karounds needed on old/early builds of RVP3 but not later ones. Given that the AspireVn7Dash572G is now disconnected from the KabylakeRv= p3, would it be possible to remove the command to EC for reading the Fab Id= ? That scenario seems non applicable to the VN-572G. 4. KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7= Dash572GInitPostMemLib.c 4(a). Line 56: Please add a header comment that describes what this function does. 4(b). Line 58: Function name doesn't follow EDK II coding style guidelines. Please rena= me to EcFillsTime(). 4(c). Line 81: Please don't commit commented out/#if 0 code. 4(d). Line 119: Please delete trailing whitespace 5. KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgPcd.dsc: Line 188: PcdSiCsmEnable is just tells the SiPkg that the platform code contains a= CSM. It is one of many... many things you would need to do for proper CSM = support in KabylakeOpenBoardPkg and is way beyond the scope of this GSoC pr= oject :) Everything else looks good! Thanks, Nate > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Benjamin Doron > Sent: Friday, August 13, 2021 5:25 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/5] > KabylakeOpenBoardPkg: Add AspireVn7Dash572G >=20 > This patchset adds support for a Acer Aspire VN7-572G (SKL-U laptop) boar= d > to KabylakeOpenBoardPkg, based on Kabylake RVP 3. As stated in a later > commit message, there is a second, similar board: VN7-792G. > - VN7-572G =3D "Rayleigh". Working, supported. Uses PCH-LP. > - VN7-792G =3D "Newgate". Assumed broken, not supported. Uses PCH-H. > Also known as the "Black Edition" of the Aspire V Nitro. >=20 > Because VN7-792G uses a different PCH, routing and GPIO configuration are > assumed to be different. Users are strongly warned against attempting to > flash images to VN7-792G at this time. Support may be added later by > reverse engineering, but logs from a running system will help. >=20 > Additional build depedencies: > - https://github.com/benjamindoron/edk2-non- > osi/commit/7bf736989159b74012d9bf3a13a9f941036be97a > - > https://github.com/benjamindoron/edk2/commit/db888a928c1c6fc94f6a767 > 0f3402718c10c01d2 >=20 > V2 changes: > - Whitespace changes and changes for coding guidelines compliance > - KabylakeOpenBoardPkg changes merged into "duplicate KabylakeRvp3" > commit > - EC (ACPI): LGMR hooked-up (disabled), other changes. > - FSP-S configuration: Drop thermal changes not set by board, do not > override UART2 mode (PCI by policy) > - Set DspEndpointDmic so FSP produces correct configuration in HOB for > PchInitDxe. (However, 1ch array DMIC may not be supported by the > Linux driver. Also, presently NHLT is not installed in any case: > DspEnable=3D0 in HOB.) > - Avoid indirect function calls for GPIO configuration and deduplicate > HSIO tables > - Make board detection work and parse PCB version information > - Begin working on hardening platform and improving PCD > - DXE stack guard, NX for stack, NULL pointer detection (DXE NX is > broken) > - Measure FSP to TPM (presently skipping FSP-S, there may be a bug > where the first TPM command from this time will timeout waiting for > goIdle) > - UGA draw protocol and HII OS runtime disabled, fast PS/2 detection >=20 > Benjamin Doron (5): > KabylakeOpenBoardPkg/BaseEcLib: Add some common EC commands > KabylakeOpenBoardPkg/AspireVn7Dash572G: Duplicate KabylakeRvp3 > directory > KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files > Platform/Intel: Early hook-up Acer Aspire VN7-572G > KabylakeOpenBoardPkg/AspireVn7Dash572G: Add initial support >=20 >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardAcpi > Tables.inf | 18 = + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardSsdt > .asl | 34 = + > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ac.asl > | 16 + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/battery.as > l | 408 += ++++++++++ > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ec.asl > | 431 ++++++++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/mainboar > d.asl | 79= +++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/thermal.a > sl | 117 = ++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c | 104= +++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c | 288 > ++++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 82= +++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspPolicyUpdateLib.c | 213 > ++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c | 139= ++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h | 26= + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c | 243 > +++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c | 77= ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.h | 29= + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdatePreMem.c | 66= ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 145 > ++++ > Platform/Intel/KabylakeOpenBoardPkg/{KabylakeRvp3 =3D> > AspireVn7Dash572G}/Include/EcCommands.h = | 7 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Fdf/Fla > shMapInclude.fdf | 50 += + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library > /BoardEcLib.h | 112 += ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/DxeAspireVn7Dash572GAcpiTableLib.c | 74 = ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/DxeBoardAcpiTableLib.c | 30 = + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/DxeBoardAcpiTableLib.inf | 47 = ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c | 64 = ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/SmmBoardAcpiEnableLib.c | 55 = ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/SmmBoardAcpiEnableLib.inf | 45 = ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/SmmSiliconAcpiEnableLib.c | 166 = +++++ > Platform/Intel/KabylakeOpenBoardPkg/{Library/BaseEcLib/BaseEcLib.inf =3D= > > AspireVn7Dash572G/Library/BoardEcLib/BoardEcLib.inf} | 13 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardE > cLib/EcCommands.c | 218 = ++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/AspireVn7Dash572GGpioTable.c | 398 = +++++++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/AspireVn7Dash572GHdaVerbTables.c | 203 = ++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/AspireVn7Dash572GHsioPtssTables.c | 26 = + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiAspireVn7Dash572GDetect.c | 97 = +++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiAspireVn7Dash572GInitLib.h | 33 = + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiAspireVn7Dash572GInitPostMemLib.c | 126 = ++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiAspireVn7Dash572GInitPreMemLib.c | 344 = +++++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiBoardInitPostMemLib.c | 34 = + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiBoardInitPostMemLib.inf | 47 = ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiBoardInitPreMemLib.c | 99 = +++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiBoardInitPreMemLib.inf | 126 = ++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > .dsc | 67= 4 ++++++++++++++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > .fdf | 73= 3 ++++++++++++++++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > BuildOption.dsc | 15= 3 ++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > Pcd.dsc | 54= 6 +++++++++++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.c | 188 += ++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h | 39 += + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h | 64 += + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeSaPolicyUpdate.c | 63 += + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c | 74 += + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf | 52 += + >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > PeiSiliconPolicyUpdateLib/PeiBoardPolicyUpdate.c | 332 += ++++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c | 642 > +++++++++++++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf | 107 += ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cf > g | 35 + > Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h > | 32 + > Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h > | 2 + >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/EcCommands > .h | 2= + > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/BaseEcLib.c > | 4 +- > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/BaseEcLib.inf > | 1 + > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c > | 76 ++ > Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > | 1 + > Platform/Intel/build.cfg > | 1 + > 63 files changed, 8741 insertions(+), 9 deletions(-) create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardAcpi > Tables.inf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardSsdt > .asl > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ac.asl > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/battery.as > l > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ec.asl > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/mainboar > d.asl > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/thermal.a > sl > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiFspPolicyUpdateLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.h > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdatePreMem.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Li > brary/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf > copy Platform/Intel/KabylakeOpenBoardPkg/{KabylakeRvp3 =3D> > AspireVn7Dash572G}/Include/EcCommands.h (74%) create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Fdf/Fla > shMapInclude.fdf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library > /BoardEcLib.h > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/DxeAspireVn7Dash572GAcpiTableLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/DxeBoardAcpiTableLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/DxeBoardAcpiTableLib.inf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/SmmBoardAcpiEnableLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/SmmBoardAcpiEnableLib.inf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardA > cpiLib/SmmSiliconAcpiEnableLib.c > copy > Platform/Intel/KabylakeOpenBoardPkg/{Library/BaseEcLib/BaseEcLib.inf =3D> > AspireVn7Dash572G/Library/BoardEcLib/BoardEcLib.inf} (58%) create mode > 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardE > cLib/EcCommands.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/AspireVn7Dash572GGpioTable.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/AspireVn7Dash572GHdaVerbTables.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/AspireVn7Dash572GHsioPtssTables.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiAspireVn7Dash572GDetect.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiAspireVn7Dash572GInitLib.h > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiAspireVn7Dash572GInitPostMemLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiAspireVn7Dash572GInitPreMemLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiBoardInitPostMemLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiBoardInitPostMemLib.inf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiBoardInitPreMemLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardI > nitLib/PeiBoardInitPreMemLib.inf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > .dsc > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > .fdf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > BuildOption.dsc > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg > Pcd.dsc > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeSaPolicyUpdate.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > PeiSiliconPolicyUpdateLib/PeiBoardPolicyUpdate.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/ > PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cf > g > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c >=20 > -- > 2.31.1 >=20 >=20 >=20 >=20 >=20