* Re: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.
2020-06-10 22:06 [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string Bjorge, Erik C
@ 2020-06-10 23:26 ` Ashley E Desimone
2020-06-16 17:29 ` Nate DeSimone
2020-06-16 17:36 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Ashley E Desimone @ 2020-06-10 23:26 UTC (permalink / raw)
To: Bjorge, Erik C, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Pandya, Puja, Bret Barkelew,
Agyeman, Prince
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>
-----Original Message-----
From: Bjorge, Erik C <erik.c.bjorge@intel.com>
Sent: Wednesday, June 10, 2020 3:07 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.
Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
edkrepo/commands/checkout_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/checkout_command.py b/edkrepo/commands/checkout_command.py
index f4483d4..0169f30 100644
--- a/edkrepo/commands/checkout_command.py
+++ b/edkrepo/commands/checkout_command.py
@@ -44,4 +44,4 @@ class CheckoutCommand(EdkrepoCommand):
if combination_is_in_manifest(args.Combination, get_workspace_manifest()):
checkout(args.Combination, args.verbose, args.override)
else:
- raise EdkrepoInvalidParametersException(humble.NO_COMBO)
+ raise EdkrepoInvalidParametersException(humble.NO_COMBO.format(args.Combination))
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.
2020-06-10 22:06 [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string Bjorge, Erik C
2020-06-10 23:26 ` Ashley E Desimone
@ 2020-06-16 17:29 ` Nate DeSimone
2020-06-16 17:36 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-06-16 17:29 UTC (permalink / raw)
To: Bjorge, Erik C, devel@edk2.groups.io
Cc: Desimone, Ashley E, Pandya, Puja, Bret Barkelew, Agyeman, Prince
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Bjorge, Erik C <erik.c.bjorge@intel.com>
Sent: Wednesday, June 10, 2020 3:07 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.
Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
edkrepo/commands/checkout_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/checkout_command.py b/edkrepo/commands/checkout_command.py
index f4483d4..0169f30 100644
--- a/edkrepo/commands/checkout_command.py
+++ b/edkrepo/commands/checkout_command.py
@@ -44,4 +44,4 @@ class CheckoutCommand(EdkrepoCommand):
if combination_is_in_manifest(args.Combination, get_workspace_manifest()):
checkout(args.Combination, args.verbose, args.override)
else:
- raise EdkrepoInvalidParametersException(humble.NO_COMBO)
+ raise EdkrepoInvalidParametersException(humble.NO_COMBO.format(args.Combination))
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.
2020-06-10 22:06 [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string Bjorge, Erik C
2020-06-10 23:26 ` Ashley E Desimone
2020-06-16 17:29 ` Nate DeSimone
@ 2020-06-16 17:36 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-06-16 17:36 UTC (permalink / raw)
To: Bjorge, Erik C, devel@edk2.groups.io
Cc: Desimone, Ashley E, Pandya, Puja, Bret Barkelew, Agyeman, Prince
Pushed: https://github.com/tianocore/edk2-staging/commit/3e6b805a
-----Original Message-----
From: Bjorge, Erik C <erik.c.bjorge@intel.com>
Sent: Wednesday, June 10, 2020 3:07 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.
Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
edkrepo/commands/checkout_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/checkout_command.py b/edkrepo/commands/checkout_command.py
index f4483d4..0169f30 100644
--- a/edkrepo/commands/checkout_command.py
+++ b/edkrepo/commands/checkout_command.py
@@ -44,4 +44,4 @@ class CheckoutCommand(EdkrepoCommand):
if combination_is_in_manifest(args.Combination, get_workspace_manifest()):
checkout(args.Combination, args.verbose, args.override)
else:
- raise EdkrepoInvalidParametersException(humble.NO_COMBO)
+ raise EdkrepoInvalidParametersException(humble.NO_COMBO.format(args.Combination))
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread