From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.5166.1633988808439056409 for ; Mon, 11 Oct 2021 14:46:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=E5tTQV8Q; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="207780946" X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="207780946" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 14:46:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="480045056" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 11 Oct 2021 14:46:47 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 14:46:47 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 14:46:47 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 11 Oct 2021 14:46:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXXo9I/QvSE164FiTbiWvRAVCEKnSHbdO3T/mkompZuRbE7twNTMAniXXf5PUm2EjMdGlpCEaJSYb9tgFB5JWyLnUi1+0ylKmiPYMgxSvTw6/Bf51FXfV/QhsYvxg5Inf/MqtlUVBNT1CQyMnC8QC6FRKx13BrdCXaLlFtXWMYlnW93mmOD7s9L/ohTMNG/JSUf47HtQab6JxtnhcO03v4WibW/kO5GJDL/+rLkE96TXCYdRpFsXoaGbaZ+kPcbocxSRZRUWyZvg66SntAEUcsw+LWQJ3qwjoaLsvws5y8oK9iToSHqwliY8Plntwg0nyFEBFTXCGoiJdFJl8bRUrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lbDE89OBn72zj5hHfSQ85IFt1dwtbwxktZySfLWzBDI=; b=ZPBnNfu22KgCiHD4aRvRG3rl3v2tnke/gYNTmcIlFsi8ReiYvj6X9tS06Hd9SR7XuLrZID0LlvQjhLXhQomtzPtIhL4PnG+pz8Qwe1S04ejReZHrVNdzijr/PHzfNsvlTvLZkUXx5cq0ZKtyrY7gfqxK1CBu9E53uqSE2BI+fNSnBZApCo2k3kV9EK9KO8BCtPTzdLB1Mbw6DdAv98M1Q62wKxrfYMG9QBOl65b6QEmw6DHqzwoKT88Ssdgo3MQ469VThxnmVfPWkNkarApc1BLutdJS78aETjGM5CkbSjVs++yOP1869nsJaCmtsHb47jYnTT0ok7+wCLg3dtDQdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lbDE89OBn72zj5hHfSQ85IFt1dwtbwxktZySfLWzBDI=; b=E5tTQV8QzDZM38vV++A22sIDotsKX8zALqrrB+El8tmCu+nTBvCI9xXzIIq4qgU4eBE8LEhL9fvAFZnCW9KRQYBKQznSIoYd+bis4ouBwSLXneyaCKR5s7/89tdtD5CBxydISh5IVq9nfNBlNaMrG9YysIwC3e4a8RrwgzS2Z+g= Received: from MWHPR1101MB2160.namprd11.prod.outlook.com (2603:10b6:301:5b::12) by CO1PR11MB5057.namprd11.prod.outlook.com (2603:10b6:303:6c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Mon, 11 Oct 2021 21:46:46 +0000 Received: from MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed]) by MWHPR1101MB2160.namprd11.prod.outlook.com ([fe80::f07d:7a97:3b68:92ed%11]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 21:46:46 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: Jeremy Soller Subject: Re: [edk2-platforms: PATCH v3 4/9] KabylakeOpenBoardPkg/GalagoPro3: Use same variable name for FspNvsHob. Thread-Topic: [edk2-platforms: PATCH v3 4/9] KabylakeOpenBoardPkg/GalagoPro3: Use same variable name for FspNvsHob. Thread-Index: AQHXvA/WMQYqL5QjRkiQ32tgUFjJyqvOWo+w Date: Mon, 11 Oct 2021 21:46:46 +0000 Message-ID: References: <20211008064317.1371-1-chasel.chiu@intel.com> <20211008064317.1371-5-chasel.chiu@intel.com> In-Reply-To: <20211008064317.1371-5-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9f2140cc-72ba-469f-617b-08d98d009f60 x-ms-traffictypediagnostic: CO1PR11MB5057: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U/rUtbDNsLWwZNoDKKOuR8vUNAQ91Mt7aBqi4rBJZI/vDKMzCLyV9GzWqdW/0plScpiO4sI6Y/h3regi399IOAlqpYtjUggw1DJPDhNLHbMi5ZL1K1WKV4WCWn4+tlr/4f95FUOgv3yG4qJa95gWozfZGTvga6+Xe5EDoAq3zi3OCXywtkO3ajYVxHg9gf2zvKK0/XFDQP2fem8VsVUQ5bUk8jofa/CGcu8N6D4hx8ddew3xKRCSwqp0p1A6cGi2PJ5huV2HumQgy8jIjOVbx8XsuNvkOWGZTxknqpKRHT+9vmjyYgQOQqTInWIS+vpCwJYMoTLN8Y7NbsDsmpuVYTn5uHjdR1F03lmPqaPaH11Yw8O6PZ0NvjNc1uaMNZk/5ohzh6FgNj7dxfmF4HThLxo7hPpA31wmZ6NpwojP9GMJ8ckudDj3ym/8+im4rwxvKiMSSjM6l5ZTG62SHMTPXXie5bmtx9Cx51xzXeWDFssaVTPq2XK2YFK2MyL9TAX6TUWMbY6vXdrE+p2/dbffrk35mCkMQ87tvpuOHqGYrF7DYbvzkARmGQlD5YRg1KanMloZGaWyOjYt7cfHmgynYW+94ffTxX9H1YSqppeUDVpSRZpQRNP+GZZKWO34s61xdUkHxqTwOzEGl3HgThBZah8mVb8ZKJIAbOXPwW9UP5v3d1UejEQCTpgubsYmRq6cfoUGMh1aAP0XlafXmt2d1Vy70YavlHL7VtYsZbDTOgHJorOvMmkJTuQkuppjg8KS6Oj/w64Y0ltyr72/UsNktSL7TFD21A1ngk8PyjnppSU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(64756008)(38070700005)(33656002)(83380400001)(186003)(8936002)(66556008)(4326008)(2906002)(66476007)(122000001)(26005)(66946007)(52536014)(7696005)(5660300002)(316002)(8676002)(9686003)(76116006)(71200400001)(6506007)(55016002)(966005)(38100700002)(508600001)(53546011)(66446008)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3b/T4V60Ej8wZUPRZgsSRedc9lpXtwBViGIvpx5kAUU6a/NPpi898mQ5VFPH?= =?us-ascii?Q?qzrHoFoW/4sbdo68sIFn60XU2uUTivIJWS41AYvWuZmwdLNx9M0Ji4hzkYzZ?= =?us-ascii?Q?ljDmmh2UNqeCnRCuCByDR4mE0FFpEWpnazCNrkY7ngTWe8Lrc5SRyxBD6yb/?= =?us-ascii?Q?xEKyaG0TpWHLFNgk63KXlyA5S/raLKS0DQjN55WsxpvAWKihohLAcXR6s8+6?= =?us-ascii?Q?Dqg9AZNsOyR3EE+CR6o9B5/rgab6mc7n+LpmZSizbEkzgRbKznVHMXZgJ2UH?= =?us-ascii?Q?1UhR8IYXFIM2AAWR+gtJr5LrntAvuGbt8x2LAomTADrW3Enl2SKYOXl1Z5ad?= =?us-ascii?Q?NbrUDd5kd343DWhyQ8B1HyL4Ozwuj1c1l6MNHM1ygTEA8NQiMrTK490w4uNd?= =?us-ascii?Q?PUN60BMO482j00UhDiCfD9Bv033uiNsQXMxEeTPeEMAHc7ooRUAh+iF+Z+ge?= =?us-ascii?Q?B6WbkMDsUd7ULsv/4nBV7AC1zl8C2c3nJ+hLvmdq4mIj0g1z1VRprnwcu3Ih?= =?us-ascii?Q?GJtMmc1hIu1PnSWzv7RCVgYLuOpFScae+g1S06w8FmshjMpj2170pTE/zwCd?= =?us-ascii?Q?KjlA5CqAXef9kOqO0TUZ0thcGO2b3ZlDnOu9jZNBtP+eCvswcbW/+i1loXrF?= =?us-ascii?Q?8xTNWAFxcrTVEgUI+A0kuljXzR32g/bvJwqjZzZvuSsZNLavut8R6k6PLXGB?= =?us-ascii?Q?EN0TlgKrQ1nUcayLUz2jQK2KtQgi99Yxb99Wx5F98rnQd/licl4/GQ1FnJGK?= =?us-ascii?Q?l1wBdTBHlS+Vp/uO9SZ38CFf3A9oaZN56kEBQ+L4z2CWemXKwSzGVbnjtiq4?= =?us-ascii?Q?MSStF4AR25PDmISOIs44uo3aQc06mOWXdVS1oIRaJytFUKYtFTTCw2O0Hf68?= =?us-ascii?Q?AXkwhOGNxTVy8n1UQCb/M2VaJAG7XJB24DBNn5Hwio0ykC7PEVdEXZ6QB/Mp?= =?us-ascii?Q?d7ArPWJbjNBEKT7m9KE+/hU4f5TKxlyeKVZPRUnh9MnnejIFnreorJzVaaaV?= =?us-ascii?Q?SDcLWg5YP9+mSgmHoH1TVlNYtQmQ6Ph6tUvRrdUjwaCg2TEGR9Hia9SBXfLI?= =?us-ascii?Q?I7ocvQCUh9opiqrO4LyIzoX8657OaouVj0h23Es13F04SgoSKP8rEfb2m/2r?= =?us-ascii?Q?faZMsb7kxkDD11AdS2Cmo7yFBDkx9ZCwuAvafNnh/KYXh0ygL7VowXAZsYSr?= =?us-ascii?Q?z+FEMUrtitmYzuVVyisMFUUTZsPakpLq9UaIHjRjO9KDLO5hj8pTEToXIauV?= =?us-ascii?Q?9iGzZBvsBZUthowKEUKunnKt3dbuCo1F6uJJ4/r47IbU8/KV/JhN9Psm+PhN?= =?us-ascii?Q?RDhCj3KSMKzetj/HM3QjE+YB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f2140cc-72ba-469f-617b-08d98d009f60 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 21:46:46.2286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YJmWXGedCQiv/3OTM4UNFdSC57N06JEb8GiTlf+kGRdAtF2kMBVeD6/BUNUIcKHcbc3yX6qCNKKCG1t89EoA7fd0RFUxbPniaZELaanA3uo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5057 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Chiu, Chasel > Sent: Thursday, October 7, 2021 11:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Jeremy Soller > Subject: [edk2-platforms: PATCH v3 4/9] > KabylakeOpenBoardPkg/GalagoPro3: Use same variable name for > FspNvsHob. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3678 >=20 > To simplify the implementation the variable Name/GUID has been changed > to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the > data from FSP_NON_VOLATILE_STORAGE_HOB2 or > FSP_NON_VOLATILE_STORAGE_HOB. >=20 > Cc: Nate DeSimone > Cc: Jeremy Soller > Signed-off-by: Chasel Chiu > --- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/Pei > SiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 24 +++++++++= +- > ------------- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/Pei > SiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 5 ++--- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > | 3 +++ > 3 files changed, 15 insertions(+), 17 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/ > PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/ > PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c > index 9d6c0176f6..2158eb299f 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/ > PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/ > +++ PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c > @@ -1,7 +1,7 @@ > /** @file Implementation of Fsp Misc UPD Initialization. -Copyright (c= ) 2019, > Intel Corporation. All rights reserved.
+Copyright (c) 2019 - 2021, In= tel > Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clau= se- > Patent **/@@ -16,7 +16,6 @@ SPDX-License-Identifier: BSD-2-Clause- > Patent > #include #include -#include > #include #include > #include @@ -38,24 > +37,21 @@ PeiFspMiscUpdUpdatePreMem ( > { EFI_STATUS Status; UINTN = VariableSize;- VOID > *MemorySavedData;+ VOID *FspNvsBufferPtr; = UINT8 > MorControl; VOID *MorControlPtr; // /= / Initialize S3 Data > variable (S3DataPtr). It may be used for warm and fast boot paths. //- > VariableSize =3D 0;- MemorySavedData =3D NULL;- Status =3D PeiGetVariab= le (- > L"MemoryConfig",- &gFspNonVolatileStorageHobGuid,- > &MemorySavedData,- &VariableSize- );- DEBUG ((DE= BUG_INFO, > "Get L\"MemoryConfig\" gFspNonVolatileStorageHobGuid - %r\n", Status));- > DEBUG ((DEBUG_INFO, "MemoryConfig Size - 0x%x\n", VariableSize));- > FspmUpd->FspmArchUpd.NvsBufferPtr =3D MemorySavedData;+ > FspNvsBufferPtr =3D NULL;+ VariableSize =3D 0;+ Status =3D PeiGetLar= geVariable > (L"FspNvsBuffer", &gFspNvsBufferVariableGuid, &FspNvsBufferPtr, > &VariableSize);+ if (Status =3D=3D EFI_SUCCESS) {+ DEBUG ((DEBUG_INFO= , > "Get L\"FspNvsBuffer\" gFspNvsBufferVariableGuid - %r\n", Status));+ > DEBUG ((DEBUG_INFO, "FspNvsBuffer Size - 0x%x\n", VariableSize));+ > FspmUpd->FspmArchUpd.NvsBufferPtr =3D FspNvsBufferPtr;+ } if > (FspmUpd->FspmArchUpd.NvsBufferPtr !=3D NULL) { //diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/ > PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/ > PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf > index 463455c90b..ceefe7639e 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/ > PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/ > +++ PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf > @@ -1,7 +1,7 @@ > ## @file # FSP wrapper silicon policy update library. #-# Copyright (c)= 2019 - > 2020 Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2= 021 > Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: = BSD- > 2-Clause-Patent #@@ -81,7 +81,6 @@ > PchInfoLib PchHsioLib PchPcieRpLib- MemoryAllocationLib > CpuMailboxLib DebugPrintErrorLevelLib SiPolicyLib@@ -138,7 +137,7 @@ > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdGraphicsVbtGuid [Guids]- > gFspNonVolatileStorageHobGuid ## CONSUMES+ > gFspNvsBufferVariableGuid ## CONSUMES gTianoLogoGui= d > ## CONSUMES gEfiMemoryOverwriteControlDataGuid diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index 7f276d3512..299c7f18cd 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -141,6 +141,9 @@ >=20 > PlatformHookLib|$(PROJECT)/Library/BasePlatformHookLib/BasePlatformHo > okLib.inf > SiliconPolicyUpdateLib|$(PROJECT)/FspWrapper/Library/PeiSiliconPolicyUpd > ateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf +[LibraryClasses.Common.SEC]+ > VariableReadLib|MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVari > ableReadLibNull.inf+ [LibraryClasses.IA32.SEC] > ####################################### # Edk2 Packages-- > 2.28.0.windows.1