From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-platforms][Patch 0/3] Fix SmBusSendByte value
Date: Fri, 11 Jun 2021 00:16:51 +0000 [thread overview]
Message-ID: <MWHPR1101MB216052425615650262551739CD349@MWHPR1101MB2160.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210610224550.855-1-michael.d.kinney@intel.com>
Hi Mike,
Please remember to update the copyright year on all 3 files. With that change...
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Thursday, June 10, 2021 3:46 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [edk2-platforms][Patch 0/3] Fix SmBusSendByte value
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3452
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3451
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3450
Update SmBusSendByte() to write value to Command Register instead of Host Data registers.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Michael D Kinney (3):
CoffeelakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value
KabylakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value
QuarkSocPkg/SmbusLib: Fix SmBusSendByte value
.../Pch/Library/BaseSmbusLib/BaseSmbusLib.c | 24 ++++++++++++-----
.../Pch/Library/BaseSmbusLib/BaseSmbusLib.c | 24 ++++++++++++-----
.../Library/SmbusLib/SmbusLib.c | 27 ++++++++++++-------
3 files changed, 52 insertions(+), 23 deletions(-)
--
2.31.1.windows.1
prev parent reply other threads:[~2021-06-11 0:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 22:45 [edk2-platforms][Patch 0/3] Fix SmBusSendByte value Michael D Kinney
2021-06-10 22:45 ` [edk2-platforms][Patch 1/3] CoffeelakeSiliconPkg/BaseSmbusLib: " Michael D Kinney
2021-06-11 0:32 ` Chiu, Chasel
2021-06-10 22:45 ` [edk2-platforms][Patch 2/3] KabylakeSiliconPkg/BaseSmbusLib: " Michael D Kinney
2021-06-11 0:33 ` Chiu, Chasel
2021-06-10 22:45 ` [edk2-platforms][Patch 3/3] QuarkSocPkg/SmbusLib: " Michael D Kinney
2021-06-11 0:16 ` Nate DeSimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1101MB216052425615650262551739CD349@MWHPR1101MB2160.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox